From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26033 invoked by alias); 15 Jan 2013 13:27:38 -0000 Received: (qmail 25919 invoked by uid 22791); 15 Jan 2013 13:27:36 -0000 X-SWARE-Spam-Status: No, hits=-3.6 required=5.0 tests=AWL,BAYES_00,DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,KHOP_RCVD_TRUST,NML_ADSP_CUSTOM_MED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-bk0-f51.google.com (HELO mail-bk0-f51.google.com) (209.85.214.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Jan 2013 13:27:32 +0000 Received: by mail-bk0-f51.google.com with SMTP id ik5so58397bkc.24 for ; Tue, 15 Jan 2013 05:27:31 -0800 (PST) X-Received: by 10.204.127.10 with SMTP id e10mr3512619bks.14.1358256451188; Tue, 15 Jan 2013 05:27:31 -0800 (PST) Received: from sandifor-thinkpad.stglab.manchester.uk.ibm.com ([2.26.205.107]) by mx.google.com with ESMTPS id hm8sm12724438bkc.10.2013.01.15.05.27.28 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 15 Jan 2013 05:27:29 -0800 (PST) From: Richard Sandiford To: Robert Schiele Mail-Followup-To: Robert Schiele ,binutils@sourceware.org, rdsandiford@googlemail.com Cc: binutils@sourceware.org Subject: Re: invocation of mips_elf_multi_got can cause not enough GOT space for local GOT entries References: <87a9sj32qj.fsf@talisman.default> <87mwwbx4ei.fsf@sandifor-thinkpad.stglab.manchester.uk.ibm.com> Date: Tue, 15 Jan 2013 13:27:00 -0000 In-Reply-To: (Robert Schiele's message of "Tue, 15 Jan 2013 11:45:44 +0100") Message-ID: <87txqi37b8.fsf@sandifor-thinkpad.stglab.manchester.uk.ibm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00226.txt.bz2 Robert Schiele writes: > On Mon, Jan 14, 2013 at 2:47 PM, Richard Sandiford > wrote: >> You'll need to do it consistently for all page_gotno tests >> (mips_elf_merge_got_with, mips_elf_merge_gots, mips_elf_multi_got and >> mips_elf_lay_out_got), otherwise you could end up merging GOTs based on >> the current estimate and lay them out using the conservative one, which >> could lead to overflow in the global region. But yeah, I think you'd >> be safe changing those four places, as a local hack to get round the bug. > > So, with consistent you mean something like this? Yeah, that looks good. Richard