From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 707873852C4A for ; Mon, 28 Nov 2022 17:15:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 707873852C4A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669655720; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QjdGhV1hRqYYNHddpQzdJJBI4lnCwDzfEcSQhMz6C98=; b=NSvCojjQq8IZycxqc3O9rhvpZzVQcwWNy+/UdUUwg+mFWJ39cToQ5BUHYUjVo2LR8FH6xK WP5olwaCQDyi/Ava6IGuhPjmpbC9xPjv+4wNz9Lsp7EBE29QMRawC6WDVbtbth8of27iXf JC7YUvBgowFSNDr9qEBXMRZ0YJWpzyg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-386-6vsLqZsJNDK04D2IeSSa8Q-1; Mon, 28 Nov 2022 12:15:18 -0500 X-MC-Unique: 6vsLqZsJNDK04D2IeSSa8Q-1 Received: by mail-wm1-f70.google.com with SMTP id bi19-20020a05600c3d9300b003cf9d6c4016so8845200wmb.8 for ; Mon, 28 Nov 2022 09:15:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QjdGhV1hRqYYNHddpQzdJJBI4lnCwDzfEcSQhMz6C98=; b=7pK+tQoEnk17wQJjDiRL/eKKruKxd43Y+52Q0hQaF/FsEjLJ/301EW+RuZg5VMNtFN QxP1qszJ3sdLm/5gy4zoPSgRtyxPxqnKEeXUT7w6/sg9imAbc1bENN/m39+IMfXrMd3c +tVOFyu9EOY8PZaVlZbTNL4AL6422wvVwub9Z3/jEwH/JCxBv4tgF+EvxDemaOf8+o/L Uoj9rKXArqdi3ZRn9YPtcsNplH5bncRXuX25G8Vg+b0fFz/Q4LvNpk7UwMA7Bg9LKyVk bnGUzZ68mOuKO+o/vbYtS3dhZGHxNF7mKVmIcY18MXJEkGtC8PsjZd/RtpI51+KkTjii 2dEw== X-Gm-Message-State: ANoB5pl/ixQIlWjEGBW+HDUtc333HUgHqX4+T8y6a7qw/rBDlLmVaV27 t6NpvplXEdAruPL2FtbecQZdne+//Xz9FH+zzzG8egKIvR7SxhR/s3KE9qkoHpOeDYSlnq0RloJ X79mxNIUoI94q5pVhyPeQ6WwmREepwqJInBTnqcVvXYyyv5zgDT0csY8QmF+STgHMDr6Q1A== X-Received: by 2002:adf:fc50:0:b0:241:d2de:b11e with SMTP id e16-20020adffc50000000b00241d2deb11emr24140556wrs.347.1669655717157; Mon, 28 Nov 2022 09:15:17 -0800 (PST) X-Google-Smtp-Source: AA0mqf6nClQFad1eRBPe9m2GQS+yEqHLlMUiM3qky4E/hSXUZ64x5HgRU66iPr8hsByMpJ8fAJGZ7Q== X-Received: by 2002:adf:fc50:0:b0:241:d2de:b11e with SMTP id e16-20020adffc50000000b00241d2deb11emr24140530wrs.347.1669655716866; Mon, 28 Nov 2022 09:15:16 -0800 (PST) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id n8-20020a05600c4f8800b003cfd64b6be1sm24197782wmq.27.2022.11.28.09.15.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Nov 2022 09:15:16 -0800 (PST) From: Andrew Burgess To: binutils@sourceware.org Subject: Re: [PATCH 0/2] MIPS disassembler styling In-Reply-To: References: Date: Mon, 28 Nov 2022 17:15:15 +0000 Message-ID: <87v8mz0zmk.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Ping! Thanks, Andrew Andrew Burgess writes: > This commit adds disassembler styling for MIPS. > > Patch 1/2 changes the disassembler to make use of the assembler > directives .word and .short. This isn't a requirement, but I think is > an improvement. There's a lot of updated tests in this commit, it's > possible that this patch might be too large to reach the mailing list. > In case of this, I've pushed my work to the branch: > users/aburgess/try-mips-disasm-styling > > Patch 2/2 is where I actually add disassembler styling. If patch #1 > is not wanted then I can easily rebase this second patch, removing the > use of .word and .short, just let me know. > > Thanks, > Andrew > > --- > > Andrew Burgess (2): > opcodes/mips: use .word/.short for undefined instructions > libopcodes/mips: add support for disassembler styling > > .../testsuite/binutils-all/mips/mips-ase-1.d | 2 +- > .../binutils-all/mips/mips-xpa-virt-1.d | 4 +- > .../binutils-all/mips/mips-xpa-virt-2.d | 4 +- > .../binutils-all/mips/mips-xpa-virt-3.d | 2 +- > .../binutils-all/mips/mips1-branch-alias.d | 4 +- > .../binutils-all/mips/mips1-branch-noalias.d | 4 +- > .../binutils-all/mips/mips16-extend-noinsn.d | 24 +- > .../binutils-all/mips/mips16-pcrel.d | 16 +- > .../binutils-all/mips/mips32r6-branch-alias.d | 4 +- > .../mips/mips32r6-branch-noalias.d | 4 +- > gas/testsuite/gas/mips/interaptiv-mr2@mcu.d | 112 ++--- > .../gas/mips/mips16-32@mips16-asmacro.d | 6 +- > gas/testsuite/gas/mips/mips16-32@mips16-sub.d | 436 +++++++++--------- > .../gas/mips/mips16-32@mips16e-64-sub.d | 4 +- > .../gas/mips/mips16-32@mips16e-sub.d | 66 +-- > gas/testsuite/gas/mips/mips16@save-sub.d | 68 +-- > gas/testsuite/gas/mips/mips1@isa-override-1.d | 16 +- > gas/testsuite/gas/mips/mips1@save-sub.d | 68 +-- > gas/testsuite/gas/mips/mips2@isa-override-1.d | 12 +- > .../gas/mips/mips32@isa-override-1.d | 14 +- > .../gas/mips/mips32r2@isa-override-1.d | 14 +- > gas/testsuite/gas/mips/set-arch.d | 208 ++++----- > gas/testsuite/gas/mips/tls-o32.d | 4 +- > opcodes/disassemble.c | 5 + > opcodes/mips-dis.c | 306 +++++++----- > 25 files changed, 751 insertions(+), 656 deletions(-) > > -- > 2.25.4