From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 9914A395B458 for ; Wed, 16 Nov 2022 15:55:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9914A395B458 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2AGF4jNT014262; Wed, 16 Nov 2022 15:54:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : content-type : mime-version; s=corp-2022-7-12; bh=kK2nTxM8v5kuq2PxR2CD+0IVoLZhypBarWVZlwCluts=; b=f/Gr2saHznxPdELmgQMJ5Wi0fUNjwUL0+GFVuN98+nlO/lpmjHz+QUusQXO4CwPWg6Z0 Ap34QQ/nb84FiueT39of2yo3ZnsyOP2C+aBNVhbLV4jGPBMMtlv61U9+ffLIhSKuImzs nV15nlhVKcsgk841UIO9dynybEKTS6P2Po0UhLd7JMrCawhBYrCw2JCgEICgUnHLD993 IpdVmdnda00jrJZLjPEk+xw/UVwhYbGTcT0PCjXALdXW8TMDqaSAxnrxPzrQBvdztHr3 rBvNaYm+txngtvM3W60ykJnxpDGppOx84bZvQNqtxbAyqpCWFyakqu6BGNQmUv7RruLT 9Q== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3kv8ykmu5k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 16 Nov 2022 15:54:52 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2AGFQQFC009421; Wed, 16 Nov 2022 15:54:51 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2176.outbound.protection.outlook.com [104.47.57.176]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3kt1x7kpkf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 16 Nov 2022 15:54:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zx0bVxZ0kQyJRf56nHWjMuqDCfSdA7rXo1VbgWqFlBb+ZGAUu2+eermqh8uYQrcZB/P+eFk4i+aRPmPgeb9eTDkShJXhHTvVtx2iGWsHMw3fw6ZxzZ0hvuI3HeayMvsSfyhgfyq7BP/SinPQIXzwBp3FM9dhK+325XXPY5m7C+Tt7nn3ZhxCwmMiBk+9k5LWkQ78PhKYAoCPUf7Aw0SPJyyQkjWKmt0TvOGJXOEJqn0MGfMOrbzqp4YSuRDwNg2ho7cS/im5QcoIw2LjelbzMS7f+MqYxZLZtcfH0JeSKMAI4SZmvVahfq37giOX7wZVf7P5RVLebAPpA1yt5IdFxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kK2nTxM8v5kuq2PxR2CD+0IVoLZhypBarWVZlwCluts=; b=FniXWa4q6QqOwGaF8OCNn6QVF85xVj4d1PpsC9Nx1wDbJTH9jp676aWTI/H6B4omsjcVyKBwaX4Hx9z8+uRAzkm4h/cbUuNzEmRYIk82GkId6rzrAOsbjy41TmomgnFrr5d9lErTAIJCK8iqhZLKBrO2wx8PfcT79thZ4FTuob8zgin/k0ZUm3HXaBYABI+W0fKTlkEzOqYIJkqUxc1xZDpZzGsPPlzDtGCjlgrVEa/uexZYZZQZGqZVq8A79t5/lJEZl+AK4JbH1mK4J7EZWFl/mdilTOVFIn6QBBxg6sJ8bqSJteXatG4UILza4MZtlnyiJ7T2gMQTqrAIhlooJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kK2nTxM8v5kuq2PxR2CD+0IVoLZhypBarWVZlwCluts=; b=n35Yb4HZkVYjYjRGJlV/ke16Eap8OaRXlKqTfHjGqTjPdwsas2W2Ip7Kl/3LJ7i2s3H1IeaNCDN4LiUaaCoJBhq6tPluGR7Akt0JLzDtG4Sq1WOkqGJb9KXYWhFScO7UGTmLLiTYwww0e5hyZ4IbTdKiD8r8Z1T/V28Qx/8Rty8= Received: from BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) by IA0PR10MB6915.namprd10.prod.outlook.com (2603:10b6:208:431::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Wed, 16 Nov 2022 15:54:49 +0000 Received: from BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::1823:4d74:ed9b:7b5b]) by BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::1823:4d74:ed9b:7b5b%4]) with mapi id 15.20.5813.017; Wed, 16 Nov 2022 15:54:48 +0000 From: "Jose E. Marchesi" To: Mike Frysinger Cc: Jan Beulich , Alan Modra , Brett Werling , binutils@sourceware.org, Michael Matz Subject: Re: [PATCH] readelf: use fseeko for elf files >= 2 GiB on x86_64-mingw32 References: <20221114150348.112815-1-bwerl.dev@gmail.com> <8c1844c9-4b04-0200-c24e-c33009562477@suse.com> Date: Wed, 16 Nov 2022 16:58:28 +0100 In-Reply-To: (Mike Frysinger via Binutils's message of "Wed, 16 Nov 2022 22:40:22 +0700") Message-ID: <87v8negacb.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain X-ClientProxiedBy: LO4P123CA0673.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:351::8) To BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB2888:EE_|IA0PR10MB6915:EE_ X-MS-Office365-Filtering-Correlation-Id: 28c2f17b-32f8-4a93-0609-08dac7eae3f0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2R84uqtks/8w44UxcglOxb4BswvMgaZO61239a0AmM09617/kb5rlv3y3py32oGSwPS3nrqzdaG0+gPWmMNmyQreq9YhJGVTu1sfpXzfPAfIieOfAWZ039VRccS+jC5HY2+tQevDNxoQYwJVQd/lNPXV9zD9fO7tp8YdFaykBySHA9HmCDdGwAhHsAn+8yVVKZ47Brj8ARsKj+segomYkgKdgien+EP3L/XnmrGUEGsWen2mAsYlKz83N757OmvNmw1Jz4mAys13OUjy17Y16zxhMiQuyrPJqL+9LJXTdcerUUF96W2zHRSy8YbqBMZY5XugZVymyPgxoRcyC6SzsaiZYETlZgtKumzKqYxcF+D6vt6pM1sy074pzSTzQV4fBvQ1VDPnwSAAprNKcmfjNXGP2gcVnVDhp+CjG7/FwWsg+/lf09MpNtDgKib3YV2EoI8qt20AvgUIBaHIo/pTt6qF7QFlEVeMyMUMiBU2p16uxSJfo8a70onIhXiQNCaSGFKC//9j0P4biEyzp7/0ReSlwEijFa15sXeol141eWG3Qr+BlzF90ydtd4SK/gYCY3gllVHGTwxPp3Mu0bhRGbOqOn6hIEEHC0+TNEDoEs5lhobfTSL/u1/OT2ZAN4GHRiHLaEmD1O5H7XYMXzyVLRb7tTbPrxCGdO7uLF1HYXV90qyZbK0nittU3rbMuYSU+9Hzk01mfG213xYuTFC8kg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2888.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(39860400002)(376002)(366004)(346002)(136003)(451199015)(2906002)(36756003)(5660300002)(8936002)(41300700001)(66476007)(4326008)(66556008)(66946007)(86362001)(83380400001)(8676002)(316002)(6666004)(6916009)(54906003)(2616005)(6486002)(186003)(38100700002)(26005)(6512007)(6506007)(478600001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6P10bKK8slKexqWZcYhv7EO5o98uyWifah9B0YCriFB7qAGWNsXF9II8o8/m?= =?us-ascii?Q?2amAZJSuVTmuOYgoUQqNeNXD/G605RyphDcqiiimUxti3v+izSV0hj5vk7Kc?= =?us-ascii?Q?ZO6jVdx28EMqjHa+krnlZb6c4/ImO1v80vV8DxCbjEAdoimgfQv0baPrvpsV?= =?us-ascii?Q?t+6UBlxncMduSmoop7jGmhSiACyet1UGvwbDi2NH2fhn257nt31ge0XRs99A?= =?us-ascii?Q?gfSQ2xtKpPhPMEdaGm3GNoTFZjWh4pz/lhyXg7P6olzJchOX5k0meLSzzpJf?= =?us-ascii?Q?SD3RffuSVZLuNO/k8DET5vpwpRdV0sBiU7VHfH4DxlYa+dew5avuM+/J3Ds1?= =?us-ascii?Q?FZAZD9r0kb7jCerr1KUgq9QTFqYr68AWdoR6UZiLI4qC4/A0nK32DBNHr9gw?= =?us-ascii?Q?20jPdRlqW3E+GKAcb2uB93/xW6mVx3ZYBDHDmdXyMTAbyrvy1SAA1QTVgqzd?= =?us-ascii?Q?DLWp0P6VhH/nIPoI5dT8fI1RE6ERpx0WhOW52caciJXIi0BqajTQscGeSpj1?= =?us-ascii?Q?QZWNzZsK86oOZjGuh+fNkP4g4p2pHGPcmCh6DbNiPfzhhQWvaNNUgR0ISKLv?= =?us-ascii?Q?C6npns9mjDFWXIy142bEmZrTtuIQBKBvXB8A6Suy0rGmLHl4Lhg6iZCuZ25P?= =?us-ascii?Q?MR40WbpohfnmkX/OpL/YJgOl8v8pQG/IGUso/grGXiNFtE+TKE81FrJ5toao?= =?us-ascii?Q?WidNtp1Y7dC2qntDRNaclTXyFaKaSK4Ey8coBnzNAl36URYUya3qkdSj76xt?= =?us-ascii?Q?1dLLIawC6YYVmre77CVMYvLmo5T8EcTkE4JLY5ruUt3MAOkKeQrAbMMDnCVY?= =?us-ascii?Q?PRg+UtVtFgzU6q33wq7asZzIpCBQsjowBAPbediAvkmIqJWdt4/EKog+loZY?= =?us-ascii?Q?ruBo0HWfJ3NDCqjPSHSzhtrNcqJ7peAT5sdRyqqrrC494uscoCYtEBslSgTm?= =?us-ascii?Q?HgXVsejxCOSLhk7n7hpxDtA5zbBJPeLyxrzAqWa9nVTeJ4L53Kk3cAsELseu?= =?us-ascii?Q?VIL40QfjBI4/OK2tp5tS9ncQ6x9Z8D3zihODc9K1Pno3r2ooxLJTyA33jyB/?= =?us-ascii?Q?COtQHCQ0bGo3gG2xpXHQyBGdTPCT9UbL/2v9M6PAwMvTyPXu+abYB56k+J/a?= =?us-ascii?Q?v0mP0VnzkQocbE8Ci3gWwIKITjOMQE2XHPVlL2xSeEyLnNq/TBVaZKdovX04?= =?us-ascii?Q?kG3gzYn0v/PFC534GQHOgh9aPGFuvjKWGULLOt1GnT4jSRX0z5L+Lm1vjuwO?= =?us-ascii?Q?qBi4e+lrcX6NEK3kNQCbCWPrHY3OonwJjRtw78fd8QbIwS/tkIeUTWx0HfVP?= =?us-ascii?Q?jp8aDb0TUnHilUmY8cLPh4u41+o0BBTlVLQ1xfCiIZ6u2e34xnqHdIbxpG81?= =?us-ascii?Q?Xg+g0g40sG9zuGjLZfZO9ZcUivgm2Ig857bPEmjyS/uklotppTa4k0EWjoGT?= =?us-ascii?Q?MXj8hiT+azbT7tV6Q1uaoxO9bLapLtmQXvLji8/4WORFfZw4eTTNsONH5/3r?= =?us-ascii?Q?unBc472/wsAWBnSp/V9x5oeU1WHLo+G/HdJIiTZ4WQ5DEQKH4tg8Th532kS7?= =?us-ascii?Q?fGMSv7e3jrnnOrUCpLX7oboK/dmO+EWMX/Zfg6ifh2XMkiUnfj2R4mLQkiQN?= =?us-ascii?Q?oQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: LYwlcYV0d9lh/nenm01LYmXPF+arkVonqZlrgJnmnDeSWZs1Wd9urUL8hcsgF5N6aiEngS9Gf7E25Ms/WwCDEI65TYizu+kz76eXbhyf8x7Ra+xAxElq1a38DQt7SkHiG28fpvgCRu7WVSvfbTkeCe149hdk2JdheU3GdviAXnn3uZbT64GAfLSLiiE7mrVqwG1IVZCBwXeIwQVK+fG0eO6XkssFLpiMwrjxNqmuTRRolSevslUzJnW/rV6vuflX795KyTnPKktcSQ0vQ34VjfV+JhHQYjvmPyFUWX4XeiiHdufEk4F8QEFzYC93t9gDp5/4do2CLKSdPOxZAz9YNOD6FoHnNADvZ94F6xdJqN9nngMQvZC5apVTNO2FOrnBHyqeBJeOqYDOLG/2f46zIEKJiUi2pxQj94NLsOWpr8Il8PGkzC+SaA07Rb6YDKGl/1VeTU3DQMcWD5Ige5IlR5xBMINika/MgraHjZWECfz4ObGFoUSyEdmiNJRA01gdHU6gJinxScnxda0+V/1nRSFvwhFvL7AFh1WJQk08WkSOUe5iYpTQFqwQmLEg23qIWYghC7br+e9zcegGrEdENQRArs3GgmM0hgWVmKHdX1Cdq5vBxkvFoE+wGoMTbv+FlVfoY8633Jh0CWHyeL2aw2YTH9ZvAE3w8ARwx2krNdOftRd65UZB46OSbUtonRr2RS3/tbuDrpbUQgVhA0yegTylshcg6capck9v9f8akr3+BWaEj0eEWPUiFrDz5FThcZG1ndQ6vhIKt5Q3IObuWQhKVVEt9zEp5FpLRXL8XU4aaLCC8gJeBSG1vXIxEMn583e889ClmwK24LhPFEVmqcZEqg9LjPAM7Q4npwflxiCdfbGwiTUmKN7I7VvJ+HhEyEdasKAvC90XRyEguFGrXw== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28c2f17b-32f8-4a93-0609-08dac7eae3f0 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2888.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 15:54:48.8341 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LB6M0CB6NMKc5nfXlkr3t7p0SOeKg9lh2GpD3OHgIVJ0W8Ksi1AuJQtfaQQdy3B5wY+5EJ3FVSEoeX9EVIxDSnosR3CBuBNRqJNGSdkIFKQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB6915 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-16_03,2022-11-16_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 phishscore=0 spamscore=0 mlxlogscore=999 suspectscore=0 malwarescore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211160111 X-Proofpoint-GUID: LZF8pRuevAyVmfukCkN1a5oiftnCs5Jl X-Proofpoint-ORIG-GUID: LZF8pRuevAyVmfukCkN1a5oiftnCs5Jl X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > [... snip ...] >> I think "growing" and "lot of" don't describe the effort. Rewriting to >> use gnulib (and the corresponding necessary testing) might be trivial as >> well (though I don't think so), but the returns are still very small. > > i disagree with your assessment. the patch proposed isn't exactly trivial, > nor is it widely tested like gnulib. > > further, if you read the existing binutils/configure.ac, there's a lot of > "copied from gnulib" logic in there that would get cleaned up. there's > also logic for old systems that i doubt aren't actively tested (e.g. who > is actually building on Next 3.2?). > > even further, readelf isn't the only file under binutils/ that uses fseek, > but it seems to be the only program you're trying to fix. so the others > are still broken, which wouldn't be the case if gnulib was used. > > even even further, gnulib is already in the tree. it isn't like you have > to import & integrate its build logic or manage its autotool logic or its > header paths. there are 3 top-level projects using it now, one of which > i converted, and it was pretty trivial. FWIW, we are considering making BFD to import a gnulib module with the sframe encoders and decoders (we already submitted the new module to bug-gnulib and it is under review) rather than having to maintain a separated libsframe in the tree. I also agree with Mike in that using gnulib in bfd would bring many other advantages...