From: Richard Sandiford <rdsandiford@googlemail.com>
To: "Maciej W. Rozycki" <macro@codesourcery.com>
Cc: Catherine Moore <clm@codesourcery.com>, binutils@sourceware.org
Subject: Re: [PATCH 10/20] MIPS/GAS: Fail on 64-bit addresses used with LI
Date: Tue, 07 Dec 2010 10:25:00 -0000 [thread overview]
Message-ID: <87vd35ani6.fsf@firetop.home> (raw)
In-Reply-To: <alpine.DEB.1.10.1012020114000.14129@tp.orcam.me.uk> (Maciej W. Rozycki's message of "Thu, 2 Dec 2010 19:20:10 +0000 (GMT)")
Patch 9 is OK.
"Maciej W. Rozycki" <macro@codesourcery.com> writes:
> binutils-gas-mips-lidd-assert.diff
> Index: binutils-fsf-trunk-quilt/gas/config/tc-mips.c
> ===================================================================
> --- binutils-fsf-trunk-quilt.orig/gas/config/tc-mips.c 2010-12-01 21:05:50.000000000 +0000
> +++ binutils-fsf-trunk-quilt/gas/config/tc-mips.c 2010-12-01 21:05:51.000000000 +0000
> @@ -7039,6 +7039,7 @@ macro (struct mips_cl_insn *ip)
> else
> {
> /* FIXME: This won't work for a 64 bit address. */
> + gas_assert (HAVE_32BIT_ADDRESSES);
> macro_build_lui (&offset_expr, AT);
> }
>
Not OK. This trivially triggers for:
li.d $f2,1.1
assembled with -mabi=64 -G0.
Richard
next prev parent reply other threads:[~2010-12-07 10:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 19:20 Maciej W. Rozycki
2010-12-07 10:25 ` Richard Sandiford [this message]
2010-12-09 16:09 ` Maciej W. Rozycki
2010-12-09 17:41 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vd35ani6.fsf@firetop.home \
--to=rdsandiford@googlemail.com \
--cc=binutils@sourceware.org \
--cc=clm@codesourcery.com \
--cc=macro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).