From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id E19AB3858D33 for ; Tue, 21 Nov 2023 17:45:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E19AB3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E19AB3858D33 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700588717; cv=pass; b=Wgk884v1eljpd/3ldas71atNK+6Sdy+nS/pJ1+dekdO44htFzFIyyYflEPtvrjaZgJUTCpsycBsu2bwNd4gmjEK/BRYK4BdnfKe8zj3GbaopZzJkP/VX6h9HAxCnEpytJyy7sBR3XoYNi6ES3YRp7y3seMuq5t5McamtV1VGULk= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700588717; c=relaxed/simple; bh=MCKukcWogluSi5bJA1liQGuPkIvxSvcDTIgPDI7gMfA=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=UlAbpb/YGF/TofIQu4/q6OlBQHnxeG/acL7DsBW5PKs/CRJZJgvq320rfhHIlMqkOOVnYVN3vlMwvce/ubQ5EvfrrLwuRc7o27PQ6NfAAurVIMbryJE2rNmaYcAuBqcpLKqz3C0WTNVMxy+v+NwaOOTrJt1hG424LgcqP1t5fLo= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3ALHe8AG026078 for ; Tue, 21 Nov 2023 17:45:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : content-type : mime-version; s=corp-2023-11-20; bh=27tKKjeulHdRjD0sigEoC+Y5R9hTSvuPIzOgfskfzOM=; b=TEgcwgegiWFkweKWBsVYNpZ2zA+7GhGAOMsCIRPnsBrEHLPlguRVulJNrxTYlpgOvE0U Houv/VfXVwJ/3ThCk+7+zYPhPylER8f4Vf5gy7oRCdYL6viuHRctqQXUYpgkt3HVakeS zGM85oYOna44JFi69l5HP65uP9v2EXHPSJP9S4V0cYIVMJoi4s2rlCxPGBXq2ynULhCk qySI3tU78WUnTIJ2hoU3QL4AByOMN9Lh/S/EvO7QUOev92G9DZutQMp7BgcbsAAbgpTf jBCLDkQz5SMmR5HGY9ju02Waa95ub775sbgxsC8Edg6WBuHcgfvLZ6s5aIvkBqCHJgVO gw== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3uekv2wpsk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 21 Nov 2023 17:45:14 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 3ALGZvrl002428 for ; Tue, 21 Nov 2023 17:45:13 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2169.outbound.protection.outlook.com [104.47.56.169]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3uekq7c1we-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 21 Nov 2023 17:45:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WXvrAb7ltnD2oQZhJ6PS3wOFjtQFR6jyo+vp7qdkWkOvN8bZ1uf1Z0Kauh2T8NIXH+sqwB+XoWbDyaoWb4/V6i9mLBUSj2pzA+rsK2+/OnGw9BTlh+YQnsggblniBoXVg6wrbimwu9yOSIDJLGD1wRf75r1wrde2sidD6Up4cbnflyZ6q0KMZMbiJPjI3o/wq6fQjjNQjLgDAp3938squpZhpakjHy1U369vpKc6gKd73wuBQziWqbo1tpWqMFdH8aW8hlLnJM0mTfxl/BoCYJ48p5uqgRYNz29cGoO8js/EMmtCEF9Tj/Net07lDeVyCuxWvojkeY2i3W7wRVnN7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=27tKKjeulHdRjD0sigEoC+Y5R9hTSvuPIzOgfskfzOM=; b=caBDFnyHkENDlryqA01WChQryHmo6sBr+EnXBZwbjFpCmeaCMX/2NbJ1MpcG13basgRWFyEB6H6Z77aX0wKoGgJ4dXUXLjkzdwuayTfH1W+qT7QL7vGvVFEcbbQuNBJC+ldnrPRhovLW561wTbvHheNvHdUUWdtyN9+ihK1IPufE8LrSNVFOo8HomrKPtqTvSfXSB9yrryyUnba3OAV8jsacx7JFLC9y3wPZScHPbwsWMp9hP8Xdbhj0vOklT4byHqX+DRZMPMJykAIJksG47xyl8h8Ecx6SQ79f1vb0LQn2lFJfeS27X51bDR9irQflOWmi9VHvei+5tg24PjYL5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=27tKKjeulHdRjD0sigEoC+Y5R9hTSvuPIzOgfskfzOM=; b=PfIOvMaAk6mer9CYfLk9AmQTVSRvM6RoKP0KUJ95Ux8RaAqnItPQwB1pS0foXFA+D9bICZtwliqH3S+w0LQ4/OyRj2NXMOvLxsvEDEsTaNss6SpMh9KNfInR3auU79DQnG42leWKH0r2s8t1WxQ9TtDbzsT/I3odsg5orCvcduo= Received: from BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) by DS7PR10MB4910.namprd10.prod.outlook.com (2603:10b6:5:3a4::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.18; Tue, 21 Nov 2023 17:45:11 +0000 Received: from BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::ba16:f585:1052:a61c]) by BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::ba16:f585:1052:a61c%4]) with mapi id 15.20.7002.027; Tue, 21 Nov 2023 17:45:11 +0000 From: "Jose E. Marchesi" To: Cupertino Miranda Cc: binutils@sourceware.org, david.faust@oracle.com Subject: Re: [PATCH] bpf: Fixed register parsing disambiguating with possible symbol. In-Reply-To: <20231121173447.29928-1-cupertino.miranda@oracle.com> (Cupertino Miranda's message of "Tue, 21 Nov 2023 17:34:47 +0000") References: <20231121173447.29928-1-cupertino.miranda@oracle.com> Date: Tue, 21 Nov 2023 18:45:06 +0100 Message-ID: <87wmubknkt.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: text/plain X-ClientProxiedBy: LO2P123CA0069.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1::33) To BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB2888:EE_|DS7PR10MB4910:EE_ X-MS-Office365-Filtering-Correlation-Id: 52df538f-a19f-4caa-02ae-08dbeab99bcc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kBzhs9W8RsvYTLTEHA2J+CNG8LVOBJ5FbhLeSKpRGrO2GlZ7mIX2mFaBHy93C6giYYuuZc/6/h7wvyPaWIiwDR+1i56N5nPIvPYeRCvGbhbJs0/CeUND6SuG/5jYjUGyslG9jnbA3ViFYwXNmTf4AKqsmryYttrk6M0d9aYqFPNnHtvo3wXYLAKzyxWjUPlnTy5Hm8RudtLanWxwPuzJ83o49sEMJO7R3pLErScK6oxQdHvDRtfvkpJUS/Z3WP+hFy2B1288keVlC6TO/Hv0XkLJWvieSfljlpAzGJqXvNboxqoJI0rXgFJjFBl7p7+EZr6l0n2D7a5bNHboA/h+aF0ziP5s/LRHxUECNrmDfIGMuzyu+YQzyTbsYAUSJIfFbyFw8lsHl5dD0F9RsFnPC2AWS0J0/uBV+fFcNH4v8+ox3oGt3GWjur85aKEzRt4igInLh7soN7MnW2SLqalsn9WXlwAjhjfnpJIAoLk2yKLBdFEHMQwgeyFWY6jvARVJhGGFOs17cyow8veqLi2QQvBSQ1rHYbe4w92OX47yxlA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2888.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(346002)(39860400002)(376002)(136003)(396003)(230922051799003)(451199024)(186009)(64100799003)(1800799012)(41300700001)(36756003)(86362001)(5660300002)(2906002)(8936002)(6512007)(6486002)(478600001)(6506007)(6666004)(83380400001)(107886003)(4326008)(6862004)(8676002)(38100700002)(26005)(6636002)(66556008)(37006003)(66946007)(66476007)(2616005)(316002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NH/wuzhORf/vl5/sa1NNKrI2Pve3Bz8iibYrPj6VAYGZ2FWf8yQmDhm0j6X0?= =?us-ascii?Q?xCsbjmBha58Hye2klk977qfWK9KM2q+xYNtUAXZULVL3jXGCWK1llITbQWMD?= =?us-ascii?Q?W10F8c6MoIz2NjzJQtIMpJpkRPhZlgFtExbK6WBuUdsqan+DK/UBmzsBFmb1?= =?us-ascii?Q?z+O1eR1EJypv2oxp1KAVZ1+u/NH1N/pdoobrYy4FuwIrTRH8nQSC5iL1+7Tk?= =?us-ascii?Q?pW/9G/tiOBAgKacBDHVJjeqU9OXkMpJz4xs2eVpulPI5o4ZKN70y29U6JwyO?= =?us-ascii?Q?4jMXLy5o9PhvECBekthUg7mmbwpMby1aE5y1KciO8DIMtslmMvErxlzQNaMz?= =?us-ascii?Q?3EGsr1cigB0mXHAZny/kAsieQkWRIIQ84HY5NVA975+FcDlvcFUkRFeh75y1?= =?us-ascii?Q?uOI2cY3uRfnVZmolD3q0LH/wTebjvY8pMmsllRhUItBQ+7FXa7yiiXCpytg4?= =?us-ascii?Q?niQj4Sp1HLuy/a4CZgouS3P09K4CPqr4a0INHD25ziPvYZ+Omc8S+s1aW/Sz?= =?us-ascii?Q?d/VWq8LeJLlhfJGmhoorQBVyKAohkem9I/hsukqZYTbVsC+RxfWfw0iOvqsv?= =?us-ascii?Q?eqFWS849Ou2iS0kqxkhLoFmRJ2qcQ0GBNkmi7owjKMjSZqI0E9Q88XOU+HtI?= =?us-ascii?Q?5StYOyoPlMAkvNbXJ6jfjww3LcYDgS59BLf2UtClFy7bWBiaW6PISwdAOGrR?= =?us-ascii?Q?PuX11f5a+gNQYw7pe8N0flXYKSHYjZVmo5T7NroUw2f4sBLN2Xg6mJhV5ZqJ?= =?us-ascii?Q?ImnGSfJAEqCAKxM9jJXmU6zJrb/OdqJcw7uh7b8tOes5KAgW02V0UdUVQlYE?= =?us-ascii?Q?tgdRQlUGvRWIyQWRctRl/z/bgJBp8AiF+3uGqS3o80A/IjibInrqb5CXaKxt?= =?us-ascii?Q?jNIyxTo4yzSKV3i4NAtCff8QKfBxhZwIHpTxnWw8lNoKi1pHHIMCOzf0SmEg?= =?us-ascii?Q?zepRxhld48lDAJRD6hDhyTDJXUuawUfAgnE4V84IL1IoUUNQNO4/Cj/rjciP?= =?us-ascii?Q?wTp0/WjrOlHbK9o0yWxS13Rl2aXMgTmG84iWHqsXmxDTXdb+frLVFR6IuWpz?= =?us-ascii?Q?crMPVKf2nhgXHN+Ze7kAmbhuYk3p9SmcJwdF/VlHT2zBAGmC0vaOrKkh9A4Z?= =?us-ascii?Q?eShDBxy1M223OHxTxqyy8tmGgtfHKe8A158HfE838xeazqxaJFh4B8CCXGO/?= =?us-ascii?Q?GI5daUI3dMEhpeiFXqOBtTE7p3/2yO2dbjM9Ek2yO+CsAmuv+MEg5iWrnjGh?= =?us-ascii?Q?nuwVB2or0rxADbadCLukwlTFFRsWnNVsb9/3F0IMKYXC4fnHNP9Eei4eE0un?= =?us-ascii?Q?Zlz3svzsD71iZ6NuFFSnl0GDAVGiJW+U3J6lW3b6B3q/e5+vnEh0BliIW6cR?= =?us-ascii?Q?ii93pTTpj/xUUfN5/Q5xRCC+Q3eDFz42jCm3Ckhxs/jUtbI4Nab0fgrLkged?= =?us-ascii?Q?aCzgJ5bBZnXMdW/SqlfmlV0zMWN1VIuFCSUu/CXPVPrH8D+dpBrBWFlIiwaR?= =?us-ascii?Q?1XXajVaiGN272dJKgXIimUnIFB3aLxh07Md/qOdYyAWi0w+muP0WT7cUb1pK?= =?us-ascii?Q?jy891BbJSTKlOTqGSHnyis80dxpUBbsyUoTZ7n0pEcZh89pCHZ/cXATiwV9r?= =?us-ascii?Q?cw=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 0/KPUpL9iIE9PrnXGRPnE6qkKI7hUVLFFVeyf4iTW96mSls2/K4Am7DCQkOHWu98Zp8M+HnRUQ24sUirtLylV+U6a77zMqVy2D8a5ASLZ1R+Do6FC/6y50x+jB1XXM/7+iuc58He00S2FgJX9zGH8q8Smjy8ojsFnNJng7J2EB9gwGIqVuP7VqZoyd+6f4J95TrVEaHodzgNxs8i0YGgGyiihJ8WOQTPyEYcqo4nw9dArPIUY7mA20V02jGID6HWPmDZ0QaKrT+O8RZkwf1ul15vvlVBbxUUPZR/y3gF58sf5Tqsy+tsEfl7fqNqlq7TUuyR7OW41aA+zqK5lebdXo7fqeIdFNfA0LaKdKxIAZMy6rkEA7vlOh+tZycs6xHpGHcvTWfbjHkP50haPFS8H0buHqePblfuMcgDLewKMtGyAUFXCilTQVp9psCrPTmdBKTi0ahg0CqIEAd8fb/vMa924FV+hrn9FyYUxoFkv2k7izaZp9vpz2fflEju9vgIA8GVLVraZROUN7IUd/8UPoWNqDDZv/Wir117SZgUZ589MzdERkhTn7YZ5T2KQfvLPMzirrfhHISbg3c5sgygFNA1csaNsSW6MLewjA6XKFW4Kk52hw+H1ohNdhAQxXMsH7JnoV2e06I35feuc+kZqZhpXEBPx55sYWyTNpCdxfZoZsPOjAqvvwciL2ijLK9Ayia5iRv8W1FVnfDkYfoPhzNkIpc0zLMXONOwJdJYb7i0GmL5crAq5yrILM701jwHAXiUrcJNNmfIuW0TpipHnw== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 52df538f-a19f-4caa-02ae-08dbeab99bcc X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2888.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2023 17:45:11.0464 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gE4rYN/azRCXx6lnaLDSvX4KqCIVmLLDv/raZF20ckuMXCIOdo9fpvdKETfgFzLzvvSyFIYbrXGPbks2EX8a9JfxYR26GhRWfP5lIC0TzcI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB4910 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-21_10,2023-11-21_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 adultscore=0 malwarescore=0 spamscore=0 bulkscore=0 phishscore=0 mlxlogscore=853 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311210139 X-Proofpoint-GUID: 2pNCtkWOp_5J2d2yMm47QaIvqJt2ONkt X-Proofpoint-ORIG-GUID: 2pNCtkWOp_5J2d2yMm47QaIvqJt2ONkt X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Cuper. The patch is OK. Thanks! > This changes parse_bpf_register to detect possible symbols that start with valid > register name, however due some following characters are not. > Also changed the regs-for-symbols-pseudo.s, adding some entries that > should not error if parser is properly detecting the symbol. > --- > gas/config/tc-bpf.c | 4 ++++ > gas/testsuite/gas/bpf/regs-for-symbols-pseudoc.s | 3 +++ > 2 files changed, 7 insertions(+) > > diff --git a/gas/config/tc-bpf.c b/gas/config/tc-bpf.c > index 45abc3c9578..b6b1db47427 100644 > --- a/gas/config/tc-bpf.c > +++ b/gas/config/tc-bpf.c > @@ -1300,6 +1300,10 @@ parse_bpf_register (char *s, char rw, uint8_t *regno) > s += 1; > } > > + /* If we are still parsing a name, it is not a register. */ > + if (is_part_of_name (*s)) > + return NULL; > + > return s; > } > > diff --git a/gas/testsuite/gas/bpf/regs-for-symbols-pseudoc.s b/gas/testsuite/gas/bpf/regs-for-symbols-pseudoc.s > index 693787d5479..9b75f275285 100644 > --- a/gas/testsuite/gas/bpf/regs-for-symbols-pseudoc.s > +++ b/gas/testsuite/gas/bpf/regs-for-symbols-pseudoc.s > @@ -2,3 +2,6 @@ > r2 = r3 ll > r2 = r3+1 ll > r2 = 1+r3 ll > + r2 = r2d2 ll > + r2 = r2d2+1 ll > + r2 = 1+r2d2 ll