From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta33.uswest2.a.cloudfilter.net (omta33.uswest2.a.cloudfilter.net [35.89.44.32]) by sourceware.org (Postfix) with ESMTPS id B46F43858D20 for ; Tue, 22 Aug 2023 23:09:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B46F43858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from eig-obgw-5002a.ext.cloudfilter.net ([10.0.29.215]) by cmsmtp with ESMTP id YQZjqL7TLOzKlYaVZq8w8U; Tue, 22 Aug 2023 23:09:57 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id YaVYqfIKtxrRoYaVYqajzY; Tue, 22 Aug 2023 23:09:56 +0000 X-Authority-Analysis: v=2.4 cv=WZcf1mtX c=1 sm=1 tr=0 ts=64e54044 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=UttIx32zK-AA:10 a=Qbun_eYptAEA:10 a=zstS-IiYAAAA:8 a=brt4uBImAAAA:8 a=CCpqsmhAAAAA:8 a=DMiVl_LZ8FjkDPxNUV4A:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=Kf_jLVXHvK0LmgOhLAe7:22 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From:Sender :Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=G6jNS8Dj4JL+51ghlnJjsv3yDrqMJV4WnKTa1NROoj8=; b=q2FkgqJEcLJTH7irglRwYT6GaO ZVjsY0BTtYMjyDEga6zm2a87YKWeImqWYeYxAiRzgyjP88of7gDphy4nlrAiMKhSpU70jDHHKyns2 sSkUWHhuwVvFEbwL2n9Peps7m; Received: from 75-166-142-177.hlrn.qwest.net ([75.166.142.177]:53810 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qYaVY-000ty8-0O; Tue, 22 Aug 2023 17:09:56 -0600 From: Tom Tromey To: binutils@sourceware.org Subject: [gmane.comp.gdb.patches] [PATCH] Simplify definition of GUILE X-Attribution: Tom Date: Tue, 22 Aug 2023 17:09:55 -0600 Message-ID: <87wmxmu118.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.142.177 X-Source-L: No X-Exim-ID: 1qYaVY-000ty8-0O X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-142-177.hlrn.qwest.net (prentzel) [75.166.142.177]:53810 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfFnegO/CFpkzAeLIwLPJywK4idchJeGa5am+2L9mfC94JCqvVK+spcERfLEktY50Lsw3P2Kw1o/OynDof04LIfzomTXp3CViU6AC5tHVpfmD5MlEENJR F60pDVlXl377TG6awWA4v/4ShXbDyfqcBztwy6W+qCFjl3gTRN3FT9GanNnlt/Dp9iNbL4N7FzxtI1A9E53dBrkKpyX2MuiwVFI= X-Spam-Status: No, score=-3024.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_BL,RCVD_IN_MSPIKE_L3,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I meant to send this to binutils as well, but typo'd the email address. Let me know what you think. -------------------- Start of forwarded message -------------------- From: Tom Tromey Subject: [PATCH] Simplify definition of GUILE Date: Tue, 22 Aug 2023 13:48:04 -0600 Cc: binutils@sourcware.org, Tom Tromey To: gdb-patches@sourceware.org This patch sets GUILE to just plain 'guile'. In the distant ("devo") past, the top-level build did support building Guile in-tree. However, I don't think this really works any more. For one thing, there are no build dependencies on it, so there's no guarantee it would actually be built before the uses. This patch also removes the use of "-s" as an option to cgen scheme scripts. With my latest patch upstream, this is no longer needed. After the upstream changes, either Guile 2 or Guile 3 will work, with or without the compiler enabled. --- opcodes/Makefile.am | 2 +- opcodes/Makefile.in | 2 +- opcodes/cgen.sh | 2 -- sim/Makefile.in | 2 +- sim/common/cgen.sh | 4 ---- sim/common/local.mk | 2 +- 6 files changed, 4 insertions(+), 10 deletions(-) diff --git a/opcodes/Makefile.am b/opcodes/Makefile.am index 5d179e13168..5804dd1ab38 100644 --- a/opcodes/Makefile.am +++ b/opcodes/Makefile.am @@ -336,7 +336,7 @@ CLEANFILES = \ CGENDIR = @cgendir@ CPUDIR = $(srcdir)/../cpu -GUILE = `if test -f ../guile/libguile/guile ; then echo ../guile/libguile/guile; else echo guile ; fi` +GUILE = guile CGEN = "$(GUILE) -l ${cgendir}/guile.scm -s" CGENFLAGS = -v diff --git a/opcodes/Makefile.in b/opcodes/Makefile.in index 605ce0a9ff2..29c26263061 100644 --- a/opcodes/Makefile.in +++ b/opcodes/Makefile.in @@ -695,7 +695,7 @@ CLEANFILES = \ CGENDIR = @cgendir@ CPUDIR = $(srcdir)/../cpu -GUILE = `if test -f ../guile/libguile/guile ; then echo ../guile/libguile/guile; else echo guile ; fi` +GUILE = guile CGEN = "$(GUILE) -l ${cgendir}/guile.scm -s" CGENFLAGS = -v CGENDEPS = \ diff --git a/opcodes/cgen.sh b/opcodes/cgen.sh index 40ebdf3ca0a..9497c1bf853 100644 --- a/opcodes/cgen.sh +++ b/opcodes/cgen.sh @@ -99,7 +99,6 @@ opcodes) # Run CGEN. ${cgen} ${cgendir}/cgen-opc.scm \ - -s ${cgendir} \ ${cgenflags} \ -f "${options}" \ -m all \ @@ -182,7 +181,6 @@ desc) rm -f ${tmp}-opc.h1 ${tmp}-opc.h ${cgen} ${cgendir}/cgen-opc.scm \ - -s ${cgendir} \ ${cgenflags} \ -OPC ${opcfile} \ -f "${archflags}" \ diff --git a/sim/Makefile.in b/sim/Makefile.in index 3da1b25d040..3dd14543450 100644 --- a/sim/Makefile.in +++ b/sim/Makefile.in @@ -1871,7 +1871,7 @@ SIM_COMMON_LIBS = \ $(LIBGNU) \ $(LIBGNU_EXTRA_LIBS) -GUILE = $(or $(wildcard ../guile/libguile/guile),guile) +GUILE = guile CGEN = "$(GUILE) -l $(cgendir)/guile.scm -s" CGENFLAGS = -v CGEN_CPU_DIR = $(cgendir)/cpu diff --git a/sim/common/cgen.sh b/sim/common/cgen.sh index 394ef2d2e1b..a7479ec8d4c 100755 --- a/sim/common/cgen.sh +++ b/sim/common/cgen.sh @@ -60,7 +60,6 @@ arch) rm -f ${tmp}-all.h1 ${tmp}-all.h ${cgen} ${cgendir}/cgen-sim.scm \ - -s ${cgendir} \ ${cgenflags} \ -f "${archflags}" \ -m ${mach} \ @@ -125,7 +124,6 @@ cpu | decode | cpu-decode) esac ${cgen} ${cgendir}/cgen-sim.scm \ - -s ${cgendir} \ ${cgenflags} \ -f "${archflags}" \ -m ${mach} \ @@ -187,7 +185,6 @@ defs) rm -f ${tmp}-defs.h1 ${tmp}-defs.h ${cgen} ${cgendir}/cgen-sim.scm \ - -s ${cgendir} \ ${cgenflags} \ -f "${archflags}" \ -m ${mach} \ @@ -205,7 +202,6 @@ desc) rm -f ${tmp}-opc.h1 ${tmp}-opc.h ${cgen} ${cgendir}/cgen-opc.scm \ - -s ${cgendir} \ ${cgenflags} \ -OPC ${opcfile} \ -f "${archflags}" \ diff --git a/sim/common/local.mk b/sim/common/local.mk index 5d0992fbd9e..08da2275b7d 100644 --- a/sim/common/local.mk +++ b/sim/common/local.mk @@ -178,7 +178,7 @@ SIM_COMMON_LIBS = \ ## ## If the local tree has a bundled copy of guile, use that. -GUILE = $(or $(wildcard ../guile/libguile/guile),guile) +GUILE = guile CGEN = "$(GUILE) -l $(cgendir)/guile.scm -s" CGENFLAGS = -v CGEN_CPU_DIR = $(cgendir)/cpu -- 2.41.0 -------------------- End of forwarded message --------------------