Re: [PATCH 2/2] Changed ld and gas BPF tests

[Cupertino Miranda <cupertino.miranda@oracle.com>]

Hi Jose,

I removed those relocations. Until proven otherwise the approach was to
assume that we will not needed it until we do. I could not come up with
an use case that we could practically needed those.

Regards,
Cupertino

Jose E. Marchesi writes:

> Hi Cuper.
> Thanks for the patch.
>
>> diff --git a/ld/testsuite/ld-bpf/reloc-data.s b/ld/testsuite/ld-bpf/reloc-data.s
>> index 431ef5aef61..90a5ff06896 100644
>> --- a/ld/testsuite/ld-bpf/reloc-data.s
>> +++ b/ld/testsuite/ld-bpf/reloc-data.s
>> @@ -10,7 +10,3 @@ d64:
>>      .quad foo
>>  d32:
>>      .word d64
>> -d16:
>> -    .half d32
>> -d8:
>> -    .byte d16
>
>> diff --git a/ld/testsuite/ld-bpf/reloc-data-be.d b/ld/testsuite/ld-bpf/reloc-data-be.d
>> index 4d793e2b41a..05734b12094 100644
>> --- a/ld/testsuite/ld-bpf/reloc-data-be.d
>> +++ b/ld/testsuite/ld-bpf/reloc-data-be.d
>> @@ -8,4 +8,4 @@
>>
>>  Contents of section \.data:
>>   0020 666f6f00 62617200 00000000 00000020  .*
>> - 0030 00000028 003034                      .*
>> + 0030 00000028                             .*
>
>> diff --git a/ld/testsuite/ld-bpf/reloc-data-le.d b/ld/testsuite/ld-bpf/reloc-data-le.d
>> index 97cb1b36a2a..8cabc7fae5c 100644
>> --- a/ld/testsuite/ld-bpf/reloc-data-le.d
>> +++ b/ld/testsuite/ld-bpf/reloc-data-le.d
>> @@ -8,4 +8,4 @@
>>
>>  Contents of section \.data:
>>   0020 666f6f00 62617200 20000000 00000000  .*
>> - 0030 28000000 300034                      .*
>> + 0030 28000000                             .*
>
> Why removing d16 and d8 from reloc-data.s?