From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112918 invoked by alias); 29 May 2019 16:04:23 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 112908 invoked by uid 89); 29 May 2019 16:04:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:979, crushed, dear X-HELO: mail.esperi.org.uk Received: from icebox.esperi.org.uk (HELO mail.esperi.org.uk) (81.187.191.129) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 May 2019 16:04:22 +0000 Received: from loom (nix@sidle.srvr.nix [192.168.14.8]) by mail.esperi.org.uk (8.15.2/8.15.2) with ESMTP id x4TEeoEf016895; Wed, 29 May 2019 15:40:50 +0100 From: Nick Alcock To: Rainer Orth Cc: Simon Marchi , gdb-patches@sourceware.org, binutils@sourceware.org Subject: Re: Oh dear. I regret to inform you that commit 0e65dfbaf3a0299e4837216a103c28625d4b4f1d might be unfortunate References: <0e65dfbaf3a0299e4837216a103c28625d4b4f1d-master-breakage@gdb-build> Date: Wed, 29 May 2019 16:04:00 -0000 In-Reply-To: (Rainer Orth's message of "Wed, 29 May 2019 12:21:07 +0200") Message-ID: <87woi9458f.fsf@esperi.org.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-DCC--Metrics: loom 1481; Body=4 Fuz1=4 Fuz2=4 X-IsSubscribed: yes X-SW-Source: 2019-05/txt/msg00427.txt.bz2 On 29 May 2019, Rainer Orth told this: > /vol/src/gnu/gdb/hg/master/local/libctf/ctf-archive.c: In function 'ctf_arc_bufopen': > /vol/src/gnu/gdb/hg/master/local/libctf/ctf-archive.c:320:33: warning: comparison is always true due to limited range of data type [-Wtype-limits] > 320 | if (le64toh (arc->ctfa_magic) != CTFA_MAGIC) > | ^~ > /vol/src/gnu/gdb/hg/master/local/libctf/ctf-archive.c: In function 'ctf_arc_open_internal': > /vol/src/gnu/gdb/hg/master/local/libctf/ctf-archive.c:357:33: warning: comparison is always true due to limited range of data type [-Wtype-limits] > 357 | if (le64toh (arc->ctfa_magic) != CTFA_MAGIC) *Thank* you for this. This revealed significant signedness problems on 32-bit platforms with long <= 32 bits in length, all of which I have now crushed, to the net benefit of the codebase. :) Running tests and writing changelogs now.