From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 8674E3858D20 for ; Mon, 11 Mar 2024 15:14:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8674E3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8674E3858D20 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1710170070; cv=pass; b=q2yKo+c21vjgkaEvnUKxJJtsNckdSWINr+7bgzcTmBp7ua7Yr6DkbKgSsF66wG+ZB0+ffuK2pAKxK62LDzGh4iBZcIn9f6YbKdToXrqxOu4P5uX9V1dvFOQ1+8ztFgE6h3wWRB1wrQBEgPtjgqmx2fqkAiLcRq0FTV0xTcdnGvA= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1710170070; c=relaxed/simple; bh=2FaPW6wJaEEnNzYBT93NzTAHREtPx1gisqmsl6kGCiY=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=jw3x7wSCGCJEdR4mNdm+dAHevpKc80bdE1KCBU1CZtRQi+w/96udtY9JuZeaMfPZ381JpMsr3CspWLh48lNVqED4qOd13u4MQ8KRD0iJzHie89QaeqtOqA5k/fV7eZZfrawanufJpq4N3qWBujXUVud8gnbWePaqAoACN8tHQDU= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 42BF7KSI027534; Mon, 11 Mar 2024 15:14:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : content-type : mime-version; s=corp-2023-11-20; bh=ZVWrOD2zJuzVmKTUT4bBeGkB0ZmKO2fgTUDZiTPiUUE=; b=eIXrzA1vLM8x48LPDKO1b+oYORLPmNJmKvcbqKahrO5OknPNQrn4uPyqSdygZCdCzcNJ +CRuaOrumko+IT/FTG2sVR2XsZGdoDLZP1J+3UI/awVZjAKf2VAXmVhV66GR8L9adT5f v4BQqzCMOJEDbsgKPMyIvmuRlwxcC+tRJeJDZ77t+K0rtdSSicYSKL7nWqHSKEa9sbvz jAbLO4MnscSHWXWUTqAuzbYG0UkgyqV4ufIVxaqZ976d6b5WKsAOOmG6KVr2a7l48Jog CvWNiO8PslvGgh+/eu+EjPU4C3ddx/T4DZk9qpkUmKLGO+jaBQNcV1uCirJrPE3THBUr Ew== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3wrepcujhf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 11 Mar 2024 15:14:16 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 42BEiQB9033810; Mon, 11 Mar 2024 15:14:15 GMT Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam04lp2040.outbound.protection.outlook.com [104.47.73.40]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3wre75mvgt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 11 Mar 2024 15:14:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eQUbQCX1gsVCBi2D+OcaOvQIrav9O74BomJwyiiJqLx3b3TmSyd4FCnRDsPdcF5Spzv68AvGOALrEqYOG4hSoW5gORmo3IDXbY+OztoUUVq3BaI0ETm7L3j0fY//VAeknDz5PX9439nFeYpApF0SkOwIk6jbbjRIOq8IHW1cmdmSRqc7RsJVC2hKa9sWt2zL40v7t0iBKT1yRl/QC+CyYZBzWkpVHd7MRa6cXExwpa8KaetzhcmkFu9rktmRznolA8PeRJcEMxMGCccjHfFXMB2mt+47Mr8bQIocts/awjnRrX9yM4zdxWoL+uqEnAGjTK27X3/vhD3u7JNFlIW0Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZVWrOD2zJuzVmKTUT4bBeGkB0ZmKO2fgTUDZiTPiUUE=; b=HmlG2iHmwnCrOtju0sRjhKuzVTji4MK/DqI+HjFa0N4Bjwmac8lwVWO8hKs2ygkmnnJTZv+S0htNYxuWT28oqrSCpwRVhz9xq0RluRgHozg1Wb84H97pmT9+o8rdBuVaMKcJF+R0DEcjR5em1x+zkBjTAzNDDk6sj3nAVPqiclOhe3ijhV8immHDGRq46jS2e74tS95ruCcm6cMLqgLDjKWI4bR6JOA6Gb1urT1Uvef8nU4L83CTxtCFuCphBDqAcR2kACcMAlG1poaEijotk7FV2Sxy3Wn8e8WrGmYpVfUVg9Y9UrEuHgWRO+iNqsHHrL0L7kX1pe8JusZ6UdpT7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZVWrOD2zJuzVmKTUT4bBeGkB0ZmKO2fgTUDZiTPiUUE=; b=X6uHqAqkMNy3MhS7gyMIx/9OP4kpXqr9PdC3GvoIS587qPP4OMPgadJ0SjZZgg9BpJ837KUyMQ6NXMWxrYIzxhP9PjtTe0mNF72AVR0wLb/M3x312EyW5ZsQgOpFHW+AOv6aR6w0foPMM7wGMFAQI7VyHXpV2sK80Q0/b5s+fMY= Received: from MW4PR10MB6608.namprd10.prod.outlook.com (2603:10b6:303:22e::8) by IA1PR10MB6074.namprd10.prod.outlook.com (2603:10b6:208:3ae::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.35; Mon, 11 Mar 2024 15:14:13 +0000 Received: from MW4PR10MB6608.namprd10.prod.outlook.com ([fe80::67a4:9544:7249:7751]) by MW4PR10MB6608.namprd10.prod.outlook.com ([fe80::67a4:9544:7249:7751%7]) with mapi id 15.20.7362.035; Mon, 11 Mar 2024 15:14:13 +0000 From: Nick Alcock To: Sam James Cc: Andreas Schwab , binutils@sourceware.org, torbjorn.svensson@foss.st.com, yvan.roux@foss.st.com Subject: Re: [PATCH] libctf: check for problems with error returns References: <20231009151146.3818141-1-torbjorn.svensson@foss.st.com> <20231013140152.427376-1-nick.alcock@oracle.com> <87sf2evr35.fsf@esperi.org.uk> <87zfv8p1ie.fsf@gentoo.org> Emacs: don't cry -- it won't help. Date: Mon, 11 Mar 2024 15:14:06 +0000 In-Reply-To: <87zfv8p1ie.fsf@gentoo.org> (Sam James's message of "Sat, 09 Mar 2024 02:44:41 +0000") Message-ID: <87y1ao243l.fsf@esperi.org.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) Content-Type: text/plain X-ClientProxiedBy: LO2P265CA0463.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a2::19) To MW4PR10MB6608.namprd10.prod.outlook.com (2603:10b6:303:22e::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR10MB6608:EE_|IA1PR10MB6074:EE_ X-MS-Office365-Filtering-Correlation-Id: c0fdd128-46cb-4912-3807-08dc41dde90f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XHRcq/CXoDJQmoOPdyCzqwLFZGgVKnZhUxmDYs+AJKiWzGSzlzLgYJWmWn1SfXyj25aZhICBSraZ6fTdjFxmvb2GKihu+9fs7C2h7DwVcEyxqxF5cLZ4wdD6iDDZKa3qm4E4WQw3sydaHlk7Gglh8enerJbCnvjZfWIXU255FAvDNOPkO4S/KJPnDkKyQHUuRksoyEzJ8NFw17iONJxo1Df1FbhYXirCURcd0ASKoJrvG1HdD7KTEzdL3nHV3qrb5kkAuPqRMOW408vVo4/HYcp3TBdW/GgQN29sOSxjbLl+W7KStsxX+/312YYaswY2DKCqYYxayutr0KUy0jTZPoJBInvMW40JO5x+qqpD9gED6YXXS8elt3Uk+l0SHn+HbOuzUHacFT+Ty1XEwJ3tBIet89kK67Y48CPi7wvx/xxo5doRv0LLwZO5tEc/m5I3QMYFUVRJTfVeyOgPc/7alLLtN+j7Lce9qF0saEMoruMeCu81UJ4lWdKC0WaUk0cHX6qaic8ZYkXuzA/6GcBcJDYoPzFRCfoxjBJxCCZIH8UoLDw3EVB7VN3+7icvd4vjfW1clcfEpDAztpXUXI+vg0F1eXLqN+40dXUxL9/7he7XsLuA12Mkka0e5wreie7KLIGGdwG1bDrwKz9A8l+8bUDOLpxtfmVg+DDQSjcGCiE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR10MB6608.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wP2b7DRdRMXid4/V38JrJdcTl4W5lsj+hDcgqql8hKkfaDUu+EdiMRoRlPGN?= =?us-ascii?Q?SulccwlXEoPlLLrL0S0fwr+oXnJsFPZvmoSkU1ceotgx+XUL5sXRXHgBt8oG?= =?us-ascii?Q?DRrlcVGOsECe/Th3b22UgQsrTYOTUxr1cLDJ+2MKyr9unG3AiI/aulXD0cVa?= =?us-ascii?Q?JlYScCgTZBcxXXBlonOA0PpY4O7pKKzFfhmuX5RoiU7QHK/UyZxRB24wI6Fv?= =?us-ascii?Q?7Tq9GUtkvf2K8qtk99OJINmOO3GKLflFQGfB0TAJ6Cp6pTqATHcYDZmzko/O?= =?us-ascii?Q?sqWPX5jugbMzt4PGMv9iMLH/KdM3QSiTMaGlKn80SJbj/38cWSynD4ypa5Z1?= =?us-ascii?Q?vOjD4BQ1pFCRynaaNnd7ieQ0zP1RvvJdHk0HB3vopZgrGguJMVRrAgmzE/1W?= =?us-ascii?Q?n4Df1+kWzMazzfdjoCGO/6Dhe8LimVTNT7rqyGjgoulYpVSDP0ayh4ZoAxBV?= =?us-ascii?Q?hQ49Z5QcyoD0QiJyBcVmdDUe4XVeNP1y0/kDnLi322BMJ57o1ib71/OVKbC+?= =?us-ascii?Q?T1fdxnfTeyJObNeM0C4SHM13TYVttBsbgJzfZapPc/t38GTbwcNXBhCX7peb?= =?us-ascii?Q?LwjdT3NchaJKFJOgDw/0MCS2EaJcywZKJ/ODRaXllLWjHqO8dzIiZMmHwruk?= =?us-ascii?Q?iWKro8V+UDhMrLheLrE6jifxVzs4q8c2D1Wfxo4GClWbc/rKFTqwOXQPJkVu?= =?us-ascii?Q?tgJnBAqKuskabfQtamZ7nore/Aep2G659mQtuoAZ8bsp7Lk/ROANoCUUBHRi?= =?us-ascii?Q?fBpB3RQvUlN1tSGqTShxPiM9g0tejRYr3ChbwwwfjB4YFmaXeKjeVh23VBVt?= =?us-ascii?Q?7R8GwEJlOINsh6+27dr45qKlx2WVXg6nUgQjklkS3hw4++zhQ48zQnhqO8i6?= =?us-ascii?Q?XdXWy6WqUJetaI/wkLJfwrEGt3d9SMEZqf/VU/MNckf8eSTmsGCGpbl1mwad?= =?us-ascii?Q?pM/wPHskIHKfbXyrJfWYLg7deCBmQfp1P69IZFypQpQxoodMEYhbvOD1csZD?= =?us-ascii?Q?/w92OGw93HK3dyAb2knlQLBacroM5Z4yikPqlW7cKBKNm/dpv6z5Gu4X7VvI?= =?us-ascii?Q?wgqywBSFZGPO3QdIxb9QTUsStX77NdHGmpo48UHbvv2RPF0eXanKSRRgwgBP?= =?us-ascii?Q?XdIIpF6bDaSLcpFIbpcfbOPwtoRhkRfH2sWc9MkUD2jmWJBR7VBN/F2VHGM1?= =?us-ascii?Q?I86u88vg9GsxiwwiOEDx56LJ5RtEPEA9i2IXfu5uCqPV2jY3e21k3ynoPkKU?= =?us-ascii?Q?nL0ip8b/pAWVirkKVhSzYRS4aYVvR6Tt7It/L0BLAms7zeMHed8JA7vkUNL2?= =?us-ascii?Q?1FAcyDHRV7Hj/BiIo24s/YO52DQVUVyzdwczIJ3UnMY9rK9ET8UEUpHMD+WJ?= =?us-ascii?Q?9jOmQrSN77jKaFNjy0SOqSXMl7iq0O41RiPSJfvprwj8mRXC1I6ZQjZ7+Sq5?= =?us-ascii?Q?KdFPlCcWPEXKUoT89ysrxHuXQ5zVcByk3WbHKTiSLvbH09AAg6ZsAh5KCVCP?= =?us-ascii?Q?MEcw9yOy8rdseLkjb92DerqO8EIwYsxiArz13s7C5yM6BC+zi3tBp05dzPY6?= =?us-ascii?Q?iV0NYqlqcSaaHxQMkx60+5qOCdTv+wTzgLm4ASPVQeVuw708VR1n/Ov6GVzg?= =?us-ascii?Q?5Q=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: +AyFXSwSXkGuGXl0oan6XdCDPNACkvwgt15ZEsT4jvKnSmvo9GeGO69gXPx+HW9bko5t38S7fnD+7/n4T21ql02G/sGHtKgeYVzclmNFFvf6mpKcNREp8MeCAaXexO70b++wv/S9Crh/4oOI9IGXOFEoZzFkb3fjOmpiWMf9PnrYJFzp6b26NEHeWNLdM+XWFgOEjDOmjVqdBeZYthpJhGdKHiremdWvbWeGpqUQtd+1uYkTFIqTrZHoKxlph+ntYDXhCg5qMlSoPjch0oZ5uA4BAj/Y7wBwzPzFTfDiPD0kIQdEODs114O4brqNV1FY6ImHZwMjHNve2TfO+Oedm5Kr1Qa8OdUGzxLrcQhZkejbhWWpXo1BMJh7VfJ+/R6Fyf4iMvqlltLnhtRRWDmk0HAKw9n3mqCZoH6pATHyiK7NL9r3katgdKfRBeyf8myDPuCsqa1JNLXoinVHI5QJ9MG3jPp07kVHsDLOE5w3pKq6CDy1UpbUQFJXmbEiFL+Y27cJdpqM1TIFrZUbPnBe8Xpb3XNS+YLpGJW8L8A6zzXdxEucfPo8RHociCQZrjsqZdATJjnFimRxKOwlfOf9f82dSNC5fMUbxo/veeyHfuw= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: c0fdd128-46cb-4912-3807-08dc41dde90f X-MS-Exchange-CrossTenant-AuthSource: MW4PR10MB6608.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2024 15:14:13.6599 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PlP5J1y5dJAOZPRbrXS15sTm3va2xYJ6I0u5nTNwnA+K1W6PbodDgSbRhgPE/DwJdrRAXWD+dbUgcSA1/Rh1Vw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB6074 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-11_10,2024-03-06_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0 bulkscore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2403110115 X-Proofpoint-ORIG-GUID: _xQKrTJKi-38bJEFYRSzkRBURhUA24U9 X-Proofpoint-GUID: _xQKrTJKi-38bJEFYRSzkRBURhUA24U9 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9 Mar 2024, Sam James told this: > Andreas Schwab writes: > >> On Jan 30 2024, Nick Alcock wrote: >> >>> diff --git a/libctf/testsuite/libctf-writable/libctf-errors.c b/libctf/testsuite/libctf-writable/libctf-errors.c >>> index 71f8268cfad..2790b608396 100644 >>> --- a/libctf/testsuite/libctf-writable/libctf-errors.c >>> +++ b/libctf/testsuite/libctf-writable/libctf-errors.c >>> @@ -12,7 +12,7 @@ main (int argc, char *argv[]) >>> ctf_dict_t *fp; >>> ctf_next_t *i = NULL; >>> size_t boom = 0; >>> - ctf_id_t itype, stype; >>> + ctf_id_t itype = 0, stype = 0; >>> ctf_encoding_t encoding = {0}; >>> ctf_membinfo_t mi; >>> ssize_t ret; >> >> This silences the warnings and all dependent tests pass. > > I just ran into this myself today, looks like it never got committed? Ugh sorry you're quite right! I'll rebase, retest, and push today. Mea culpa, it got lost toward the base of the huge pile of stuff I'm working on right now. -- NULL && (void)