From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 3B059385840F for ; Mon, 8 Jan 2024 20:45:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3B059385840F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3B059385840F Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1704746746; cv=pass; b=CdTVphfAag9KKgs06YTY4g27Z1UlxbeFYdQIDA8t3z5Bexv5EaoDnA46ADJRLGBZHK61IFSqo++2K25LyaNYsiaDKAacR46rY/vKoTxizY7Ak3ea2sxGcoNwogKFPbqQP0S3TXX1axru61MOl3X/VHnZc3CbjNsn08e1MSqosM4= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1704746746; c=relaxed/simple; bh=xQjOVv7VOp2Dh+Hpw5pzmkP7A1l+r30YhiT5SozZ+9Y=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=x9JDnNTbZdegcm9Fs5t1A4yrFdM5j9rQpcaQUgX7yDuniNEz2nyPXC6bmJg93gPlT2PneoIQPCSWP4oL3EZha/nm3OXh/GiWFDivh16D1SMdgMePUZmURoQLNtOauru6XYbj6wWpR+F1QfBnQPRnGf3GsgBqtldAS7lJ5+2OjXM= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 408KdeUv017881; Mon, 8 Jan 2024 20:45:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=references : from : to : cc : subject : in-reply-to : date : message-id : content-type : mime-version; s=corp-2023-11-20; bh=CtgWlD6ai5p6+aF17ceu6hGIWVxSXChhmUHNZItXJLo=; b=elC32BI+rKNCLqBJ8J5hig3uVxz6xKKYkLYk+w3kTVV81VKy16yuSPPOg6/oiTCaIeEK L9TPMdwGqa1nufbPkb5BKjriThyfpgZqUJYhMJG5JUdROOEmswH+XbwqTBqYU1OWR30c UqBb+cZS3Hsc9RiDEkp4tpzuRAuZ6y45wyimk/dSmGgDCQHBCD/+ur7pn9A+gQow/Dnc F/wJiPC5ojU2Frw/jbJFg1yRzMPBE7IEDE0c7leJCcVgnQTXE4zOEaJwO4NliM+GbFVl wf1KD3GFQCkTCZsUcPGlSAZ5xrHZDgdokBckqgaWtzXlXoinjE7YtuenXopu9w6J0MaV bg== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3vgr9b00uc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 08 Jan 2024 20:45:39 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 408JtcP8013666; Mon, 8 Jan 2024 20:45:38 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2100.outbound.protection.outlook.com [104.47.58.100]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3vfura8r7d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 08 Jan 2024 20:45:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=msVi++JwKwoWmtrkcRs6NnizSU8U4xJlxi+pSWcjsvy6BdgKNU3GY3DoigBBkU+NyeXnYEXQaCudDjzW2H7Hl99VS6d2KDkkt42YmuNwwksVYYaRsoV9UVncu7qeYuuxfzsf6ALWjCNx/3GPYawIOAr1imbrNp0Gr+2j+Farr/K/PIVR2R44zIfXhZWHjfaOuecdNs1dDBRxNv9Q65awY4jzxtiR8pGC7VOLuwG4ZxYID3nlkvunRn00sPL4MMgZWrmo6GZ6UaYuQuk8tWshZNZ8nMV9pEuIu/ldh0CqPy5kszHIV8QlUi+cHu6cUEMyYilBcHoSfKXeqXOxPNbeJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CtgWlD6ai5p6+aF17ceu6hGIWVxSXChhmUHNZItXJLo=; b=CQlH6eRDe/sFtOhbRNQ2A1T7OubgNr5nAVOJ4sapreP42wxKrfK3PHHNux4uElITlmheWvmVx2liIXFFWRGA/aGS+Rv+gAYASY4bbvuF/t9FD1VHI4WOcN7Oy0vW8lF9NbFnaNr6IVdFtsu2vtvNX95MdNSUEh2UDE//SFjWPj8ME3ovrUBObTOqvwVVTZQ+/7LUrZesfcpLfgGTaZyAuf6DS70LRFxWLzwgolgxsQ2/uLXm/VNTf//vI01Iat1blDoubyIFwtdMm4fbHvJ6MsUo7b74acezz71GOGW/jrzoAhYLxVzEvqMh+1Ky9eAsLKc01MEmQkagAEG0SJYJRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CtgWlD6ai5p6+aF17ceu6hGIWVxSXChhmUHNZItXJLo=; b=tjSklG0qTntK37sStTETNX3GBNBiqALaPHr5g4TmTjpvrztFPKo91Syv8FSC9SZjPPFul/EqZqYbb5UCGq7aMgImMngPCs79/hasy7cqVwe939ZVCV0p5BRF/a6egjF3nEGpciLphQVgr+C2u7/xGVdijXnNoP3gsJVhUrYCCWY= Received: from MN2PR10MB4382.namprd10.prod.outlook.com (2603:10b6:208:1d7::13) by DS7PR10MB4846.namprd10.prod.outlook.com (2603:10b6:5:38c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.23; Mon, 8 Jan 2024 20:45:36 +0000 Received: from MN2PR10MB4382.namprd10.prod.outlook.com ([fe80::5252:c588:583e:7da6]) by MN2PR10MB4382.namprd10.prod.outlook.com ([fe80::5252:c588:583e:7da6%5]) with mapi id 15.20.7159.020; Mon, 8 Jan 2024 20:45:36 +0000 References: <20231220132305.459519-1-cupertino.miranda@oracle.com> <874jfug0yj.fsf@oracle.com> <877ckk6sg9.fsf@oracle.com> <877ckj7jga.fsf@oracle.com> User-agent: mu4e 1.4.15; emacs 28.1 From: Cupertino Miranda To: "Jose E. Marchesi" Cc: binutils@sourceware.org, nickc@redhat.com, elena.zannoni@oracle.com Subject: Re: [PATCH] bpf: Added linker support for R_BPF_64_NODYLD32. In-reply-to: <877ckj7jga.fsf@oracle.com> Date: Mon, 08 Jan 2024 20:45:32 +0000 Message-ID: <87y1cz5zbn.fsf@oracle.com> Content-Type: text/plain X-ClientProxiedBy: LO4P123CA0058.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::9) To MN2PR10MB4382.namprd10.prod.outlook.com (2603:10b6:208:1d7::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR10MB4382:EE_|DS7PR10MB4846:EE_ X-MS-Office365-Filtering-Correlation-Id: c707ed79-ca6e-4187-a969-08dc108ac41f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: N/XYWx8qspfLg/Udkt4mTwtgOOk5pQQ6YcxVBzcxVHPkxGRPMrkm86xRHP1GU4gCWDmlwWEzsvTcIvtWfsGdSezMN+sOkeP0JNTsWw+cMv8vbBLo3Dt6CLzXyzK3zq/yjQlYk/5DYxlmUAjnIbhf0niPWQyJ7FWgQObnHkPJAfs9gb2dxhpfMqaVCFIi3MhyTKb87kl9B+FhXQiXZjwoGkgaZrRbDwVEDK565whzO8aXZg8+MZO8BA77pfBVry+f43js4SDKBpGJg1h7QlN4Mx8nxE4VxSC4wDxURdWse9WlvYufTnAFF/MoGeKf+a2Mdv0y+prmc2q8JdjCZPpak4kel95HTq2LQ+GLehyAycmEopO6zeS7Cjk+X9JjMfZh/WrYmNWdSEcF767dQSmamM2NRQhlMcNMdsCk0wy1NV+9DG3AlL+6+axpVKSHuQl2nKcS6Q3x4qTvO0BygMPqkJ9yWMIA/qFL4inibOMILr1G5fVAH6QIZThIiHg979vBcBUkuoL8tPvFZz0zc4oHVmUS9IzhgtWrhqDBydRMJ04slrqifeTMuh95RC5tIWQx X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR10MB4382.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(396003)(366004)(376002)(346002)(39860400002)(230922051799003)(64100799003)(186009)(451199024)(1800799012)(5660300002)(8936002)(8676002)(36756003)(6862004)(44832011)(4326008)(66556008)(316002)(2906002)(37006003)(6636002)(66476007)(66946007)(6486002)(86362001)(38100700002)(107886003)(2616005)(6512007)(478600001)(6506007)(6666004)(83380400001)(41300700001)(53546011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MI6Mjj5l6RYGnbvKRdXI2kXQb50mWUGVAGj390XCBwnERznafkrneTUJu6yw?= =?us-ascii?Q?W0iiRLzrLvBolkSiAeL6rpQzxbKVX3tez8WiYd2jkCDueS4z2T27+8yUbUrq?= =?us-ascii?Q?4Ox8dP4WVKXAlPNMxPyR/48JwZIWGalgfkL0McbsyZC5OAIx2Q30hoBP5HEB?= =?us-ascii?Q?+ervFHNrcfybd486VtjMANKY/2ql0iyoejKxYNbL3OY4y+Jb2Xjp0J+UrReI?= =?us-ascii?Q?XkRhSkujHJFfwk9Erk/CbHpsqM+BLYtdQvOX4QPI3F0/Coe8ON60pGXQ5hSv?= =?us-ascii?Q?mSakznHX9z8oFK/1yqkZsb+BrbJVkzTdncteMybEOaURlA8FgpN5VHrW2b5W?= =?us-ascii?Q?I/OtGmFnQs9bUapJzCyfAGxCwVWDRFjRc7NBwb/Qtp54ZTeBeegGK384GUzV?= =?us-ascii?Q?tpl1l4kP4zVRPkFUtPQWFtK80aESFoImbyUV2huSNQuE3s96z6tql5AOOn95?= =?us-ascii?Q?S1RJOM4/O8wbAgz1NPyonTr6l0fYbWM1XFd9cZtS5hHe3TJCXtQveqETBZ7L?= =?us-ascii?Q?w2xCTGFl4R6fn6CVY11YOjYZjwFDQPsT2vxUSXYPB20OUmAuyYly8hCo+sWp?= =?us-ascii?Q?cbzCyeqX9CyoZq9E/1Y55Mwqr7gFOCQIcj5+J7kzWhWgXj3Belrs4RXySrfh?= =?us-ascii?Q?swGjhX9ge4JnNWM2aFl/mwt0SuNNCNimG9Fd0ipEqA9GMJm8xbyKqZ9xG3Ro?= =?us-ascii?Q?XwH8aFC5GWOOWKdoe8fsz1uDceBhIMh6DeDFqFX5Q+SdoqLofgXjsr2hzj8e?= =?us-ascii?Q?xLtcMvpT8kfdool7qYutBUgtUZW9iJ8CIF+zkC/3hlAYByh/6/DhqbTaCzkT?= =?us-ascii?Q?Pl5ulbTdeN0asA9dUxTL5sdRQRdJxztta37B9EuUgyJLsQX86WCXl2k6gO7m?= =?us-ascii?Q?4WatkL1CLNo4p02Ml//5zhLkgKb0ZYi/EwNF0VtGDO8qDQdhu1nEmqCKqlml?= =?us-ascii?Q?B4vX5D5Fg4S6vLZFJYsMau3PzbeCOIYhBZFU0HfJABG60HaNeqeUofdRJjos?= =?us-ascii?Q?OwCCZD/JKURy3z/tMKTKnkIhQhTEH2R76k4NHp+SUUXHxAQM1BpiK/KBObjC?= =?us-ascii?Q?W5hIpqb0i0ImQcPubbmsg/QI0nItefEut+VGP9/vgkoaqzZlLV7JB6MmOaMY?= =?us-ascii?Q?Pmo8rKx3ryb0UTGk9Fe3mYsayccyuiXtRLwpYKYQBI1ALMV+03mV2hbOM1In?= =?us-ascii?Q?SeSD7SZn5G06gJGNaQMvIAiqS6tVPs8/8QXioXYzxtLVD4IVk3K3nbixfTeL?= =?us-ascii?Q?wcRak2zhlqDZgukc4KfNz3i/BtwXayE7rv4usxuy++BhRpKYL+M3kHfqDzRu?= =?us-ascii?Q?/QayZUJpU5kN2AtUKpQCn6JxgLXJfVEedtnpImLaMWtrwl9PkQ9GDcWEtpdq?= =?us-ascii?Q?OY9gSLkzIRb9ZKcXNA5gFdrLiLRwNPpBW0Fp7URbIspfLzAond8rRhusr1+D?= =?us-ascii?Q?Pq+uHPuiEjdvupV0bF6MgjvAOTj0ER4JIKJlpNXOO0QARiGClGEmT1oGQ2WK?= =?us-ascii?Q?1IG6B6j0nXch/s8FBTdMjoX/97P8B6d+Fbe2FDO7C0Uc0NPJw7RFEIvDpbkS?= =?us-ascii?Q?FtWvhZ/rGuc+GJc/bKbHiMCnjqY8pFOPnhQaS7UeYKeG7ZcZjZM4KiapIH3r?= =?us-ascii?Q?Y82WpEeQd+/L5nxIVvNaq3h58pokFCZuW0Q+74CG4fMQ?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: GHCvaZniyeCNtU+4mTAsbyRuSiRXVkp2oXC4oEBWBzEbocKBjSmwyKVMgQa4GR2cAizeJY6jFpciIYeyGtH+Ih3XQ1BHrD/maURzzzyJdPk6ilh5ARbfgdFSV8iiVauT5ph3gqG8EtA2jbLnsWGOBBip2yIJChLRilt/ZWXEYhn4LuhOdUk7MwKZDamhHkZDlRpOnOn8uUKqE0Q1QE7T9jX96uVWB+LZczU71Kas41gy4DZgwbD2dEgC9wcJx0uXkhPFYIeIN1oCRGYp6+0NWRUDpd65IZ3CzqUswI9J0nLw4jiTEP2zLwloPri00c1MKqzxQo1l2oDzQcFoTFob/2vqkC+lBRzKL99YEPpeblwW6UTM9xuLul3ADh9tYAX40BYm5vFzdbAkdHXMAYMtHhYOnAiNsGyQhteS4HOvF7RCC6pc1jzpuCfC+HvNUvJxZLudgk/vdPBF1MFGo+APIC8FFtVYLHvHAZ3oLSL0s+YLbppKVDdVbQpEPwE3MsP5+fWq0UESX2zBkAwCR+p4NN0eIXXY8qVeR8aKMv6FHQ7HqmEbL6sDH77tF5VlSdAiNKuFDBY2lolKnW9Clnq/2buvYnjVOIQcZqUVhQMJCn4= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: c707ed79-ca6e-4187-a969-08dc108ac41f X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB4382.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2024 20:45:36.4197 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pVxr04i+1pOlx87Tlcym+5tWeRblyKRjkxEaP38jQEVyEbuoC8qwfYKGO5nyodXuRapu1AAS39K79zZDsDJ5Ra9VRFNzPYI2rt8vkDFlT2M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB4846 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-08_10,2024-01-08_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 adultscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 phishscore=0 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401080171 X-Proofpoint-GUID: 1UKVoIBAGZJL7_maodFn96Qmou6iArwW X-Proofpoint-ORIG-GUID: 1UKVoIBAGZJL7_maodFn96Qmou6iArwW X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Thanks! Committed. Jose E. Marchesi writes: > Hi Cuper. > OK, thanks. > >> Hi Jose, >> >> Thanks for your review. >> I realized I missed to update the macro for the relocation where the >> properties like size, overflow check, (etc.) are defined. >> I have added the comment near the relocation macro definition. >> >> Sending the patch for review once again. >> >> Regards, >> Cupertino >> >> From bb8afde9a8f17d42393067c3a667bec1f08b252a Mon Sep 17 00:00:00 2001 >> From: Cupertino Miranda >> Date: Wed, 20 Dec 2023 12:24:03 +0000 >> Subject: [PATCH] bpf: Added linker support for R_BPF_64_NODYLD32. >> >> This patch adds linker support to patch R_BPF_64_NODYLD32 relocations. >> The implementation was based on comments and code in LLVM, as the GNU >> toolchain does not uses this relocation type. >> --- >> bfd/bpf-reloc.def | 17 ++++++++++------- >> bfd/elf64-bpf.c | 1 + >> 2 files changed, 11 insertions(+), 7 deletions(-) >> >> diff --git a/bfd/bpf-reloc.def b/bfd/bpf-reloc.def >> index 7e7497892fa..42ba1a169ea 100644 >> --- a/bfd/bpf-reloc.def >> +++ b/bfd/bpf-reloc.def >> @@ -90,17 +90,20 @@ >> >> /* R_BPF_64_NODYLD32 is not used by GNU tools - but it is generated by LLVM. >> We provide an entry here so that tools like strip can safely handle BPF >> - binaries generated by other tools. */ >> + binaries generated by other tools. >> + R_BPF_64_NODYLD32 should be fixed at linker like a R_BPF_64_ABS32. >> + The difference to ABS32 is that LLVM execution engine does not resolve >> + R_BPF_64_NODYLD32 relocations. */ >> BPF_HOWTO (R_BPF_64_NODYLD32, /* type */ >> 0, /* rightshift */ >> - 0, /* size */ >> - 0, /* bitsize */ >> + 4, /* size */ >> + 32, /* bitsize */ >> false, /* pc_relative */ >> 0, /* bitpos */ >> - complain_overflow_dont, /* complain_on_overflow */ >> + complain_overflow_bitfield, /* complain_on_overflow */ >> bpf_elf_generic_reloc, /* special_function */ >> "R_BPF_64_NODYLD32", /* name */ >> false, /* partial_inplace */ >> - 0, /* src_mask */ >> - 0, /* dst_mask */ >> - false) /* pcrel_offset */ >> + 0xffffffff, /* src_mask */ >> + 0xffffffff, /* dst_mask */ >> + true) /* pcrel_offset */ >> diff --git a/bfd/elf64-bpf.c b/bfd/elf64-bpf.c >> index c932a4024ba..0bffe2c5717 100644 >> --- a/bfd/elf64-bpf.c >> +++ b/bfd/elf64-bpf.c >> @@ -276,6 +276,7 @@ bpf_elf_relocate_section (bfd *output_bfd ATTRIBUTE_UNUSED, >> } >> case R_BPF_64_ABS64: >> case R_BPF_64_ABS32: >> + case R_BPF_64_NODYLD32: >> { >> addend = bfd_get (howto->bitsize, input_bfd, where); >> relocation += addend;