From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id F0CD13856246 for ; Tue, 24 May 2022 09:34:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F0CD13856246 Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24O8kU6Z016571; Tue, 24 May 2022 09:34:20 GMT Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3g6qya5pvt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 May 2022 09:34:20 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 24O9SJpW026004; Tue, 24 May 2022 09:34:16 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2045.outbound.protection.outlook.com [104.47.66.45]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id 3g6ph27fpj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 May 2022 09:34:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m7Ct/Y/8mMnLlUNa0ErQLD89jmRqRtaGJC2fdQpM9oJg67nfmTWNh0oh3qGfsAEJlrjnFp7on6S/YIykAA81qlsrO6v0cNH6ct9r+M/+wD0UXy76h+Vimjjxm+48jJwpuUQmNZssMLA2zc6nnzbQYh+rQLQCWBOiqVrEaA86ePZehP7RMw6Pg+9XsDbV3jiNlyyd5whh99r0Fg+v1/dGTCNKOuzz1oD1ILTkDsE/xCzaFIEGPt3q5JY+oJnx9CqubDc6mIiJ8CHWGwzfWvwEraEL7mSw0oSouf81OV8ibQlxBJG6Ss3pnss7+FX3lHQUH7Tbivz/FailyuK3357C0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ydDpk2dAc7hVwmGJvpfIoEIBiW/ktkphT5R6Wp6w9DU=; b=DLqUrdjRlPI95lrKb5ViczeBfF0NHHQ+DW5BWNP3j+WE0zX65gvyP1gs5549NyTbcMLnc2cqh6pk0R9eHVWP2JVk0wyX617RbkPU9FnTn7t06J9CkJ1r9F4cppQxSrKrm+lcT0nE/crIzblqqb6zrcs2dgDstcTLbFEANwVSBVhNfICDwVanABafQRJpK5dX65hR9bx8Hb49M2lDKEZEZotpb4/znqwXPqxPsxfVCWLlX7xT4ItnxY6Sd8Zj+jd1oOXlf5O2TJTznxIJKr313y71NEVZjFvt6v+S8q9cjqgrb/0kAbHggvn1w8cqHPTX2wQw/zV3323qd4M2O4+N5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) by MN2PR10MB3647.namprd10.prod.outlook.com (2603:10b6:208:117::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15; Tue, 24 May 2022 09:34:14 +0000 Received: from BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::287e:5ffc:d595:8316]) by BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::287e:5ffc:d595:8316%6]) with mapi id 15.20.5273.023; Tue, 24 May 2022 09:34:14 +0000 From: "Jose E. Marchesi" To: Luca Boccassi Cc: binutils@sourceware.org, Nick Clifton Subject: Re: [PATCH] ld: add --package-metadata References: <20220515191846.114257-1-luca.boccassi@gmail.com> Date: Tue, 24 May 2022 11:34:05 +0200 In-Reply-To: (Luca Boccassi's message of "Mon, 23 May 2022 12:26:31 +0100") Message-ID: <87y1yr1dgy.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain X-ClientProxiedBy: LO4P123CA0530.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2c5::13) To BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 45220016-a9b3-46a1-fb39-08da3d6890c5 X-MS-TrafficTypeDiagnostic: MN2PR10MB3647:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dh5mhFYiifMT/zWQiPZs5kXOM8XwnzEFZZnapBfGl/HCXBmm5OqVR5AxEU66QLOTRTOdNdQCvu9oTpnu4N7Gl/ET+/K5wmlFXo8LhpWrUI7sBoBi32mS1dzZmLD9aEqUOF2bYQYEJ/DP5nyBT6aeHfe6BbXbP2XJ/x92PD2UJws5CLeRUXD2EAbgCRuLnvIWFK2OWmI4S2IEAGPYWFL3PyWzml51mva/nty8EU7BRdB+XV39SXUd/dB8Btr/T7lLEmxMXFBhuZP8eyjw7noklX3reW4wMEa8OpJEtLdYjWtTXiWGQkSG76BWPY01/6OJUtT6VW5TcGevllIv8StqHM7M4zEoSDEllyI6s12cc1Gjh/OzCjrAm8urigNk+7emUz3C2DzBALCS/VjYy7TfUOrcjFygcsK2RpeM3D+dvAb4WPUizNYHEdLU2iBOYyIiuD13qk3rQz3B3mK931DfwIbEKePaiil/OinBYTVsE5ZU0KpH6cgnI6HUsf69+B6i1c076TBhPXoFCRbALATBlTUa60FJ8wjBjWXnakgnmzCYOJ1l7kVUCU+XoLCY4fB/twdDfFdeJsS6bHEzwpjioxVhMBnMjbiZdA2Gb/aTcTaRJWNaPyhdm0mCjVAUA3cdnBje2XgFZpqTVfXwBDhtHPRl9UjIlEq/WSSfpDRXcT/3wDvnowBBa7NgWdE5qJnW/JktjXaQwZZcnBDgE8A4lF/NB/y3ui7O1pGT5sdxeidbPAAko4OQENRjoGBCbSM30tomWzw+ZvWybiTK2D8yTw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR10MB2888.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(508600001)(83380400001)(4326008)(66946007)(8676002)(86362001)(66556008)(2906002)(6666004)(6512007)(26005)(966005)(5660300002)(186003)(8936002)(2616005)(6486002)(38350700002)(6916009)(66476007)(36756003)(38100700002)(52116002)(6506007)(316002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?crBjNehXoqighStFzZZ9uuaU2RZ1sj5hvDLRs7AnxN30fddEfUE73VMw0m/a?= =?us-ascii?Q?Lf79A+JQQV/h85ma2VeELiWLwMhbbOihxM2j9Sq/EiPEdes711aOtC6jkL+D?= =?us-ascii?Q?OYS4iHfzUQooY6K8CClqGA70uO83JIwgbqAM/cyHOnArMPgwuUz9gIrKsfVR?= =?us-ascii?Q?A8kBCCBXwGWSEm4bq19H6d7EgqBQGp+MFOoM3KGGbhKO5axXbQPMh+Ut5+gx?= =?us-ascii?Q?nc9Jvs8U3n99Oj1mO/xSzvh2NED6NVQN/bl7GysNxjbU/6kwGwMerH9SnC6E?= =?us-ascii?Q?l08Fj0BuHf2iCClJYnAFzcqOcvwt8rCH17VZR537mQTJExpztzwZueEIQq3v?= =?us-ascii?Q?sP9dZ1c5IgTvo1AB3yDRenm4RVQ7K6Btfa6ZJY5EKfvXUYTAjfYFDz+GK3me?= =?us-ascii?Q?8tPqv51/jP/vK5SW+PxGoPA6gF0dDoIQC6N8F10v4rj1iL46IYSqnEozuHj2?= =?us-ascii?Q?J0ozh+CghxnpO2c7NL7s2UH/vHhiKIT8JrIkWD+QWOvhXPEL0MCf+Gsuh39f?= =?us-ascii?Q?Lt6CAHIdQWxbKPz6aQDgYAGDsb+C2PqYeDgVBbZoSmAMPzCwZ3epZ5bVUHoQ?= =?us-ascii?Q?9OiowYuRNKsPRu+EOu+adVwbT/tR8PRTQi0kGQ7jrZB4xPXzsPRRltQpKObT?= =?us-ascii?Q?txo8wgcMhEiCTh88dn4jMRWVMqS+7eoceFG031Tn/4UWVixXv9htmYE/h3m3?= =?us-ascii?Q?cNb/PhRfDTIVkiwJbF1KpSbOC9rE3Wl89tquIHXPWWQQn0BvzW8oIouSf8Mn?= =?us-ascii?Q?p4Nd3dhNWJ8l/SEA1ZsnY6fVBaknJDWeGEGvmA9vWmICJSZ/NfgXCOH6DDha?= =?us-ascii?Q?s0sEYxaEwE8zmh3xczHMoAGO225dclvRSDNx/7CLEimZSSvg6n8cx8QWShf6?= =?us-ascii?Q?qE3Q44DLkE/w1PpMo3Iw39e4y7kEARtRKE1IfnSolPCfD2erRdxhDQvf+E3C?= =?us-ascii?Q?fq6n3SUPnaK2p0jpjTQfRNg1wbtG+hT6UqN5rpqUa4Zs0faIlPM4wccwC+de?= =?us-ascii?Q?zUpULGXzaPTUupblYUIyIfX00O7mMOzzeUDhkWcLRksAILUAQhbw5Azwt2M2?= =?us-ascii?Q?1mJCWMuXksFYBStoRBGNx5kxaCbs/APUi9mG7sRSwWL483rP1gf/G20Oepd9?= =?us-ascii?Q?rTJ0QY+Bjm6Y2Zec2UHYEUO8rug+HbgZdcvbpoxJCDgCxA9qbcpODu8d1f26?= =?us-ascii?Q?qU3jm2KBVAGrNTkptZGh8gL44TPOqWH9dyxuB4/WOeW9Zm447mbVm4EQ7HYV?= =?us-ascii?Q?Ja1/ept/Xbh9+Mg7M2toiHhCYLdfGa22gj6mzA33HDRmm3uLpcGDAaDLbObs?= =?us-ascii?Q?rMMv/T/jUd/+7gTssvTAS3It4QFDEldxu+3wEDq2KQApvgtiwqpnXghFT8Hy?= =?us-ascii?Q?M6/t4iv35Pcv9ZtnWMDgWPQfVh5upp633eRPGQt442xqeQ6bD0zvupo7+kNi?= =?us-ascii?Q?dtePoKtrLznPdGS8yNypLPSYOgDfVKMXpu1wwQnD2m4dk2Bjh2JudltzGanM?= =?us-ascii?Q?7TvkAC2DkdaNxYczEzLfsv+816nZ3CEbIVfT22oTKRKBbhy72mgyQ/tJRqQd?= =?us-ascii?Q?Bkv3Sqs1vG04wj8UlvCzUWPKxRi93SINMj/Ukl/tZsfxfg2TZEGesK5Z3MzO?= =?us-ascii?Q?2bZGwB1v8g2S5Aad7U/UgKOnAZ285QDKmaNh1at46xP/RCaM13UGUd1mmsLH?= =?us-ascii?Q?+WB+iR2A3jSYoqeYiEFJASSj5sNQxf+fzL0EqnuPHSgBVXb4SMNr+6BSfU8E?= =?us-ascii?Q?bc98KJQ8C9xo0c5scigpkhNeZxqH73I=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 45220016-a9b3-46a1-fb39-08da3d6890c5 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2888.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2022 09:34:14.3164 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: m5wHv2169Ra0CEa4/Qv7au1CO1Oc3e81CVyXiQhAuBhLzP1rgQYk8UbV36tceQJWsUPRJf+PtMajut/CUrnWhGrMRBDLXzdYhXerVOxAUHE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3647 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486, 18.0.874 definitions=2022-05-24_04:2022-05-23, 2022-05-24 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 bulkscore=0 mlxscore=0 mlxlogscore=999 suspectscore=0 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2205240047 X-Proofpoint-GUID: m4En_F0opRr5PRKiNM8D99Guqp9f-nph X-Proofpoint-ORIG-GUID: m4En_F0opRr5PRKiNM8D99Guqp9f-nph X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 May 2022 09:34:45 -0000 Hi Luca. >> I've added an optional usage of libjansson to provide additional validation, >> so that it doesn't have to be reimplemented everywhere a thousand >> times over. >> For bootstrapping purposes the dep is optional and can be skipped, for example >> in Debian/Ubuntu it would be annotated with so that everything >> works out of the box. As far as I can see at https://systemd.io/COREDUMP_PACKAGE_METADATA/ the payload encoded in JSON comprises a single object which must be a dictionary, whose entries all contain strings. Basically: {"..." : "..."[, "..." : "..."]*} Isn't it a bit overkill to add a dependency to an external library just to verify the format of the above? A regular expression would suffice, even if a fastidious one due to the string format: S -> JSON string B -> [\n\t ]* PAYLOAD -> B{BSB:BSB(,SB:BSB)*}B >> >> bfd/elf-bfd.h | 8 ++ >> bfd/elf.c | 6 +- >> ld/Makefile.am | 6 +- >> ld/configure.ac | 35 ++++++++ >> ld/emultempl/elf.em | 9 ++ >> ld/ld.texi | 7 ++ >> ld/ldelf.c | 121 ++++++++++++++++++++++++++- >> ld/ldelf.h | 2 + >> ld/lexsup.c | 2 + >> ld/testsuite/ld-elf/package-note.exp | 49 +++++++++++ >> ld/testsuite/ld-elf/package-note.rd | 6 ++ >> 11 files changed, 244 insertions(+), 7 deletions(-) >> create mode 100644 ld/testsuite/ld-elf/package-note.exp >> create mode 100644 ld/testsuite/ld-elf/package-note.rd > > Hi Nick, > > Did you have any chance to look at this? Any thoughts? Thanks! > > Kind regards, > Luca Boccassi