From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by sourceware.org (Postfix) with ESMTPS id 9A4083857409; Wed, 11 May 2022 18:13:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9A4083857409 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nefkom.net Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4Kz31Z2Bj0z1r3f0; Wed, 11 May 2022 20:13:22 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4Kz31Z1S4Xz1qqkD; Wed, 11 May 2022 20:13:22 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 0Y1-K-lKoTvl; Wed, 11 May 2022 20:13:21 +0200 (CEST) X-Auth-Info: Hi6Zzj1Z1Ge1/i2Ps/P6QtlLRbVKMpSBAj5m2K3fZs0C2TgzuRNZKZeiP30NTlGI Received: from igel.home (ppp-46-244-167-40.dynamic.mnet-online.de [46.244.167.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 11 May 2022 20:13:21 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id E170A2C3784; Wed, 11 May 2022 20:13:20 +0200 (CEST) From: Andreas Schwab To: Dmitry Selyutin via Binutils Cc: Dmitry Selyutin , Luke Kenneth Casson Leighton , gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] gas/write: extend fx_pcrel_adjust to 16 bits References: X-Yow: Hello. Just walk along and try NOT to think about your INTESTINES being almost FORTY YARDS LONG!! Date: Wed, 11 May 2022 20:13:20 +0200 In-Reply-To: (Dmitry Selyutin via Binutils's message of "Wed, 11 May 2022 20:59:24 +0300") Message-ID: <87y1z8szsv.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 May 2022 18:13:26 -0000 On Mai 11 2022, Dmitry Selyutin via Binutils wrote: > diff --git a/gas/write.h b/gas/write.h > index 501bdd828f..e31a0f5955 100644 > --- a/gas/write.h > +++ b/gas/write.h > @@ -73,10 +73,10 @@ struct fix > unsigned fx_tcbit2 : 1; > > /* Spare bits. */ > - unsigned fx_unused : 10; > + unsigned fx_unused : 2; > > /* pc-relative offset adjust (only used by some CPU specific code) */ > - int fx_pcrel_adjust : 8; > + int fx_pcrel_adjust : 16; > > /* How many bytes are involved? */ > unsigned fx_size : 8; It's probably better to swap the fx_size and fx_pcrel_adjust fields, so that fx_pcrel_adjust is aligned on a 16 bit boundary. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."