public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Second mingw build fix for ld.
@ 2014-04-15 16:44 Steve Ellcey 
  2014-04-15 20:36 ` Richard Sandiford
  0 siblings, 1 reply; 2+ messages in thread
From: Steve Ellcey  @ 2014-04-15 16:44 UTC (permalink / raw)
  To: binutils

This is another fix for mingw ld builds.  If you use emultempl/elf32.em
when building ld and set HAVE_DOS_BASED_FILE_SYSTEM then this file uses
ISALPHA but does not include safe-ctype.h.

This patch includes safe-ctype.h, in theory we could ifdef the include
to only be done when HAVE_DOS_BASED_FILE_SYSTEM is defined but I think
it is easier/cleaner to just include the header all the time.

OK to checkin?

Steve Ellcey
sellcey@mips.com

2014-04-15  Steve Ellcey  <sellcey@mips.com>

	* elf32.em: Include safe-ctype.h.


diff --git a/ld/emultempl/elf32.em b/ld/emultempl/elf32.em
index 0173b66..31761ca 100644
--- a/ld/emultempl/elf32.em
+++ b/ld/emultempl/elf32.em
@@ -38,6 +38,7 @@ fragment <<EOF
 #include "sysdep.h"
 #include "bfd.h"
 #include "libiberty.h"
+#include "safe-ctype.h"
 #include "filenames.h"
 #include "getopt.h"
 #include <fcntl.h>

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Second mingw build fix for ld.
  2014-04-15 16:44 [PATCH] Second mingw build fix for ld Steve Ellcey 
@ 2014-04-15 20:36 ` Richard Sandiford
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Sandiford @ 2014-04-15 20:36 UTC (permalink / raw)
  To: Steve Ellcey ; +Cc: binutils

"Steve Ellcey " <sellcey@mips.com> writes:
> 2014-04-15  Steve Ellcey  <sellcey@mips.com>
>
> 	* elf32.em: Include safe-ctype.h.

OK, thanks.

Richard

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-04-15 20:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-15 16:44 [PATCH] Second mingw build fix for ld Steve Ellcey 
2014-04-15 20:36 ` Richard Sandiford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).