From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 2963E385DC3A for ; Sat, 9 Mar 2024 02:44:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2963E385DC3A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2963E385DC3A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.211.166.183 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709952288; cv=none; b=lp7mWaYkyOMmmWsFBghbxIIFpiSo0nIL9BzMrxWjtwsPl3iodsxD14uLZf6ZpQLP1hCmRXGlEffycPs7i8JgkualYlASytkRNj1FfsaFHFn08svphbzHmawZvNTPF7JayWvV7gfdG+b48c0Ccd5wWnfFRXCgSdbHAQ8fwXW91SQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709952288; c=relaxed/simple; bh=Kr3J7hidu9Nn0alLYWZoCsqHt3bG9ftHmYUG5yEXi6U=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=YjP6Vl1BYCfmI7FkgidpOA2HfWKs0+by0H2QsGLHmuCVrSwoc8xjf9bOkqp4PH6qm4oBy1z31lV0FxE9jQtNjB5ycfYE7JdwLg9qw4Z9nvQQxQyUoMFSsTAos8tEc/opnsf1xUdmKPCCKAeSNSi+pZfqsaAg337wyeLVaXun/i0= ARC-Authentication-Results: i=1; server2.sourceware.org From: Sam James To: Nick Alcock , Andreas Schwab Cc: binutils@sourceware.org, torbjorn.svensson@foss.st.com, yvan.roux@foss.st.com Subject: Re: [PATCH] libctf: check for problems with error returns In-Reply-To: (Andreas Schwab's message of "Tue, 30 Jan 2024 15:27:34 +0100") Organization: Gentoo References: <20231009151146.3818141-1-torbjorn.svensson@foss.st.com> <20231013140152.427376-1-nick.alcock@oracle.com> <87sf2evr35.fsf@esperi.org.uk> User-Agent: mu4e 1.12.0; emacs 30.0.50 Date: Sat, 09 Mar 2024 02:44:41 +0000 Message-ID: <87zfv8p1ie.fsf@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Andreas Schwab writes: > On Jan 30 2024, Nick Alcock wrote: > >> diff --git a/libctf/testsuite/libctf-writable/libctf-errors.c b/libctf/testsuite/libctf-writable/libctf-errors.c >> index 71f8268cfad..2790b608396 100644 >> --- a/libctf/testsuite/libctf-writable/libctf-errors.c >> +++ b/libctf/testsuite/libctf-writable/libctf-errors.c >> @@ -12,7 +12,7 @@ main (int argc, char *argv[]) >> ctf_dict_t *fp; >> ctf_next_t *i = NULL; >> size_t boom = 0; >> - ctf_id_t itype, stype; >> + ctf_id_t itype = 0, stype = 0; >> ctf_encoding_t encoding = {0}; >> ctf_membinfo_t mi; >> ssize_t ret; > > This silences the warnings and all dependent tests pass. I just ran into this myself today, looks like it never got committed? thanks, sam