From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 77DE3385841F for ; Tue, 4 Oct 2022 08:53:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 77DE3385841F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664873585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=b3pziClRUEfmOb2yustf+pCpePZ3Z1HZIysHD5t9dMM=; b=N7jmwsw077pFpw1xgNbcbbZ27+r0DS0+cGcCLzrdO4SOBEnwwJISSsONILqzP3g7BLNvuZ w9uyZPol9cjOxOkT/gTAxUC5hKGdW3aSE0bkr8VCZNaVFLEZgCXvFLjx1Hai+e3Glk+dD+ h96N6LswFkLweAiFdecQpfjYA3QHmww= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-223-V0LWAQD6NluGwho97uJg_g-1; Tue, 04 Oct 2022 04:53:03 -0400 X-MC-Unique: V0LWAQD6NluGwho97uJg_g-1 Received: by mail-wr1-f69.google.com with SMTP id s4-20020adfbc04000000b0022e03fc10a9so2597379wrg.15 for ; Tue, 04 Oct 2022 01:53:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date; bh=b3pziClRUEfmOb2yustf+pCpePZ3Z1HZIysHD5t9dMM=; b=jM10dByVoZwNn2XAtZnkpD3lvVd4lEHU0W2M7PKMPWUBQMrOqeILBqdBeQyPlFjwXv rjAit8ugl4R59pWZx6rit/H5BJanG50nRBG5ws9RJn/rkuP3X7XT+d+oY5ePCYppK1OL R5VCuaa/mfWbnbJcBiF4sgVrvB0K3feDkWfQG07zD7X7jO6s3VHYByVbZtbeAoEmfeIB HVrIIchtv5UUkJIObiMbAdw+200AURIADxTpt1O+l3i6I5PpS06Rgxp+rTEo3tqdxizt 0D8eTCCi5/JbIViD5X08gN4u6+YamUltSW31ROG2trAe6QWaiahcL/c4m9fTxvDaVrOa fn9Q== X-Gm-Message-State: ACrzQf0EyoThmHqQXC7q/fK3ybDC9TQt8c/+4hs4FOszLhRBCl+GWEgc 8bJ7WmFITi5D5jmhjCUdk1zO1zT9AMavmEcdq8RTih5gCxk9xLB9brPjkYJm2HqeMYNZfWG5l2G hh0OC6WtUEtOmoXg1gg== X-Received: by 2002:a05:6000:1e0d:b0:22c:aa08:5272 with SMTP id bj13-20020a0560001e0d00b0022caa085272mr16363602wrb.296.1664873582016; Tue, 04 Oct 2022 01:53:02 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7JEVkLd+BQKchygUQpoOD8A1ZsOgtZ2FQQnWzDQEjd3tfaXULxYd+KqsDtPlgpyzNupudi4Q== X-Received: by 2002:a05:6000:1e0d:b0:22c:aa08:5272 with SMTP id bj13-20020a0560001e0d00b0022caa085272mr16363591wrb.296.1664873581807; Tue, 04 Oct 2022 01:53:01 -0700 (PDT) Received: from localhost (52.72.115.87.dyn.plus.net. [87.115.72.52]) by smtp.gmail.com with ESMTPSA id x12-20020a05600c2d0c00b003b51369fbbbsm19220016wmf.4.2022.10.04.01.53.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Oct 2022 01:53:01 -0700 (PDT) From: Andrew Burgess To: Nelson Chu Cc: binutils@sourceware.org Subject: Re: [PATCH] opcodes/riscv: style csr names as registers In-Reply-To: References: <20221003101328.1790113-1-aburgess@redhat.com> Date: Tue, 04 Oct 2022 09:53:00 +0100 Message-ID: <87zgecezrn.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Nelson Chu writes: > Please commit, thanks. > Pushed. Thanks, Andrew > Nelson > > On Mon, Oct 3, 2022 at 6:14 PM Andrew Burgess via Binutils > wrote: >> >> While reviewing another patch I noticed that RISC-V CSR names are >> given the text style, not the register style. This patch fixes this >> mistake. >> --- >> opcodes/riscv-dis.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/opcodes/riscv-dis.c b/opcodes/riscv-dis.c >> index 6ac69490b78..031c19334fa 100644 >> --- a/opcodes/riscv-dis.c >> +++ b/opcodes/riscv-dis.c >> @@ -547,7 +547,8 @@ print_insn_args (const char *oparg, insn_t l, bfd_vma pc, disassemble_info *info >> } >> >> if (riscv_csr_hash[csr] != NULL) >> - print (info->stream, dis_style_text, "%s", riscv_csr_hash[csr]); >> + print (info->stream, dis_style_register, "%s", >> + riscv_csr_hash[csr]); >> else >> print (info->stream, dis_style_text, "0x%x", csr); >> break; >> -- >> 2.25.4 >>