From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7778 invoked by alias); 24 Oct 2012 12:17:58 -0000 Received: (qmail 7357 invoked by uid 22791); 24 Oct 2012 12:17:54 -0000 X-SWARE-Spam-Status: No, hits=-7.8 required=5.0 tests=AWL,BAYES_00,KHOP_PGP_SIGNED,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 24 Oct 2012 12:17:49 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1TQzu8-0004pl-VI from Thomas_Schwinge@mentor.com ; Wed, 24 Oct 2012 05:17:48 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 24 Oct 2012 05:17:48 -0700 Received: from feldtkeller.schwinge.homeip.net (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Wed, 24 Oct 2012 13:17:47 +0100 From: Thomas Schwinge To: "H.J. Lu" CC: Subject: Re: PATCH: Add a testcase for PR binutils/14481 In-Reply-To: References: <20120816203255.GA23224@intel.com> <87a9vmzbyb.fsf@schwinge.name> User-Agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Wed, 24 Oct 2012 12:17:00 -0000 Message-ID: <87zk3cvzbv.fsf@schwinge.name> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00344.txt.bz2 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 2841 Hi! On Wed, 24 Oct 2012 04:28:59 -0700, "H.J. Lu" wrote: > On Tue, Oct 16, 2012 at 8:14 AM, Thomas Schwinge > wrote: > > Hi! > > > > On Thu, 16 Aug 2012 13:32:55 -0700, "H.J. Lu" wr= ote: > >> I checkec in this patch to add a testcase for PR binutils/14481. > > > >> --- a/binutils/ChangeLog > >> +++ b/binutils/ChangeLog > >> @@ -1,3 +1,14 @@ > >> +2012-08-16 H.J. Lu > >> + > >> + PR binutils/14481 > >> + * Makefile.am (BFDTEST1_PROG): New. > >> + (TEST_PROGS): Likewise. > >> + (bfdtest1_DEPENDENCIES): Likewise. > >> + (noinst_PROGRAMS): Add $(TEST_PROGS). > >> + * Makefile.in: Regenerated. > >> + > >> + * bfdtest1.c: New file. > >> + > > > >> --- a/binutils/testsuite/ChangeLog > >> +++ b/binutils/testsuite/ChangeLog > >> @@ -1,3 +1,11 @@ > >> +2012-08-16 H.J. Lu > >> + > >> + PR binutils/14481 > >> + * ar.exp (bfdtest1): New. > >> + (long_filenames): Run bfdtest1. > >> + (thin_archive): Likewise. > >> + (thin_archive_with_nested): Likewise. > > > >> diff --git a/binutils/testsuite/binutils-all/ar.exp b/binutils/testsui= te/binutils-all/ar.exp > >> index 0caa847..c66c43e 100644 > >> --- a/binutils/testsuite/binutils-all/ar.exp > >> +++ b/binutils/testsuite/binutils-all/ar.exp > >> @@ -27,6 +27,8 @@ if ![is_remote host] { > >> } > >> } > >> > >> +set bfdtest1 [findfile $base_dir/bfdtest1] > > > > This is not correct for cross-testing on a Windows host, and results in= a > > bunch of ERRORs about the file not being found. Here is a patch -- OK = to > > commit? >=20 > diff --git a/binutils/testsuite/binutils-all/ar.exp b/binutils/testsuite/= binutil > s-all/ar.exp > index 05cc261..8b7629e 100644 > --- a/binutils/testsuite/binutils-all/ar.exp > +++ b/binutils/testsuite/binutils-all/ar.exp > @@ -27,7 +27,7 @@ if ![is_remote host] { > } > } >=20 > -set bfdtest1 [findfile $base_dir/bfdtest1] > +set bfdtest1 $base_dir/bfdtest1 >=20 > # send_user "Version [binutil_version $AR]" >=20 > Can you try this instead? Yes, that seems a reasonable change anyway (no need ever to transform bfdtest1), and it also solves the Windows host issue: Windows allows running executables without specifying the .exe suffix. These problems remain: | Then, with that patch applied, the tests still FAIL on Windows hosts: |=20 | FAIL: ar long file names (bfdtest1) | FAIL: ar thin archive (bfdtest1) | FAIL: ar thin archive with nested archive (bfdtest1) |=20 | The first two will go away (PASS) if I force (by copying it over) the | unstripped executable binutils/.libs/bfdtest1.exe to be used instead of | the stripped one -- huh. Yet, the last of the three still FAILs. | Debugging that is for another day. Gr=C3=BC=C3=9Fe, Thomas --=-=-= Content-Type: application/pgp-signature Content-length: 489 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQEcBAEBAgAGBQJQh9xkAAoJENuKOtuXzphJg54H/iMsdIYnRy1E0RmWAveF1YvI vnSf6XCH5kxjml43QLIPtU7gTZ58cBCDC2mj3Ueex1FvvhiLV6oFjCkMIALQ9zrl 9SzetBg6u264AgUA4E9o7bcWB7fCcRmpAnGngMPaIJZnZANdSsp13NO079iiLy4+ 1S3bQrhFNHhhRSgfmOetF8/V5tRUrEsKJ9bF8p/MeAcmmsbOGoftcTms71OTRJh1 U9nE9t3yJ2bSWHR+1DW3onL4QpcaxJV9cWpSc0VjgJ5eKX2oxWd+GuDtt9ElLB+a D3cscsyF35JlUfl/ssnUEN0oO6K2JgKVt12ifY4wlLBgf00bn0b+NmNSbJmuhXE= =83oI -----END PGP SIGNATURE----- --=-=-=--