From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-69113-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 12022 invoked by alias); 7 Dec 2010 10:14:05 -0000
Received: (qmail 12006 invoked by uid 22791); 7 Dec 2010 10:14:04 -0000
X-SWARE-Spam-Status: No, hits=-2.1 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST
X-Spam-Check-By: sourceware.org
Received: from mail-ww0-f43.google.com (HELO mail-ww0-f43.google.com) (74.125.82.43)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 07 Dec 2010 10:13:59 +0000
Received: by wwi17 with SMTP id 17so7637026wwi.12        for <binutils@sourceware.org>; Tue, 07 Dec 2010 02:13:56 -0800 (PST)
Received: by 10.227.136.132 with SMTP id r4mr2743554wbt.170.1291716836744;        Tue, 07 Dec 2010 02:13:56 -0800 (PST)
Received: from localhost (rsandifo.gotadsl.co.uk [82.133.89.107])        by mx.google.com with ESMTPS id h29sm4127998wbc.9.2010.12.07.02.13.54        (version=TLSv1/SSLv3 cipher=RC4-MD5);        Tue, 07 Dec 2010 02:13:54 -0800 (PST)
From: Richard Sandiford <rdsandiford@googlemail.com>
To: "Maciej W. Rozycki" <macro@codesourcery.com>
Mail-Followup-To: "Maciej W. Rozycki" <macro@codesourcery.com>,Catherine Moore <clm@codesourcery.com>,  binutils@sourceware.org, rdsandiford@googlemail.com
Cc: Catherine Moore <clm@codesourcery.com>,  binutils@sourceware.org
Subject: Re: [PATCH 08/20] MIPS/GAS: Improve a LUI complaint message
References: <alpine.DEB.1.10.1012020105230.14129@tp.orcam.me.uk>
Date: Tue, 07 Dec 2010 10:14:00 -0000
In-Reply-To: <alpine.DEB.1.10.1012020105230.14129@tp.orcam.me.uk> (Maciej	W. Rozycki's message of "Thu, 2 Dec 2010 19:19:21 +0000 (GMT)")
Message-ID: <87zkshao0u.fsf@firetop.home>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <binutils.sourceware.org>
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
X-SW-Source: 2010-12/txt/msg00261.txt.bz2

Patches 4-7 OK

"Maciej W. Rozycki" <macro@codesourcery.com> writes:
> Index: binutils-fsf-trunk-quilt/gas/config/tc-mips.c
> ===================================================================
> --- binutils-fsf-trunk-quilt.orig/gas/config/tc-mips.c	2010-12-01 21:05:50.000000000 +0000
> +++ binutils-fsf-trunk-quilt/gas/config/tc-mips.c	2010-12-01 21:05:50.000000000 +0000
> @@ -10005,7 +10005,8 @@ mips_ip (char *str, struct mips_cl_insn 
>  		  && imm_expr.X_op == O_constant
>  		  && (imm_expr.X_add_number < 0
>  		      || imm_expr.X_add_number >= 0x10000))
> -		as_bad (_("LUI expression not in range 0..65535"));
> +		as_bad (_("LUI expression (%lu) not in 0..65535 range"),
> +			(unsigned long) imm_expr.X_add_number);
>  	      s = expr_end;
>  	      continue;

Like Paul, I think the first order ("expression is not in the range A..B")
sounds more natural.  There again, the liberal dropping of words makes
the thing sound wrong whatever we do.

Patch is OK with the original word order.

Richard