From: Ben Elliston <bje@au.ibm.com>
To: binutils@sources.redhat.com
Subject: Re: Use $(SHELL) when running move-if-change
Date: Mon, 20 Dec 2004 23:49:00 -0000 [thread overview]
Message-ID: <87zn08edhb.fsf@au.ibm.com> (raw)
In-Reply-To: <20041220212226.32268.qmail@gossamer.airs.com>
Ian Lance Taylor <ian@airs.com> writes:
> I'm checking in this patch to bfd/doc/Makefile.am to use $(SHELL)
> when running move-if-change. $(SHELL) should always be used with
> move-if-change or indeed any shell script. I suppose this one went
> unfixed for so long because it is only run when recreating info
> files, which normally does not need to be done when using a released
> version.
While we're discussing move-if-change here is a trivial patch that has
been sitting in my tree for some time. I always build with make -s,
so this bugs me perhaps more than most. Like mv(1), move-if-change
should be silent, too. Okay for mainline?
2004-11-01 Ben Elliston <bje@au.ibm.com>
* move-if-change: Don't produce any output, just like mv(1).
Index: move-if-change
===================================================================
RCS file: /home/bje/gcc-cvs/gcc/move-if-change,v
retrieving revision 1.3
diff -u -p -r1.3 move-if-change
--- move-if-change 11 Jan 1999 14:12:18 -0000 1.3
+++ move-if-change 20 Dec 2004 23:48:07 -0000
@@ -1,6 +1,6 @@
#!/bin/sh
-# Copyright (C) 1996 Free Software Foundation, Inc.
+# Copyright (C) 1996, 2004 Free Software Foundation, Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
@@ -22,7 +22,6 @@ then
if
cmp $1 $2 > /dev/null
then
-echo $2 is unchanged
rm -f $1
else
mv -f $1 $2
next prev parent reply other threads:[~2004-12-20 23:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-20 21:22 Ian Lance Taylor
2004-12-20 23:49 ` Ben Elliston [this message]
2004-12-21 2:32 ` Ian Lance Taylor
2004-12-21 3:20 ` Daniel Jacobowitz
2004-12-21 5:16 ` Ben Elliston
2004-12-21 8:20 ` Nick Clifton
2004-12-21 21:05 ` DJ Delorie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zn08edhb.fsf@au.ibm.com \
--to=bje@au.ibm.com \
--cc=binutils@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).