From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9073 invoked by alias); 20 Dec 2004 23:49:17 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 8857 invoked from network); 20 Dec 2004 23:49:03 -0000 Received: from unknown (HELO main.gmane.org) (80.91.229.2) by sourceware.org with SMTP; 20 Dec 2004 23:49:03 -0000 Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 1CgXGx-0000T3-00 for ; Tue, 21 Dec 2004 00:49:03 +0100 Received: from pcusersgroup-link.cbr.comindico.com.au ([203.220.47.98]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 21 Dec 2004 00:49:03 +0100 Received: from bje by pcusersgroup-link.cbr.comindico.com.au with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 21 Dec 2004 00:49:03 +0100 To: binutils@sources.redhat.com From: Ben Elliston Subject: Re: Use $(SHELL) when running move-if-change Date: Mon, 20 Dec 2004 23:49:00 -0000 Message-ID: <87zn08edhb.fsf@au.ibm.com> References: <20041220212226.32268.qmail@gossamer.airs.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: pcusersgroup-link.cbr.comindico.com.au User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 X-SW-Source: 2004-12/txt/msg00252.txt.bz2 Ian Lance Taylor writes: > I'm checking in this patch to bfd/doc/Makefile.am to use $(SHELL) > when running move-if-change. $(SHELL) should always be used with > move-if-change or indeed any shell script. I suppose this one went > unfixed for so long because it is only run when recreating info > files, which normally does not need to be done when using a released > version. While we're discussing move-if-change here is a trivial patch that has been sitting in my tree for some time. I always build with make -s, so this bugs me perhaps more than most. Like mv(1), move-if-change should be silent, too. Okay for mainline? 2004-11-01 Ben Elliston * move-if-change: Don't produce any output, just like mv(1). Index: move-if-change =================================================================== RCS file: /home/bje/gcc-cvs/gcc/move-if-change,v retrieving revision 1.3 diff -u -p -r1.3 move-if-change --- move-if-change 11 Jan 1999 14:12:18 -0000 1.3 +++ move-if-change 20 Dec 2004 23:48:07 -0000 @@ -1,6 +1,6 @@ #!/bin/sh -# Copyright (C) 1996 Free Software Foundation, Inc. +# Copyright (C) 1996, 2004 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -22,7 +22,6 @@ then if cmp $1 $2 > /dev/null then -echo $2 is unchanged rm -f $1 else mv -f $1 $2