From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50046.outbound.protection.outlook.com [40.107.5.46]) by sourceware.org (Postfix) with ESMTPS id BF0EB3858D32 for ; Wed, 5 Oct 2022 06:02:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BF0EB3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AFZbMqTFx0mzcTZsyoLXxSZqOKMdAFkYcFHl9uiLdX2mrKA9Y7GzLMS7YZszaYmtKAC0ZSRZcci4yU40BT0tQgHA7Q582e2jfDhy9lJ/ronPDcNRy9Pm5aStyqQpf1fJ07gOAdxZypTf0yMIS7L0yEsp8OSS+jJvgzTyOV1fAhDRhoLf5nmnyqqJcU77EgGuBjiNkqDpObhjAXkjuo815ZQku8gBuSiYGU7zk9vqfZgdHPAjtoAMWPWFPbjuJQZctUm7+Qb1ZQ1lEcQccdZba3N/nPob5Ezik0n+dDtpemK1cJB0+6nR1gCpNvHeMatF+7QEquS+iANbyQsCqgpYPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pjitGjRB1FsDSxrGdSZPS+JcgEpp5A0FrKz/JVJG46A=; b=PEeIvNBW13aI3xaZDNtbwRjEnrmcCxh2LJN6tkasixtxGOCTK0vfedpDZA1HjQoHk97v0uD26flMQzXJonMMJrRg4f3PU3nZrWORkcZXSe4G0kZM4ghEoPUyH2ng+tQlM2JSpwoRAZSUVIIa3hkLwehMBI20BWJ8DQXkLARk9zqOtdFgpzu0cjiJ0hdB5O+Y02Qfs6xOYxYuwN7wkFrVy/dbYQkMTV8nsD891Yph0WYMnTCTekrrT1qADO4pkTXDZizEdHQtLBfBXFgsdk46WAinE02h2GmdOaJP57FXUT4rkzPNKq1FaaiUjzXBdC0Mt27boGmBn1x8chucbYUVqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pjitGjRB1FsDSxrGdSZPS+JcgEpp5A0FrKz/JVJG46A=; b=bM7ZkVlKSR63zkmhhpz3ZihK4F1GAN9b+1EdjDA+tD42gHp7XdtliuhGxxFUheTPspu98mZvR98nHjx6BlnQLAroyv/Nl2KRoZWEvhi0YtcNumW0RscS1sEcZewWPkEN4helf9QWtqSHagpViMgWiAwE/VIbgELf/sEgful3xZALNCeYuB+WCeMqFbDPOm8tcXhYvr7uSQOnu3D478XPt1im7jTiIsnJE92NlLJd0xzFgjfAvHXNLok1tO7Z3QttvHEXFR0ID7FUuBt2kb/kVW1lxvrnDdv8siNCruPhxkyGOsrjGgvrdnEbDT8YwHe/DAeN7Hzpsb/4NS7VPL9lgA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7695.eurprd04.prod.outlook.com (2603:10a6:102:e3::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.32; Wed, 5 Oct 2022 06:02:28 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Wed, 5 Oct 2022 06:02:28 +0000 Message-ID: <88104e82-8c29-058f-557e-3a040ccf797a@suse.com> Date: Wed, 5 Oct 2022 08:02:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: Support objcopy changing compression to or from zstd Content-Language: en-US To: Fangrui Song Cc: binutils@sourceware.org, Alan Modra References: <20221004220134.ifx4i33v2obhzitr@gmail.com> From: Jan Beulich In-Reply-To: <20221004220134.ifx4i33v2obhzitr@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0758.eurprd06.prod.outlook.com (2603:10a6:20b:484::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7695:EE_ X-MS-Office365-Filtering-Correlation-Id: 77dcaa2d-3790-4564-4012-08daa6972eb5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pXrGaBYxKoAosb3yNiA9sg4W5ai97KE3bjVe1TvuW/jOtpZf8lUQDiqD4aqCPXVlhRvY/aC6LeOPOOr791fQQJ4nScS9D8BmcMhUCNyNxwzCuV9bU0STUKPD+6r6GASHf7ZvOQGYNuJUSh0r9ln2avVDnluU4hLThEgg+EhhAb4wwrDLD4gPlPuQURJFYCUzOoUN3fyL3yp/5SEP8IpbGKRBzXF3S2W/rKEvyAvoI5SAzNMyzT9A5vgKacUflFt923OvUeXO1Xad1PliJMjqNcwWzQvVCjDCwONn5hdTZN4eFg8LadlT0/6+aJES9C8Iw6ktTXF66QuW0b7enQ2ISULaYasZ8ihF1LwQi8KIWSLdduablMLSmpLEnoc5qVl9nypbSbI+Z3ewJVBtQDBWYPLXuJ0NkOorNE6FvVLrTzPyhgQjf6q1xC/lju+V3YvTwj+ijLZEbg9CfaBAjVKzkdNR1kj7CcNmuJKMiQIxJTC6qdONsQXuZRaAbdFytezVN+Vtxp62GOqW+5Yn0l2cc6DhmAUdJQeUnFh8AIiQyCbx35VBzQTjJ04pcJqcSreCsY/nbzLWFl7CTNgFKcZNkA+nyJLtpNYd1bhBn9Ri87NtLIuWafJu+4Y0gM5nkoA3fWQGM3tK9FBzq1ei8lWOgbbAgzcIm9NTGIbLKm4OmMqu8caazCmxBQ74Q9KHRRidX4ZhngrhMZEadiUOLFjTT83oDGMajJDQLQVCbAk2gvjM6GTOpCCpsezlBXdrBszCFHSw4rHQWB8IVualnCaevEGTRwYN3vRsA0lP21qex+YPA6nGGrg/kZAY+Tw9RaLN X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(39860400002)(376002)(346002)(396003)(136003)(451199015)(2906002)(6506007)(6512007)(26005)(41300700001)(53546011)(36756003)(5660300002)(478600001)(6486002)(38100700002)(31696002)(86362001)(8936002)(186003)(2616005)(316002)(31686004)(66476007)(66556008)(66946007)(6916009)(8676002)(4326008)(781001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bVI2ZmVVS0JWSVI4ZEdrV2pzdFBCOXJHK3l1ZnhLeUJxRlpBVTJCRDdsTWox?= =?utf-8?B?cnRGbnBOaHdlNjNjdnZUUnhZanpZTlVkS0NqQUFWTStkZkdhYTdKYnRtalF2?= =?utf-8?B?RTlNTkJhSzZ5UmZHT2hCRG1DejY5aVFHNnRRbi9UOGRzeHBLazh5OW5PQ0lE?= =?utf-8?B?SHQ4aE9oME5ab1dmS0lzcmZYcFgwTlo5UWlNWTNtTFRXUE1JQWM2RzQ3cDNu?= =?utf-8?B?NitLRis2cDZDNWRZaSszYVl1VktYSGdKdENieE5Tb3BBSVdVem1OZGpWNGto?= =?utf-8?B?aUh4N1hHdHZXRzNpbXdKUm1SeTFIUldVMTlWY01GZ2FCUUsrRXBqQm9hR2s2?= =?utf-8?B?Qy9FSnNvNUNZVTlOL1dtWGM3TXcwZDNBMlBuZzgrRXNXM0p6WUs2aXY2Z0tj?= =?utf-8?B?b3FhUldHOWVnMXQrN1NEVVE5YXkxL2syeE9ycjBKZ0pkZFRjTmdIejEyZ1ly?= =?utf-8?B?bGNSQzVFZ3I5OUJFb282OWJXdWVZenQ4Y3U1L2UrTWhkeGg1K1cxT2Z1cWdZ?= =?utf-8?B?K2F3c09CdmVqWEhIVUQ4aDZ3ZEJjc2VzYWEybEZSTHpzNGtObjdTN0t0MUFz?= =?utf-8?B?SnZOc3R3NEV0eFNRQ0J2ak51QjZVSVovVGlHMGhWNHFVYUpnRUJYb2VqNUtz?= =?utf-8?B?NExwSFlFQmtEdGRxSjJZTWRnaDMyZGJpd25hYll6RlAvSExRaWVmUHlnTnlQ?= =?utf-8?B?eWtPblVwSjNpeFBUSW9ydnlhRTd2VUh5cmdGSVBYVzZycXVHUm1IOC82RmFt?= =?utf-8?B?TlRKclQxTnd3R2ppNjZ3QTRQcDNpV2VjV2Jha0VkWFdOK3VjaDJwMHpMZEJD?= =?utf-8?B?aWs2TkxLdUZhUTdiS1V0R3F1dnl5elVCK2Z3R0Z6VUFUQXlHZk5temRFSjd2?= =?utf-8?B?MXBJbmpZQ1BHcExSVGgrT1pjaU5xSW9TSEVJa0JhNFFwU3lvM2JxRFFXNUEw?= =?utf-8?B?RHV5MktLRkJCcWpMazdodXBCMUcyL0lyODZpQmRFNzBlbUZoMXAvS25jbFRS?= =?utf-8?B?QzdPNzc0QUt6czVKY3hGbjY2a0xsT0NPdzBEdCtUbDZiN3RscE05eXFJdzEw?= =?utf-8?B?cXBOOG4weUlXK3RCalF5Nno5emRmSGNEQnNwQVdPSlpOem9qZUVBRGZrS0xl?= =?utf-8?B?UjBBQ3BGU2Nid2VoRFBnaXh6OE80UEREb2NEZks4bVAzYTh5em1pRjZMLytQ?= =?utf-8?B?SmdHYVYxS0ZZS2J0Vk5hRTNac2tGMGdMRXdyaGtSbFF0Y3NDZytzeGRQRHhI?= =?utf-8?B?OW93L09TZ1dERU5BcHIra3NJd2hkUHJrdVQ2NmZ1T3ludm0yYUZoa1p3ZlFr?= =?utf-8?B?SitlRXUwb2h3bE9KQmczeWRvMmhEK1dqQm9zY2NSaVlDZ3A3UHV1emxNK3N4?= =?utf-8?B?dkhnZTh2V1J0dkpxNHA0ZVJvUFhtTnFtbk5hanAwL1kzMXdxblRKU2wrbG03?= =?utf-8?B?Q09rcGdkcTFoNS9xT0thNCsyQ1BPdGwzOTJIZmNtclBFNFFjMVlrZ0VYZy90?= =?utf-8?B?Qjc1Nm1LZW5velA3Tjg0Y203V2hIN0RDaWpDWGxFN1lwQlBkL2RGOU5HQ241?= =?utf-8?B?Zk5xQUZoZE1jUVlQbEtNT3hwbk9sYTV2R2VPYkpJYUxldDl1MzdZSWNUMW9Z?= =?utf-8?B?UlVFZFd3Vm5mc1RqWWdTUW1uQVJoaGllaFFhengyNGxjcmIrRUtaVTZQTWdE?= =?utf-8?B?SzlRelJmQUc5L09XbDVwN2Z6MkhKOGUwL2wzWXR1UFZCTURPa216Q3hNb3RN?= =?utf-8?B?WGR6WWI5ZVBhU2M1VzgrK2tMcHk3QnRqaHdIY05zNmkyOVJOMk9mZlVPQlNF?= =?utf-8?B?enBtdTR1eTZDaDIzRzc1SmRzRDZlaEhVZ3ViTVRHVHJJNWtLNVJCREgvaUlU?= =?utf-8?B?cllEK3VTQ2lEc01Qd1lLcW4zSEFjanNmd1JreG51SzBkdk5MVTBIMzBJbEs4?= =?utf-8?B?S01UMGlQcXFCVjNuNEx5czFjV2xOZ042aXhkSHdVdGJ5ZVFwd2M4S2ZSbXhG?= =?utf-8?B?bjl2eUZpNnAwTHRZaDZaU0NYR1M3bnUrQWhsMUlSblpDVi9Jc0t6NW1mc20y?= =?utf-8?B?QzNGd0w2ejQ2a21ZTStiSmhTbWJSOTVqQTFlanBWMURFSWFjQXB2VnpqWmh1?= =?utf-8?Q?G+XTW9XizjrNoa2psMzlC4dAP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 77dcaa2d-3790-4564-4012-08daa6972eb5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2022 06:02:28.1499 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mLUTJxvXAs64nfpB9m0UfWryln2qY3eHt5dbasdMRVy8oLiAAe3BJn6Ed99lFxVP42vcBzGc96koA+eWxrOmbA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7695 X-Spam-Status: No, score=-3030.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 05.10.2022 00:01, Fangrui Song wrote: > On 2022-10-04, Alan Modra via Binutils wrote: >> Commit 2cac01e3ffff lacked support for objcopy changing compression >> style. Add that support, which meant a rewrite of >> bfd_compress_section_contents. In the process I've fixed some memory >> leaks. > > For objcopy --compress-debug-sections=zstd , I know that omitting > recompression of zlib into zstd was intentional. --compress-debug-sections=zstd > does not specify what to do when a section is compressed, so both (a) > do nothing (b) re-compression with zstd are fine but I think > avoiding recompression can avoid some complexity... > > If a .o is compressed with zlib level 5, should --compress-debug-sections=zlib > re-compress it or leave it as-is? > > At any rate, I think the objcopy --compress-debug-sections=zstd > behavior with zlib compressed sections is mostly not interesting to a > user. Considering that --compress-debug-sections=none means "decompress" rather than "leave alone" (which I would consider more reasonable), I think it is a logical consequence that =zstd means "(re)compress" (even if, like for =none, I'm not convinced this is the best possible behavior). In any event, even more so now that there are two truly distinct compression methods, I think a way to express such variants is quite desirable, perhaps even necessary. Jan