From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2041.outbound.protection.outlook.com [40.107.104.41]) by sourceware.org (Postfix) with ESMTPS id 485E938618CF for ; Fri, 24 Nov 2023 09:04:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 485E938618CF Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 485E938618CF Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.104.41 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700816662; cv=pass; b=r5e695l3yvQwX1EtdA96mwXS/rVLVcEbU0QEKhHp5zcHUS+sSGTJNBSK8Sj0Ibw1+S2LqcwhMEHgL6obNe8H8PscYGXuNh6eYMvgrOE60OIj8d3JooYs5/PxrfhIOaXe0Xk27wMJxG1ZKxV3hLxp60pQzjmPCeMmjSsIJB8vlmA= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700816662; c=relaxed/simple; bh=fqgQSUxJuCMTtvIuzDOn5V0o+w9pb2ahSAMHVxN9FuQ=; h=DKIM-Signature:Message-ID:Date:Subject:From:To:MIME-Version; b=Tbd9LJrkK58i6DICBQzPbFuN1qqxLWWCJ44q6p/qXfGo4W5zlnl7+MYgP3yO4QgawptkrJVcFYkIzqUTemuFqBgJFirjifdpfygXjQbN8hbbORXvupigmGlLOHXkazIQl/c2hmjbQb4/vlb0RlxaOfs3zSjqFuzfz0yj4fEkJYw= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BAkjtoB8dY1LinUEqdbTWSY8hRQXkECWBJhVD+sWbk/bldijJDRR76M/JCM/TKmX6Nl7IOmt2OJNonxcLHp+jNEUYv8TKdBHKr1kVV9mcUuaHOSMLbRGh8rE0Q1k/Mtw41QGbcae46Lpj6JtXhcu9IZapsL38j9d5p1/sqrw5wCWEDtEY9DF1ZuvRWhS0frhlE0JZ0Z4ulE8dSCFReBFRj177zdm+S8I9QOUPI7aE8iDm3pMHlS/v7dnVVcwR8o/s35p+j1Q2o8tf9BLXxImpgYI4PT7q2ZxgHwc6CWVVef2qPtgXy5P/G6PX79+M3/DylgAb26dT50VRtnnjMZbWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/fjh4uYEsXN5eJRAxw/lS1RbaMC3a2M3urGkY+tVwmw=; b=HW5/zGL8/Mcg9IiNhtxTaaDb/ecFkV3sudo7NZp15GhGYQZyaii/1l6ogKDFJMBbPHUaKL83d2lwj/ESXFNK04lG8mMr9lOLlZ3TVQS37t8OYdKkB+3JiEyM41bDdBT8C92TdfuU6EW+cD7VZmSwWo+q12D4V9T2yGhkHd0/Pt8gmdEqPg4IItizZpjwkuC+6Hf0nYpPOVEsueTjU1gdOozlMKLIfY3pqSafZi1L7rxsejaM5Up3fvZyxuF64S5lBsLewumStmzAflx0I3GT8hIhrNRhYb1Zq/2rlQo+gCY/6sXGQ+jZ3g8zxq/dwCAZKj9oA6fNglTjzZ8dqOg/Zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/fjh4uYEsXN5eJRAxw/lS1RbaMC3a2M3urGkY+tVwmw=; b=yYmdLaj8er1yXDnmqoPg/gGX+sm0P/YlMZWYqYdoD3odRlX4h020LKyXDxiE+0Xs3NvCipqNPExgFWX2+mb/DGD9tADUHB3QQw+dFgh/CHVksvWhB64yuLLduFZw5vyzHHbugZFp5v4HTJ9Wjrq+NIN/lhAFNsqZ4RNxx2lLUKl4a3mE0mGQkImZDtVHaaGt6b6dmVrUy4vGC9S3yA/5RK0TeF75wDQvcPh/ED1aszEWzZ4oszCNqTqSzIemdyUVghxTNLMKx1Paup69pUg5ERl961hq29CtFtr11PYhxNKJyQ74NFShxyL3aXINuK3A89okMhZhbL0Au/hgQdIgiA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB8PR04MB6778.eurprd04.prod.outlook.com (2603:10a6:10:111::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.14; Fri, 24 Nov 2023 09:04:18 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44%3]) with mapi id 15.20.7046.012; Fri, 24 Nov 2023 09:04:18 +0000 Message-ID: <8857c2de-39b6-43c7-93d9-43554ef317c3@suse.com> Date: Fri, 24 Nov 2023 10:04:17 +0100 User-Agent: Mozilla Thunderbird Subject: [PATCH 3/6] gas: no md_cons_align() for .nop{,s} Content-Language: en-US From: Jan Beulich To: Binutils Cc: "H.J. Lu" , Nick Clifton References: <94626e2b-0e73-4267-9c80-cb25e1dbab9b@suse.com> Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <94626e2b-0e73-4267-9c80-cb25e1dbab9b@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR5P281CA0033.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:f3::10) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB8PR04MB6778:EE_ X-MS-Office365-Filtering-Correlation-Id: d29b9729-e894-4adc-5a53-08dbeccc570e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7fvQbZarUgXGRwiuyZXw1rI2fCpZ5MZOCTgIEa5l8GYM5Uqsy13Ok/TN3qxKRLDpZUoK7kUgLY4Zd6sJr+R9TzhLxQGCNuKkeCcamTt9McvGBs9HPBuzX6mOGoENyQH2ih/rzjfKRsU7uh4xXP3XzkJM2zCbCd3Q4ke7AXXeJiB6hu9WTQ8KTX79eHHRzfdAKMlS9qQLqRy40+azi6PugJar4cBwrvcpHH8G9Adfck1uh+vku16Jc6CbpBtV3BfkXPT7kxPqmEK0goC/xTg/vqilOQJT2G/B8OibzzAbxV0CoZj7/vFj0cE+dzBlKBjwFgKAEDR0YYsHAbUg4GwpTm3Jk3WHTtG98xONOqMEYIvuANfMDMfvwne2KTE81bC+aPVTwMOV2SOFOe0H5dv6FbefgnpoKJZTeyxfOajHrbyl9T8KW5Z25OoPCjby5dhTD4SssuPrf32WeaEoqFvFG/rTx2wZbYdGeQaNpmjEUhDps4NeAJMLzwK++eWzkbbaAEINPnh+BYdyDU4mVLLqDU+hAaa8vCWzqEx+t1EvfnaLOB4Uv1yOftlHcSZYrGaBdhpWqCdz86e5kj0PolB7sbu6DMP3cEsEBO9C4tpCO67wklPO1TYDEtQRGGbpU6YjMbKQ+OR0/9Sw8YdvRbL9yYvWpiQzEJU80VmQQbqQyaZiWKLud8EQb1A/lvqeQq7hWJTEroI2Q24yXf8DxIcjjFjA88WRJq1u1b7M813IQQQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(396003)(376002)(346002)(39860400002)(136003)(230922051799003)(230273577357003)(230173577357003)(1800799012)(64100799003)(451199024)(186009)(2616005)(2906002)(26005)(31696002)(5660300002)(86362001)(6512007)(31686004)(41300700001)(83380400001)(66899024)(8676002)(8936002)(4326008)(6506007)(316002)(6916009)(36756003)(54906003)(66946007)(66476007)(66556008)(478600001)(6486002)(38100700002)(142923001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c0R3Vi9KMlV2VVluelBYYUhkSHZaTVhIMUNCb3VFb3k3YmFySnJ1RHVicnpO?= =?utf-8?B?YTlBbkVMdzRTaWYxNXJIZHRrSjVnbzFvL082OGVXaGNSRmF0VmpUZEFHemJz?= =?utf-8?B?QkJyYnhFd1AycmpQYkV3R09ldkE3UE9ONmM2bzErWmR1S2Y0Z1gydVRCRnRa?= =?utf-8?B?R29lck5mZ2g4Mit0ei8wNUhIRDl2enlMeFJYZkZMa09KNXRIT2R3WE90Sk14?= =?utf-8?B?dkk4L3NzQkJSN0paRXByMHJUUGRMZllQbVpKemh3OFIvOFJPV2NYUGttbzc5?= =?utf-8?B?M2w0S0V0Yk5ORGU2ZHFvbVdlaWo2OVZhdUgrME5tVFJDVUMyMmFjZ21lUHR3?= =?utf-8?B?WVFycUxUR2xSYlJSTnZiZk41Y3V2bFR3dEl6VWplSjNsNjhmMGZGTUs1TGdy?= =?utf-8?B?SDMybWNQR0loTzljUGs2TDc0Vkh0Y0YrM1dzcGd1bUFKZnYyTkJzK3dudTZM?= =?utf-8?B?b2N1cWpYZ0cxalFRcitTWTFBMkZKY3FpUHV4ekhCRHl6aHNCYzB4WVgzWEl0?= =?utf-8?B?Zy8wczZOSlMxUFVLWUxRazlrb0IzbU5qK1VzbzNZUmttTlBrV2RxUmZHZFk5?= =?utf-8?B?RUhOOVNrQ2hXVUhhS2lMZjlSOUdTamxkT1RCckVrY3hVamdMZFFhamVzQUsx?= =?utf-8?B?eVlBdDQ2YitVa1Btcm9IcE9LUnhJUnNoQllxeXZXckwxbWRxcEMxSkdTWWUx?= =?utf-8?B?aE1ZYWcrSTVnTTZCZHdGK296NjE1OEd1d2dOTHF1YVVJc3NXK0UvWkJnMG1r?= =?utf-8?B?cFVwelFaYVUvakZFS1pDbkMrZUVacFZSYmM3UFViWisrd09qdFllN1hkSnBO?= =?utf-8?B?OXArNjRuZ0R4OVluYXRDOFAxaTZ5dmhraGJUZVJEd3gxZlNLZStpdVAzblN5?= =?utf-8?B?bUVEd3RWNzBhQmZMRGRvVGk3YWk3MlZxVG5rU2lHcFI5c2RNWnRqRmsxMER3?= =?utf-8?B?VXBrQ3hENEJGT045RWo0ODdGYTJtNzB3WXZHWE5NRGZIbnZvK3U4TkVHVURD?= =?utf-8?B?bkkvYVBtbEFLajR1ZTNvZ0lBN0Z4M0oxUWZ5UFFjZW9KWDNZOS9oL1NFZytp?= =?utf-8?B?VkMweUpXVGhXWmRjZEsyVStiK3IyODBVRnpxNThQMlFYYXNmRFNqVU51N0cx?= =?utf-8?B?NERKcDdsLzNyaVZ2a0xZd21KSEN0TnZyNDErOXpYMmFDS21kWUlEbEg0ZGJq?= =?utf-8?B?MmcvT0tHWnpxeUxZdWIxa1lXV0Y0TVhCSC9DdFFqSjVWeDJKRm41eHFFWktv?= =?utf-8?B?QXBIMGZJTmhzNGwxZUZoTldrc0VxTi9hblF4OHhEbmFpWU1hTytobnU0TllU?= =?utf-8?B?NFJLaGNINThuRkJKY1NsMUJic3drUUptbkRqemtFR2g0ZngzSXlnSGtXN2xO?= =?utf-8?B?a0ZHQXlFZk5NeEx6emZpNWFySllwTVZRNjF6U0dRdU0xc3pSMGRwRFhVNnlh?= =?utf-8?B?ZkNVTFRoaEFEYWFEVTJlMkRYdUs2d3orMnZodzIybmlnT3EyR3VZY1l5UU81?= =?utf-8?B?QXh0dmlPNXBPM0pwNytrVU5yb3lTM1Uzcks4ZGN6Q2tsT1RxekdJOC9TNjB2?= =?utf-8?B?aHZKKy9aYldrYmtCdlFBNjlhR2FOVmZFdlQ0UVptblBsQnV5ZXRYWVBadXpZ?= =?utf-8?B?Tko2VWx5YWMyQ0NwdGxTZFU5QS9GMFZRYlVicWU2c0lXcllWR1hUTFRwaEhQ?= =?utf-8?B?MncwTzRrUUo0aXhHTG1taU52QU9TZi9HR2QzdTdHMkJGL3pkZDRDNlVoTFhY?= =?utf-8?B?QXQvbVlZUHJGQjhjOE43Znppb1FTa3lQT1hYNXhqVG5DZWdzWkVydVgvNmZi?= =?utf-8?B?ZFJZMS9GTGRFWXVNdmVNWFQ3YVlMTkVVNjFWTDFma2hOMjZJaVVYS3J1S1Mr?= =?utf-8?B?V1BRYk13R1E1eHM4ZWVHU255aGt2SkpOWUJnR3k2UHpPekZLRFBUM0pscGpj?= =?utf-8?B?cGZrZG92N2ZsMjZnOHVORnB5dTZxQmNsQVdzSFhFYzRGbkNOQUsvN3haTjdr?= =?utf-8?B?dUhjbkFkZERtVklHcm5URUxLa2l1M05WcTZzSVdORHlyU3FHK1k0Nlh5MitV?= =?utf-8?B?TlhjQ0s5eXlkK1k0eXorU3h3ZExNOVBKOFRwcWVNK1owbzBmR3VCdklzdXBm?= =?utf-8?Q?W6XcTl6yTS+nGnOrGhP7i1Rc+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d29b9729-e894-4adc-5a53-08dbeccc570e X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2023 09:04:18.2181 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6Z8HmwBIZnmRL9alrXPXD/rJUbme8d81kj0tO9Fo4AYvYt8ys+w4chDfDkqVja/ZN1Qp4ontft1PO4xtfKGLjg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6778 X-Spam-Status: No, score=-3026.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: .nop and .nops generate code, not data. Hence them invoking md_cons_align() is at best inappropriate. In fact it actually gets in the of x86'es state maintenance involving i386_cons_align(). --- I also consider it at least a little suspicious that all common code invocations of md_cons_align() have an argument of 1 passed to it: What's the point of that argument then? Target specific code invoking their own target hook can surely deal with passing appropriate arguments other than 1. --- a/gas/read.c +++ b/gas/read.c @@ -3466,10 +3466,6 @@ s_nop (int ignore ATTRIBUTE_UNUSED) md_flush_pending_output (); #endif -#ifdef md_cons_align - md_cons_align (1); -#endif - SKIP_WHITESPACE (); expression (&exp); demand_empty_rest_of_line (); @@ -3519,10 +3515,6 @@ s_nops (int ignore ATTRIBUTE_UNUSED) md_flush_pending_output (); #endif -#ifdef md_cons_align - md_cons_align (1); -#endif - SKIP_WHITESPACE (); expression (&exp); /* Note - this expression is tested for an absolute value in --- a/gas/testsuite/gas/i386/align-branch-6.e +++ b/gas/testsuite/gas/i386/align-branch-6.e @@ -1,2 +1,2 @@ .*: Assembler messages: -.*:4: Warning: `constant directive` skips -malign-branch-boundary on `jnc` +.*:5: Warning: `constant directive` skips -malign-branch-boundary on `jnc` --- a/gas/testsuite/gas/i386/lfence-byte.d +++ b/gas/testsuite/gas/i386/lfence-byte.d @@ -27,4 +27,13 @@ Disassembly of section .text: +[a-f0-9]+: f3 c3 repz ret +[a-f0-9]+: c3 ret +[a-f0-9]+: f3 ff d0 repz call \*%eax + +[a-f0-9]+ : + +[a-f0-9]+: 90 nop + +[a-f0-9]+: 0f ae e8 lfence + +[a-f0-9]+: ff d0 call \*%eax + +[a-f0-9]+: 8d 76 00 lea (0x)?0\(%esi\),%esi + +[a-f0-9]+: 83 0c 24 00 orl \$0x0,\(%esp\) + +[a-f0-9]+: 0f ae e8 lfence + +[a-f0-9]+: c3 ret #pass --- a/gas/testsuite/gas/i386/lfence-byte.s +++ b/gas/testsuite/gas/i386/lfence-byte.s @@ -21,3 +21,10 @@ _start: call *%eax .data .byte 0 + + .text +directive: + .nop + call *%eax + .nops 3 + ret