From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 75F7F3857803 for ; Tue, 25 Jul 2023 14:13:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 75F7F3857803 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690294419; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UoaBnF898V4YI4MPrUhri0jJg/9A4ym4jRXUYqw1+d0=; b=Sx8vmLXAJtgVgJxjabbCyH5fPQBVPFskaY+y3m37ylL3doRrN69WU9sla54J5RVHC1Fnz1 SDmsWnvfg7+kRZH9ZQEDSjN4HQZ378DlPDaLNv2sZVgV3hO+lTfFkmIPsPAI7U2qBoqjcR n0pOznDklPd20T7xh8ILXbhuWsKZRpE= Received: from mail-ot1-f72.google.com (mail-ot1-f72.google.com [209.85.210.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-78-b95pPPMnPtqzRpO_TRk6nQ-1; Tue, 25 Jul 2023 10:13:34 -0400 X-MC-Unique: b95pPPMnPtqzRpO_TRk6nQ-1 Received: by mail-ot1-f72.google.com with SMTP id 46e09a7af769-6b9cf208fb5so10765505a34.3 for ; Tue, 25 Jul 2023 07:13:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690294412; x=1690899212; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UoaBnF898V4YI4MPrUhri0jJg/9A4ym4jRXUYqw1+d0=; b=dK24zvscqWDRU8ALkSIrtiG2EATt4PTgXgsDiSozKM8rRqHXzUyIDvDR0hfPHUZ8S9 iHjJY+zOOXKwDjvsvP+oybmc3J7FiT2Nir8mv3HAIOW+4wXZuhwHmZYM2xKgpaMbaIKv OctWZOwdgkeitV5pzdEgDGOQFrUGKkdsTXn4Tb1mnfDf6GELSSKLTwSG8yC31CAcQmU0 cAIoWRMZOn67EVh5lgzO7YZrD4Owf8lI8ojOoNXHI2NKqS+i+BEpyASirNHKlUBV/+gc UOZ5MDRiB+KLb4P1VPGZr+M745hSIGUduBddAeZeZ/Usf/+3mwmGfQ6R9fso+nmUZvNp S73w== X-Gm-Message-State: ABy/qLb1VXy472bUNvoiGvFUHrQA2A0r2AO6k+d3ERzjf4V1bxev3zKI XyLnNtYMPesEFxoYNnKBLw3fwmJUAqwX1o2I1DMBql/OEsaBgg/iT32TSE4eZPf5z4IJ3c9vM3p 8ERPmszBwnnk0dXRYUlBMvKXXUw== X-Received: by 2002:a05:6830:1e89:b0:6b9:146a:f1c9 with SMTP id n9-20020a0568301e8900b006b9146af1c9mr11226167otr.0.1690294411870; Tue, 25 Jul 2023 07:13:31 -0700 (PDT) X-Google-Smtp-Source: APBJJlECOokBSGrzT5x3vAZNcdGRzMtKpBjwReefOJw9pI2ySRp+QuP66dot0fVh/5rv3x7q+Nt9OA== X-Received: by 2002:a05:6830:1e89:b0:6b9:146a:f1c9 with SMTP id n9-20020a0568301e8900b006b9146af1c9mr11226146otr.0.1690294411592; Tue, 25 Jul 2023 07:13:31 -0700 (PDT) Received: from [192.168.1.7] ([79.123.79.89]) by smtp.gmail.com with ESMTPSA id r4-20020a0ce284000000b00631f40503cbsm4350908qvl.12.2023.07.25.07.13.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jul 2023 07:13:31 -0700 (PDT) Message-ID: <886f77cd-8cee-d530-64f0-c09cb9643a93@redhat.com> Date: Tue, 25 Jul 2023 15:13:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Paul Iannetta Cc: binutils@sourceware.org References: <20230721074956.7188-1-piannetta@kalrayinc.com> <7a676623-4084-c210-3dcd-37e813aeb32d@redhat.com> <20230724123338.r27dhowqkwzqgt4u@ws2202.lin.mbt.kalray.eu> From: Nick Clifton Subject: Re: [PATCH 0/7] kvx: New port. In-Reply-To: <20230724123338.r27dhowqkwzqgt4u@ws2202.lin.mbt.kalray.eu> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Paul, >> I tried compiling the binutils for a kvx-elf target with your >> patches applied and I ran across a compile time warning/error: > > Yes, indeed, it was more of a convenience macro but it is not well > supported by gcc13+, that's the only location it is used so you can > safely comment out those lines and I will remove them as well. Ok, so with that down, the port compiles. But then there are some unexpected failures in the gas testsuite: FAIL: .set with IFUNC FAIL: elf type list FAIL: elf type-2 list Which are all due to the fact that the kvx port does not support indirect functions: gas/testsuite/gas/elf/ifunc-1.s: Assembler messages: gas/testsuite/gas/elf/ifunc-1.s:9: Error: unrecognized symbol type "gnu_indirect_function" I suggest updating the list of targets-that-do-not-support-ifuncs starting at line 237 of gas/testsuite/gas/elf/elf.exp to fix this. There are similar problems with the binutils testsuite: FAIL: nm --ifunc-chars (assembly) FAIL: weaken STB_GNU_UNIQUE symbols FAIL: strip on STB_GNU_UNIQUE Tweaks to proc supports_gnu_osabi in binutils/testsuite/lib/binutils-common.exp and binutils/testsuite/binutils-all/nm.exp should fix these. Finally there are quite a few failures in the linker testsuite: FAIL: --export-dynamic-symbol foo archive FAIL: -u --export-dynamic-symbol foo archive FAIL: -u --export-dynamic-symbol "f*" archive FAIL: --export-dynamic-symbol-list foo archive FAIL: -u --export-dynamic-symbol-list foo bar archive FAIL: -u --export-dynamic-symbol-list fstar archive FAIL: pr26580-2 FAIL: Build pr22471 FAIL: DT_TEXTREL map file warning FAIL: Build pr22150 FAIL: Build pr25458 FAIL: pr20995 FAIL: --gc-sections with __gxx_personality FAIL: ld-scripts/fill Six of these can be fixed by updating proc check_pie_support in binutils/testsuite/ lib/binutils-common.exp. Interestingly patch 2/7 added a test to this proc, but limited it to the kvx-*-cos target. Which is odd since it appears to be a problem for all kvx targets. Most of the remaining failures appear to be due to this error: error: PHDR segment not covered by LOAD segment Which I am guessing is due to some kind of issue with the built in linker script for the KVX target. Although I am not sure exactly what the issue might be. All of which is to say - please could you submit a v2 patch series with these issues resolved and your other updates integrated, and then I will have another go at reviewing them. Thanks. Cheers Nick