From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 1938E384AB66 for ; Thu, 18 Apr 2024 07:40:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1938E384AB66 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1938E384AB66 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713426055; cv=pass; b=SPvQHzi6I2fGZ9M3qu7vYV07AzZrl70a0AATWrM+QFgTu8XfSbCDTVbsqcCp3pLpH1TU+rmmEirmtgxSocTojyRFqHK0V8dWN9lUCH7Uui4090d/N9g2IwBnD8fu2dOJPSqKSFCeTPrh8RO+pNsqBxWUJHTp06NLdvGRlNUm6p0= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713426055; c=relaxed/simple; bh=evz/24GZ0nCILR6m5Zzt9dN9CFKZb5f3r47/uwEhRr0=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=bqF4+4vXvgVFSc9ALfcElS+fDpLolLhjZkZGPYcR2iXiReHU1p+DJPEN4Bqjm9vc5hg32+o4ubqrMyJleeCuZl8TUKJ/ILdZV82s4UGnDiBuFs4ipjsmWhYwSHOStD3A3E97KMKCjBtSqc5W7j6YttI4XEpZW89bggh92uSppeY= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43I3wugS031342; Thu, 18 Apr 2024 07:39:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=iM3xAi+3fCjpJXi8hpI2qKgrl0QNQQ9w41xltsp/W9c=; b=iYjOTI7ei79qKlbOFY581cn79Orhu71nO3NAIhYycR2oodg4ZCqmmGbVmqQ3z5QTyfSE nHmtQl5HGYLLIHmNB7kQ69NP/xLYPGXwVVrAQPgJpMA26OFqRjDNDe5adG63cBdRmeqL mZodyIoFZ1dWdKPylLeYpP/wTUzHPCwvdG/uD7Lz0esEfRVxNJuhrrO28xUZXpkH+OJo jt7TUyx/GvSK1IvT4jpy5MIs3D/oDqcGE13NcCW43zrGLMndp1lfahw7mYik+R5wilTV PJHvavdMOKJxgswqRl7S6a5di7+qMktvn8xCAjjJyFOFiTNP5pRUcaVIWz/xC1R8puJm nw== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3xfhnuhsqf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Apr 2024 07:39:48 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 43I67StS004961; Thu, 18 Apr 2024 07:39:47 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2101.outbound.protection.outlook.com [104.47.58.101]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3xfggg96cr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Apr 2024 07:39:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YLn3vX0beEWVDFOVru/QenuHXH/URnAgB6HEo5A2Xc6jnvOghwIJYoHFqH9HL9XdbHC2SgAqk1uFrTH0eUmPwZEm6RVgkCKbgEick66M7hyGMM9v9P50eB/ecT2KrjIyVI484QvLghnFHYPwbZ/hfdoGIjhYxBdQnp0wlqzeWVdASANKSnlXUKjt+1D1xI50Qw2cE1xG//miVTA6ptZyaIOiauETmN9aWEbf/64HiBHLFZja9QOXOoVD9af/gKSDpQ96wwSgBUjH/jlrT7+wa/Dz3cbE4DkTRRk/BSJ4XBt2HwpgeRcLjWnp6sVtHFROjYv8xzrWHkYr3PIzYOGfCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iM3xAi+3fCjpJXi8hpI2qKgrl0QNQQ9w41xltsp/W9c=; b=f40JashZlvsg1H8sCB//FjVBn6ha4kMdVN7GACcmsUS70R+h5kyoiJEwltcenusxXEcAzD3h6ltAEplmu9hGS8Mi6uTmEHDURuXE4rJ/C+iEivBgswp0O8HGHui+UUOlifs/tu+tK5yNtI1Tgi85WV41KFHivCY7lYqqXHVpn9Pr77oFL+eY2Qv48ch4Le6HXlzJIEB6AU1tmZLRPu7na8/nQ+c2pRfwspM1m5zge52ufCOHq+01HhLibj+XFwvI2RR+/PRIk4GaOCxGUt2xAg2WW+nPMO/DH5HybKPVszapT03JQvhxt4tUouMFSM02dnbdrnJ7yFZn6yWjzgXmCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iM3xAi+3fCjpJXi8hpI2qKgrl0QNQQ9w41xltsp/W9c=; b=w2zpC4RQB8nkIACVyMD6hQkUK3tWlNYyQsZDmbbUDoImzvNZaPQcZN4buQh9Qn8b/GeZxw9sz1LtBo5/ax9PshfqsJrfyf/BVXNfC8z/y2Z/+zG0+FGGmJ0gxijBVDNVWQNlQTPNGtR2sYbBH83iCH6j4Z6ep7mgAlXS0IO4jjk= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by BY5PR10MB4273.namprd10.prod.outlook.com (2603:10b6:a03:205::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.49; Thu, 18 Apr 2024 07:39:45 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::6f0e:742a:270:889]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::6f0e:742a:270:889%5]) with mapi id 15.20.7452.049; Thu, 18 Apr 2024 07:39:45 +0000 Message-ID: <888015cf-de85-4ac3-9709-4c797e65ad00@oracle.com> Date: Thu, 18 Apr 2024 00:39:43 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 02/15] gas: Enhance arch-specific SFrame configuration descriptions Content-Language: en-US To: Jens Remus , binutils@sourceware.org Cc: Andreas Krebbel References: <20240412144718.4191286-1-jremus@linux.ibm.com> <20240412144718.4191286-3-jremus@linux.ibm.com> From: Indu Bhagat In-Reply-To: <20240412144718.4191286-3-jremus@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4P220CA0004.NAMP220.PROD.OUTLOOK.COM (2603:10b6:303:115::9) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|BY5PR10MB4273:EE_ X-MS-Office365-Filtering-Correlation-Id: 5887875d-348a-4bc0-96f5-08dc5f7ab7a7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 48YD7pEvK/JSwRm+Q+5SRbNDkzOTygVTuJy7IoQ+GSqCJTfkoX8jr9mmAvAxclVwVLcaroi2eDTPJSMku7iQl1T+W7JV2MSCQZHT8QwHWKC/c6RZIRfqA1EFgwDKGs1XWzYu6v/6bWA/JyI+jkOrPKTG9NsJCV4WwoFE9WRfrXYJPcTItAYa+8hbwl+DEcnplZpPyXE0KhVhU7FsIyV2+aWo6dCeb3KyMlRUsiE4gHTVCZK0DzIrp2u7dNqmasRofkAwi/AmfdqdlatbQUzQbqoHwG4oNmLZWGnZjxGYy9SjRqtUP4V8BGRYClmte2tikFJGhjr3cY2hb8Ex0SC/DSgMoBMUrMfUSLbC/vL4L+NtuALjwtC56d073FsZkn/vbhJYhE5R0lGaqzU8tTj1bnCWZy0/8ICWIc+ZAwhV0ToffzIWVDSvT1XeH2tzPOSDaqRpWgBkhTJaVO5lsOb8iJPq0sMCpspiuylOpRCwvHttAiMSpytVvCVkxmxbRugoaRS8mZz1wNtQarv/L2JfG1Z2Iuk8wpPD2FmwAWny23XQZWo0DGQPOhEty5tNcXtrIInYqIviuANtoqMwTQMlOxvuuCj/DHQq9dlbk+Zfbz3fwIIC21hjs0D8z2vbw4ssHlBtVT1bMtr3rFyBJgy4V4zxiMG0L854y7GY2f/IlTE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(1800799015)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VW0velN0WFZkd3hSNXUyaWV5Sjc4NTJsOFdlWVZ2OVlNUVRFVGJVaE1HK3FV?= =?utf-8?B?ZUV3WU1GUE44RXdYWkZRaWVJT3ZTRWgrc2RFeEt3MXN6QUZwSTQwVDM4ZUJY?= =?utf-8?B?ZmxhODFyLzArcUxZajBUclA2SFlXS0ViVnJhUy9ZUFNKazFoL25aUUpSazkr?= =?utf-8?B?TXpaU0VoaVlUZFc3ajQzUXhLbmplYVNJc1VuTUZXZ0htQUhkQ1NDbUNpckgv?= =?utf-8?B?UDN4OVE2T2p4S0dHM1VHZjB2YUZ1NE82ZVN4ZGVqNERRcHpZbjJHcjJXUlpy?= =?utf-8?B?TGRySkl5T3dMYXAzOE5ZQTlKWjh4c0lxQU5USGY0VnJxL21mQnFTRFkyTXZQ?= =?utf-8?B?eFYzcitXNDVvbThYMk5kdlliT0xkemcyTW82UnpGWXlDNmZvQzZ0YUNUL3d6?= =?utf-8?B?SFc0QmUxYVd5djBnSzVSMnR0WkYrQ1BmcTdabmlZNHBWKzR3dElxSlJoa3Fx?= =?utf-8?B?ZHN6VEdMVFllZ2pDdEtTMDltOUtvMlR0Y2VOWUpISWI0T3NwcXJ4dldNOVJm?= =?utf-8?B?djVnbGhZNHFNTGc2TVRPVGY3UWpkNzFUSU5qMGtKdjRRMjM5L0MxMDhINElu?= =?utf-8?B?ZW56TmpLOXMyd0MwaHJ3NjJNTXVPSi9lTDFiL3hpQzNxZnRkbkV5RW5hYXFE?= =?utf-8?B?UGgzVWYxNnQ3cnhsL0NkWDFmYmxKUENZcjRDbmlCQkNtYi9kRVVady90Tk9q?= =?utf-8?B?RGlIOHh0YVBkWVNuMURJbW9NVkV4WTBxL0JTY25OWk1KckVLbSsrOHAvbDVw?= =?utf-8?B?RDJ3WmtSa1huaVNYeXp3TjlJdjcvS293MVFEMk5kM3ZZQURjMlBBajdKeVhq?= =?utf-8?B?MFRjQ0FKSG55OWFDQnFSdVd4SGRUVDZUMno4QUFzUElXT1NTaHdJQWxVU3pw?= =?utf-8?B?QlNhY1ZBMnRxM0JDZnhkNXFqUDN0Y1VtTjBxWlNTb1hNV3VTQmxvbnJORVZp?= =?utf-8?B?aFE3TVIvanNIeVRlS2tLVXpuOWdCbmxWc25GeU1yWEp1ZXBWemZzcDhjcDZ3?= =?utf-8?B?RTEyck1abFZGLzVYWVIwWk5kRzU3V21Qb202ODBDa09WMTJrK2FhY3J5WDl2?= =?utf-8?B?RUlwczdZV3pBai9qOTFnUk40WCt6eXNBUlpSclJrRU8xSUlDRGljQVlZQUVW?= =?utf-8?B?VCtnWjNhTHhsVWZtTUNoYjFJYzRDSVNGTnVhSGZma2hSeHlpV3pDbk9WblVh?= =?utf-8?B?VjhBWkpWWUJnUkFIVmxBQXBHTnVTYVlCbU83RnZ3dXlId0RiMU1ibFBmS2lm?= =?utf-8?B?VDFzc09QdFlzVlF4TG5CTG1XUVliRGFmOHpoKzJ3Q09ZRjF2L21FaW91eURs?= =?utf-8?B?eWl0SkVXb045K0hQODhzOGFTeDVld3RYNzY3a1N4cklKdGRPWHQza1ZWbThk?= =?utf-8?B?bVA2MTd6YWJMMkt5YkZKQmN5MlFiWGE1cE02ZWdUUDVSVlZsYTAwSGQvT0Fn?= =?utf-8?B?L1IrbG1ETkI0WldnRVd5NWtKSHU2Wlp4NVhsN2Y4WlQxTzBBUXpPU215dHVm?= =?utf-8?B?Z0ZyTEJKVTZycm1MWGtENlNOL1dCNnRTVWdxWk9hNk5Lc3NuSXdqQm5VUitO?= =?utf-8?B?ZU9SeDBnYnRUamFrZS8yUVFsSTB4N2U4SWNudXZ3R1dCTUdGeTgydWluWktm?= =?utf-8?B?YWNoTHRCVWZORmM4ZVNXb0tKWm9CdkJZMGtYdER2V210T2JsVEMxYTBWOTFo?= =?utf-8?B?bElYbjdlVEJVODJmOW1mQVZweFJ4cVVGY2RLRStpYUd6RVRpMWxMYTNFRWZ3?= =?utf-8?B?RlNpN1ZMQ2lXNGR0S3dnSnoyOFpaVWUxWFpxNW9ZWHM5YkJ4d214QW5ibGh4?= =?utf-8?B?MGhTdHlsejE2RXk1VHlTbWhJQUJicFdZdFNVOWhBZTNZd2RmNEF3U1BsL3g4?= =?utf-8?B?Mm54dkZzVGxUYWZTeENFZ2pvSm9DZ3VlcWdqZVdqUG5PVVlMSmZuV1lwcHc0?= =?utf-8?B?emlPUVNuc0dKalRVTzdNR09VSTdtS3k4TnZYVHI2aTFPSXIrZHNtWDMwWkoz?= =?utf-8?B?L2tBVXR5RnQ1VEV2WERWWmZBZGV0MEx6a3RGSXZaVFJWWlpQYWxNdkFDY29P?= =?utf-8?B?b3NCUmVyamRBYkVKejlTbjVodUdJeE5TZW9OclFyR3pJdU9CSno2WjNpZWRl?= =?utf-8?B?VjZHWUtvUGMwNVY3dVBuTkhYYkRKYjRNWUIyZVlMbHRIcEJ4cTh5UkZmQWR4?= =?utf-8?Q?7JzquqHcdp5JLvdSY1TMnBU=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: IVlzyPLhhO8BV3r0z3wUePmV1V4TzXADPyxhjt7ze6LDaqqXNXO3WRmb4Hcyqj6lS+kXueWFLYAT+Fsrwd5ENBScno/4WKNdL5OiuccQAJG0BdoMErqzON+G+HHpGGeGdkbSMauXfsNjpTB5vlMhbv7Srm+50bzewstpmKA7xP2CuFAr/m0ypiH+Mb7mfi1G0ejZ2o8SesZCA7cPgUYOJMbLNXNLlt2aXk+w+CEZZkJ3hyMHYTSNW+Yl6kmWFFC8inYVcwtAolXtvD/aW17jylKouLBzSTW5K1jtmu7k4nfohonCIqPnAFKM7DTG69NyhYZEEgshl5UUqT/y3EFtADneOcOtzTxeYltBtUvjkKU+Mm37/oBm/K4xtEjx9JkNSgi6pKaysWonF57toaFlH+W6qWfRB/zrsM5hGb9Ehh2xeNYVOjCT2aIEZEtjJfrSJLLyS5AVW5w8p78apE357yD1GmMFn3jnBFx4Zs1ydC+3+FY60RCt87zeXrRz4sIa7ksrQw4EVF4ydRsDxow6krXE1B1DPU2E/sJBHAJptIVPbS8OTu1XZXth8bQRnhYc7cxFktlFUjwc5ETENJgpq3hB/vXMKsWFf7jLhlAd7BM= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5887875d-348a-4bc0-96f5-08dc5f7ab7a7 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2024 07:39:45.2621 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 15l0JuhhgKelbvUG+OhiolZU6d5bHcOyXYsgiwFmwvdayN2dNout2egogvc5Ujm9cvDNW1u92+EQdh4J+el1Zw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4273 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-18_06,2024-04-17_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 adultscore=0 mlxlogscore=999 suspectscore=0 bulkscore=0 spamscore=0 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404180053 X-Proofpoint-GUID: hHsRhshJupFg0Azr3tursUbclzJ6Q3Da X-Proofpoint-ORIG-GUID: hHsRhshJupFg0Azr3tursUbclzJ6Q3Da X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/12/24 07:47, Jens Remus wrote: > Explicitly mention "SFrame" in the descriptions for the architecture- > specific SFrame configuration macros, variables, and functions. > > Use the term "frame pointer" (FP) instead of "base pointer". This aligns > with the terminology used in the SFrame specification. Additionally it > helps not to confuse "base-pointer register" with the term "BASE_REG" > used in the specification to denote either the SP or FP register. > > Specify what the SFRAME_CFA_*_REG register numbers are used for: > - SP (stack pointer): CFA tracking > - FP (frame pointer): CFA and FP tracking > - RA (return address): RA tracking > > Align the descriptions for definitions in the source files to the > declarations in the header files. > > gas/ > * config/tc-aarch64.h: Enhance architecture-specific SFrame > configuration descriptions. > * config/tc-aarch64.c: Likewise. > * config/tc-i386.h: Likewise. > * config/tc-i386.c: Likewise. > > Signed-off-by: Jens Remus > --- > > Notes (jremus): > Changes v2 -> v3: > - Add "SFrame" to architecture-specific SFrame macro, variable, and > function descriptions as suggested by Indu. Do so for all and not > only those previously touched. > - Reword further SFrame macro, variable, and function descriptions > to align with those previously touched. > - Align description of definition in source with declaration in header. > - Corrected formatting of ChangeLog in commit message. > - Changed commit subject prefix from "sframe" to "gas". > > gas/config/tc-aarch64.c | 6 +++--- > gas/config/tc-aarch64.h | 12 ++++++------ > gas/config/tc-i386.c | 5 +++++ > gas/config/tc-i386.h | 10 +++++----- > 4 files changed, 19 insertions(+), 14 deletions(-) > > diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c > index 6ad4fae8b0ec..077cbd485979 100644 > --- a/gas/config/tc-aarch64.c > +++ b/gas/config/tc-aarch64.c > @@ -8870,7 +8870,7 @@ aarch64_support_sframe_p (void) > return (aarch64_abi == AARCH64_ABI_LP64); > } > > -/* Specify if RA tracking is needed. */ > +/* Whether SFrame return-address tracking is needed. */ > Nit. But then given the nature of this commit: I see that this commit uses both "return-address" and "return address" keywords. Also, the code already was already using "stack-pointer" and "frame-pointer" (my bad), lets use the same style, and use - "frame pointer" - "stack pointer" - "return address" OK with that change. Thanks for your patch. > bool > aarch64_sframe_ra_tracking_p (void) > @@ -8878,8 +8878,8 @@ aarch64_sframe_ra_tracking_p (void) > return true; > } > > -/* Specify the fixed offset to recover RA from CFA. > - (useful only when RA tracking is not needed). */ > +/* The fixed offset from CFA for SFrame to recover the return address. > + (useful only when SFrame RA tracking is not needed). */ > > offsetT > aarch64_sframe_cfa_ra_offset (void) > diff --git a/gas/config/tc-aarch64.h b/gas/config/tc-aarch64.h > index 1b8badad9fdc..63acbd46a379 100644 > --- a/gas/config/tc-aarch64.h > +++ b/gas/config/tc-aarch64.h > @@ -267,24 +267,24 @@ extern void aarch64_after_parse_args (void); > extern bool aarch64_support_sframe_p (void); > #define support_sframe_p aarch64_support_sframe_p > > -/* The stack-pointer register number for SFrame stack trace info. */ > +/* The stack-pointer DWARF register number for SFrame CFA tracking. */ > extern unsigned int aarch64_sframe_cfa_sp_reg; > #define SFRAME_CFA_SP_REG aarch64_sframe_cfa_sp_reg > > -/* The base-pointer register number for CFA stack trace info. */ > +/* The frame-pointer DWARF register number for SFrame CFA and FP tracking. */ > extern unsigned int aarch64_sframe_cfa_fp_reg; > #define SFRAME_CFA_FP_REG aarch64_sframe_cfa_fp_reg > > -/* The return address register number for CFA stack trace info. */ > +/* The return-address DWARF register number for SFrame RA tracking. */ > extern unsigned int aarch64_sframe_cfa_ra_reg; > #define SFRAME_CFA_RA_REG aarch64_sframe_cfa_ra_reg > > -/* Specify if RA tracking is needed. */ > +/* Whether SFrame return-address tracking is needed. */ > extern bool aarch64_sframe_ra_tracking_p (void); > #define sframe_ra_tracking_p aarch64_sframe_ra_tracking_p > > -/* Specify the fixed offset to recover RA from CFA. > - (useful only when RA tracking is not needed). */ > +/* The fixed offset from CFA for SFrame to recover the return address. > + (useful only when SFrame RA tracking is not needed). */ > extern offsetT aarch64_sframe_cfa_ra_offset (void); > #define sframe_cfa_ra_offset aarch64_sframe_cfa_ra_offset > > diff --git a/gas/config/tc-i386.c b/gas/config/tc-i386.c > index cd20e0c9415e..08a8eb2aeb69 100644 > --- a/gas/config/tc-i386.c > +++ b/gas/config/tc-i386.c > @@ -11181,6 +11181,7 @@ x86_cleanup (void) > subseg_set (seg, subseg); > } > > +/* Whether SFrame stack trace info is supported. */ > bool > x86_support_sframe_p (void) > { > @@ -11188,6 +11189,7 @@ x86_support_sframe_p (void) > return (x86_elf_abi == X86_64_ABI); > } > > +/* Whether SFrame return-address tracking is needed. */ > bool > x86_sframe_ra_tracking_p (void) > { > @@ -11197,6 +11199,8 @@ x86_sframe_ra_tracking_p (void) > return false; > } > > +/* The fixed offset from CFA for SFrame to recover the return address. > + (useful only when SFrame RA tracking is not needed). */ > offsetT > x86_sframe_cfa_ra_offset (void) > { > @@ -11204,6 +11208,7 @@ x86_sframe_cfa_ra_offset (void) > return (offsetT) -8; > } > > +/* The abi/arch indentifier for SFrame. */ > unsigned char > x86_sframe_get_abi_arch (void) > { > diff --git a/gas/config/tc-i386.h b/gas/config/tc-i386.h > index 7aae7a33dc14..e98362111698 100644 > --- a/gas/config/tc-i386.h > +++ b/gas/config/tc-i386.h > @@ -441,20 +441,20 @@ extern bool x86_scfi_callee_saved_p (uint32_t dw2reg_num); > extern bool x86_support_sframe_p (void); > #define support_sframe_p x86_support_sframe_p > > -/* The stack-pointer register number for SFrame stack trace info. */ > +/* The stack-pointer DWARF register number for SFrame CFA tracking. */ > extern unsigned int x86_sframe_cfa_sp_reg; > #define SFRAME_CFA_SP_REG x86_sframe_cfa_sp_reg > > -/* The frame-pointer register number for SFrame stack trace info. */ > +/* The frame-pointer DWARF register number for SFrame CFA and FP tracking. */ > extern unsigned int x86_sframe_cfa_fp_reg; > #define SFRAME_CFA_FP_REG x86_sframe_cfa_fp_reg > > -/* Specify if RA tracking is needed. */ > +/* Whether SFrame return-address tracking is needed. */ > extern bool x86_sframe_ra_tracking_p (void); > #define sframe_ra_tracking_p x86_sframe_ra_tracking_p > > -/* Specify the fixed offset to recover RA from CFA. > - (useful only when RA tracking is not needed). */ > +/* The fixed offset from CFA for SFrame to recover the return address. > + (useful only when SFrame RA tracking is not needed). */ > extern offsetT x86_sframe_cfa_ra_offset (void); > #define sframe_cfa_ra_offset x86_sframe_cfa_ra_offset >