From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2084.outbound.protection.outlook.com [40.107.22.84]) by sourceware.org (Postfix) with ESMTPS id 70BF53858C41 for ; Fri, 7 Jul 2023 13:47:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 70BF53858C41 Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UdRc8GjHQFIzHUktDHbP2iNzxD+hUB7DrXMkahPDGewKmM+OkGDi+HjXHVuJUyJSjXOZ40HiBOhr22zKyi2z1Oi2qJalVMaMhgF1Bqv51RiLgtpy8Dcs22zFgWUJH5YDrwL1SM6yHnWqXBB7JpAQ9J11Upmp4FTOCJivJIW0KwkvdFsk/8kM6JUbqoYRFaoRQzvYTuP7ta2HAg34GJrzdEh2POnrjT7LvkmyV5IUDpzkB+mlUmU57s9pesTUeE3hhtAJ6ZnO0Ze7PbIuvxG9GSaSqSUHtNSAUifNY1Oi96LkHP+tnCovg8uOGR3OFqLPYa93NsmdVZomb5vtkoAa4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r664fwlTtEkioypSaa3IJ1UvEkpWzWwUIX+VF72ayEc=; b=Xw0dVPBKsdG/ksioHF1eFq0dwDNgWo3Kf6pX2L9+4+tHp7THX/Qvmib+fDgaObp2R9hsoYqJkkFzFU9/v4f6xH3ZSa3TTLZ1DU119WIv0zpHoDP8QqUps+3MINyUNbPmeeFgvFtxUxj2oOB6Zqe2kKNca9qM1VrYjfHW+ReomyourUknA/lm++Kr0F+5TRVJ+9zo8Yhg+iOFIiU24j8OVs8zbrHGjKCK8g3hRSCl4sFMmVUN5juCCDBb8ZrSi1+99HdojqgxKYLAD8b7eiw5V3G0mS48x8vAySeO4q5kTmLgsyAU0e6vlqziRH9rC/cminur0lDGVgLCN/hn7Y+XwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r664fwlTtEkioypSaa3IJ1UvEkpWzWwUIX+VF72ayEc=; b=fxhmGDPyKA3IULQsXasvgiRWCj+HMDHW4x0k1OZdUkdjGyWGmF7LrCrdAQ9Gqp+85m5KJeZdajFZYyay1F9bkKcboakwQsHxnBYtLQs3PHl8QnZNOqeEz6F+LB6I6hKULMXCKlmGMjUwZVVp1v5KFfN0X3KM8i6h4DNVQuK88csaXoVv5wx/ld6kKtAqJmOueW+z473e9HrRIQfwbmOgPD/XF9ahADwHSGsPlZkKNNYowH6PmTKrGB5hPquxSB9KmAqsPloF7Ep9NIWw9c+HdYkW4cCcNK3n90RjepJIGLd4kBnDvHl94yvNeIBwD35qI4oziDU+fejuRcmvcRSi5w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from AS8PR04MB8788.eurprd04.prod.outlook.com (2603:10a6:20b:42f::21) by AM8PR04MB7988.eurprd04.prod.outlook.com (2603:10a6:20b:24e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.25; Fri, 7 Jul 2023 13:47:38 +0000 Received: from AS8PR04MB8788.eurprd04.prod.outlook.com ([fe80::cbc0:69aa:c9a2:198e]) by AS8PR04MB8788.eurprd04.prod.outlook.com ([fe80::cbc0:69aa:c9a2:198e%7]) with mapi id 15.20.6565.016; Fri, 7 Jul 2023 13:47:38 +0000 Message-ID: <88c2fb96-185d-ae27-c025-ed025ed54641@suse.com> Date: Fri, 7 Jul 2023 15:47:35 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: Binutils Cc: Mark Harmstone , Nick Clifton From: Jan Beulich Subject: [PATCH] ld/PDB: fix off-by-1 in add_globals_ref() Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0012.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::17) To AS8PR04MB8788.eurprd04.prod.outlook.com (2603:10a6:20b:42f::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8788:EE_|AM8PR04MB7988:EE_ X-MS-Office365-Filtering-Correlation-Id: 31a76ffb-1f24-4693-beef-08db7ef0b9e0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xw6AhOOEqrLMcvfYb/VDOPamYqaNrtHpo10Q4ZlZM9bnZPnvhC0tIY3yG8P9SIxd7N/k6ANk0cyPfYf5GsWwuzomoG0XMLkPQFXPsAyHchtm+vS2QODstnjLDVECYdsh+kOwhFfrW/S7UxaMw5fGc66bDMl9i8p07pTpQTFmjsZBCrLMMvWWBzTolrptCsHYfQpOlwvqcbxBQ1A1ZluTpq0rDfHzGQu5YKQwq3TfaCCIge0RSxolsOBEZ5rKO1iRYYGgSoxIsqAf5sfbZ0JjmXsJ6UaZfbIAwTxoNKLflq2V1snMF9e9EOGA7+90O5U8e4SU62Vpu1l3nyLCOSi/j3YnfWUcZLBdV0JRtJA5yg2qTE18A2VgL5DT5pGStUc3suR3/wkcAES/h/BSe7SJjSO/c7TuVZWO+f/7y/ISnl21jLo7jBnRORvRBdwGfIcBx9hnfFafBP1LHewHuOJhVKod2pR5ytLSQuzqjPI1W2DzA/NGguTJO44/N2VMV8A/fyJ3G0M7G/eWGMn/Bu65EwUN8/wWUO1d9JMF8cJ/2YrfVnqP/d75KLaYYfD5T6MkjNpkuoeQFuj5IW+r8KZlZ+9IvNsyHGVdsrWgmJLvhnmy5GtTDsIdx+EuCcbFD4uiISF1Levtb5En4warK/nWyQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8788.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(366004)(396003)(39860400002)(346002)(136003)(451199021)(2906002)(38100700002)(6512007)(83380400001)(2616005)(186003)(26005)(6506007)(31696002)(5660300002)(86362001)(8676002)(36756003)(4744005)(54906003)(6486002)(6666004)(478600001)(316002)(41300700001)(8936002)(66556008)(66476007)(66946007)(4326008)(6916009)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M0szUDNGL3kvdXBKY1BZek5iT2c3dUNDbW5Nc3QyT25ZTUpjV2tHNE9Tcll3?= =?utf-8?B?b3o4azduK1UyelBpckhOKzdHTXdjeG10TlFJRit6dXN1MkowaUx2MkhhejZs?= =?utf-8?B?MldyWEVrMmRva2xXMkVaVzN5WDIzRzNPdWNHVTRJQ0dPS1pya0hRaFRSRkJu?= =?utf-8?B?NE1mUmZuQ3YxTlpCTkt3R09NYXRDUjRwalRhMFlhQjJ3WGlvMVJKRm1CMGVp?= =?utf-8?B?RnQzUHgrZnlWbWEyUXdod1RFa0lHUUpOK21ldWlrWGhQT0NOQ1ZWV1FoZFZq?= =?utf-8?B?Z204TURBQlgzU0hORTZYd0ZEOG5QY3lIU0dsZ2I2OXRMMitOVzlzMzJ4eSt1?= =?utf-8?B?VWcvSmdPOW82cjc4SUZCTW9VVGtLQldwRXVGV3VUS1VTa0x3dVJFYjcyUzB1?= =?utf-8?B?RlAvOTdwUFVweE93ZWdvQlplbEYxSDNUM09EZmZkdEVISStWL0pUVDJuWms3?= =?utf-8?B?aW42d08wcTg1L0lLRHg3VW5lV3J1ZDFuNlJHa2tkdnlvV085MGhseGdKanVk?= =?utf-8?B?MHB5SHo4ZnkrTjdaWk5uSzh6RVNvUWZYeEYvNmtOZGZ0UzlOZ0laSkUvaUMx?= =?utf-8?B?ZllvZjE5OSs5T2dHNUIxWTRyM1BFTHZrV3JsWmd4UEUrNDVyaXFhdGIwdTMr?= =?utf-8?B?QTdzV1FpR3cwbDVzUW1oS2V1RTAvRFdFaHZpOTh3SjlLckh0R2dqc1ZGQnNx?= =?utf-8?B?VytuVVRUYTllZlZvdTNVZ21aRkhmRm9RS011Wm1KS0lmTCtRTk9HazErRHh2?= =?utf-8?B?M2wwbis5ek0xSHR1dHc2QVY3WGtVRzIrNldiWU5NZktpRXFpQm9VbnN6NjJ4?= =?utf-8?B?akJHZEhjSnpyQ1d0YXQya1BrTW5tRHVQT3k2OEE1aGdpQjNvS2NEY3BxUTV6?= =?utf-8?B?RStVZUFTZFpjdmx4QlQ2UHVPWUdCQmhtRjl0L1FlbUFaeW5CSzF2TjVRanZQ?= =?utf-8?B?YVBsS3ZvS0RGQ3M2MVJPWW8zL3pZUUlLeEdFbHVJNGZaTElUMkFLVUNML0lK?= =?utf-8?B?Y01yV3NNSGkxZGVuQlRWeDZFT2MyelkxM3VXQkwwOUlMTGdDcHJWckhkbG9w?= =?utf-8?B?aW9yZm9ydEdsME9qT2lDZi84SjRMVlAxMG01a0Z5cFUvOVNQQ0lEaGtYcUV0?= =?utf-8?B?ZjJycWhyKzZ4a0NpdWZQZ2lyTlA0N2Z4K2M4a1RENkZvbEFLZUZUWXBhdmw4?= =?utf-8?B?T2EwaHhUNDN5Z1ZyS1pOYkErcEtrWHN4MFFIcXNpM3lBMXBVZkxTY2RqbXdN?= =?utf-8?B?MmJWdElSTjVvcUpnRE5VKzM2Q2M3UmpjcXBUNFFMUEZua3UrT0NTeGd0QVFE?= =?utf-8?B?cGZQS1U5d3pkWk1CN2xlK0tmR2RiODFqb1pqMXVobHRIeW9mRW9TWlB5MUEz?= =?utf-8?B?SldYV0hBR210OTRWS0RqT0lWQW45aDlpRXg0bzVDcVhibGFocDAvRXcvdlVI?= =?utf-8?B?RUppblEyTTBkMFFqRDBpUis1QjRWZWZpK2NNc1Vma1R2bExYeXpCYVFjbHhR?= =?utf-8?B?VTZ1eXVydVhVN2FtWEtWSk9xSzdZLysrWkRJV3FOMjcybUZYeE9rR1VQOTU4?= =?utf-8?B?aFdMMFp0UUVPZFo0TzRsZ0t2a3pVVzIrdWwyRkxHblRFRFNmZTNDTDdVMU0w?= =?utf-8?B?Z3ZXTFRVZWliVWNkc2VsWGZEQlBHd2NqclRSbEVDSXVMcy9KS0RoemFUaldx?= =?utf-8?B?V1lNVDRLWklzbi9rdzdWZE9yWDk1NG1TWnduL0Y0dlRDNzQrQWNWM3IySzVI?= =?utf-8?B?ZWRWVnNtOVlBdnowMFJIZExRMHJCQU5qcjBVNFQ1OWRQTDY2c2lpcVJmTGFu?= =?utf-8?B?SGM0SG8yMFZhdDVYY3FBaGYxanFXNE1VYkJDNnFMUnNQY3lQcjQxdjdMblJ4?= =?utf-8?B?QTdRQWRyZjJpcUxWcHUrRW9NdkdvbUVNd1ZrbnAzUGl4RExIVTl1bWN4ZEN5?= =?utf-8?B?aFlBSDY1aFJTZHlQcFFZZFY3Q3NmTG5QRktvMWRMVkpWSWl3aUkySmxCTngz?= =?utf-8?B?MUZLUnRibFRISlZnRWxXbEV0WndsdEc1S1FncjlwcG91WVpjWmpmOHJxbzZD?= =?utf-8?B?M092ZHNuVnAxMklrcnZtMG1oYnhBQzFzZnZNQnBEMmVZWkg1ZGxLa0QxQlNJ?= =?utf-8?Q?Ck3AcUuVGnuygNK5ydsTEKu7n?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 31a76ffb-1f24-4693-beef-08db7ef0b9e0 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8788.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2023 13:47:38.0015 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GArXy+xlSDlsgbFR2njOLvMiIUdGRO8NZ2vd20/wGYLgh/vHJxTozt3SiSbvbBv6zmn+x2Njvplh54GAFTONAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7988 X-Spam-Status: No, score=-3026.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Copying one too many bytes can corrupt memory, detected and reported by glibc on a 32-bit distro. --- Nick, again I expect this wants to go on the branch as well. I'm sorry that I didn't get to look into this earlier; I had noticed it a while ago already. In any event I'd like to give Mark a little bit of time to reply (if necessary), before putting it in. --- a/ld/pdb.c +++ b/ld/pdb.c @@ -880,7 +880,7 @@ add_globals_ref (struct globals *glob, b g->offset = bfd_tell (sym_rec_stream); g->hash = hash; g->refcount = 1; - memcpy (g->data, data, len + 1); + memcpy (g->data, data, len); glob->num_entries++;