From: WANG Xuerui <i.swmail@xen0n.name>
To: mengqinggang <mengqinggang@loongson.cn>, binutils@sourceware.org
Cc: xuchenghua@loongson.cn, chenglulu@loongson.cn,
liuzhensong@loongson.cn, xry111@xry111.site, i.swmail@xen0n.name,
maskray@google.com
Subject: Re: [PATCH v1 1/6] LoongArch: Fix ld --no-relax bug
Date: Thu, 16 Nov 2023 15:34:03 +0800 [thread overview]
Message-ID: <88c34da3-2457-4332-a620-437efa4baafc@xen0n.name> (raw)
In-Reply-To: <20231116062307.3292483-2-mengqinggang@loongson.cn>
On 11/16/23 14:23, mengqinggang wrote:
> When ld --no-relax, pcalau12i + ld.d still can be relaxed.
"When calling ld with --no-relax, ..."
Apart from the grammatical fix, is the "pcalau12i + ld.d pair still gets
relaxed" behavior actually intended, or is it the broken behavior that's
being fixed? Looking at the code it's not so evident so it's better to
explain a bit.
> ---
> bfd/elfnn-loongarch.c | 19 ++++++-------------
> 1 file changed, 6 insertions(+), 13 deletions(-)
>
> diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c
> index 18ad3cc91ca..1162cb35cd6 100644
> --- a/bfd/elfnn-loongarch.c
> +++ b/bfd/elfnn-loongarch.c
> @@ -3996,29 +3996,22 @@ loongarch_elf_relax_section (bfd *abfd, asection *sec,
> loongarch_relax_align (abfd, sec, sym_sec, info, rel, symval);
> break;
> case R_LARCH_DELETE:
> - if (info->relax_pass == 1)
> + if (1 == info->relax_pass)
> {
> loongarch_relax_delete_bytes (abfd, sec, rel->r_offset, 4, info);
> rel->r_info = ELFNN_R_INFO (0, R_LARCH_NONE);
> }
> break;
> case R_LARCH_PCALA_HI20:
> - if (info->relax_pass == 0)
> - {
> - if (i + 4 > sec->reloc_count)
> - break;
> - loongarch_relax_pcala_addi (abfd, sec, rel, symval);
> - }
> + if (0 == info->relax_pass && (i + 4) <= sec->reloc_count)
> + loongarch_relax_pcala_addi (abfd, sec, rel, symval);
> break;
> case R_LARCH_GOT_PC_HI20:
> - if (local_got)
> + if (local_got && 0 == info->relax_pass
> + && (i + 4) <= sec->reloc_count)
> {
> - if (i + 4 > sec->reloc_count)
> - break;
> if (loongarch_relax_pcala_ld (abfd, sec, rel))
> - {
> - loongarch_relax_pcala_addi (abfd, sec, rel, symval);
> - }
> + loongarch_relax_pcala_addi (abfd, sec, rel, symval);
> }
> break;
> default:
next prev parent reply other threads:[~2023-11-16 7:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 6:23 [PATCH v1 0/6] Fix some bugs of relaxation mengqinggang
2023-11-16 6:23 ` [PATCH v1 1/6] LoongArch: Fix ld --no-relax bug mengqinggang
2023-11-16 7:34 ` WANG Xuerui [this message]
2023-11-16 6:23 ` [PATCH v1 2/6] LoongArch: Directly delete relaxed instuctions in first relaxation pass mengqinggang
2023-11-16 6:23 ` [PATCH v1 3/6] LoongArch: Multiple relax_trip in one relax_pass mengqinggang
2023-11-16 6:23 ` [PATCH v1 4/6] LoongArch: Remove "elf_seg_map (info->output_bfd) == NULL" relaxation condition mengqinggang
2023-11-16 7:43 ` WANG Xuerui
2023-11-16 9:38 ` mengqinggang
2023-11-16 6:23 ` [PATCH v1 5/6] LoongArch: Modify link_info.relax_pass from 3 to 2 mengqinggang
2023-11-16 6:23 ` [PATCH v1 6/6] LoongArch: Add more relaxation testcases mengqinggang
2023-11-16 6:39 ` Fangrui Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88c34da3-2457-4332-a620-437efa4baafc@xen0n.name \
--to=i.swmail@xen0n.name \
--cc=binutils@sourceware.org \
--cc=chenglulu@loongson.cn \
--cc=liuzhensong@loongson.cn \
--cc=maskray@google.com \
--cc=mengqinggang@loongson.cn \
--cc=xry111@xry111.site \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).