From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 7DC27386001F for ; Mon, 31 Jan 2022 16:31:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7DC27386001F Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-269-oJy7vL7HNxqr3PTL18VOMQ-1; Mon, 31 Jan 2022 11:31:50 -0500 X-MC-Unique: oJy7vL7HNxqr3PTL18VOMQ-1 Received: by mail-wr1-f70.google.com with SMTP id e15-20020adf9bcf000000b001de055937d4so4989443wrc.13 for ; Mon, 31 Jan 2022 08:31:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=+HDVZvSVMbOcnJBdBnAATUwd/0OCv3pK8t1gCUJH+aA=; b=QE8S1y3zuA2evnUNmVTXiZV6E7ARh8XLRoE9IRaIYo1R4Y0WkCgi2Ldei44GFx6MO0 yi0GB64a9ay9+uKZDTwPjvf3GkXmwYcCCQbxaHpYFM3knpZgzcl+/hc7riOzQXAf7ueM g74Mr31N84K9iXCD0MCZTBehOAPsLxWbP7J2IRO7hWvx6eS7tZdmnUxbo/jb9mL7uw8Q +CnlkSgKvrfSYavXq6VW4s6XYprpEoyI/fC8jQFl2pbkFg+STNCXKruI4VCFC80tPh6B sNSx5i8Tj2auiGNBil9E9Ps4t3xl+9hJP2MgbWnzhyfQ8/6hJqgNG7iNxmHZKNOnMzdI Y9NA== X-Gm-Message-State: AOAM532EZvIWGR8YJAtlbkEpwGXbuFmeqVa8bXDGmvNsBVF0RPnb5z0n XaubemvGKskJuSdNezfyU79XBa51GicmapbWzefnRu4zPwopC47iYA4H3veaaI4Q6JUffKo3ioa Afp7dYjLzhoFqLbUFaA== X-Received: by 2002:a05:600c:34d2:: with SMTP id d18mr19589561wmq.88.1643646709765; Mon, 31 Jan 2022 08:31:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJxlCiCKu/w0LaEqMVJh0LiamkbvqT/vAkCojzYPJxfz4tMiP7kEkUQR7BotmOOADLxQmV0J7g== X-Received: by 2002:a05:600c:34d2:: with SMTP id d18mr19589545wmq.88.1643646709593; Mon, 31 Jan 2022 08:31:49 -0800 (PST) Received: from [192.168.1.6] (adsl-164-239.freeuk.com. [80.168.164.239]) by smtp.gmail.com with ESMTPSA id p8sm13330469wrr.16.2022.01.31.08.31.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Jan 2022 08:31:49 -0800 (PST) Message-ID: <89206169-2af6-b7db-b0da-84c0c29112c2@redhat.com> Date: Mon, 31 Jan 2022 16:31:48 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] Load debug section only when dumping debug sections To: "H.J. Lu" , binutils@sourceware.org References: <20220130200435.1634559-1-hjl.tools@gmail.com> From: Nick Clifton In-Reply-To: <20220130200435.1634559-1-hjl.tools@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jan 2022 16:31:59 -0000 Hi H.J. > Don't load debug sections if we aren't dumping any debug sections. > > PR binutils/28843 > * objdump.c (dump_any_debugging): New. > (load_debug_section): Return false if dump_any_debugging isn't > set. > (main): Set dump_any_debugging when dumping any debug sections. > * readelf (dump_any_debugging): New. > (parse_args): Set dump_any_debugging when dumping any debug > sections. > (load_debug_section): Return false if dump_any_debugging isn't > set. Approved - please apply. Cheers Nick