From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 624853858D32 for ; Thu, 25 May 2023 10:24:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 624853858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685010295; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yI7roW0mfWRTL+F7tClWY8d75kvrlV8bslmRq+fxaqI=; b=RPFulJnLPm57B3tsHIdHxaD9oWQX7NIy9rJVdIX6NUSGTauOeHQEfQGk//ayAlrpAqelSH 6pa4CF2VHzFmD0hJ9/J4m13STuzNH3lsNt2AlF2Us0p/uQBfhbcJoCJm54O9WTKEi9fDhJ ab/TSEZqaNHGfZxAPu4cWz+TtnAEp6A= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-299-4BIl8_mqPkGvhmnGw2Y05A-1; Thu, 25 May 2023 06:24:53 -0400 X-MC-Unique: 4BIl8_mqPkGvhmnGw2Y05A-1 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-3f52eb10869so15779641cf.3 for ; Thu, 25 May 2023 03:24:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685010293; x=1687602293; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yI7roW0mfWRTL+F7tClWY8d75kvrlV8bslmRq+fxaqI=; b=dTBSCGyTfN/2acGPMqAR10KOluoC1i+KPEsMPEG29NlArSIrj4lqes6F8ragTyMsVa giXUKXL0bu/k0GteUpYOk935AAwPVDcDpGlkzYcrWKO8Tw2Q+o/6PMVNRMSIf+APHZNg DCIXKbDuYV00qoVHESBrLN4JTM+h8rOwOf+b74Rj/RKTgrBmlk0l42ZpYjZcPCp4Ycif tV35KnE3whjXLLWQrghcmIjhdYVH7MCSmneyAnr2IvpSC2fOpQyCAV+KsNBK0OnQ4r+m GqtQFf4VjAt3TZBmJDOC0brQtL509K78ASJzEIt0DxP6foqCJ5ydCWkswiptlpPyVc3d Afug== X-Gm-Message-State: AC+VfDyzBUr6WHvPrR92AwI+Hc1plsFiRnF+aNQ+W64z7Ex8su2923bi ZVNcKA8F0cQ/VX+u+On8dd6061ppQqozcDYBVcC9WVoEnaLCn+DySRYD+eP4lZ0BVfMunfUzZFP YXrZfkNJIxRxAWV0N/Q== X-Received: by 2002:a05:622a:190e:b0:3f8:229:7a21 with SMTP id w14-20020a05622a190e00b003f802297a21mr273463qtc.4.1685010293501; Thu, 25 May 2023 03:24:53 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5WWchNAhrCOtMgJ+2LEJiRhbSwMxNMu7izljbNQhyOeOQ+fJx1Qlt/y2Wj02owupqbdf1i2g== X-Received: by 2002:a05:622a:190e:b0:3f8:229:7a21 with SMTP id w14-20020a05622a190e00b003f802297a21mr273454qtc.4.1685010293264; Thu, 25 May 2023 03:24:53 -0700 (PDT) Received: from [192.168.1.7] ([80.168.198.238]) by smtp.gmail.com with ESMTPSA id r6-20020ac85e86000000b003f018e18c35sm296437qtx.27.2023.05.25.03.24.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 May 2023 03:24:52 -0700 (PDT) Message-ID: <89293134-2df0-1c6c-c0b1-a6bf3f904fc3@redhat.com> Date: Thu, 25 May 2023 11:24:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2] pe/coff - add support for base64 encoded long section names To: Tristan Gingold , Jan Beulich , Tristan Gingold via Binutils Cc: "Jose E. Marchesi" References: <871qj7wgn5.fsf@oracle.com> <16e8afe2-80cd-b87e-35f5-8eb8daa8239a@free.fr> From: Nick Clifton In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,BODY_8BITS,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Tristan, > 2023-05-24  Tristan Gingold  > >     PR 30444 >     * coffcode.h (coff_write_object_contents): Handle base64 encoding >     on PE.  Also check for too large string table. >     * coffgen.c (extract_long_section_name): New function extracted >     from ... >     (make_a_section_from_file): ... here.  Add support for base64 >     long section names. >     (decode_base64): New function. This patch looks good to me, so "approved - please apply". I suspect that the issue of NUL padded base64 values might come up in the future, but if it does, it will have to be with a valid test case and then we can properly determine what to do. Cheers Nick