From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2071.outbound.protection.outlook.com [40.107.20.71]) by sourceware.org (Postfix) with ESMTPS id 5AEA73858002 for ; Fri, 10 Mar 2023 09:27:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5AEA73858002 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LZSbwlmGcE5binAZAZyJ7+ZbONroMvEizq6mzLwg3TfWRbPhD1U24YWwpnDy3DaW3ozf71qH9kYdEYh1HqXudFo+kkgoHO6OdHKzjjtvgWvinJyc2aya8OR94s7YdId1sRsID5iU1/gIqDZyfHUxZ5VvpojIYQFdUOXE4zHoToDqIGdIGAQe73inhOsHCqu7XasbiFN5tGb6VoY1r7jsHxLytCLDk2S7hjr5rcjuBA6kQS9ITgEOwWZ8syW7OmAwv75VsTlICbuueKI6m4r7/+C1bZTcMxj2G+lq1KPx1yynu9u+oPId0yoAEtWF0RaTp6YnkVwBfqIvvnIyuvZPsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BIB725LlYOkZ3qCJi3o5WZr1x6hVlG2TJadW97ORhO8=; b=U2+VY/XDWffK67AmlcTRRCfrPWMjidl+Vh1soN64ZnT/6yXQ8FtLXWjf6Q1Tt2oWxmAxNDFDmERVaAaSKTCdSGAto9mO185Qa2BQBXpogwuMtaFpD8JTRYgUzqqPSSbzgt4+thtIxbENQOVJhF6ACP3MclsMfCs1EdnHV1tJ5XUmvMRylFDi+YZMyKez3dUakWJdcpEyMuVFHfU8YWoK3rNcjdtTm/PUnaECBpIuuGhy8YXYocbuak6bVPjVjkC3RPXI99FF85nvjTQjPtp2OZrLePDwUKRoD4OONn59VOiI4soHtSrT/Q7lPLYL/JyVel70kTw91X+7ofzaJJo4Bw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BIB725LlYOkZ3qCJi3o5WZr1x6hVlG2TJadW97ORhO8=; b=OewBra4uFRxZPx+0Vp9lqz3GwdQ0IQLmoqMfjgv/jR1ybGwpzK6mPzTF0zpdzKGU9U9CkpztqJSuFKPGVLiS135zpOKsGOuunfNVBioiYlqZQTguGsB8Ik3+b/nDV1OCbIAMdnKp6/j3DxRDNe+UMQeGeMX6bGktQg9EzKGZ5pw6imxXQalSNex2TGmVzk1iQgpSQZw0Qy5PzwhbGXTiq8GXvzD3V7U4FU/jMuWHNdw14/RdoKz8Bk/CdcEptG0Pj8f3PSmUnYJbXu1ByeWPP6SaeEKbg/qVocDekX+p7iFlBG1ucTD+Qf1BREuCrJVbIXa23arWXkn0ZNj5PjRzwA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9464.eurprd04.prod.outlook.com (2603:10a6:102:2ac::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.19; Fri, 10 Mar 2023 09:27:28 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%5]) with mapi id 15.20.6178.019; Fri, 10 Mar 2023 09:27:28 +0000 Message-ID: <89f892c8-e378-b81c-7b13-322a7876a252@suse.com> Date: Fri, 10 Mar 2023 10:27:26 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: [PATCH v2 5/7] RISC-V: relax post-relocation-operator separator expectation Content-Language: en-US To: Binutils Cc: Palmer Dabbelt , Andrew Waterman , Jim Wilson , Nelson Chu References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0162.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB9464:EE_ X-MS-Office365-Filtering-Correlation-Id: bd1318b3-95d5-4678-434b-08db2149aab1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zwcfXW5ZCgaQoY8bcsdR/nFfWx+8Weso3lpD2vKX3/Vibp8PO63dAS+2lAwDKr4dimFTZmhtUCCDfkg5uIovcYE8HEb/djDaaJKPRX9gI3R9aZpIbTo+IVuF2ZwTXVHc73KxltXhRITmdbcYncT+8RTmMv3S5zAxkWhwAqTdnaIHX6sN0anE23kmcQoBgvjRGaGDtSI88t9HHUp8Tpn+BrT31HpnLFjdg430mE5tUxbTR2KJQlHYNiNxvbSqxcS6eUYGjn/0hFV7Uqqq/09iUUo49utPhtaoTzFw71K+OInzj1AAKNUTGN3fG2p0lrGRJtIPYHk9xkaAwY40bdrGsbjZq2NmcLATmZpPxmUId6l9LsMd8HHNFLd8eGin7a1GMl+p7nPUSfK5m0qAdtyNKuEKh7eX5zSLNHc4iQFyDm/+YwP54Zhnk8fnBLZSc7EqRODhUQ07K3UKB5ylKx/eyeoEgWJe6PqSg620rNAXxSXuoXIM9sLcmbYwyvoVGQEIHa1BJZyKXfwxyru9uxbXJW1Voh6oeVGjqddrZc5j9vOmpAkiWCZwaqWyXX8x9iSAxAJH98raHQUIe/FOnwvAmgdpp020uCjdHxUwb+O1IQFOB8bAbpA17lh4s7A+9Ws5LdsuEddhx0XfPetq8LK3xnNt9G0iQkaI0mUH7+4DhTcGZSyMtNFBqSarHFAP5x8eh3CHvrJZc5zm5pKhlpGZVwIBWFvcVUpIFmyQr1fezxQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(366004)(39860400002)(396003)(136003)(376002)(451199018)(36756003)(54906003)(478600001)(6486002)(316002)(5660300002)(2906002)(8936002)(66946007)(66476007)(8676002)(66556008)(4326008)(41300700001)(6916009)(31696002)(86362001)(38100700002)(186003)(2616005)(6506007)(26005)(6512007)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RG43NGt2SGZGNmU4OVRjYy90OEZIOHBVMjZtVXdMYm1sbFgxbU9Id3lCcXFk?= =?utf-8?B?SzVZakhaWmc0WFpnU3hYOHBvR0NJV21GSzFjWmxmU0lMMnB6UTd2V2w2dUxZ?= =?utf-8?B?b2E2aXY2VDkrNGI3b0xjYmUvdXcyTHd5aVExbTdVQzRBTEhERDJ1OWVNeXho?= =?utf-8?B?dFRtOEk3VzZxYzJ3blNOZE5hamtsUm1XOERTTkxHa0lpZCs1b0pHMGVRb1Fn?= =?utf-8?B?eHNsUXgvQzNPTkNNcFhCWS85YTlIekxGZzV5UCtvZlJpVlpYaEttaEw2Tkhj?= =?utf-8?B?Z2czSGkyVjdBM0ZiZVNYNTNmQVRHdXhlRDJaMmF6T2dFWWNydUQ2K3RtQm94?= =?utf-8?B?U05rQTNCbTEyeDFpSm9senR4U0owNmFhZ0hCOUduRUZ5T3p2aVl4bnJTbTlH?= =?utf-8?B?aHZsdlk0UVJnbGtTZ09ZTTlOWDl3VHpWRzRkdHNJa1B4NzJhVmtVUGFtM1ha?= =?utf-8?B?Q3J5RzNDUDZBT2piOVJDalJTajYxUjZhNHZPSkNCOHoyQlFXQU9vV3pqeUhF?= =?utf-8?B?N2FVUUdmaGdnUTlOS0xlcnlyOVBsaUNjekZRUFhhcTVLc2wxYmZqSk9IQmVp?= =?utf-8?B?b0xreHl0b1ZOVTdLeHQ3STg3alF2UmlqVEZMNGxkRHIxUkE4SU4zRkNscjlv?= =?utf-8?B?dzFJV3Q0Z05YRzZwbnFFRis3dnZvZXZYaWZJREt0L1ZzTGtYdnFsMlhKajl5?= =?utf-8?B?M013TEhZYjBnRUJQbktHOWdFOGFRNUtzY0l4Q1IySUJ5RW5VSFd1cGY5MU5T?= =?utf-8?B?dVVkMTdGemNuM05mK2g4YVpUcVFsYi9rVU5nU1pTaWsyUEN1SFpvbFN3a3RD?= =?utf-8?B?dEN4WWV6c1NKS2IxWE9KUmF2dWRJbmZUdFJwMHNXZmx0RWJ4d3h0bjcyUytk?= =?utf-8?B?Q1R5MFRXUUhsM2pSWkQ0VDIwMXRpWG9mdElJT3NBR1lLSkRuT3JtNzRLbjI5?= =?utf-8?B?ejhqWmg4dXJCbms5K2d6SjZRbGpKOTdHeVlmSkhFU2JLdUhObE13d3N5eXdy?= =?utf-8?B?cTQ2VllHT2VuZGRXdFM1OGt1VDRKVGduRjBXbzB5QlRDK3ViOFBpR2RGakpr?= =?utf-8?B?T2tHRWNkdVhvMEZtc1BYMU9YRnY3NFBKSS82Q3VXN1VoRlIvSEJQNlpqZ2JR?= =?utf-8?B?YTJPVlc0YXJJOUlFSFFkRnFlZnFLMTdYNGVubjZEY0p5cHRIdmVtaG1UUXAr?= =?utf-8?B?d0xQK2lVYXBtcWtxbE0zSzZRdEwwN1NWVTZpcDFtclVNdjhDcnh5M3BNT3E5?= =?utf-8?B?UGloUVpnMTBQMmI4dlVDRXFrZTRZekFNY05iblRDdXloM2JsYm1QbDd2Z29z?= =?utf-8?B?NkZwN2pnOXlBelZIbFVDd0hyR3lTNTkwSEZwV3JyZHVYaUZFNjN0L2l3Y3Jj?= =?utf-8?B?d2pTYU53TlhIN1VqeDJwSmQ3UGQzdFZIU3RaT1BCZW1xVTJjVzRTS3FoR1hO?= =?utf-8?B?UWZ1NE5iZmk4Ymc0UTlGS2s1QjlEWi9lY3BlNTBPQTJnZXlJUXRuYWxCVHBl?= =?utf-8?B?NnY0YnV1YXRvblFEc3dSZXdnM0l0Y2R2ZmhXY04xTUhBWisxdEZOT1Ztem5W?= =?utf-8?B?K3dPS25Rbys1cTV2R3pMTFlIbjJGY3NjRlpoOUMrUVRRSlRETEJCQ1d6QXN6?= =?utf-8?B?a1hUYmVFMk9UU1dMSHo2Ukl0NmVUOFVVZEFQcFBKR0xoZ2VkWlpaaGRYUXVJ?= =?utf-8?B?L2xmU0l6R2wyTjlBWUM0Q3cvYWpLYTVxb3QvYUNKdGJwYzVkQVpXL2hHRHhs?= =?utf-8?B?ZmxudGl3dk53ZE1DaUVNOXJ5ejBmdWs1MER2ekJPTHdHTXNBNTBDd0kyeXdP?= =?utf-8?B?M3FOMlhYQlRoT3lqeHNtN3NSN0Vyd0xjV0wvdzhtRkVWRkJBV1RoY2htcXY5?= =?utf-8?B?TndXWEE1d2hETDhxSnRWWHRTNnhkWFVTWStPdDdYK2hFUlp4UFVSZzdFVjdj?= =?utf-8?B?MFhmb0luTmltc1E3SVMrV3BqTHIveWFIM1pSdldJaHM0Z3RueFA3cnNtTld6?= =?utf-8?B?bjdnUHgwVlV6dnNvV2ZTUnd5MTk2S1dQak5SUThoUzFDUTFIVFh2R0htcTV4?= =?utf-8?B?b1ozVC9DdmFmWDVlMUluOGh3aWhkS3VsNmRFMmorZGx5ZTJrdWc2b0xOMU9B?= =?utf-8?Q?eQs54QBPmjN08A07hJpc782lA?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bd1318b3-95d5-4678-434b-08db2149aab1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2023 09:27:28.4536 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k/IsENxDCjdk8Wm81FBBriE548X4raiM3U/01PwbUK2/uYn+B9LiQR+xhMKrHeTW28i3XAcLsT7U0P7JIfwxag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9464 X-Spam-Status: No, score=-3028.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: With a blank being okay as a separator, constructs like lui t0, %hi sym lui t0, %hi 0x1000 are accepted. But then it makes little sense to not also accept e.g. lui t0, %hi +sym lui t0, %hi -0x1000 Therefore instead of looking for a blank or opening parenthesis, merely check whether what follows wouldn't continue an identifier. Note that we don't need to also check is_name_ender(), as LEX_END_NAME isn't used for any character. --- v2: New. --- a/gas/config/tc-riscv.c +++ b/gas/config/tc-riscv.c @@ -2184,7 +2184,7 @@ parse_relocation (char **str, bfd_reloc_ { size_t len = 1 + strlen (percent_op->str); - if (!ISSPACE ((*str)[len]) && (*str)[len] != '(') + if (is_part_of_name ((*str)[len])) continue; *str += len; --- a/gas/testsuite/gas/riscv/auipc-parsing.d +++ b/gas/testsuite/gas/riscv/auipc-parsing.d @@ -1,3 +1,3 @@ -#as: +#as: -al #source: auipc-parsing.s #error_output: auipc-parsing.l --- a/gas/testsuite/gas/riscv/auipc-parsing.l +++ b/gas/testsuite/gas/riscv/auipc-parsing.l @@ -3,3 +3,7 @@ .*: Error: illegal operands `lui x10,x11' .*: Error: illegal operands `auipc x12,symbol' .*: Error: illegal operands `lui x13,symbol' +#... + *[0-9]+[ ]+# Accept unary .* + *[0-9]+[ ]+\?\?\?\? 17070000[ ]+auipc x14,%hi \+symbol + *[0-9]+[ ]+\?\?\?\? B7B7CBED[ ]+lui x15,%hi -0x12345678 --- a/gas/testsuite/gas/riscv/auipc-parsing.s +++ b/gas/testsuite/gas/riscv/auipc-parsing.s @@ -4,3 +4,6 @@ # Don't accept a symbol without %hi() for 'u' operands. auipc x12,symbol lui x13,symbol +# Accept unary operators starting the subject expression. + auipc x14,%hi +symbol + lui x15,%hi -0x12345678