From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 0AAB038582BF for ; Fri, 9 Sep 2022 10:55:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0AAB038582BF Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662720917; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ahg96LFaDBNDyDOV8C42KiACeipqxOLpSUmYAP51pKk=; b=B5mZ6FE9OvB/Xp6hUok0VqvcExEreX5Ryddd9G9O10oNcCpWvdWRrVIpr3QYHQjQd9OSXE ezfIiR9i0zZVY0mVmxXptMhKsr+k8hZK3p0WpWjbLMWF/ZAfegmBepTGGPVA1LmR+s+Pjj JhAY0cOhGAWWuyPs+Z2xuo1PfYx/4gc= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-599-QBK7f7mJOC2GTxdQfUN-tg-1; Fri, 09 Sep 2022 06:55:16 -0400 X-MC-Unique: QBK7f7mJOC2GTxdQfUN-tg-1 Received: by mail-wr1-f69.google.com with SMTP id i22-20020adfaad6000000b0022a34fc07caso266189wrc.5 for ; Fri, 09 Sep 2022 03:55:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:from:references:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=Ahg96LFaDBNDyDOV8C42KiACeipqxOLpSUmYAP51pKk=; b=qvtucr+Kg6ilsw+1bAQUcty0fG2r5b1HqqgROzLsXjgu+CcHc33g43EcjqlEyieLnS Zbbn/QeVYSmi4T7BOrRycjVAfncSWZRniD6amMazrZG6tTtoJlUqPIMpJHcj6sDSTWyI xN37xg3+qsmJVH27YtxvmJaRkQs17hypGTglu+1yVETH13/LVl4d2+NmQGB9CxKZ/L9u hYfHNM2cJexbno6e8mneDL0HNwJQZPnYbTVKR+mgG9T8aR5MHpy95JSLzn0RxKNU3M9K vQshDelkCPLMEWbXI2scfTkqhBrBZw4Hch8r1G+0uVkDbO0Yx1O0/rIdc7UV1vRGzkhw G3/Q== X-Gm-Message-State: ACgBeo0njDvXK9YKiGiMMnLITF/T0o9FZ4Z8XUJQ8zuLTT+IJ/17D2FM WPHiCcvHJR8Qf96ijc8S56w+iQqyF1a20DtlRgwLwHd+sdDYgKlRXZOVkyzAfz6GPHXKUhuhM/z 7nuATwR6xPGx6/DMd/g== X-Received: by 2002:a05:600c:3555:b0:3a5:d319:35cd with SMTP id i21-20020a05600c355500b003a5d31935cdmr4947993wmq.161.1662720915248; Fri, 09 Sep 2022 03:55:15 -0700 (PDT) X-Google-Smtp-Source: AA6agR7QJZ1xTKZenFvnz5jWf49RRLfw1ZqLpyp8jGSo8GcTc5l5nZ6SH3GriyEz2etvh9h63ltljw== X-Received: by 2002:a05:600c:3555:b0:3a5:d319:35cd with SMTP id i21-20020a05600c355500b003a5d31935cdmr4947982wmq.161.1662720915069; Fri, 09 Sep 2022 03:55:15 -0700 (PDT) Received: from [192.168.1.6] (adsl-2-solo-172-253.claranet.co.uk. [80.168.172.253]) by smtp.gmail.com with ESMTPSA id z11-20020a7bc7cb000000b003b3401f1e24sm247756wmk.28.2022.09.09.03.55.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Sep 2022 03:55:14 -0700 (PDT) Message-ID: <8a0ed098-8e53-f843-e40d-30e7122447bc@redhat.com> Date: Fri, 9 Sep 2022 11:55:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 To: Mark Harmstone , binutils@sourceware.org, jbeulich@suse.com References: <20220909001423.23938-1-mark@harmstone.com> From: Nick Clifton Subject: Re: [PATCH v2] Add pdb archive target In-Reply-To: <20220909001423.23938-1-mark@harmstone.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Mark, > See https://sourceware.org/pipermail/binutils/2022-July/122019.html for > the original patch. > > Changes from original: > > * Reduced number of targets that pull this in by default Patch approved, but with two caveats, one major, one minor: * Your new tests (thank you for including those) fail for targets which do not support the pdb archive format. For example when I ran the binutils testsuite with a toolchain configured as --target=x86_64-pc-linux-gnu there were three new failures, all of which looked like this: binutils/.libs/ar: tmpdir/test.pdb: invalid bfd target FAIL: pdb archive 1 So please could you add a test for supported targets at the start of the pdb.exp file ? (See the start of dlltool.exp for an example of this). * Please could you update the comments in your C code so that they follow the GNU Coding Standard. Ie: /* Comments start with a capital letter and end with a full stop followed by two spaces. */ Cheers Nick