From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 01870385043F for ; Fri, 7 Jul 2023 08:48:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 01870385043F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688719731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+yy32u1vl+yQ+5eZuGZyMt26xLpzJ8PnNpZ66yiiNFg=; b=QCtacGUs78K0mL9/Ix6vnitJkTvSakPXdxM1IuLB9ZOItTv1g+v4GSb9/cRJJ+NLqw0uuF e33PM/XSQXsZLwjfqmtxdSz9MRicTk2PHvIA49tQAfbb3D84+jj6bYEb55eMKXwtw2+msY 6xTZZY0Zhitk1sREuGJ1VcBfv0YS2ys= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-341-_t9qPjEfNK6GjTPvyLGBaA-1; Fri, 07 Jul 2023 04:48:50 -0400 X-MC-Unique: _t9qPjEfNK6GjTPvyLGBaA-1 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7675581a4afso218318985a.1 for ; Fri, 07 Jul 2023 01:48:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688719729; x=1691311729; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+yy32u1vl+yQ+5eZuGZyMt26xLpzJ8PnNpZ66yiiNFg=; b=jmmO0/ooI9/NdGCjVNz8doxXJ8UYEWJ6humO1t1F0Pu9KHyzhCeDVOjAEsS23/2hQ/ 0uCArxKSssk9W2Fs2fE5AXq9lIOu7cWSJIRKbijLkpdVHVCQSzPHXHMeRi5ckccJQ9IN aPVRRL3V3VT0YT27TXCG3Mv5m6N5w5me8dcF6zO/ZHTjih30L/RiTrcR2yGEO0G+8/wB a5CjE0G2AI8fxcGIcsr/QQLTohYCELdpHAY5x0uq1om8MwUoTpXMus1SOyChq7TcpA/7 tnNn+JvvZYLGRqiukvyk1TnIhG5tmJo0BqfcweMBbQRZcWCeZC9KRM2WSMfkBTQVKSqq nFTQ== X-Gm-Message-State: ABy/qLbajJ9BZomdGZ9UCdSIRrcJ+RyNVhoKHCLolgQkUBKJ2IZTqPeI r/bT5+awGXImck6uYYzju5x4/BEI8JOs/2txSuOJy9tvzClUwgIsXycGyskBXDHcP8dkdNbpusm MvbKGse8r0yh6M7xbyE3YOUCqXQ== X-Received: by 2002:a05:620a:4441:b0:767:159f:eb62 with SMTP id w1-20020a05620a444100b00767159feb62mr5311167qkp.70.1688719729157; Fri, 07 Jul 2023 01:48:49 -0700 (PDT) X-Google-Smtp-Source: APBJJlGcE7W3h9usvV88oYE2HUqkDnMB9jhj8j2DrEHFDzo7Afw/gJlo77dJ8lQoXbyFcb6LcTEuBg== X-Received: by 2002:a05:620a:4441:b0:767:159f:eb62 with SMTP id w1-20020a05620a444100b00767159feb62mr5311159qkp.70.1688719728938; Fri, 07 Jul 2023 01:48:48 -0700 (PDT) Received: from [192.168.1.7] (adsl-2-solo-172-78.claranet.co.uk. [80.168.172.78]) by smtp.gmail.com with ESMTPSA id f13-20020a05620a068d00b007677e20f179sm1652167qkh.7.2023.07.07.01.48.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Jul 2023 01:48:48 -0700 (PDT) Message-ID: <8a29cb25-6a6c-2cea-1eb1-a23c622b67e7@redhat.com> Date: Fri, 7 Jul 2023 09:48:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] ld: Use run_host_cmd_yesno in indirect.exp instead of catch exec To: YunQiang Su , binutils@sourceware.org Cc: amodra@gmail.com References: <20230630060757.2006878-1-yunqiang.su@cipunited.com> From: Nick Clifton In-Reply-To: <20230630060757.2006878-1-yunqiang.su@cipunited.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi YunQiang Su, > Catch "exec $CC_FOR_TARGET" won't use the gas/ld that we just build, > and in fact run_host_cmd_yesno is a better choice for it. > > ld/ChangeLog: > > * testsuite/ld-elf/indirect.exp: use run_host_cmd_yesno > instead of handwrite catch exec $CC_FOR_TARGET. Approved - please apply. Cheers Nick