From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2071.outbound.protection.outlook.com [40.107.104.71]) by sourceware.org (Postfix) with ESMTPS id 9485A3858423 for ; Fri, 24 Nov 2023 07:09:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9485A3858423 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9485A3858423 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.104.71 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700809783; cv=pass; b=E4wggLKJwzzhofFsMD7HafmS/jPZPjE6bP2LCuTZIER4pccZ9OUBj5kbAbwXEJ9Obc99oiQaviClyCyQPO3Lj1fYjOlH+UmKvT8rgnyIkbtELD/TzB4Zsh9NUo0Pxu61t9Dp0grJSRiwzthaPfu9YXSbbsyjdU0gZHxOOXoP5m0= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700809783; c=relaxed/simple; bh=PLx5DMvuKKa+cJpe5GSkW9xDF2x8FcujpxXg+GGFrJo=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=Kn8rScKhrBd2tUeHMPz94lQsDn0XcuLS8N329PXM2D3sI1TkmREu3KSAJ11cMo5JyBH8dCdH7IC6PBn/HnqQ197kf7WSdHCwqn9WFU7pRxdwTq/FI3NrfTfOFO9B+k2r4MHcEpAbyzIF7zl+FbxigF7SFsIcGQ+ZktqezoaimJw= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P0XSW4o7BFzsg2X2CfSsLG71zI7o0ZS1r11nXkx3ikfP78YW3P88v0OmX+Q18AKUpgFMSoHdR6aNvQ3t6eWAH+2kG87k2qjDhd5S7ZgC9l26ybcVNtIJ5BvHAqiJFt03fivJWYPA0BSNOTjkO6A2965qsNrpV77ScZf8LNMlH/8q0osscfo+k+8BRYdP23C9VuihE9Zckww47X9n/wb3FBOLvc2+1unFNn3MMFfxbqbKIkA3STUVb3SqDJsKijESIvrXtV4ssDzsC+etbFPOfHXPa0k4khSPH/NI1hpYxejJ8vgfvxGgiHmEwBTBOe2PN47mqspQaw7qubecOMHcRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pmD6gDNJIfnx4s2l2lGS7ZbrJn9mBN+FSzPLLJCllvQ=; b=PKsOB1zblo7IlcgnX3I7NLUj9IDTrDnzNbmvpaJUiO9Uk0yP9P2aoWymctzNKQcRLliv9VYglGyXd5WZNHCKbB1vbb6FkRWVn746JS0n2ZCYpOJVX+/mW8E2zVZRRirWxk2gfwPbQGKdVFQd3Q6wNCcfFT8o0XPDoQ3vFm29mNQEI4Vodpd84sEGqynqnV+yI6nuRTLrHYVeAY/6Om12Q42PLInaVrwCvFRVbZrQkmVrhBhqGos9BZogh7m0djSGV195aE9cgrVv1IKx0uT5oCaoBLOiQDiCL6S+eJ0G0elys1c9hwzgOfaeWYf9fzB+/Dc+kwxUi0KtC8W17MZOKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pmD6gDNJIfnx4s2l2lGS7ZbrJn9mBN+FSzPLLJCllvQ=; b=TP6rNvIn/2JB2WD6vmiHSagYLiSvAc9l2U9w5ori7Ds/E8vh9Dh831E+Ho2k2NEL7v80Umps9ZzdKnokFvmtwpCQKpK0eM25Jx+DtTHkoUPeWCKSgf111TZpjHylzu1yIxHjc80ZUkBK46aeAilyjBOMi68tLqxw9MG3nbBsGqo54kt/+dPhjPAnVoxVG/hHSbjg1YOy7vb7O6AMcA6MK+UrAGU9+lVG/hdA+UzZ0jqx3VnWDg4vgZJAKcDN0nFrJ6kfCiyan0d0aS7KzE8/1vb9nDvWPjlqPj0WyZp5sbg/WazpsjbJ1XEnCRXc7yWQVeclX7UvYc8r2zN4OA3BUg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM9PR04MB8354.eurprd04.prod.outlook.com (2603:10a6:20b:3b6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.14; Fri, 24 Nov 2023 07:09:39 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44%3]) with mapi id 15.20.7046.012; Fri, 24 Nov 2023 07:09:39 +0000 Message-ID: <8a3b094b-b9d3-4aed-8dda-cb01c6a053d7@suse.com> Date: Fri, 24 Nov 2023 08:09:37 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/9] Make const_1_mode print $1 in AT&T syntax Content-Language: en-US To: "Cui, Lili" , binutils@sourceware.org Cc: hongjiu.lu@intel.com References: <20231124070213.3886483-1-lili.cui@intel.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20231124070213.3886483-1-lili.cui@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR4P281CA0340.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ea::19) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM9PR04MB8354:EE_ X-MS-Office365-Filtering-Correlation-Id: 0fe7c8d2-2d03-4f92-2ee9-08dbecbc52ca X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P4LIGyXoZcw4Tn0Mmkcl0+4k+EPbn5BgNmhLy1T/Un0FbNDFUPka2jmoCLHHaTUuf6t+q6CJh3Udtb6QNk7fAj7rn1sadBOedVpi6df3eLOLSApUPF+0fh+UUptUaj5ToTriges3wGMQKZIw26baXsISHfgaQaCWGUMMUqlZM9E0oja0nntuBU7ZVW57kou/uPoRkFlm1LZW8EnoybYXQXCbjVGtqFwtTGwKw4dKS2VbIETniN5I7DqIg6bI+j9aGEH0ux5EBmQQwG3VoIyhDW0Fi9Z7P4I4Sbu6wTgS5VRjNF9Kw/t9L39bTYIkLmKSsRThB16+DrJjB+Dd7w869NESW4F4C+6OzbkYVNUvvgsJGQNuXpfmxiNahl8JKctWOzMnejQNXPmvCprtqrLDyR3VPXBIx37iHYL7qab2Q+rveh8XrC5izLTNhQCOyD7KgS3w/SuwbWmzSSS1nyO3/uiGxr4DS2iHMJNlBB3DqgyUPcdixKFz/bb29QgCZ1N+mlYnxRSPkn6Xrj1bRtKjbV3yV6HdgRz0QaL24mPefcMZlG1vdM+aMtws3IkHKCZpmLdpdYAWLM+hqvXANiB8nEKbnbc/2jwy426R1En6LptIlRyww8bS2yWk+tIqOz3Su9/i5jXuHiX3NzdNIDCfIg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(39860400002)(136003)(396003)(366004)(376002)(230922051799003)(186009)(64100799003)(1800799012)(451199024)(26005)(83380400001)(6506007)(53546011)(2616005)(6512007)(5660300002)(41300700001)(4744005)(6486002)(2906002)(478600001)(4326008)(316002)(8936002)(8676002)(66476007)(66556008)(66946007)(86362001)(31696002)(36756003)(38100700002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d0NzN2tDaENibjIxU2MxZWp6WkRCV3R4ays5cE52Z1N2aVV1T2ZXbzZoaTla?= =?utf-8?B?aUdGME9yaGJDUWk5TEg4SExvSC9xS01IaDdFSE50KzAwSE9zYytpbkZVZ3BB?= =?utf-8?B?ZHVZYjhzWXF1OTlwZno3aFBJWlIranh3ZmJhNWkwaTQyTUlwNzBoN0xxSTh0?= =?utf-8?B?azVGOWhFZlVQT1hiS09ER0xtMWFrbUVhSXNNb1R1OVp0SnAzSm1SaDNzSTgz?= =?utf-8?B?eFl4V2hGanFBejg5OVVkeGRuU1k4c2lDS2xqWkxpUThscWZicEFwMHk2KzlZ?= =?utf-8?B?ZzFSOThGdUNPZGhYeWpUb21YZ2VQaHFBZlhqT2pVMkdXeU9rUzg0MDlxdXFJ?= =?utf-8?B?NURsTWRQNEQ4c2t4bmNGc0MrWGFObHpiVFRybmtacnYzTkIwNjgxU1VmVXZC?= =?utf-8?B?bytRWGpWK2VvSkl6bVYwRjZZYjNLQmJCTFNUZlJtc3hZSGxUT2N6WUU4Qzlt?= =?utf-8?B?bzNGcjNWZ2YrTGN3TmtKL0F1dFNJQlZxYXh5UlY2bG1iUWN5UE9QYllvUUF1?= =?utf-8?B?YzNaODF5cUlJRWVnSkh5MnFtclpEbG4wQVFCbVlJM1prb2gvZjQvdno0Mmxj?= =?utf-8?B?QXFRZmhHSnE4V2ZrV1Y5c0VwNUI3endwTEl4dVJqMXRKVDE0emt6Z3lzTTlj?= =?utf-8?B?akcyNHNsdEx5MTNaSFUyRjdsZ1JiNjA5RmlZdnlyOXF2emJmemQzbHM5Qytr?= =?utf-8?B?dlhFTXV6bDVRT2JXekZEWmdSNk1qTG1TZ2I2cGNranhCdkI1VVFPNjl6NTBP?= =?utf-8?B?S3BIOWNCN0R0b1AxRXFXWGpDMDRRMmpYSjJBSjdvcDJ5MFcyR2xnSVI5Sm1w?= =?utf-8?B?bk54Q3ZVTHg1SjNpU3NjVVZKU3piZ2xaVVVOV21kc2R1VXdYOWtzdWVZVmoy?= =?utf-8?B?a3hRNDNCSDBJS2U3SnVUakdoS1o3YmkrU0JNUTZhZkNuSnJUY3JXa1dHRWNu?= =?utf-8?B?MUJTbVdWYWx4dnp5dklqc2kwZE9GbjUwREZsWk91TStvTC9PUmNGU2VKdkdR?= =?utf-8?B?d3MyVUZYb1V0dVFPcWxGWGRORGVJYTNMcmRlQmpaOHljczBJV01zL0ZhSjVa?= =?utf-8?B?NXlNaENnMUJ3RzBKc1Z5M2o2Z1kwbGZMVnJtQ01nNWU2czZwc0JQTFdnRFEr?= =?utf-8?B?TGlkSDBmYjVNV29EL2hPL0JZcnZkZ0Ird09URWl1WTh2cUFmaHJtSitPOUE4?= =?utf-8?B?ZjJud01kckRSN0g5SHlVa2I0V0VOTGdzM0RiNUNWNzA1cnRSOHpwbERHN2ZP?= =?utf-8?B?c3lxRWErMkg2MFpmWXg3ampYWEU5Ujdja3Q2WklXZmlDK2NaZ0QwMldlUGdB?= =?utf-8?B?SzdHdHR4SVpQV0lGdFpZVzVJYy9nMmJEeThITFY5RnluYUxSY2pXcnFjRXZL?= =?utf-8?B?K3pDNEUvRHlCN0VKN0NFbVlQYi9FbG1lV3BvK0wzRU15NE1laU9qSldhc1Ni?= =?utf-8?B?azZtN2d2elZtUzlJVkJXc3E4NVczR3hDcy9SeW85OEJMOVdQaVZnMS8zSEFT?= =?utf-8?B?UE5MODhqTVRIQjB0YnVSUmJxVU1ZTTdWVGFWSGl5SnhyTWZ6ck1lZzZDeWRw?= =?utf-8?B?cHJiUWRBRGxtYlJLZ0RFRVVsSElGVzc0UDNnMjdMcUUwN1kxMmpGM0U0YjA3?= =?utf-8?B?V1BwNkJaZ2VSVFVSMU9ROVNNOERrbkIvUHJ6d05jbXRyREljSUpjbTRXU01E?= =?utf-8?B?d1FsVlBRdzlBRTRYd1ZJVXc4SXowbERSME9BTFdPNEJyajBTTFMzNGtETGYz?= =?utf-8?B?R0dHb2JwVTE3MVV1dlBLbjArMVpVaFFXaTYyakNvQllubDZ0QWZ2UTFoeUxw?= =?utf-8?B?eFFjR0NyS3Q1SzV0Wkl2QjcrU3YyeU1keTlKWXM4Q1ZxdGw2cWxRYU1lODBB?= =?utf-8?B?Z0JTVmFESFpxQ09Tb28rcFYxYTlZTmpMN3E4TzFqNDViVlV1cUwxYko1VHZj?= =?utf-8?B?Q0VtZ2h2WUd2VGRGeExMdTZvMzB6NzR2Q1FabG5mZnpaK1M5OU9sSzFmT1Fr?= =?utf-8?B?bEF6c2NvVlRWMkJ4NzgwcWV1cGVvaklOaWdYUzZHVG8yazdOZUlJUU5laVJj?= =?utf-8?B?TWJQRk9CMXM2NzdJbklpN3laT0svNzNwNnNIaUV1ZDhFR0xPN2JPNnZOaXU1?= =?utf-8?Q?8d9/tA/p0ISho2kUxYmt3u+mk?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0fe7c8d2-2d03-4f92-2ee9-08dbecbc52ca X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2023 07:09:39.1812 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vRNqswpKajx3BxNlpB7h4x9Ionf0dtdq7o3ncSJ/IilesOjwusKhw376FzQ1dJgGXjp9ZGNjfAPgJMCrgKBgEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8354 X-Spam-Status: No, score=-3026.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 24.11.2023 08:02, Cui, Lili wrote: > Make const_1_mode print $1 in AT&T syntax, otherwise > there will be correctness issues when it is extended > to support APX NDD, Looks fine to me, but I could easily imagine this to face H.J.'s opposition (and hence my suggestion in this direction wasn't exactly this way). Since iirc he's going to be back soon, may be best to wait until then. One request though: > --- a/opcodes/i386-dis.c > +++ b/opcodes/i386-dis.c > @@ -12090,6 +12090,8 @@ OP_I (instr_info *ins, int bytemode, int sizeflag) > case const_1_mode: > if (ins->intel_syntax) > oappend (ins, "1"); > + else > + oappend (ins, "$1"); > return true; This was already overlooked when output styling was introduced. Please switch to oappend_immediate(ins, 1) here (i.e. replcaing the entire if/else). As per above - from my pov okay with this change. Jan