From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2074.outbound.protection.outlook.com [40.107.14.74]) by sourceware.org (Postfix) with ESMTPS id CB99938518B1 for ; Tue, 29 Nov 2022 09:12:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CB99938518B1 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CxElBZxJrxuCTbL+BsfgCyavOwXL8upf1o8cRRvAYcxA6R1riEo3MEPes3pOmSG+d5gUOLkzTKq9ouQNsW8hXgT6yothaVBbOxtdyWwMvf4uzCLCHkjZh5sqYUZ4miu/wfJafbPkGPUDLcoiRV76CI6CbpT/SCxYDmZDXtrF5CH6fTnFEYuPPv8uNyAfI0mfqYbANXcNsnibmQQEZT/xZNTWS7kREAdE5kAdWbz9iqQ6EUvbsnRCa7Q2iDNmw+tuaJKvHDT5AJYYLlZU++V44pvfv+G0/ia/HEyPmSRQQACcu4+04Yym19GYOvwRxdul+/W1z2s2REjJoI0S6Rnsvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F19TAifRUGzfHPx6NQAaaZ68xFz/o1rp3QZfWMSeFJk=; b=OPLaJdlFV3b0y5qxb0VQ4xkryk7nX3RLu64CM0p/seTD1Ygq5jTJF1xU64Qd5keL778GqmAzCXzefrqvYpscRhtDV388vvhNbTlJKY7UC7sd/S02A7/fMI18FelevWpAQ+8wooX8d4/1Sap6jJ9BPmjCVkSeAyfG+r2cWANO1HJY+SZzafSNP2PinbaqKoN6D7I5k08q6tR4tw185vVaLFQ8qnvsNc2FmzdMNwRDNjf3Xh051i8u6aJCyScl6VOPwfRljsCVzI4rtsk3bF607G+u5sB6ocOslozQ/aFA+c1HoR7Af0lWLkOcFiTQH8oyijrPn/wKtuRCj9XI0sNsJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F19TAifRUGzfHPx6NQAaaZ68xFz/o1rp3QZfWMSeFJk=; b=DpgfDiHt567uJwdyseAPWIkat4gLj1jawg+HP2vm80O8Kerw2g8x3ILskoa7Ws30y4DpxkJcLX5IS1fBA1878PK0oSKptGJMGQHn31gGbJWruJ/Uj7rlYMuenUwmzywkBnbJ8gl00hsgDkbycnLxMOKPlXq7WLAELaWMjAnSj573cOy9GLfkMlfxbMiTTBSvFzl5s9FytLzD3L2WlGC1fUy2Hr+A/0P85ksqLwTgibSvSQDaLmiwddtY5EKD3hov2Fy9aAUaicYkLG+1kDNPG4/jZb6kjU+hAar9dGgmlffJvgY2wzbS1lPf9Gl7T/uPNUn9nkboAamYSsmzZX0m8Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB9094.eurprd04.prod.outlook.com (2603:10a6:20b:445::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.21; Tue, 29 Nov 2022 09:12:36 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 09:12:36 +0000 Message-ID: <8b1cb175-ec6a-e8b0-8d85-4e6743f06532@suse.com> Date: Tue, 29 Nov 2022 10:12:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] x86: Remove libopcodes dependency Content-Language: en-US To: "H.J. Lu" Cc: binutils@sourceware.org References: <20221122181927.251937-1-hjl.tools@gmail.com> <4d995c45-7e4c-4f66-5459-1b1c33aa4dd8@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0132.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB9094:EE_ X-MS-Office365-Filtering-Correlation-Id: d0e5ddbd-d3c5-478b-4e6a-08dad1e9db3d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: boj9x4PvlaUIBDyYUtZgyfDSdTVO5ujpLkBfPnK7Lwh4BH2mvJ4/ZIZAGILmt1esp6gQWBg6SzKmwGoZeFcsptPsnsAx2bbduPOfqWxvBkSA8utg47KC/jRe056PLZ4S3gxD+HaKFkykqXtN1sAsjBq8tZSdIZ02ZdGq6Z46wjb0PMjDnJtcua2RPF5K+CZ++lS1fEMZmnMhWog3UGJi3T2qrzj2bPlbO1e7DbQ6kNBLz2Jt6p2dlHxGKJUdoMUHLFTWitPJaFOWn0lip1mhUeSfRP3DqALNKiGc74rnysjIqxx7Vusv/YrGczQLfcYT91piP+guavn8P9MRU74eopYvoBCJ2NEXcn1k3O1r2qBJe0yV4E77CaBhKdn0wthG72IV12v2hEciyPYMnfSwZ+DFs1DNeCd+pZ8MusW8Pi0OATt0OXRVZtybtYCgUjCiqMIileNjq98DPFLTV0gpCNLb54omJ7C44kZ53StSkvTzJu26hGtJyZcPfzK3QRvjIFIHDVC+XXWSu9+rkUU8A6rvATtIPqmiRwb0YN3o1hX8JVCvMnuq4SENyDkhAEKicji+v00AgzBj3/vmqdj8J3GndBnqje8k8XwqwB+cMKXOAjOU8IdvT/9XWmc3qj/ePXcWOFnmqbh9cj7gBPWMvf2S5q7atwF6PmB5r/I5YF/NooW243DFo0bxwr//q8orayMailCzrXakZlfiIPNNFuPuf5/AJsB4jWi2dhZbPnk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(136003)(376002)(39860400002)(396003)(451199015)(5660300002)(66476007)(4326008)(8676002)(8936002)(31686004)(41300700001)(6486002)(66556008)(6916009)(86362001)(66946007)(2906002)(478600001)(316002)(36756003)(31696002)(6512007)(53546011)(26005)(6506007)(2616005)(186003)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SzROT043ZlRORXIrYW5YY0RMM1RjUXhJMTFZZEN1OXArbTZENjI4VmlUZ0xu?= =?utf-8?B?dmxER2J5eFl2TitWd2dHR0RHRjNRY2lUeUhERFZ5aDNsRzdEaG5JaWlvUjll?= =?utf-8?B?K0V3T21oWTBNNGZ3a3BKWVhDRFBXTTNmSEFmYTl6RXpWRllTbzB5KzJoVFdN?= =?utf-8?B?NHNVMkhWRmx5RTl0djN4bGpuVUJxM09SYlhNaTJmU0dDazJGSU02OWQ0dnE5?= =?utf-8?B?eEpDZjVndnhqak1heTVibGtmRzRla2FxYllVVGJZOGVDeFY3WHRURkVUVWFp?= =?utf-8?B?cVkxTVE4ZmovZHlxTklReG85RHhkNWExblprT0hZWGgyR05MK0ErYTR5dFdt?= =?utf-8?B?SC9CdkFObEFxUE9laURkcUViNFArbTZweTZidkN3VzBQeHIrbXhXYUdYTUVX?= =?utf-8?B?R3BVblRUN0lyeUlONUx6WDI1TmJUaUhBM0JOKzZ1OWx6YmZ2QllDZ1paVkkv?= =?utf-8?B?T2FnSWhBbzcyQkhLamtiK1gvcFo2RER1MlQxK0VsYlhLWU9uaTJTMkRVNjRm?= =?utf-8?B?R2hjRkxPNGFjM3Z3NWVEWUFPSVJtZ1Jtcm5tQmxqcEpGL0RqcUg4WXQ5RDNQ?= =?utf-8?B?KzJLVHNHYU1RSjBYdWNUMVhNVHhLZWRqYXVqY3Rtc2YzOFQzSVhueHZrUVp3?= =?utf-8?B?clhvczBzTmVZckl5N01va2RNNU1kVmdLQXFNdHowNkw2K05FRGtPOGx1OHlj?= =?utf-8?B?WDVjcWFIbGtyVU5xbHFmVGFEQzNTUHk5V2hpSlRZNkp2UmJzb3dLQjlVQzRy?= =?utf-8?B?QndTV1NsKzVTbW1xc05tNmZlQzdoV3VKaGwzQnpqY2s3QjNDSE9Hc2Zzb1ZE?= =?utf-8?B?KzF6Y0xqNERJRXRvSkwvTWV0NUJtTnlWSG02aXl2cUludkcrajlVVWpxdFNz?= =?utf-8?B?N0tjMFdXYkxiQkZiK2RXNHVPd2NsVHpqUFFPWE5OQ1VNbFJsTUtaMjRWeVZr?= =?utf-8?B?dVNpUnRHZ1UvZGc1UERkNVh6YUdpSHk1VE40ZlNGU1NlUEd1dHVmcXFMK2Y4?= =?utf-8?B?TFNaRmpQUldvajZKY3I2VGcyMUJKTU4xRnY2ZlVPaTU4TzRQSXJrWnVxcUZs?= =?utf-8?B?NW9GQzVJak5DR0xGNkNlaFlEMEN6RDE0N2hvc0E5Wk5hRW5nY3RxakxEbTk5?= =?utf-8?B?N0VYbUlDaTdNZ0JWMjdCcWdHeW5GK1BUZ3Y0S2l1SmhzaXBPSURWYmNaekt3?= =?utf-8?B?djAyUnFGcHAvand6ZHFmWFVPNmhJQTAxY0xVWHRiTTI2MEZZODdJS1ZZT1I3?= =?utf-8?B?Yk4yMndaRUtmU3MyWlRFRFpUY1N4bmdyQjJuZDFBRDdVTW5nTEMyK0haYlNx?= =?utf-8?B?Y0s4VGh2THJjU09wYmxwZlE0NkV4Mnhzc1hJeWMvMEgxYkdxazNCdEtxTHZR?= =?utf-8?B?dndwanJNSlhvNkoxakNZeWJ4Rnp4a0ZuSHVaNldZYnFRSEJCenM4WUk0UWpa?= =?utf-8?B?YjJENHV6OFpKbjF5dURCZkZ5V1drd0toN0NRQXp3MUUrSUtydkhvMURNVmdB?= =?utf-8?B?bjY3U3U5WHBaUjh5ckV6YUNDTDliaDhkdzFPWTNPbTZqcnZqY0EyYkU5SUlp?= =?utf-8?B?aVBQa2pCa2ZiMUp3WkJsNm5QVHRPenp6MzZ0Yk0rZCtlMmZGek9MbzlReTAv?= =?utf-8?B?SndvNnNwbmd6aFhrN0J2Wlc2YWpxa1d1cSs1K0hOQjJjOWF0R1NiTmNJaE5h?= =?utf-8?B?WldvTXJHb3ZGTHJqdjRHVjAwNlNyOEtTZmtzUjF1NUZLSXJUSXVUOE5Ka1lV?= =?utf-8?B?Vm9BdEpsZzVmSE9vYmp6OVhRRkZFUENRRGFmbEkvcVhRS1lmTW02OS91dkFj?= =?utf-8?B?d0pnbjA1YVpMVk9kYVBvZWtLbkEwd0lvanBkVWZaZ3Y3U3AzT010YUtaWFNF?= =?utf-8?B?YU9BZzdoWGhZS0xZSVA1Y1p5V1dINk95RmZrT3JuY2M2NjlxRmVFNVNwL053?= =?utf-8?B?Q3pXaHRsMndIbjNvN2U0NEpZWkJvYUdSUTF6V25VU0Mwb2NhaTBhaHZ5eEpp?= =?utf-8?B?cEhzWDQ0UEJrUU1mRmZHWW4xdGRtMmZZc1ZLaEE1VmF3NjdqREJLNjNnbGJS?= =?utf-8?B?VXhodzVXK2pRc0lIK2tOazJoRmk1c1lKQWpkV0VLQ3R1bXdSdjFyY214VnRF?= =?utf-8?Q?382yEhajbBS7ffomgwz8uCr4L?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0e5ddbd-d3c5-478b-4e6a-08dad1e9db3d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 09:12:36.3409 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AN0LGtToQXSOQcN3PRkMHp3f86xz6TkJ2pcuJT+6cYnW2OkvCI/HGiHPEsukBppleskfUTn2v3ACWzb7AOKWvg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9094 X-Spam-Status: No, score=-3029.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 29.11.2022 00:43, H.J. Lu wrote: > On Wed, Nov 23, 2022 at 12:36 AM Jan Beulich wrote: >> >> On 22.11.2022 19:19, H.J. Lu wrote: >>> --- a/gas/Makefile.am >>> +++ b/gas/Makefile.am >>> @@ -446,6 +446,12 @@ development.exp: $(BFDDIR)/development.sh >>> $(EGREP) "(development|experimental)=" $(BFDDIR)/development.sh \ >>> | $(AWK) -F= '{ print "set " $$1 " " $$2 }' > $@ >>> >>> +$(srcdir)/../opcodes/i386-init.h $(srcdir)/../opcodes/i386-tbl.h: \ >>> + @MAINT@ $(srcdir)/../opcodes/i386-opc.tbl \ >>> + $(srcdir)/../opcodes/i386-reg.tbl \ >>> + $(srcdir)/../opcodes/i386-opc.h >>> + cd ../opcodes; make gen-i386-tbl >> >> This recursing into a different directory (and then even using "cd" and >> "make" instead of "$(MAKE) -C") is what I have specifically avoided in >> my patches. This is deemed an anti-pattern by many people: If you >> consider running make in just gas/ is an okay thing to do, then running >> make in just opcodes/ is, too. Yet with such a rule doing so in parallel >> can result in strange collisions and likely partially broken files. > > "make" in opcodes won't regenerate these header files. As far as make > dependency is concerned, > > $(MAKE) -C ../opcodes gen-i386-tbl > > is like other programs. No, it is not. There may be auxiliary files which get touched as a side effect. There may also be some other entity (down the road) wanting to do something similar, which may end up conflicting. Plus you shouldn't set a bad precedent. My objection remains. I'm actually puzzled that you've now submitted a v2 of your patch _after_ having made me (by remaining silent there) _once again_ waste time on submitting a new version of a series you (apparently) mean to reject in the end. I don't mind you wanting things done differently, but then please say so. I did specifically wait a few days to give you time to reply one way or another. Jan