From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by sourceware.org (Postfix) with ESMTPS id 9F9313858C83 for ; Mon, 7 Feb 2022 09:44:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9F9313858C83 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2054.outbound.protection.outlook.com [104.47.12.54]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-25-7l-k4gLbPaKD9b3NunwBfg-1; Mon, 07 Feb 2022 10:44:42 +0100 X-MC-Unique: 7l-k4gLbPaKD9b3NunwBfg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gelDKEtvaCubqtLjxqVyUFWpGeFD2QiULTGX27m2gSemuiy5XFqon70m2FNfoLYPkcCfAueViy1UJxeBL2AUCRECr40zwMTLEyd8iYn+3m11ojLLPL4P0E+rNewayp+dWYK4zmWrLw/2NBN5v2qLUBfVSmWJ0OeLG7G2N+AQLmdr4B4wmRZn4N9UOXLsGlrTRw6ykwBQ1k0nRpkmrpdU2wWMTX8QihGxcn3QYx6DWmgTk0gPQgZep7Mz2YN8QBlXaFdiFbQR/1TESKGIffgQDJc+FaA9Z/sIoamOhs0dsLhHHNOpRNWXGJy5/dOB0USQFfU/j4RxE7Sikj8XwubzgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GbNHZvOKJvTpdM2689TznygG7Bj+lK8NFqslRNM1IqI=; b=UlwXoN+LsZAKghayOG1vvU5Ac3NZHh0D1KCllPUeGPwAWR6b+VBG/n7+yvHXT9fKURXkyQoQnJyvdzIzHEQGXgaJ6RbRkaKTnAvvjTbMgC2psaR3g3/Oz082XXnRbVjeqW4Eut0z4+abP9IML8CwFJ/e9SWdvyikmL2wgx5gQoZ/3LgXE/3vM6W6JFn82C9d0AkdwTbO9etTaLjqyk+HGixhfBtxFg1xvptQW+bmE74ROeUIeb8iXIKXgo2Uqvrwo0XYGg4i9HBdNY91EnOCI+Kjc8CWEUdWcp9VtUpHCJeG5xL+Sn/XrXBb5SknWKnWHjaMX43ZANYS9DXIZ3t7iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by DB8PR04MB7130.eurprd04.prod.outlook.com (2603:10a6:10:123::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb 2022 09:44:40 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022 09:44:40 +0000 Message-ID: <8b5990b6-a9c0-8365-17b0-fcb99b22a3f0@suse.com> Date: Mon, 7 Feb 2022 10:44:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] Fix the disassembly of the AArch64 SVE DECP/INCP/SQDECP/SQINCP instruction. Content-Language: en-US To: Shaokun Zhang Cc: Jingtao Cai , Bo Dong , binutils@sourceware.org References: <20220207093441.55725-1-zhangshaokun@hisilicon.com> From: Jan Beulich In-Reply-To: <20220207093441.55725-1-zhangshaokun@hisilicon.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8PR04CA0180.eurprd04.prod.outlook.com (2603:10a6:20b:331::35) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c1bd68bd-6843-45b6-0dfb-08d9ea1e7623 X-MS-TrafficTypeDiagnostic: DB8PR04MB7130:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1751; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Qmi39lH1XW6s5a3M3cd7rK4dOq7vHkd1/RzvLv98v5a+YgcnTp804TC7IqjYBcdzAyot9NW4p+EbHFjuMjSby1CpBkAgjzIvQIgwgKJRG8iXceIVthgDtlAjrvsweaLc+nwIGevX2UnndL3MVR/RUzCuHwcSRa7Xxl9KkPauNO0nkUQ8MM3Kda5zM/cpTfz1nbXiwC+OWR6fRpUFpnKz2Kg76tUDTiERI1VHEpxaRT9KrgRzjakgrR3uc5Xa4k4ucCZLxOWQBkbD2hgC0ib8s8PxEHbZ1ENYVWVVqmH88avUO/6VI0iHwfD4AIrh2lTYJDdb4VeUkFIyWt4N+Wb8fqEIZse4DbmItMw0vCpc/lTbAuMczv+0o3FHM9JNmzMoR2E2Tcad/aG/mA7Q/9Xj8nQ+u4tn4tfzFch9LIFblxhFilYtkJMdzovYKB0bPcFY8m/uG0uDHbNiyyKmwY4a3PLD0rn0h56iISiIpk3Pg8cZ26QgmVA//9lS3hj8LhDWYS0tbzLwzWEFfrW53nOk6TM3l44ubGx0kPNqQeYu+AZ7KskZFTQLv/DdCaQ9U7oiVtWT067KjuQb8a4iLN6IZaskoxQ3ps8vbatGdWqT+MQS8TVloFtTBNctD/QP0ppWr7MAcleiQRN2EENqe/Z+Z9fzSx/0FM10ZTjJWZ0YiQ7aXa92RpnX6j1AxdGoNRdiIF6DjdPeEXRKP8Ma7tgP/GQzq0G6BawwAr97KUVjncal0J3UIKQdvuLHznGLwFgYhdPN+7dBlchLXLRg+cCGIv2lQaEFCR9/lxoih8gqw47dVeQDGb7nusF6SdOBmvY4 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5600.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(86362001)(31696002)(54906003)(38100700002)(8676002)(8936002)(4326008)(66476007)(66556008)(316002)(66946007)(6916009)(966005)(83380400001)(2906002)(5660300002)(6486002)(2616005)(31686004)(6506007)(6512007)(508600001)(53546011)(26005)(186003)(36756003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U1JTckJnSWZXNE94S0FZT0dpWE43bytaME1zS25RUlJjc1FUNnJGbWF5RUp5?= =?utf-8?B?RkpyVHNTS0VDYVJ1MElyOGdneFdablFldDhIQkV4ckU4Umhoa1E3QS9FK1VG?= =?utf-8?B?Y1hwaG8zdExNRkVLelZUb1NPMlVvbnpZWlBqRXdkbEtBQkR5cjUxSWFjYlFQ?= =?utf-8?B?TzdLR2JnT0RKa09OclhnS2UvcE9NMHUvL1lmaG1OVEtlaUo3Y1V3WjMreVpV?= =?utf-8?B?Y2ZnMnJTZW5LQUlqeXYrRjRUem5JS1ZoQUNSalR6OStKb1pES1FzZDBLVU13?= =?utf-8?B?MHFKcnlRblRPakM4LzM5QjY2bVdjTXJMRHNjekpHZEhPVGwyMTdBSjRneW5a?= =?utf-8?B?WVpLT2E0eVdOSm5GQzhRR1RWU3lqY2lZRzB2ZWFPbk95aXJHb3dJWnlwY1Uz?= =?utf-8?B?aGhRT05YSHViaXRHd3FDT053bVBpVjBCQ1VVUmJOdUdZUlduUVhxemgyR1Vq?= =?utf-8?B?WGFVZzVTUW9tWFFQVUVyUEFsVTQ2VE1OZDIweHhITzZvM0dsYzMwSkQwQVc2?= =?utf-8?B?MzBDRUJLVXlFRTcrN1ZVNzIvZ0JuMnhoa0dXM3U0TEVCNklNaVkxQ2lNb0U2?= =?utf-8?B?VU1SL3RJOW9WZklRWXp0a1BNYTQrMDdGOFZrbGxVRG1pV0J5TEQxNldxZVZr?= =?utf-8?B?S1pROVBWNm9PYnhxS3RUR3o4eldRWHRsWnJhSkJzSFZnazRjS1NtMlI0WDRZ?= =?utf-8?B?N2IwM1I2R1prVTh2YkNObVNFSjA0UGJSSDlEOTFha2QySGN2Tm42emRRSFdy?= =?utf-8?B?UGVhNFpSWDVxTTlwQ21hZFlBZmNZbWFJcmw3b0xiWGxGcnRUejYrQW5JOUFt?= =?utf-8?B?Tk0rRG4wZTExb2owTnIyNVNqVTVNb3c0K2Znc1orSVR3cFJHczk2QW1NUkow?= =?utf-8?B?L3Z6TUlVM2VTRktvZElnOU5TYlpraHYvcTJrdStla2F1UWJFSEZqRUtTc0gz?= =?utf-8?B?ek5EUVIwc0YzMUdxQkJMbXZBbklHQkxvYXd0dUNNRzF3Q3JwTFhVVEovMG55?= =?utf-8?B?aUlLYnNoWUY0bFFSYzB1aFNFOHhsVzNYU0FNNGJhOVBzZ1Z2RHk3Nk4xQWFs?= =?utf-8?B?YVZPUmRncmRuQnppaE9obmxIMFluYi9uU2pUcUVvb1FIWXZpR2QvWUtpVkFy?= =?utf-8?B?RVV2ZE9ma0MyTURoZUY3UjJQQmJlYWp6YzVaNXprbGxhdXhkaUxLN25yZmtm?= =?utf-8?B?MWxUY2Q0STY4NG5JbVBTTWdRTXgrS0RLUis3RHV2cnhwT213M1pLRDhocjhB?= =?utf-8?B?Z3lONVQydEg0azU4Ry9GRzJYWWcyWVVKb2tFUmJscTRySGNlejd5SldQTjdW?= =?utf-8?B?cGxPRzZVT2dsbU1vb25jeTdFcjJxMUx1ckN4dS8wR0lpdmlQbzc2NjkzV29Z?= =?utf-8?B?emZqM1pZV29NTHNuOGw4dFhOTTdZazRQT3A1eE1aK3czSUNsN0FvcGRFQnQy?= =?utf-8?B?QUZ3NzcvbVFjWGZJd2FVYTN0UWtNbkVYanJLcUFWd2dLbU0rZmoyMWo2WDNh?= =?utf-8?B?eExYOFJzYWFMRVpQMEh4ei9aREliaFJWanQyMm9icDY2b05TZEl0VW9ESTJ3?= =?utf-8?B?S2QrdmZJU0dXeENHU1hVeWtWVjVMQXZ5RXRUY2hibHpibDUwa0c4bE4vY0RN?= =?utf-8?B?dUcwakxDNlRKMGxxM2VidWhLUmtQKzVOeHJBZFF2ZkhJQTJuRzJCNWpmdVhP?= =?utf-8?B?VHdxZURiR2x3aEJoeWkyWDVmZnhqajUxRW5GSjZZelNjbzBLNE5kZ1hHZnlT?= =?utf-8?B?bWlMVElEOFhheUhqZG5OTm9WWVQvQ3ZmczBGM3hWWFJYN240VGxjTjZ6b3dv?= =?utf-8?B?dE11K2pMbkpRc0dwRVJOOFBkeGVkS05VaWtOQVV3QXhaMk9NUDJuNTNqajRH?= =?utf-8?B?UW5lNGt1eVM1S2p2UGxpTWJ3WmRqTGJzTWhYY1hoTmJDWHRYMkgrT0RsWk1B?= =?utf-8?B?QzlqeTJON1ZRZmZTK05YQ3NtTEwrNm95bWFHOWhvVFFSc1RTYVFobEVUN0hG?= =?utf-8?B?Rlc4ZllvN0c5bHJ4RHZWWWh5eEhSSUNrZEF4c0VBMEczcDBmVTZjOXYwK3R0?= =?utf-8?B?bXJnM2NGQ3Z1QzlyNkRLWDN6OGxVV21jL2MxQVhGMm9wNXRMeWhOVys4MFBs?= =?utf-8?B?RkhsNlI2ZkNlYy9tSWp3MTZrdnRNQkVjUHpVMXlGYm9uZyszWm1tZWJQa1Vz?= =?utf-8?Q?3tn1ZgooZWbJsM2m0FN6LKc=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c1bd68bd-6843-45b6-0dfb-08d9ea1e7623 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 09:44:40.2813 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OUHmbwjGFhL1Yer0CWI69V0LhDfCfJd1rq5Meu26261NyPxnPdkwJ314+3mQCvonjyp2jJEuPHY16DWNbRkZCg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7130 X-Spam-Status: No, score=-3033.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Feb 2022 09:44:46 -0000 On 07.02.2022 10:34, Shaokun Zhang via Binutils wrote: > From: Jingtao Cai > > This patch fix qualifier for the AArch64 SVE DECP/INCP/SQDECP/SQINCP instruction, which take the predicate size specifier: > DECP ., . > INCP ., . > SQINCP ., . > SQDECP ., . > > Omitted predicate size specifier will be prohibited in a future release of the architecture, please refer to Arm A64 Instruction set documentation for Armv8-A > architecture profile, see document[0]. > > [0]: https://developer.arm.com/documentation/ddi0596/2021-12/SVE-Instructions/DECP--vector---Decrement-vector-by-count-of-true-predicate-elements- > > E.g. : > > DECP Z1.H, P0.H > > This patch adds support for this kind of operand. > > DECP Z1.H, P0 > > This instruction leads to messages: > Assembler messages: > Error: operand mismatch -- `decp Z1.h,P0' IOW unlike the title suggests you change not only the disassembly logic. Wouldn't it be better to make this a warning initially, and convert to an error only a few releases later? That way people don't need to immediately fix their code. > did you mean this? > decp z1.h, p0.h > other valid variant(s): > decp z1.s, p0 > decp z1.d, p0 Isn't this misleading? Should these "other valid variant(s)" also be output with suffixes? Jan