From: Xi Ruoyao <xry111@xry111.site>
To: WANG Xuerui <i.swmail@xen0n.name>, liuzhensong <liuzhensong@loongson.cn>
Cc: binutils@sourceware.org, xuchenghua@loongson.cn,
mengqinggang@loongson.cn, Fangrui Song <maskray@google.com>,
huangpei@loongson.cn
Subject: Re: [PATCH 1/5 v1] LoongArch: bfd: Add new reloc types.
Date: Wed, 20 Jul 2022 13:19:01 +0800 [thread overview]
Message-ID: <8bdbf9037b596fe02b386ef15da8a9b484a42c6f.camel@xry111.site> (raw)
In-Reply-To: <f0b6a8e3-e6f6-d47f-35e0-481dbc929dad@xen0n.name>
On Wed, 2022-07-20 at 12:03 +0800, WANG Xuerui wrote:
> On 2022/7/20 10:07, liuzhensong wrote:
> >
> > Some relocation name changes make sense. But, how to name a name is a
> > matter of personal aesthetics, and it is difficult to satisfy
> > everyone. Does the name of the relocation matter? should we pay more
> > attention to the specific implementation? Remove useless and add needed?
A bug fix needs immediately attention, but a new feature may need more
discussion to make it easier to be used correctly. I'm still reluctant
about "adding a whole bunch of new relocation just 3 weeks before
Binutils-2.39 release date".
>
> Also, if you think the current names are more appropriate, with
> objective reasons, then *please communicate* your justification and
> thought behind them. We "outsiders" actually intend to cooperate, and
> have voiced our thoughts, but we don't know what you and your team
> think. For now all we have is this "LO12/HI20/LO20/HI12" and outsiders
> can draw no conclusion other than "hmm this is going to cause
> confusion". We really need to communicate more in the open for pushing
> things forward, constructively.
About "LO12/HI20/LO20/HI12" vs "0/12/32/52", please consider: if someone
has not read LoongArch manual, he'll have no idea about what is "HI20"
and likely [mis]interpret it as "x[63:44]" instead of "x[51:32]". But
if he has read LoongArch manual, the manual already uses
"LU12I.W/LU32I.D/LU52I.D". So a different notion for the parts of
immediate seems a completely unnecessary deviation.
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
next prev parent reply other threads:[~2022-07-20 5:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 8:43 liuzhensong
2022-07-18 8:43 ` [PATCH 2/5 v1] LoongArch:opcodes: " liuzhensong
2022-07-18 8:43 ` [PATCH 3/5 v1] LoongArch: gas: " liuzhensong
2022-07-18 8:43 ` [PATCH 4/5 v1] LoongArch: Move ifunc info to rela.dyn from rela.plt liuzhensong
2022-07-18 11:45 ` Xi Ruoyao
2022-07-18 16:27 ` Xi Ruoyao
2022-07-19 7:26 ` liuzhensong
2022-07-18 8:43 ` [PATCH 5/5 v1] LoongArch: Delete R_LARCH_NONE from dynamic info liuzhensong
2022-07-18 10:06 ` [PATCH 1/5 v1] LoongArch: bfd: Add new reloc types WANG Xuerui
2022-07-18 11:33 ` Xi Ruoyao
2022-07-18 12:11 ` WANG Xuerui
2022-07-18 12:18 ` WANG Xuerui
2022-07-19 3:57 ` Fangrui Song
2022-07-20 7:47 ` liuzhensong
2022-07-20 2:07 ` liuzhensong
2022-07-20 4:03 ` WANG Xuerui
2022-07-20 5:19 ` Xi Ruoyao [this message]
2022-07-20 12:54 ` liuzhensong
2022-07-19 7:32 ` liuzhensong
2022-07-20 2:42 ` liuzhensong
2022-07-19 4:29 ` Xi Ruoyao
2022-07-19 5:40 ` Xi Ruoyao
2022-07-19 6:31 ` 刘振松
2022-07-19 6:34 ` Xi Ruoyao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bdbf9037b596fe02b386ef15da8a9b484a42c6f.camel@xry111.site \
--to=xry111@xry111.site \
--cc=binutils@sourceware.org \
--cc=huangpei@loongson.cn \
--cc=i.swmail@xen0n.name \
--cc=liuzhensong@loongson.cn \
--cc=maskray@google.com \
--cc=mengqinggang@loongson.cn \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).