From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140080.outbound.protection.outlook.com [40.107.14.80]) by sourceware.org (Postfix) with ESMTPS id 0564F3858410 for ; Mon, 14 Nov 2022 15:30:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0564F3858410 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TtWwsi49Zl0LmFc975oiyw5H/+j87B3XOD4BXnArL7LkmVt/LnQPBNvIwHGtRDEQTtrBiYAiwyfddQ4gwphG0aVbxvoQzkwaSrrv8Q20Z3mdB+g+GCxNn4AziWLIE9LAiOfcXavoTD9+lTyUClFtDCbA3bT6RFUlDZfynxbxmqwIl8h9A0F/4GcploBnBZTxfUPUc0npyN8uFLrAnOOvDDd9rEEcYWLK2HZwZG+Uhf3sBr2L1D09QQVxOqCvrNRtwnAS/nVe1nHMuWJdHHLu/UzH4H1BGzyar/2Ed2ISXMRQ4mJLW0/WQlV4FeMe9MplV8BXc9Hktu+xuxJyQg0hFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/Ot79Ka3ylzMUdse1N8TDc7OVs9rIx2vqffH3HRzzWY=; b=DG4m54+Pwcv9otnY15Kot4MJawXeXNJ25SzDGNI8TQxiE+LWYBO3Hu4STNJ5v3Uep54n4024Wfav3rodrmiac16q4W9ZGt+TerNmZNpqOymAjA5JbGrY8Oa2eqlh2g1mudO1W4CjIEa0852zqq+w2/mBSIEs1qzjqoqlS/Oq84TZ+NvRolTyUTwnYZ9ST83x4bg/4rslhTpeiP0UDuQbiuGHuzOrfFUjDkQQj59UwiAcxdN37ihXwCJhm6wzsC2Ey54yvEYHgB4g2p3kW4Wt97buZCl45iU8y7eP1UjpyH409F3a0SZMVGxfkuBXM2AUBaYZ4OsAJnvxz02v/kp/EQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/Ot79Ka3ylzMUdse1N8TDc7OVs9rIx2vqffH3HRzzWY=; b=DmJBm4ljJcCsCC7gDnvxfyCpw1OgNvbF40cG9d9xvbz5h4kV6+kyEww/TEqSHtElbdHdS3no8/8uaJXXXWKrxKgPHwYfwpz+mPOL6206mnx5GGL8qelRaH7YQ9xyI4uF4kW/VkiCr7pyxI8oY1WUDqjX+9duTpxQDrD8/n3XIFV9ORUMSEuTfcFHibvYNqGVv7vuSbJzdEcn2miCX8zGybafMwmq3DsgwFrYPo34f7e9I7ObnhdTaiAgVFo7/PzukSysG0zr7u1qv9SN9Rp7lqS3Ius8sPjmcsqg+7nabWxnhmmDkaKxZloAuM5C9Fec3vx4Gdna/1VmfiVGIPpbhg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AS8PR04MB8387.eurprd04.prod.outlook.com (2603:10a6:20b:3f7::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Mon, 14 Nov 2022 15:30:23 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::48df:9a8c:c706:36b5]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::48df:9a8c:c706:36b5%3]) with mapi id 15.20.5813.017; Mon, 14 Nov 2022 15:30:23 +0000 Message-ID: <8c1844c9-4b04-0200-c24e-c33009562477@suse.com> Date: Mon, 14 Nov 2022 16:30:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] readelf: use fseeko for elf files >= 2 GiB on x86_64-mingw32 Content-Language: en-US To: Brett Werling References: <20221114150348.112815-1-bwerl.dev@gmail.com> Cc: binutils@sourceware.org From: Jan Beulich In-Reply-To: <20221114150348.112815-1-bwerl.dev@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0173.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::15) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|AS8PR04MB8387:EE_ X-MS-Office365-Filtering-Correlation-Id: a9298f20-9dfe-4ade-9bb8-08dac65525c5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oodeAL+kistKqZ6tVVujFGSYagsgEO35Ibt012oc2LBTWkuJCnhiq+uPHmxgph7do9W5sV3FJVmQwNEzb8p+749lnYbycRo/Sl2PEXj+pSFrzlgEHt9nu95ZCGyE2S/kzZuwaolA269Pz0ltFMmsaWuDp4YeGzQBc0J/sRsWu09Bzv2EceZ4HE/kB34Pk59JbcSHu9GXOhCOcjkTu50puSBOyhSrdh+E6l5phsu6kEVUCRO9RfhbYERQEwayV37Nc+EguazQUar0JIsMLZwtFzMJpIbSR1YI57zoqBOErLsfpfh+PvlLfpjVSMV8v9SncGjMtRgMzNmWKUzU6IzQxQ1v47cmwDHHJsnkWkN9oBah6/CtsGM/22oVpkbnchLhhX12QW565S78YH+zp7zK4RQRWbAorZeFfK+JqzqAY1vA8sChl+m0T2r1Lj85DZ2aC3qNPAKcn9k+clspkQbO6Xh+x7Bwdv49s9tolILrhDs3j6G3H0EXRznkYptzqg/RDUrPf6jvklUeakE4LsRqOLjZrV0yZKYpf2YadD+ceGIKMzLXq8c564x/tTTuSYS0lCltoPHe47/zCcxxO2eLKBiNd803++peiDea7zsVmyAQ4iD+jyCvz47Pu2TBJz2YMoS6UMn99RFc7Wic4J672gB21j1UQfVn9aHF/5uzGGfrBIhAoPHGyOEwvrPonn4TIkFelWOkwa8Xa5qzyQL5Ajs0C4Y6vYW524A/zfegT7tDGO/qROzoSL9uPhjXWxflKizpJUaP1sAq8KRxYCC+PNrh09QRnVzhcqsxJRPrUDk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(366004)(396003)(376002)(136003)(451199015)(66946007)(36756003)(8936002)(31686004)(31696002)(86362001)(6506007)(38100700002)(2616005)(53546011)(2906002)(41300700001)(4744005)(5660300002)(26005)(6512007)(186003)(8676002)(6486002)(4326008)(478600001)(6916009)(66476007)(316002)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UkdjNmZnK2RoeHJVeFhNUDlXRS9zVGpHU0lzcXpRS0JnN3lCQUFMWEladnlL?= =?utf-8?B?Tm1qSS9LVEd1dFRYd3hzdzV0UllDOXVqK0ZjQUJkSU4wMkVKS3paS0FMcWY1?= =?utf-8?B?Q3FVSExXMWpONnBXTENOeXVGaXJHRGNaWDVMLzV0R2Z6RGNmYkV2WHFIS3FF?= =?utf-8?B?bG1HQ2xKVVRRUmxZOUQ2enNLT0R2bFBFVEhZdTdmQnNPazR6VUJQc1VBT083?= =?utf-8?B?MzlSMXkxNFpKWjlCWTZXdkxnbWpCNjJydXFsNEhRYU9WNlRvbnQ0aVVwa0JN?= =?utf-8?B?RUZPSkV1L2V0R016OXE4dHVDS3JDbWdUejc5THRqeDZydGdHU2VKQ2w2ZDVO?= =?utf-8?B?dzNRV3BUVEw5Z1NoY29QaUZ5V3k4L2ZNS2FidkdYNE1pam4yMCtmUUhORCtl?= =?utf-8?B?YlZqVlNQalhKcTY3TTdxK2hLUW9HK01DRWo2Umg0V2xBMDJMdlRkSmNISjdB?= =?utf-8?B?eE5MdmQyb3orQm5QMmdJQTFJVHBkZE5PZzFUekoxS3JtRjNoNUp3TTFJQ0Nr?= =?utf-8?B?QWlKNklpNG1LZi94blA2ZkVCWXFjam1sMnJJaWJ2bHg0UXhqOXlWdExNTWpm?= =?utf-8?B?L2hrUzJycHV3WmdZdDYybW5pT1UvdU9MdmcyTHp5WEJFcHQ0Vlo1Qkpoamsv?= =?utf-8?B?N3FPbzRud2luVEM3RXhjUEZZNGo1elZuVG9NR2VpUjhGNFNBdjg2N1RNNDNp?= =?utf-8?B?S1lGTHFobzJ0K2N5R2tBaFcyRy83V0JsV0xlQmhsUldPUGsrVFBISVdsdFlY?= =?utf-8?B?ZGRORkN2MVlZb3dnSHYrK3QrYW9peXd6QkdYMXQ0RzAySGtISm5xUFdnWE8r?= =?utf-8?B?Um54K1FLYjZpMHJWMmltYzVqQXFndUdHOEF2Z0s5aWRLY3dLMEE4RzhJVm1D?= =?utf-8?B?TUh2QVFrejFHV1JjRnJiQjZJMDIzYzNxaGFJMzE4TUtUczFLNzBHeHJTampi?= =?utf-8?B?MXRvaXd4VWVjdUtLQTdHcysydXl2VzREek50UjVhVk9CWFpoeU1HdFNlTE9t?= =?utf-8?B?aEQrNUVMemJkMXdZcjNpSGtoY2xuR05pTlY0MHhvN01WSS9nSUxoWWNXRFFM?= =?utf-8?B?YVR6NHpCZFlxRHZScjlRSmtlaWVNS2dJcHBvcDR4T3FFSGZmOUd2MmFidmJu?= =?utf-8?B?THpORktvZElXRFFCR0hkRDlxYjl4TFBlN2lNR2Y1Z0NlS0Zkb2cwcko3ZlMy?= =?utf-8?B?OFgvYm9KUUhLRnNldmNEVXZvNXdVYWdDc3pPVkVxamJpdmRGZ3hYYmg4MkdS?= =?utf-8?B?NE1kaEQyem1DR0lvelRzR20yNklNWkp4S1hrZ1BjSEQ5eWhXbXlwZUV3ekdu?= =?utf-8?B?T2dZUE54UU5MYUdwTUFvVWwwUkdpMmhhU1N4c3Uza2E1bWlZRmZvYi9ENlVj?= =?utf-8?B?VVlmc1NpNWYxR2pBSXZ3VmZjM1FNZlF2T3lBK09CWC9ibHQwMjhCTE0wd3c1?= =?utf-8?B?S2xNVU1mSWNnYi9UWDk2NGx3SFNzVUlkMkxNVWRNSVlGV05vbm1PWTg4WjBl?= =?utf-8?B?VWZBRVFZb3NwZTBxODkrNGpCQUU5STVLdklKR2UyazJUNUFjWURKS3F0TGZ6?= =?utf-8?B?TzlIcFY0TEo0S0lwK3lqTnhaVDN4VHloRDE2dVd4WFQzMlI0M1ZreFpqRkht?= =?utf-8?B?Nk5pNnlkaTd6dnBlVkNPeW9pS05uZVdMUWFqZ0lFOE82QXdwV0p3WlZpS2k0?= =?utf-8?B?Y01iTThBeUhodkRyaU1PSnV1RXduWU5jb1NVMFVPWGhHZzNiRmROcHRDWGlE?= =?utf-8?B?ZlUrdHJaMndBM3hSYU5kemM1ZkttV3lmRW8rVEFMMVh6WVBlRHVtaHFiVWRG?= =?utf-8?B?VU5WTkk5OFBTUkQ2S0FRRndmSkh3Q2ZHTWxQRWIvOUlsbzUyZFI4ZTFEbnBT?= =?utf-8?B?ZkRyM0hjR2FVQ3AxTGpiaXFHMUR3cUhHVGZaUEZOOEhPbXc5YTZMSkFpTXAz?= =?utf-8?B?RVRYY3FUdEdUbU11bEJsdGJoalFJeGZNUXNhem40L0JaY3NOZk45Zk5qWFM2?= =?utf-8?B?eDhUeWxiN0dVN051aXIzb0lncHp0Q1lhNXUxVFJSSk9BRHRxR2NYc2NDU1d6?= =?utf-8?B?bEVkbENsb0xCVjI4VjZpYlp6QzFUSm1yZitnQnFOMWRiQkl1WVZyajVuWk95?= =?utf-8?Q?uY8oZVWm2YvPpPxj6Gpz+EnGv?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a9298f20-9dfe-4ade-9bb8-08dac65525c5 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 15:30:23.8167 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hAIX8+uZYS3ijuN7MW0IS3E+YO2rVEJwtE3H6y9F6KghBa/P5im/Nz/BftkeUtnokMzn9blZv+9vVz5bIdFLYw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8387 X-Spam-Status: No, score=-3029.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 14.11.2022 16:03, Brett Werling via Binutils wrote: > Switch all fseek calls to fseeko and cast the given offset as an off_t > accordingly. When building readelf for x86_64-mingw32, a long will only > be 32 bits wide. If the elf file in question is >= 2 GiB, that is > greater than the max long value, and therefore fseek will fail > indicating that the offset is negative. > > To work around this and support up to 4 GiB, we switch to using fseeko > and cast the unsigned long offsets as off_t values because the size of > off_t is 64 bits on x86_64-mingw32. Is fseeko() uniformly available on all platforms binutils can be built for? I'm afraid the answer is no, so at least you'd need to introduce some configure logic for this plus some abstraction. Jan