From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2064.outbound.protection.outlook.com [40.107.104.64]) by sourceware.org (Postfix) with ESMTPS id 6A4813858D39 for ; Tue, 14 Nov 2023 07:14:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6A4813858D39 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6A4813858D39 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.104.64 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1699946085; cv=pass; b=hvhCsb8H7i6bwfKaOGGAGm0Q0Yd1XoTSLOfR3DXLz8pGPEBtaK+rxaMEKhHEu6HRoF1a2bOimqAWQXSvJCmPSdMwNOPIIxj/nL7QZ02dI8MhJsuXRErQXxwdGfQUWvAuMuhYH9biARk9vNkGfVJfYhiIuLbDxFUNinGl569uwYg= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1699946085; c=relaxed/simple; bh=Ftx4M+0tuu2mITs6rB4gi6L/DH2XZ2cRvCf4zaC4tPw=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=I0ohWU1TVnCb5QWWtWvSjXeQjQlYMROZKWRiMJVjDKzj23dPvYBFMQtXxMdwgyR4oT/NtpCGpm0ZXYrP1RQ+zHHmp7lykOTcDI70JAAlvJIRR4ck9hOqbdXTQHBaET1fcdYESl2/+GoBpL3Bld/sdNMWLHsssQySbx/GwZ0arB4= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LZ7VhJrWntt3PRx2ks2m3IDr+gncZZdIJp0O9tbinJY7VeAqyl+GVkoruQ5aWxKRzLvNm6kr+HOZsqgkUi0OSW14/nixCCuhEAYs2ThKLpuNeOdQggKJ2L1gfh8L03iwDdfHFMJJZLP8KTee0fXIOovcfAHVTBFFMWXCI4d/cFNMEgDURQPsohgWJPMgq0fJdZ6ikagq0IrTABVR6I/qXfwCQl679tRtUMDU5qX4ehAfmE48W0zD2EdnToDMruAIw8MNQPZ5cMVdyKRB66dL6LLvzWSK4CR+UcjiwYe+9n992DwUXHR9IXImxu4e+NNL5vfe8PUw70knaoSSLKX4lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hnKakPmNvnkNTE5lr6vp9oDe938OOF//MxkABU1tdqI=; b=KE+567afHCgvpavrEDri2x9E8hfNxNraMMSjN2y1NWzlqj8gjKSE0FS8Z+K8jhQ+Kdw3WkjWYAer2Lc74dLFkZoTqG9v7cF3YjKMm4x/Cp2fV1mLQWdnqbSaYDNyM1hOspBnvSRLV/+pJHSe0qdBuk7BkqvrVhRL4EjCn+kuIB0fn7nVzMkkVgcX6Vhpbn/TIZL/oNTS0pulSEyisTx8hAe7FYdfpL0S+nSyvwCyLosPXduE1Y3oLUJx6hePyPGopt+EpXIBAGB7DIFS8k7v+iO3pNQVAjyUO9M66tJYIRLa7aZAOFjdVraGHjiFwRaaP38mTOUGNR5HpbtT8cmRHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hnKakPmNvnkNTE5lr6vp9oDe938OOF//MxkABU1tdqI=; b=tHMYRwWlSkwukmLMDuOWmoGICmJ8I+928OMCPMc2l2KEK4HKsfPS7D6Gu4a/3bI1K6jGcCFBzH12cvo5r4TCYIRXm19e+8etdbwBiwADJ1W/67vAMRy72Kk4SxYy8qWl9DOmvS+oOUBJLbcYzDUGEYyq8/A1bM60MDkVIeUk0hdeZsS0JwMC+JPb627c6LQJZjP2SgOpvYukpS+wteXLRN6v98q9uQScGk3Co9a+t64m1/6eQ1/iU7S62vBJjE+tDeiQMyiMMTnoZEXDP8GfEgaRq1u654S9+S+NVCGD+S8KQiGadrvTyfTWsddnmkCEC0W7F/Ie3a1XjPSnKM1ySg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PA4PR04MB9462.eurprd04.prod.outlook.com (2603:10a6:102:2aa::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.12; Tue, 14 Nov 2023 07:14:41 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44%3]) with mapi id 15.20.7002.015; Tue, 14 Nov 2023 07:14:41 +0000 Message-ID: <8c470237-ab0d-8927-af86-31e0f8d45752@suse.com> Date: Tue, 14 Nov 2023 08:14:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH][v6] Support Intel USER_MSR Content-Language: en-US To: "Hu, Lin1" , Lili Cui Cc: hongjiu.lu@intel.com, binutils@sourceware.org References: <260c522e-dbb0-7e40-1419-5bb269fef823@suse.com> <20231031021410.1543517-1-lin1.hu@intel.com> From: Jan Beulich In-Reply-To: <20231031021410.1543517-1-lin1.hu@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR4P281CA0398.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:cf::16) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PA4PR04MB9462:EE_ X-MS-Office365-Filtering-Correlation-Id: 72e9d3f1-e264-4ecf-d808-08dbe4e15eec X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VsvBlZRhrYW2R2zF2ycfRx+UmBj3VXqela9Mw7HlN+cmJQH0XIqzcUURhyXWIEpTrYWfspgu+gNfHi3eNYDt3yO37wAJRIVWK3wArw7smcUeT3QDqnWN7DZedwJ9fnOKMaEOj//JcytJmYXBTC9+5w0cEPvj1UYuDa0tKHXqK9u4tXFLklRx+01UGicCxismHk9wnEecqjYgdcjebxe2Doo5GzMqFuAwHGR26uGyoiTmecz/YBUFQcuS01F7LjNMkCVn6yhNRhJtzMhu5cwy+dcux6TKlpp3nNzB2ADDzyDvG4eigm3eHkqnFL+JAlk0ayWAvC+7xHaoLjt1OH3dioLnBuDFBzE7Hwv4ZgyHki54VHQe6BehNmLxAdsfK1EXPqPnv+PAGhbznjfb7PdFrLRTWk27zUB21KsMyoka3zAhjx+BlBg/6stTYopZd+YQ23HNEP137jPpNE160CgQ6PI2bcsBbRAPvD/m4ywqmerh6WQ2nXj9VK+PIGdUOTjGAw4Bjei66DNJ661/WnUt4ObN27re9QoLjKu1RBH1iO6TO68epViLuDoHawUG26eVVBwHgzKwQHJwWQFdSYnNuo3qpMZno8XKuwEkBzFkNh3i6GkAlP7l8NUpmALa8TNOxAjmJfpiNPeUDc7E5wxaaA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(136003)(346002)(39860400002)(366004)(396003)(230922051799003)(451199024)(1800799009)(186009)(64100799003)(36756003)(83380400001)(26005)(66476007)(316002)(66946007)(110136005)(66556008)(2906002)(4326008)(8676002)(8936002)(5660300002)(53546011)(478600001)(2616005)(6506007)(6486002)(6512007)(31686004)(31696002)(86362001)(38100700002)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U3FEcGpBUk5mbVpOWUpQb0lBRlNHcWRQb3lHN2V6VTh1QkhCdTdPS2cwWHpJ?= =?utf-8?B?MitLaHFyTXRuYWZseXlqT0V0QjBpQzVKYThaR05FektxZkNmTnhNZkhXOHZP?= =?utf-8?B?eUdtTk1MWE96dytLWmN6SStvU0ZCOHRXeTE1N28vQVRpZnZXVXJmZkhDZGlJ?= =?utf-8?B?ajYzV0dacEJSQy94c21Jd1FrWkVnMzc3bTJxNExTUE9vSzdCeUZoc3dxQncw?= =?utf-8?B?SHR0R0IzaDVsK012N2dGQ2p3eHNRaHYvekpoc3hOZHZwL0ZEaENUSng3Nld1?= =?utf-8?B?MUFRNE1mdWw0Z3BFczNmMTFtc3o5NXh3NHdQdVhKakk0KzdRZjRmVG1pVnp1?= =?utf-8?B?SEZMbTBON2ZvdFdBeks0Y1NhQ3BkeEtPQUhORHpTN2ZQbUZpU3ovcUVLUjNV?= =?utf-8?B?Y21kZ016Y0Z2ZEwycXhwRktTSHdYWEhkbFRtVlNBaXdONWIrNkZZS1Y4bnAy?= =?utf-8?B?RndQdlVTZnV5S2lRS2hpaENVL2d0U2QwMzhHeitiNGV4dnA2M2VmM2dJZVg0?= =?utf-8?B?dkVnbG5XTEsxc25xUWZRQXQwbXdBNEdsMlhIa3hJZm9kc3czWDJoZm1xU3RK?= =?utf-8?B?QTl2ZDFPdmVwd1hFd0hzbVRKdzkyeHlQVTRWeUplREdCU3gzVkh2aGlCU3ND?= =?utf-8?B?SE8wQlhBWVJOT0JNV2gxM3Fwd1FvdU1PZkQ3VnRzakZwb2YvdHZCZmN6SFZ5?= =?utf-8?B?VmN2SXZIc1hOSWNjVVduak9UQzc1RkRuSGd0bm5JcWttQzlERlBaZTZFNnY5?= =?utf-8?B?bENiYUxZUmdSOFA2Y0ZYMVJ0bHc0dXFUcHVoTlZqOWlmOTZTek50enAxWmdS?= =?utf-8?B?SzRpZldjZHBZalk3c2Y5cnF6aTNjK3c0QWI2NTQ3NXNxQmIwcnBtMnBoRkVy?= =?utf-8?B?UFd6NWFRQVVJaVZTMy9WQUE1K0FXL0dQZHBBOTB4WkhQS2FqRWlkZHlUazlL?= =?utf-8?B?T2F2dVlhN1ZYMXkxUTNhZkJFcDZyVkk3d0FudStQRExjVEJkNm9FU05EbytS?= =?utf-8?B?QU5WaU1nWGt1WXluQXUvemtjNkFPRmZjcmlwYm1BLzBQRzJrSDdjdkpCMFdp?= =?utf-8?B?VFBLSU92TGN1VnhXcGRnVTlBeVNLY0lORUNMTW8xVExTdW9kcTdmUDR4UXF1?= =?utf-8?B?UWc0MzlmTDFOMHlNZ3AyL3U3Ym96YkJwdVdYcHE2anVEK0k0Q2VNNFdaRFQx?= =?utf-8?B?aG14YzJxdXB5RzlLN2JTeXRjWlJsdDFHck42dVI0MlROQWdhYUlHQ1B1M2Nh?= =?utf-8?B?ZDZ0b3NiWDVONSthNnMwU3Y3RmFnbU5vbUpLMHUzcjVHNjBJZXhtSEVmU2xq?= =?utf-8?B?UWxodFUzNjFmRktCQk1ndCt1NTJBb2liQ2JLcDYvTU00TitRajgvSXY5cmRs?= =?utf-8?B?YUp1Nlg0MkdRcWp1UGwzd01OL0l2aFN4RUtTVUQ0SWh4dmI4R1BWYUgvVlFF?= =?utf-8?B?NHBYejVzZE53TkNwS1BhTjZIUFEzZVExQ2ZhZTZpTU1jY2JCMnp1OEJpQUxF?= =?utf-8?B?L0xTa2JLWmNUanplbk9VVFZmU2ZqOUJYUlFrelBKZTdFQ3hOempUejFUeVVs?= =?utf-8?B?RzBHb21UclBaMWNHRVE1eG02Z04wWDRIQUFDdThENmRENXAvN0loVlZxM1VR?= =?utf-8?B?eGRDMEdnK1Q3TTU1WHB2NThKcW4vZWtEd3M2dUlmU0ZEQys1N0JlSTF3aHRC?= =?utf-8?B?eG5KWmY1ZjF2bStRcmRjdEUzbUd0VGFUanZTLzNuRHh5a2dLQWhQZnEyemli?= =?utf-8?B?aE9BQ0NnTWhhTWkxZldiMnhXakx4OU96dVlveGltd3I5ZENFVWpXWVN3R0Ny?= =?utf-8?B?M3QxekNYZjJ6V0s4SmlWcWNsemZkdWloTjNZTEN6clpaUkNMcnJNR1JOS2R0?= =?utf-8?B?MjBOaGNGdkdMYmo4Z1EvNGx6Q3p5UXdoSjVvWTZ0UHhEN2g0Q0ZmUGhwUHg2?= =?utf-8?B?U0t5U3ZJWmRjaFRmZVBFemlVaVpUY2tIQWZ4eDVhZXhydEk3S3ozdlE3cXl0?= =?utf-8?B?b245eWd1ZmJCKyt5blB0aHpnajhwOVBjcGw1NGlaMFZ3aW1PVUxRVlNZOUZZ?= =?utf-8?B?TzVYMWlaVWlUM3ZxQThHaHFzTHdmVk5lMlBmN0V2QzNBTVNKb1k1M0paRXg5?= =?utf-8?Q?h0Efc8GJM6VLRsf261WNfYK0X?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 72e9d3f1-e264-4ecf-d808-08dbe4e15eec X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2023 07:14:41.6123 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9X7QZilzXxfOHGzY1cdbV8aiZNfn57qwRz8/2I/ARMHLvPotklIRGQIPLcjyxSSeE6rW0seP3cDDnEyo875VqQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9462 X-Spam-Status: No, score=-3028.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 31.10.2023 03:14, Hu, Lin1 wrote: > @@ -3346,3 +3348,12 @@ erets, 0xf20f01ca, FRED|x64, NoSuf, {} > eretu, 0xf30f01ca, FRED|x64, NoSuf, {} > > // FRED instructions end. > + > +// USER_MSR instructions. > + > +urdmsr, 0xf20f38f8, USER_MSR|x64, RegMem|NoSuf|NoRex64, { Reg64, Reg64 } > +urdmsr, 0xf2f8/0, USER_MSR|x64, Modrm|Vex128|VexMap7|VexW0|NoSuf, { Imm32, Reg64 } > +uwrmsr, 0xf30f38f8, USER_MSR|x64, Modrm|NoSuf|NoRex64, { Reg64, Reg64 } > +uwrmsr, 0xf3f8/0, USER_MSR|x64, Modrm|Vex128|VexMap7|VexW0|NoSuf, { Reg64, Imm32 } Actually I think the choice of Reg64 here for the operand specifying the MSR index is misleading, even if in line with what the doc presently says in the Opcode / Instruction column. For both insns the description says that only the low 32 bits are used (and the Exceptions section confirms this). Such operands, however, are expressed as Reg32 everywhere else. I'd like to suggest that the spec be adjusted, and I'm heavily inclined to change binutils regardless. Thoughts? Jan