From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id A15C03858C53 for ; Tue, 6 Feb 2024 23:15:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A15C03858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A15C03858C53 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1707261312; cv=pass; b=OXgHImFAjwvdz/paHg8BYRwt7Sy1xR1rRvbHDwjBrdjkgUcD92Yh9TITF5gOZVa3TApVgZGm3VTnb10K4UDdvgzNlvS4njE213Y4u2BjP8LU6oDCheSzEabf6rfcOnLSdXMirJktHc/MvfCFF0Rmzj22eb8zERhNE+iTwwgE5uc= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1707261312; c=relaxed/simple; bh=MQSWb5CtQbjNP+IWY/dvthRA0Rr6YJ2RkKQKuyRwNuc=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=JwBpSGOnQNNfft6P7t3vllDt/l51w0WJvd63NmexunCNhlYc/tQrM1tt6bXIuoR8kyYcVqRTD10469gKThtmB8s/ObqvbBMpTEv9GVwg0Gjgv/beb+Hgc2g8bq2ACarbli6fPHc1CAlZqbXIrPMucDGwD0wvmfn3SQlmGbCETG0= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 416N3l9g018036; Tue, 6 Feb 2024 23:15:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=UiToVzjYJ0hBTd+tBA/JvYLCd4fhACRwpFEFAe+OlWU=; b=ZHrJy/tHfpfsRq5TTS5kmxeFJTILNX3BabQDm8aoLfeYSdzuq5neKc1rjpP3rwzIuKH8 xM85vRHEB1XqpcUOO25SMa64VY9ukRNAnfZOjJ8Gx4TVenG8XvmMoL8kw0iahEe4mPgR lmiPjWhdV0B8p6RXjRhDx8/ZSbBZZBPb2eKLgE5BFlgBJHwRUX+bOb/pMQGLAegQzVSa zSpsxx6SLxKIw5ggvVLvRcWyaF87kVmKy9/6qlOMlp0/MklrmdFXyyTP2RVgy0YbUsp+ IjBJFlKR7KooTrxMi/R3BAMHVuSzxagJji9iujMEbtskGTwLvbk38A/5hVSaR4zmaLFP DQ== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3w1dhdgbby-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 06 Feb 2024 23:15:08 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 416MUJpr038686; Tue, 6 Feb 2024 23:15:07 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2100.outbound.protection.outlook.com [104.47.55.100]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3w1bx7wmmm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 06 Feb 2024 23:15:07 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eVQlJ28LxIw77EJx/0fp9vsCkhlO8Gcgb/eoMovqaXsNf++9CaTg90VsM/MQIfhKZP91GnFtaesCyMcfjhY3Coc7IApNMkJQolN00PjTnhYfqVi4c9FoRN3HlmZaB10ly4KPl8iDrzYgaMPcUb2ghceBK2sQnRXlGnp22EiE4tmPuokUb7brTOjRkMYa4uAJytpPLM9dRGVE+K39XtMFVK9sUDq0PitTdsuXCawE5utc2dyLsLehHZuhf/37aAqcFZO0K8hYFMi/Seh8ab/OwS2yfRreaFhwSGo+9TVgLYgWv4KILROur9vOZjebsS9wDdUlY0KxkOOheNW9m3wyew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UiToVzjYJ0hBTd+tBA/JvYLCd4fhACRwpFEFAe+OlWU=; b=U7K1aUKdcttgLBJDSFDDB8xddh/ts+6DF620SEm1i8R/Q2ACKeCCpRgb6x/3/suogKpejy9kN7Blz7Qm83/DM/BmyOw4Efi/+LZn5GkJDOnviLAacg1XJFhJW7jgmDiY/jHfzPk3PCsyfE7ZXm8y1LmMyx4FpuY7iyCoj4RZWMpC7qK2Ix5W+5wk4TuHibfrXinC2sD9RcYT/vkO78WZeh5/2vICJgYq57Fc5eXR4pvBQBoM0XSUAuOY4hcPzzhXqbxFPIYpOhhcuPVILzKNN5zJIKHVZbAGzAJJwlNmzhjJZCZRMJTesKdDmyf8Iz7A03/sYHUkvW6ZmkXkIj97MQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UiToVzjYJ0hBTd+tBA/JvYLCd4fhACRwpFEFAe+OlWU=; b=ag5FV+bJ52fJIMpIZKgxQ5gHKOzybOM2cGCu+MHz6NVcfp9eo6jqvm5VhCUUY3PB7fUcs2oYm3Y4RinKjNLpS/q/R8AzIPKmtXvH8dK9tH1c+BiH+fBO9KswAMFY8ldlyc3YM6AzylKeS1gkKWRQg1rOqQNvmThUt2IucU/6EWs= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by DS0PR10MB7222.namprd10.prod.outlook.com (2603:10b6:8:f2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.36; Tue, 6 Feb 2024 23:15:05 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fde7:fb92:8ea1:a5ac]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fde7:fb92:8ea1:a5ac%4]) with mapi id 15.20.7249.035; Tue, 6 Feb 2024 23:15:05 +0000 Message-ID: <8c584403-2d51-44e7-9eb7-45a971e6694c@oracle.com> Date: Tue, 6 Feb 2024 15:15:03 -0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86: change type of Dwarf2 register numbers in register table Content-Language: en-US To: Jan Beulich , Binutils Cc: "H.J. Lu" References: <2384ac80-6530-4097-8d60-d37336aaa341@suse.com> From: Indu Bhagat In-Reply-To: <2384ac80-6530-4097-8d60-d37336aaa341@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR03CA0136.namprd03.prod.outlook.com (2603:10b6:303:8c::21) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|DS0PR10MB7222:EE_ X-MS-Office365-Filtering-Correlation-Id: f4bba0a8-1954-4e01-181d-08dc2769743f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GwatI5u28h/1Jwk3VzJi6BRWrP/uRMw/fz+1wScVvyAovzCg/D1fpaUWzq4kfd3Y2zGEqpKcYzsfVSR2AOvyVSb3eidiwcuZlBwwOWrNp8Z6PRBalgGLEwfEBerSBoNZnBpZJ8wYHtHwz5kUvlpPIf2jc1dz3HVWChOlCU1hnsPCcmTT3qOfx9rfBLikmjL+9z1i0uLQTuv6KAc0nyMLPv/bHBVlwAWL1xzWdBn5ygkx8aWrJJY9YYxJmh+jESuZLkQjxBgVaegPQekOLkMuh+i8deejsvXrHkoMuQrNpZPzFVmg4AHudd1NMn03r6AAxvzoUmfqc66YyjNnr+T2IS/c9hJpxwIozVHO/4M4EwwPNKrOQtpDD2w9Z/Hqh8JbWhq0pfJil72xtr8MnuRSvUGgggGzMdABIS1b4A+buDQbFPmOoV315DXoX7VyQ/ZCBxBUkXN3O4hSl9214tY0thko5H9c9lUHwl6wFqUtui0msJh3nNIp4nLSR4NS6+MazznI9q8UKzCSL9W1+pcYouFvQRaZjGvLxy3AXHJ+7BYnw9Boe96O17q/tHzFRGGLp5tiv2jrbVRiQmXirtY1yJLKT8r5iZGqoRkn4gmKIHsnMytK8TZ9LUpL4To+zW3hmmXDWdh9TwFTSPyjKepJQw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(39860400002)(376002)(366004)(396003)(346002)(230922051799003)(64100799003)(451199024)(186009)(1800799012)(86362001)(41300700001)(36756003)(66556008)(6486002)(66946007)(66476007)(6506007)(316002)(53546011)(6512007)(478600001)(8676002)(110136005)(8936002)(4326008)(38100700002)(2616005)(83380400001)(31696002)(5660300002)(2906002)(44832011)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHRLQjhJVXMzalVmSHo5bWRWR3o4Y1hOVjYvME13VDdxM0xjZC9mdXovREJ3?= =?utf-8?B?TktXOWJzekpxcVVtRitoeTVuVXFtWjRlOVRtaDl5RCttM1RtS0JIL3NpYnlv?= =?utf-8?B?ZGZNTFpRTWdVUEhUeHpHTW5aQ0szaTU2RjY1UDNHQ0o4dlBReDdxZTdLMktF?= =?utf-8?B?dDFTMC9kcWlGTForbXJuNmVuaERLaDY1Sm9wWXNVeE83TzFESlRmeFV1L0NL?= =?utf-8?B?cWRSSURUS3BzM0NxWU9YU0ZmWklGNlpqU0lYaXZjd05JUDJvL1dzd0lZaWFL?= =?utf-8?B?eEhKRHoyMjIvQUNvTWdGVmkxSzFrZXpTUWRWUXk1dTlQWkNTdHNFN2RkVTJ6?= =?utf-8?B?ZmxNeWd1Z0FZN29wMWlzQndoeVB2VFZ6TzNTZ3dBbDRzRkZJeElNSmNaT0Qz?= =?utf-8?B?ZjlQbHdHdlo0K2FGUEQ0ZC9MSHZ4RDdTY0FWM1ZpSE81dDdWVVNTTUxvb2pD?= =?utf-8?B?dW5Bc21wdFc4S05pRk55ZWVzQ0JHelRlLzRrRk8vN2RwVG1JVVUrbGhSTUxK?= =?utf-8?B?TDlydmFuMnFhcUoyZ2d5MUYrNllXd2hTcXZCaFFFN0FUUS8xdlBWcFVPS2h2?= =?utf-8?B?UlRuaitUZUFtdi9UZGd5MlhIeSt3K2JpNnQ5dEhtL3F4V1JQd1hRdFNCTDEv?= =?utf-8?B?NCtaZUt6b2JDRGZhUC9KdE9jbHNDUG5uYk5KVmZuSG9ZejVpWkM4ZytRSW1L?= =?utf-8?B?NmFlMnBudTRUVFBqTkFtaEtzUmsxYzFQTGZJUU5aNS8rNDB6SHJHRWNJMzlB?= =?utf-8?B?WTdJbS9WT1greDB2U1QrdzFhSTQyc1MxZ3Y4NlpnbU1sZG40TzdlVVhydEI5?= =?utf-8?B?TVI5TFBXOEJvcG1VcnJRVDVxaW41SStqcUE0T2JWRkU5SUt1TFRiQm9wZW1a?= =?utf-8?B?MnpKMERnemZ2Zk8vZHVZRzUwUWtmbDZTbWdWMGVMbGZObzBmRTRTSkF1NXpk?= =?utf-8?B?TENrSTJ2ZE4zYmpVVWJNaC82VGR3SHFBOHNIRkZBM1hXNUdhdVBXcGFjd2Iy?= =?utf-8?B?NXVrYUF5MGFxeHBDRmpVQVZqa1owSGhMSzhSMWJCUkczcEFUQW55QTFtVmRL?= =?utf-8?B?UDQzaHdQamwzMDl5SkhzNmZ6SUtwMldkRXdjVFVaSnZMZmIvdUxEcWxzUTBO?= =?utf-8?B?TU5UcDBTa29sUE9PcTRrYnl5aVpobkhML0xWbDB5dmlPSmJVM1YwNUdqUVZQ?= =?utf-8?B?WC9XMklqYUxZZTl1eUR1Z01zRS9Td3lXV241NXN3YS8xZXNGR2U5bGY1L2hx?= =?utf-8?B?cHJaUzkxeW1YbldreUo3TlFSSHdpbEV0R2xMeDdpdUV2OWJqcHNjZW5UdHpr?= =?utf-8?B?ZGxxYVN4VFI4Y2RSSk9wZ1lQV3Nmclk2dGc3SjZnNUFFZkxMMVVEeWN1WkV5?= =?utf-8?B?TDJET0NXTXQ0NGtnSkE5T1RFZ3d5LzNzT1FJUFRGclZhV01ZYW1jNVIxUGQy?= =?utf-8?B?SWxBOG55K3BITWZwNzNZOVZLODdqTGd1OUI3enh1dnNTQXdaOUo2YU9mWXVL?= =?utf-8?B?Nk9MdWpGbm9SVFRxdXpjZmdRQnhQUlBtZ1JCV2lBSGJpek9vOWF3aFppRFBT?= =?utf-8?B?a1ZWTDBlVGM2dkNtVXpFSjh5RkJncHBaMmpRSW5zNW5NajBoS0IxQUljUDli?= =?utf-8?B?NkhrRTU1UEw5TlI2SW5WSjVMZ1F1eEJ4WEZMZW1BNCtzRWExNEZla0dybFdQ?= =?utf-8?B?Z1diVEp2MlE1aG81NERQWm9Cc0dVZENQTjBuQitMT3lBRUNFb2ttUDUrZHd6?= =?utf-8?B?VlUxUlZBd3p3M3Y0Zk9BOE5HNlZ4UzgzVUZHY1BpZm8yMWhHelByNnBRbDJ6?= =?utf-8?B?UWs2WEtMTEo1QW15Zi96TWkvakc0TkF3VHRRRkZBMStDYTRUcGdkYkZuRFNW?= =?utf-8?B?aGRDNjNpc1h6cUIzOGh5RWxadVVBa1N3QWpaOEl6YzlMeDlXL1lWbGRxQloz?= =?utf-8?B?eGxUVjRrcExuUTRsRE9Uc3REcUdURUZoblVUUjJXa1J4M2tHelM3aU1kWEdS?= =?utf-8?B?VmtGcFRDWFVpRUgzVDRCYmxiVFV0QlFUUDBQUFRUcHZKZllvazhad1FvTHdv?= =?utf-8?B?Z2psVVVHMEZ3NWtqNTduRFJqVDF2aVpDVW5YWjZmSHR4RElNUUl6VXRUUklY?= =?utf-8?B?ZlQzSzRlTEYzZHdBaU91elVZM2VWRzJLV1pCeEtmRVVsSktvWWpWOHNGY3JS?= =?utf-8?Q?DToDpkGyBYecvNBUDMBI0Gg=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 0o92aNzJ+dyq9Wp865HToFVwyL4qozAOJ5lUomq2oyezYebIqDvR0HuIYnKAG527mSHqyzR3erfN3Q4DUQyJT3QZoDj7Th+EIaeYRMLow1HNx8ypFQ3M+c11IRe/zhmxsFTg4/TdF+vsgQC/GUmbKX3G66oeKfyYgBo4p0db26SzywFMINhqAuFP9mViys7vmtbQO/jszc59ILA6xbSEnyxUV8ZTtWQ8tH+iMllzSAjYvR2y6KyBElplah+TjmOyWo+YxT78uVYTcNm5nWu08+Ee6aktLEY+6iAw/TTMNzZYZ7Nqcv6svMnnR1WtuDKRTkPv6os4AZh5Id6IcrA3TjYnDBCE98WipOywKZeLkXBddhZtE1rcmUfFr3M92pJu7oIBxPDijW6O3/n+/PpnjTS8yjmoc9M5Q2rPO5HkstX5rodlU+Is/pND3Rk2t60zs20DaIwcDvSQ5Jmv5PrMM+dizIEE9+Trg6egPCGuW7g0Ds4sHJBxf3gPoO1L+W8A2JGlgGNQmLtLQjI75Ue5ZjaqdH0GfvmV8GA7kh4S4l+8DP/+9mSNVXRMSgenv62bXFwAqmHrqMlUcRtzDu87ehFR782FAjxUOkXQ3AS1O8o= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: f4bba0a8-1954-4e01-181d-08dc2769743f X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2024 23:15:05.6187 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZDd1+rBjg9PI7aizZR+uT+wX/ge9aWtl1/dNkOAPZaiyNvukeL/W+ZEMJkVUhZbxcohZPozJLyuNc6aBINjGDA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB7222 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-06_14,2024-01-31_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0 mlxlogscore=999 bulkscore=0 mlxscore=0 phishscore=0 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402060164 X-Proofpoint-GUID: wSCjnKoU__o_EXYyKGc8XupREzRPBmIm X-Proofpoint-ORIG-GUID: wSCjnKoU__o_EXYyKGc8XupREzRPBmIm X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jan, On 2/2/24 02:25, Jan Beulich wrote: > Already the %bnd registers used numbers beyond 127, and eGPR ones are > all out of reach for "signed char", at least when CHAR_BITS=8. Switch to > "unsigned char", covering appropriately in places where the value > returned for "none" actually matters (in tc_x86_parse_to_dw2regnum() > this is actually achieved by altering how X_op is set). > --- > I question the use of flag_code here, btw: Imo the choice ought to be > tied to object format, not present assembly mode. Thoughts? > I dont claim to have a full grasp of the matter yet. IIUC, we need to use flag_code as DWARF register number will differ for 32-bit reg vs 64-bit reg? We do the other set of conditional assignments (to x86_dwarf2_return_column, x86_cie_data_alignment) in md_begin (). What I do not understand is why are the assignments (x86_dwarf2_return_column, x86_cie_data_alignment) not re-done in set_code_flag () as well ? (Consider user/compiler may pass a .code16/.code16gcc..) (..And orthogonal to this, I see that SCFI needs to fail elegantly if .code16/.code32 appear ,i.e., when flag_code != CODE_64BIT.) > --- a/gas/config/tc-i386.c > +++ b/gas/config/tc-i386.c > @@ -5395,10 +5395,8 @@ ginsn_opsize_prefix_p (void) > static unsigned int > ginsn_dw2_regnum (const reg_entry *ireg) > { > - /* PS: Note the data type here as int32_t, because of Dw2Inval (-1). */ > - int32_t dwarf_reg = Dw2Inval; > const reg_entry *temp = ireg; > - unsigned int idx = 0; > + unsigned int dwarf_reg = Dw2Inval, idx = 0; > > /* ginsn creation is available for AMD64 abi only ATM. Other flag_code > are not expected. */ > @@ -5441,7 +5439,7 @@ ginsn_dw2_regnum (const reg_entry *ireg) > > /* Sanity check - failure may indicate state corruption, bad ginsn or > perhaps the i386-reg table and the current function got out of sync. */ > - gas_assert (dwarf_reg >= 0); > + gas_assert (dwarf_reg < Dw2Inval); > > return (unsigned int) dwarf_reg; This cast can be removed. Thanks for the patch. > } > @@ -17459,14 +17457,14 @@ tc_x86_parse_to_dw2regnum (expressionS * > > if (exp->X_op == O_register && exp->X_add_number >= 0) > { > + exp->X_op = O_illegal; > if ((addressT) exp->X_add_number < i386_regtab_size) > { > - exp->X_op = O_constant; > exp->X_add_number = i386_regtab[exp->X_add_number] > .dw2_regnum[flag_code >> 1]; > + if (exp->X_add_number != Dw2Inval) > + exp->X_op = O_constant; > } > - else > - exp->X_op = O_illegal; > } > } > > --- a/opcodes/i386-opc.h > +++ b/opcodes/i386-opc.h > @@ -1051,7 +1051,7 @@ typedef struct > #define RegIZ (RegIP - 1) > /* FLAT is a fake segment register (Intel mode). */ > #define RegFlat ((unsigned char) ~0) > - signed char dw2_regnum[2]; > -#define Dw2Inval (-1) > + unsigned char dw2_regnum[2]; > +#define Dw2Inval 0xff > } > reg_entry;