* [PATCH] [PRU]:ld: Fix __init/fini_array_start symbol name
@ 2019-05-06 20:24 Dimitar Dimitrov
2019-05-08 13:57 ` Nick Clifton
0 siblings, 1 reply; 5+ messages in thread
From: Dimitar Dimitrov @ 2019-05-06 20:24 UTC (permalink / raw)
To: binutils; +Cc: Dimitar Dimitrov
The __init_array_begin and __fini_array_begin symbol names are a mistake.
There is no reason to deviate from the standard naming.
This patch fixes an ld-elf/pr24511 failure uncovered by:
commit a288c270991de1578ad28ac312120f4167347234
PR24511, nm should not mark symbols in .init_array as "t"
Note: I have fixed crt0 locally, because the newlib/libgloss port is not yet
merged mainline. I'll resubmit updated newlib patches once the GCC port is
accepted (hopefully soon).
ld/ChangeLog:
2019-05-06 Dimitar Dimitrov <dimitar@dinux.eu>
* scripttempl/pru.sc (__init_array_begin, __init_array_begin): Rename.
Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
---
ld/scripttempl/pru.sc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ld/scripttempl/pru.sc b/ld/scripttempl/pru.sc
index 933a1f9690..9ef798082f 100644
--- a/ld/scripttempl/pru.sc
+++ b/ld/scripttempl/pru.sc
@@ -119,11 +119,11 @@ SECTIONS
/* CRT is prepared for constructor/destructor table to have
a "valid" NULL address. */
- ${CONSTRUCTING+ __init_array_begin = . ; }
+ ${CONSTRUCTING+ __init_array_start = . ; }
${CONSTRUCTING+ KEEP (*(SORT_BY_INIT_PRIORITY(.init_array.*)))}
${CONSTRUCTING+ KEEP (*(.init_array))}
${CONSTRUCTING+ __init_array_end = . ; }
- ${CONSTRUCTING+ __fini_array_begin = . ; }
+ ${CONSTRUCTING+ __fini_array_start = . ; }
${CONSTRUCTING+ KEEP (*(SORT_BY_INIT_PRIORITY(.fini_array.*)))}
${CONSTRUCTING+ KEEP (*(.fini_array))}
${CONSTRUCTING+ __fini_array_end = . ; }
--
2.11.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] [PRU]:ld: Fix __init/fini_array_start symbol name
2019-05-06 20:24 [PATCH] [PRU]:ld: Fix __init/fini_array_start symbol name Dimitar Dimitrov
@ 2019-05-08 13:57 ` Nick Clifton
2019-05-08 19:08 ` Dimitar Dimitrov
0 siblings, 1 reply; 5+ messages in thread
From: Nick Clifton @ 2019-05-08 13:57 UTC (permalink / raw)
To: Dimitar Dimitrov, binutils
Hi Dimitar,
> ld/ChangeLog:
> 2019-05-06 Dimitar Dimitrov <dimitar@dinux.eu>
>
> * scripttempl/pru.sc (__init_array_begin, __init_array_begin): Rename.
Approved - please apply.
Cheers
Nick
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] [PRU]:ld: Fix __init/fini_array_start symbol name
2019-05-08 13:57 ` Nick Clifton
@ 2019-05-08 19:08 ` Dimitar Dimitrov
2019-05-09 9:29 ` Nick Clifton
0 siblings, 1 reply; 5+ messages in thread
From: Dimitar Dimitrov @ 2019-05-08 19:08 UTC (permalink / raw)
To: Nick Clifton; +Cc: binutils
On сряда, 8 май 2019 г. 14:57:28 EEST Nick Clifton wrote:
> Hi Dimitar,
>
> > ld/ChangeLog:
> > 2019-05-06 Dimitar Dimitrov <dimitar@dinux.eu>
> >
> > * scripttempl/pru.sc (__init_array_begin, __init_array_begin): Rename.
>
> Approved - please apply.
>
> Cheers
> Nick
I don't have write access for binutils. Can you help to merge it?
Thanks,
Dimitar
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] [PRU]:ld: Fix __init/fini_array_start symbol name
2019-05-08 19:08 ` Dimitar Dimitrov
@ 2019-05-09 9:29 ` Nick Clifton
2019-05-09 20:56 ` Dimitar Dimitrov
0 siblings, 1 reply; 5+ messages in thread
From: Nick Clifton @ 2019-05-09 9:29 UTC (permalink / raw)
To: Dimitar Dimitrov; +Cc: binutils
Hi Dimitar,
> I don't have write access for binutils. Can you help to merge it?
I have done so.
Would you like to have write access ? If so please could you fill
out the form at the URL below. You can use my email address as the
approver.
https://sourceware.org/cgi-bin/pdw/ps_form.cgi
Cheers
Nick
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] [PRU]:ld: Fix __init/fini_array_start symbol name
2019-05-09 9:29 ` Nick Clifton
@ 2019-05-09 20:56 ` Dimitar Dimitrov
0 siblings, 0 replies; 5+ messages in thread
From: Dimitar Dimitrov @ 2019-05-09 20:56 UTC (permalink / raw)
To: Nick Clifton; +Cc: binutils
On четвъртък, 9 май 2019 г. 10:29:02 EEST Nick Clifton wrote:
> Hi Dimitar,
>
> > I don't have write access for binutils. Can you help to merge it?
>
> I have done so.
>
> Would you like to have write access ? If so please could you fill
> out the form at the URL below. You can use my email address as the
> approver.
>
> https://sourceware.org/cgi-bin/pdw/ps_form.cgi
I've been granted write access.
Thanks,
Dimitar
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-05-09 20:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-06 20:24 [PATCH] [PRU]:ld: Fix __init/fini_array_start symbol name Dimitar Dimitrov
2019-05-08 13:57 ` Nick Clifton
2019-05-08 19:08 ` Dimitar Dimitrov
2019-05-09 9:29 ` Nick Clifton
2019-05-09 20:56 ` Dimitar Dimitrov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).