From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by sourceware.org (Postfix) with ESMTPS id 557C13858D20 for ; Mon, 12 Aug 2024 07:39:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 557C13858D20 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 557C13858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::62d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1723448390; cv=none; b=B5kW5mq/Z7DRyhrbyOgYTrbfxPTm+MTZ/wzOe/ONg4qm33qBxAIZDt2QyW0wtXLJJQqIjAbu7niGRLqnTAfdjIqOQzwXUleggWbUOlzm0tKlRWvt79drx2D3CEOvfqFH2rjGovF9OBdU+8/57TBUih4vVIuGs0wJgoZ0hVtV/Sg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1723448390; c=relaxed/simple; bh=Y4jk7r0947zfJv4hsIb2maQ0T016bsbSUf6dPO2Jikg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=QVAQ8MFM/ppzpOQ0e2qhd7bEi1hVS7cCr1HibQ2YpINkAVfprs6Q+CUocp3mgm0QWBD+DvYFeRKQn2ajwAnoDzxVQCAeUyHcUjWdvsff6qFe386bAxrUqxT/7O8w4Tq+y2YDHq0Pnf7rYWjOX+FCZiZKVGZVb6amIVwVD7VP0/k= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-a7aa4ca9d72so484065166b.0 for ; Mon, 12 Aug 2024 00:39:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1723448387; x=1724053187; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=GtRCElXUYpCr4L8R5kWue99v485ExI1a6fKwN20RuLU=; b=CpGvaocW7DaDBdztShmETa8qrLUmeHqnMNo/hx2mCx7uadZJLQrMn0UTYzT3v2k+/W W14m5KdUWnRQhPV0ougtGVUIZ4gnQ/yJYA3pUyH7I1YdimvkJFWPpv8TlpOMcGoZYYbK YSlMTZke4Afn/09KW1z3Cdm84KIzJP3gBIRKI/6kLyt6sk01s8pEbJyRKFdHHT8akg8c Sa3+KEMb+WMcB1DioPnE3pdILs1FzWKXUR+pLWaRXjEA4lujQkpg87LLvBDeb8sHtHA0 nCHeLm9wL+Sc79CWn3lRwpXopPMbnhFEHX+RGizDng8d5294rgG6rc3Et2zA9hbHKCxT LceA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723448387; x=1724053187; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GtRCElXUYpCr4L8R5kWue99v485ExI1a6fKwN20RuLU=; b=kMhOmmV88WzBvtawpg+l1rjTBpxWopR65G2mVGRgzu68N3s8ENSk/4I+JChEQnWmez SHLN0sakhMn+vVOtM/Ju3BJkX/sitUPZdKQdd+zcGjhW645v0zBKwx2FudecrNv5KQG4 aYeU89FtnKW85DD6c32GSOFzuhoiGLVr7mk3dhxwcirTxyECLviUAdZjI3ljY6N2HZyc GGHS6I7G32POIqOWC0+0OZ4GXslEYla0QLS+ckCAUWThaqD5fatcD6y9fYgFRWZRdu4T /kHd9/S4Fv3wJaT5UAoagMgzFPQij6veHf1jG9fydzRY8ykRotflha0EWp1pgYhaX/6W jsEg== X-Forwarded-Encrypted: i=1; AJvYcCW8TZGoLMlIxSvBQObVPDXdJR7zMztHAUaOYZ7ZN9yzaoB/dVli/OD8dnyMMlJmY5ojPngzlOeA6292Lf1khq34/ijcoQrj0g== X-Gm-Message-State: AOJu0Yy+JC5GNnwx7VIQpS6WNhBLnHUq8QPpneWbPtU3QBPsC/rNlbpl zFUQ2nqjlf5lo1T3ZnP4OnOE+Kr8TpEKbbsqSvO+cf0P5aJwomvndDRO56vDNg== X-Google-Smtp-Source: AGHT+IGpQM02NVamP6cQpw2RJmwQyIf5sUZB3R09nOaKYyWgAs9I5hgLrmQXjAP+CcOZZUNbndW8nA== X-Received: by 2002:a17:907:f183:b0:a7a:9447:3e91 with SMTP id a640c23a62f3a-a80aa5e5725mr627965566b.39.1723448378677; Mon, 12 Aug 2024 00:39:38 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a80bb212ffcsm204489666b.169.2024.08.12.00.39.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Aug 2024 00:39:38 -0700 (PDT) Message-ID: <8cb9a0b8-c6ba-4eb5-ac10-bc2b1dcb7b52@suse.com> Date: Mon, 12 Aug 2024 09:39:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] gas: Add a macro test with expression argument To: "H.J. Lu" , Sam James Cc: amodra@gmail.com, nickc@redhat.com, binutils@sourceware.org References: <20240811231107.590443-1-hjl.tools@gmail.com> <20240811231107.590443-4-hjl.tools@gmail.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20240811231107.590443-4-hjl.tools@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3023.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12.08.2024 01:11, H.J. Lu wrote: > --- /dev/null > +++ b/gas/testsuite/gas/macros/arg1.s > @@ -0,0 +1,7 @@ > + .macro test arg1 > + .byte \arg1 > + .endm > + > + .data > + test 0x10 + 0 > + test 0x10 + 1 So this is precisely what that entire change was about that you're proposing to revert. Within binutils, instances of such broken macro invocations were deliberately fixed up front. And the NEWS entry the commit added also is very clear about the above no longer working (and never having been guaranteed to work). Just look at it the way it is textually present above: Knowing that macro arguments don't require commas as separators, how many arguments do you see? And no, using knowledge on the internal workings (brokenness) of the scrubber is not allowed to determine the answer. (My answer: Three. And that's what gas also should determine.) If, purely from a practical / pragmatic perspective we'd really need to keep the above working for some more time, then I expect we'll need to invent a mode within which we can warn about such broken macros, telling people that new behavior will be enforced in, say, the next release. Otherwise how do you propose we ever address (without heuristics) the issues that the changes at hand are actually aiming at addressing? I did actually think about possible transitional states. Yet I didn't figure any that would be halfway sane _and_ useful. For example, while we could add a command line option to request old vs new scrubbing modes. To be useful (for the purpose of fully transitioning sooner or later), that ought to default to "new", though. Yet then people will need to fix their code anyway, just (possibly) by adding the new command line option instead of touching assembly sources. And then: I deliberately waited for comments much longer than I would usually have done. No-one really cared to comment on the changing behavior. And hence I'm a little irritated that now not just a possible workaround is suggested, but outright reverting. Bottom line: Clearly a NAK for this testsuite addition. We must not test accepting input in ways other than (more or less) documented. (Documentation isn't great for macros, but the possibility of not using commas to separate parameters and arguments can at least be derived from reading what's there.) As to reverting the two commits while working out a possible transition path: I'm open to that, provided some constructive comments actually surface, so we / I have a way forward. Jan