public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] opcodes/i386-dis.c is not thread-safe
Date: Fri, 17 Dec 2021 15:23:41 -0800	[thread overview]
Message-ID: <8d2cec0e-ef70-96ce-d705-1c7e57ac6334@oracle.com> (raw)
In-Reply-To: <d48303d8-0b82-58d6-fb1f-464b3c148d5e@suse.com>



On 12/16/21 23:24, Jan Beulich wrote:
> On 16.12.2021 23:26, Vladimir Mezentsev via Binutils wrote:
>> From: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
>>
>> We plan to use print_insn_i386_att, print_insn_i386_intel and
>> print_insn_i386 in a multithreaded application.
>> These functions are not thread safe due to the use of static variables.
>>
>> A disassembly output is changed due to fixes in swap_operand().
>> The old swap_operand() did not cleanup mnemonicendp.
>>
>> Tested on x86_64-pc-linux-gnu.
> Looks plausible at the first glance, but it would be quite helpful if this
> was split up some. At the very least the fix to swap_operand() should be
> a separate prereq change, imo.

  Hi Jan,

Thank you for review.
It is a good suggestion.
I will prepare a separate fix only in swap_operand().

Thank you,
-Vladimir

>
> Jan
>


  reply	other threads:[~2021-12-17 23:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-16 22:26 vladimir.mezentsev
2021-12-17  7:24 ` Jan Beulich
2021-12-17 23:23   ` Vladimir Mezentsev [this message]
2021-12-20 23:04 vladimir.mezentsev
2022-01-04 17:38 ` Vladimir Mezentsev
2022-01-04 17:47   ` H.J. Lu
2022-01-05  6:54     ` Vladimir Mezentsev
2022-01-05  7:07 vladimir.mezentsev
2022-01-05 11:42 ` Jan Beulich
2022-01-05 15:53   ` H.J. Lu
2022-01-05 19:19   ` Vladimir Mezentsev
2022-01-05 19:47     ` H.J. Lu
2022-01-06 12:47     ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8d2cec0e-ef70-96ce-d705-1c7e57ac6334@oracle.com \
    --to=vladimir.mezentsev@oracle.com \
    --cc=binutils@sourceware.org \
    --cc=jbeulich@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).