From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10063.outbound.protection.outlook.com [40.107.1.63]) by sourceware.org (Postfix) with ESMTPS id E96493858CDB for ; Wed, 3 Aug 2022 08:45:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E96493858CDB ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L5JKVpas2++LA0AZHK28RhIuMXHZQ0n2L+kuwwqdbLHwLEmy8bVOkyXG7NTeUjFWJq7hUoIdZLzN/v2XW2B89U054OtlYyw6OSrrhugFE2uz4w/pLFQrt+NsSzlBNn6rFw8ItwiGAPBAtZjSGTYfGVGmWL5S0VD7TLljNftIGvogAVn+zKMh1r0VuPKMqs9inwZGWVl72oJJtLlH4j6PmBQQ9SPF1u6WNkwlix/DmRAO2rSVAYCfljcKTazV0qJJq59vlK3dU7xF/UW21Snp8hBD70MyWotRLn6gChkEDlT2Jmc3VjSJFYahdFKN9hzGmydTCwh70FKBrqV0lXFD+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RqpT1l0zRssw2xedc3D/ocoiMnbW9MWQGOsxEHDKf1A=; b=U+KkYKC3t+RrUe153qNsNgYHZ9PDRD8LdYTf3o/DSINGDJiU00Lj3+IVbPH6qKzBz3kZjyO66Aoh9UqWQgXs/upO17Jb09f5W0wj+Ym9DIkm/WXvk0r8s2ctuUBa5tiFT2QQTn+x/pf6pZ/TM/BHqiwhelVn7DURih3EDKgwAzjO/yi34n9rv9O3BrJJg7tRMHZY237nPt5HVwNEPNJZen0hsHRwrCdHyDrxPPsxvIaVa2JjBiXgcgWZQ849VMYvkONN1j/hxJtWUHw0zuHl6VWFXUK0BCEU38aRw2o7ZqGg81UMbfdkUoPdurWbg33ud7/SHkKHi5YLaZqa38BX4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB4208.eurprd04.prod.outlook.com (2603:10a6:803:45::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Wed, 3 Aug 2022 08:45:13 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::1959:dab4:15f1:4acf]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::1959:dab4:15f1:4acf%2]) with mapi id 15.20.5482.016; Wed, 3 Aug 2022 08:45:13 +0000 Message-ID: <8e49a184-c4f1-7156-044b-5940a2b1a204@suse.com> Date: Wed, 3 Aug 2022 10:45:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] elf: Reset alignment for each PT_LOAD segment Content-Language: en-US To: "H.J. Lu" References: <20220801231122.2503979-1-hjl.tools@gmail.com> Cc: binutils@sourceware.org From: Jan Beulich In-Reply-To: <20220801231122.2503979-1-hjl.tools@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0131.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 668c0dc2-c829-48af-54fe-08da752c7b38 X-MS-TrafficTypeDiagnostic: VI1PR04MB4208:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: efIiZ81dCRnXqHWgni97IZ4/NCqmlw1KDHOFPQt2WWUTwN3Ip/ujICDwi1LhxfDTU3142lhJWgJWp/lZZ2hCHzxdTZoW4TIWzZsrpBD33gIBNdq2qgugL6kI6K4+eK7N09f3rBCbP89kZZOAh67sgoNfjSrqwm/ZiIG7EMeassncVzlQWfNkmtfQNJp/izPPCHXP9VSZEQLJGDmK/yd6+OFz3JhdHVGYGPs4sFOta/IRaQCRWMG9jqj/vPeak6D1uS/hToHMuqk7xsy5egKGoGTOoEB4RTEtfXT82KpetEOTYyMXEr3Smv0zNdBFttj7R6/1HXgGbCqf6KLNxzVrqD90qwn3Y1Ha6XacHBop37QBTBN5LuHBjf6R/vzNZI399gN7HzMdUA8PupJ5nOwWHhufQhMWbBLZ4ZJKY+Xty31R7r4vLFDNajNFWgs+RLZ3hcB/3Jo0ype2U8dAxJUld7gis4GO6UJRd05bD2m7pMLBE/EuwyWgOYdKkKkznFMK0YzE2jwkBhlkugo4Zl5UJUJRlXcOZb2gVFtQf+YxfM0oz6dNNcjeefWuCbOf5U5SfbDoC2pMkRzloRlx7OhgG/Z73/bFYVAq/1qAYbE4LKCBS2BaIEAK9FuLgaNqWjMjRsJnVDgBbNc7B5b+DWweGs+jWiJDWUnTzGIeSNlmoaa3u3CA9W6FeWmkYIMGLRninfcxK3VXbOgZpUttLwKZ1LPNRA2SE3VpZD4jlJ5OrhjFDUOoT/h7Q2i/YRskHPL0RXhn9ffeMd81gJodUAy2hZV2eK7VwrKdxxm/JmKexgl/qsyBtwttKFSZPbEMk8YmLIqWj7kmJeivZ+1jXjSrDA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(39860400002)(396003)(136003)(376002)(346002)(366004)(186003)(41300700001)(2906002)(26005)(6512007)(6506007)(53546011)(2616005)(86362001)(31696002)(38100700002)(6916009)(478600001)(66946007)(66556008)(4744005)(31686004)(316002)(6486002)(8936002)(36756003)(5660300002)(4326008)(66476007)(8676002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y3V1dkN5TEdkalZHcVBjL1lld1RPSWFvNnkzWnNkdXcyejdEZkZTT0VxeXBO?= =?utf-8?B?UWJtLzErcnZsSkttSnRjUnlTZG1rcUYrNmpoaFBRZUNOR1ZTb0ZHK1NXL3Zv?= =?utf-8?B?RFk5Z3VOYlZBbUxweFdoT1VCOGg3dnhVMWZiT3ppR25WeUVYaU96ZmtETmZh?= =?utf-8?B?b0hiT2RiajdrWWpWbGFnK0lMc1lyeC9qaHJ4VCt2bngzVDBiT256L3JIT1BC?= =?utf-8?B?bWdtRHphOVVoM3pUSjRUU1VHWmRWdEZldVJ0OVpOSEtEcTdFY01XRUF6Snd1?= =?utf-8?B?cVl5U1hIU0JEMkFjbEdjUWM1TUdZMlp1elJsLzBoZXJDNG5scFJ2cXlDbkNM?= =?utf-8?B?WlV4bWtjL3o3bTN5WEtxWTNUVkJhT1oyMGlmQksyWVlpQ3FMdmxNVk1QZW1n?= =?utf-8?B?cldpeitydWZXcmk0SSt5QlhNMnNWYXVuTnMvZ2E1bHNvNDVvZW1pZ09IeU9u?= =?utf-8?B?ZmRrSUgweTdFdUpxVEZQVStVZDZ3NkV6ODkya2lNNzgxOVFrejhEbUl3TDV2?= =?utf-8?B?bENseUpDYzZNTWZKSlhlZEpVdTg5Y08wUmJXOVgxcHNsZEM5cndvcWRLQldq?= =?utf-8?B?M2g3K0Z6N1RMOUI5OFU2S0FJa0VaV0JYcTV5MzlqUElRNkFHNStOeWxkaEtT?= =?utf-8?B?dkJxK0dnL0QwZkRmWVBxOG94QXluR3VQZ2NQcmMrNWErbytPaTlIaGVQL1Vr?= =?utf-8?B?eXl0Y2EvMm9XSVR6alJNNkR5SzRROUhNREZGOTI4V1pFVWNsejJ2NWlYZGJx?= =?utf-8?B?NTl2WkUraEkwaFdxTEFvNjlCOUJQekVzNW9kcFJsK0U3WE1iRnVKY0UrRkdW?= =?utf-8?B?UHFDbzhKelJNS3FMNk5jZERWRmpRQ3hRWUd4eDY1d1o1ckVjWGVsYVZJM3Jh?= =?utf-8?B?MkFXUjNZc3AxZDc4b0hjcHRUb2RiT2JkUEF2cDRjSUhvWVhZVld4WXpCdkNG?= =?utf-8?B?K09xZzhqdnE1cW1UQ1Z6Q1QxWDFwZDRLVkQ3SXpVSVMwRDZkeXZGbS9PcFpz?= =?utf-8?B?UUl0bnIvdS93TW5PRlByQmRtLy9XTWRkd1YxZ0ppQTZJWVFFcEhrU3p4aFdC?= =?utf-8?B?WkZIUTJ3NENiZVRjVS91ZVhBaWJRRmhrdjJITS9RQWFud0xqZDRwR2pNdkZv?= =?utf-8?B?TVdWNVF1VmthbjNPQ01NdFNwUEd2RlFtSGV5TTZ3RmZmTjA3cFVYVmlGdTht?= =?utf-8?B?WlNveC96ZnZvQmhaamUya3pLWHp6blN2aU51bDBucmw5U29ZWHo0Q2UzQlZw?= =?utf-8?B?TUEzcEM0bXJFQUtnYnBOSkZrcnJ4eFMyK2JMZXZvbXBDMjR0UUd1azc0WlNX?= =?utf-8?B?eEJVNUJnNDhuOWVlMHFiZmRHa2g5WFFzKzRzbkdJbkhwQ05Pd0dCY2pua1li?= =?utf-8?B?WG9rekVRUHJhbU1CSm9sTDZ5WndsUy9NbFpkM3NmSjR2TjV3cWZSUFhRdkFN?= =?utf-8?B?RHZtZnJ0OEVGRTFHM1pZNENHMWFpamxjOWwvRG5PY21LQVNwWVYyek85ZExl?= =?utf-8?B?RFI2UUdGSldYV0JiYk1MTGJiV0RzMWxyVU1OUDJMQmd3cDBGM1gyc2hPMWFm?= =?utf-8?B?dS9hd2RFWEt6TFlxcGxpMFF1V2ZpcEVjUkljYnQ5Q0VSa04ycXNTaEVmTEcr?= =?utf-8?B?djZhM2VnYkdHTjI4UUljWWtSWXYyV1JLVWlHQ00wL1VlVmRkU0hFVjlhWG1S?= =?utf-8?B?VlFyZzVoTDVINFBRdCtIRzVCazZYNkxGQythSFR1R0J5eXFZNEZJeVgrM2x4?= =?utf-8?B?Sm5Qa0V1UGl5MDF5aWZvSUVOS2pmOEJ5V3hhYUNEUk1XOFVrYjh0cnRyL3kx?= =?utf-8?B?Z0JEZ0VCaitKSmNuT2dRdC9nUjRnUm5TU1JZMXJVRDAzSG8zTXlvcExQTXht?= =?utf-8?B?L0RJSVZzdkJUQVJTSWUyVHplZEkxQ2lHZ2U5V0RpZytRQjI4NHhSYUdiYVFW?= =?utf-8?B?NUthMTl5elBiR0ZVQ01SVVp1NHoxZVR1UkE4RGFiemdPZlp4OG9RTy9OVE9T?= =?utf-8?B?SE5iZExOTjZBaHVDaGdXRVN5eU8xSHR6bDRWRUFzZmVSVnFsZURmdnRnK2k5?= =?utf-8?B?V09jay9QZTRNdk5PMXZaL3d5Yk05bW1WSnplRFZjZXpjNS8yYWdpbEw3TUR6?= =?utf-8?Q?dgiDh0mbB2XWRrhtZoHi03zOX?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 668c0dc2-c829-48af-54fe-08da752c7b38 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2022 08:45:13.4365 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RK1SxSMgqAGKNEVG2VY1xNwlwppbUWc++sKmi29GwDc1TSvRJCTeqdxThYrs9y6hYUkcx8eXxEotbCuMWg089g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4208 X-Spam-Status: No, score=-3030.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Aug 2022 08:45:18 -0000 On 02.08.2022 01:11, H.J. Lu via Binutils wrote: > --- a/bfd/elf.c > +++ b/bfd/elf.c > @@ -5439,7 +5439,7 @@ assign_file_positions_for_load_sections (bfd *abfd, > file_ptr off; /* Octets. */ > bfd_size_type maxpagesize; > bfd_size_type p_align; > - bool p_align_p = false; > + bool p_align_p; Wouldn't it be helpful / good practice to also move the two variables into the loop's scope (and then using initializers in favor of assignments)? Okay preferably with that adjustment. Jan