From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70054.outbound.protection.outlook.com [40.107.7.54]) by sourceware.org (Postfix) with ESMTPS id 39F6A3858297 for ; Tue, 16 Aug 2022 07:31:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 39F6A3858297 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ndRegxUyg7fqIfhylIjuAqQuJ9qkX+tueK/6nffeYcHjqXa0NSM1y3sJIfd8cKiviwR/thx2P7tZylpkYdEz7QmeR83DUcodP/0QhGCowKafnTGRtqqycjReUKCes1wC6kqTPw+Vv9EB8sqvHiku20WvBfbiG6B/Io/RcjOT3En7nmk2Jq/9Soh5y0Epcwr93SG5462UB77rSnZVkipFWnDe+NzlA9OHppzOs4v/9/4nCMiUvWJY6u+0tjcRssoYRZLG4XOB4Ng/ZAwO3DXjOMC4Nt6m3PCXFF12WQuzYTwgGBFDcUBu7MLC46Qo0i3vOAHzZxdXPx6aetRfH6yRaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TuNCliAS9SD3vcHxmvNT4PzPcqbhEwi6Y6kJP405Irc=; b=h0lPVndpHajlMwlFnGFr84uT9L2rMxhLQYqvqBwdvd5NESORI7/OM0kiTo0vNFimLtClaIRvFGIfDY0/XZbsEtYBgbZ/Aljxx/AHF84FOCqnSmGTQqZyvSeDCd64bsvPejFNwh/HdCmP7JQyXAWX4GlZNny8GNI4MyZayvgSKryYAfXuRNuwrZAS7uiDovGFnESy5aklCuzQGdrfH78ZQcSEWZWfM6qJ+DX16w46DGTZwbGNIrQqWyKY50A1wHcZsXA10fHM+q+naDQsH2RFlz6cOTqBBB1M8p5MPNNc2PH7TU4XKE50KG31Dl0SSofL4wjVxJW/N/xhFvyKS2tjZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU0PR04MB9563.eurprd04.prod.outlook.com (2603:10a6:10:314::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.10; Tue, 16 Aug 2022 07:31:29 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2d5d:bae0:430f:70ad]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2d5d:bae0:430f:70ad%4]) with mapi id 15.20.5525.010; Tue, 16 Aug 2022 07:31:29 +0000 Message-ID: <8e4dc724-3516-6ec7-5a6b-70ed70e3e237@suse.com> Date: Tue, 16 Aug 2022 09:31:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: [PATCH 3/7] x86: move / quiesce pre-386 non-16-bit warning Content-Language: en-US To: Binutils References: <32216291-fd1f-4579-87de-d24cb7190894@suse.com> From: Jan Beulich In-Reply-To: <32216291-fd1f-4579-87de-d24cb7190894@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS4PR09CA0001.eurprd09.prod.outlook.com (2603:10a6:20b:5e0::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 32fe3b07-dc92-4b76-fe47-08da7f5955e4 X-MS-TrafficTypeDiagnostic: DU0PR04MB9563:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bM35x2lcgu5wTDHq12okGsMYkGGtlal6D9CEuBQoomvbHESnc8/pF8fIUOSqHGF7wSzmevfBt2m6DJTXQLwtQD4eWcSjQKIABnHEDtaFdEj4aeftdxPUTYuHQq2F8OLfCFucdhpB29X6omFMha0ou7FclDFDFL+5GdLtxEiauUnJlZwnBHbJuNpePH8sfx1d7ev5wJk66wSFPutVtGe7OUPy9VLW0d257H/9Jg//1P9kpbBkXpI92pBzA8AnGAtDhmt3BOR2jc9uHSbRtOzusN1+ADIpB2uQTa9riB6LotRHhUlF73iu1OYBk6mu9VTBa5IvReK2wTJVorr6Zy2BdgcYBPwb7yb3jSTtLN5+/NmRIp8ScWAp6Ao2uMNOeeZYEZ35YjVAtu3tyzyFarhBDg0SbU2UfwX/7fENov/Dd1QLMtg+rql2HPR6R7AMyd7VaRCWeINqBkhTInnFMu6a+o/r4bHHGubCbLpsZJbx3Omgk/0Rl+XZ0vbYHATazmnMtXz81tb+eACfzD/o8j3iJuCRWoWSH+VwjeT4x4LnWHmh3vmpgD2TH0Xpd2b0GYl2PFXLaykWBsyF6RiSDTRyz7Zny7UaBQ5ZgSiT2g6SxPVB6VxZjRFcsoNOk+Ht5hF0Wa5K0U0t/Brlyzu9ruVjn4X8oe5xYRTwG7J3pC1Y04b1tfCTQcPLN9cLTuCzOoQDymvgh/POp5M0RnyRhiUE9H5/3+JAYealk+3x/AQxdjXW1nWQE0iJf7TlzezfVPMSP4VhDoiGSR262qFYePOA8X7WMqbe2x9Zg1O4FCwVLl20BQJiglnQA/+nXF5CY93uSGOo87HtSl40VljVEqw1Xw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(136003)(39860400002)(366004)(376002)(396003)(346002)(6512007)(478600001)(26005)(66556008)(6486002)(41300700001)(2616005)(83380400001)(66476007)(31686004)(36756003)(38100700002)(6506007)(86362001)(31696002)(2906002)(6916009)(8936002)(4326008)(316002)(186003)(5660300002)(8676002)(66946007)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZUJ5TWRpRzgrVEo0bitLRTRtbHNUdjNYNHhFMjA0TWR6WjlvTlhCcW1aR0FQ?= =?utf-8?B?RlprN05CRG9sVlRjWVNVZDFOa0dUOVBJUHFqSnozREFVRXNhMS9nQkd6MFhV?= =?utf-8?B?WlhoR1JnMHF2L0FtbEl5QlNYWFlESHcxcnFLdXV0L0xBakNtTFBrSUlkTFlR?= =?utf-8?B?b3Y3ekpoSTR6MWJRYlQ5VDdVemdpbXEyNk5wUWFROENRK1RQSVI5SmJPaGRX?= =?utf-8?B?cFc1OUM2WG15ak15aGkzZExYTkFubWpvTldzeEpLQ2tQUGozMFhyblk0eUZq?= =?utf-8?B?bmUzZ0Fab3MyMEEvbUZxNElVT1lUckQzZ0ZFall4OEtJMmt1YjZhVG5GT2hR?= =?utf-8?B?NDlEV1FGZ002YkJ2T3VqaXdIUEhFRTFsK1lVTzZXeUpsZkg3d0p1dWVJVFQ2?= =?utf-8?B?ZERMb1JVb0JJMTFwNW5tTTNnZ2NoVnFzQllsRHhSa2JWcEdtTkFTdzVZUXVS?= =?utf-8?B?K1dZM21yWVRaM0crY0RLZVgrVU5YbjkxbUFWak9wYVJvcEJZTWg0YVBaM0py?= =?utf-8?B?bGhZeEpBalFjRlA0ZEtGT2pqSDlnWENJeVZ2Ym9ZUnVyL2x3b1FvdmlaTnpV?= =?utf-8?B?RkxTN2dKTmxIWE5UY2xQbXg3TnNZSlJBWFVzQmFFRWY5SkUyL1A2MXNZUDZw?= =?utf-8?B?OHA3NHA3QktuUXlyOFFidk1HR0ovSDdkMFVHRXc2R0lEQWp3ckN0ME1mT3R3?= =?utf-8?B?MklQMW02R3IwNFF4RHMxOEcvY3VBZkVIWWtzSEJuN1F6RGVtYjlMV1NKWnJN?= =?utf-8?B?UjBNYXFxdTc3d2JTM0R0d01tR0wxQThzZEtQT2EyaW5qK05zV0xNRHRKbXVN?= =?utf-8?B?K2FZNGZJQUIvWTFnZ3F1YzNYNG0ySHp5bzRkRHVGd21LTXZLMzg4cHhRT3dB?= =?utf-8?B?dWRsd3RPdWQ5Umg2K240czFvaVd2UVVqam9LeDFDY1djK2Y3UDlZY2pkQ2Yz?= =?utf-8?B?TDFHQ2dPWVZGdWtXUHM3dmNFbmxaeGFITm9rQW9pbW8wb1hITHFITkxPRXdS?= =?utf-8?B?TkpvaitEdWg3cmE2UEJXZ1lZdmd0M2hZYnVwR0FkVEoxcDU4czc1RVJOb1Jw?= =?utf-8?B?eE1YL2owK1R5K3lUWUJGS1laYXY4R3ArTm1LcnZJZElvczh4QTY0czRJSXlB?= =?utf-8?B?NHdUandmNDhmQU5RYXAyVnF5TlhkQzlXcWFzZHNMZHROZVgxUlVDMFBaTjZH?= =?utf-8?B?Q0ptalhWdG9NZEIyRS8wdjEvK3pZM09jN1dtVVd0cjJxQXk1UHhUWlFTSmlU?= =?utf-8?B?NDU3TVkvbjhtZHdHeko3VmJBSHhKbzVYT0ZZVERpSFJEMitzUWlWVXZkQTJR?= =?utf-8?B?TnN5djZqc215S1dnV0ZaVzZuS3pKaFRYbEhHUXFMU2k3RTl5TUthZEhDUVdC?= =?utf-8?B?TXZaMWRESUZvVElLcHp6T1RxbGI5T1JDaFZQcndRWU5rYUdCVXYyL29XN3Fu?= =?utf-8?B?cnJIL2ViR3N6c0lOSlpVams2bGc5czNGV2ZsL0lqQUl2WHpyRmVFWERHUC9v?= =?utf-8?B?alU1cFY1STFGUEppVWRhcnlGaFVmZFZoYzdJbExJd1d6MU1PZEhtV3htZWRa?= =?utf-8?B?em1pQWNCKzFYbnZXRkhnSklkang1VUgrQkI2UHQreklwSitraVZUQWczd0Zh?= =?utf-8?B?TGtXKzdsMzl3Z0lzZHBzUHRBSTNEalBxWlBhNjk4TkpsZXowZEtXRDB1LzZU?= =?utf-8?B?SWU3KzR2N2gvMkJHa1QxVC9PUjc5QUoyYTN5dlZXMzBIRktDaVU3VWJTK2d0?= =?utf-8?B?a1dxNXZjZVNwbGphTDRrcWdPUGs4YWRVOVdQSGluWWdRTmR2eGNiWGNlMXJx?= =?utf-8?B?YjJNNTVIVW44UE8zOE1SVW1HY04zUjdYMURBZUw3ZmJWMkNyYVlDZnM3Zmxr?= =?utf-8?B?eFlRTURFeHBtd1U0em0yNmlrTTJJMXRIdEg1cUFGVE1tRU5XakhsRGN5K1Zr?= =?utf-8?B?YjNRKzZjbElRdk1FOWlXR21ObVQrRzVyWEtJSjZPSXBRNjQ1ci8vMU9YL1M0?= =?utf-8?B?YVI3ZEtYUjlURTJHb0cwb2YveUI4NElSdUNza0hQWnYrbEhKTmZicnptOGJh?= =?utf-8?B?bGllWXM3S2hWV1k0SGlhU3FqaWlLVXJiUEFpNmFDcEZqUGdONUtBWjRmS1Nr?= =?utf-8?Q?M8LIkRPjubheUjtUI/XYZl4Li?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 32fe3b07-dc92-4b76-fe47-08da7f5955e4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2022 07:31:29.7171 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wupMxqITrJJAQOfVWX22a0/1h9FxUiuT6Y22KGtTOotclLGs8Th7cjRF7dYX4s4MPfPqxsAxhqi9m/YZWuLyfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9563 X-Spam-Status: No, score=-3030.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2022 07:31:33 -0000 Emitting this warning for every insn, including ones having actual errors, is annoying. Introduce a boolean variable to emit the warning just once on the first insn after .arch may have changed the things, and move the warning to output_insn(). (I didn't want to go as far as checking whether the .arch actually turned off the i386 bit, but doing so would be an option.) --- Otoh I wonder whether switching to a pre-386 architecture shouldn't automatically move to CODE_16BIT: Us emitting operand- or address-size prefixes violates the architecture specification. Alternatively we could outright reject such .arch directives when not already in 16-bit mode. I've left the message text unaltered, albeit I think "addressing mode" is particularly misleading for instructions without memory operands (nor any other address-size affected aspect, like in e.g. JCXZ). Originally I thought the warning may get in the way of work done in subsequent patches, but I think I've convinced myself that all affected insns are post-286 and hence wouldn't yield CPU_FLAGS_PERFECT_MATCH. --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -765,6 +765,9 @@ int optimize_align_code = 1; /* Non-zero to quieten some warnings. */ static int quiet_warnings = 0; +/* Guard to avoid repeated warnings about non-16-bit code on 16-bit CPUs. */ +static bool pre_386_16bit_warned; + /* CPU name. */ static const char *cpu_arch_name = NULL; static char *cpu_sub_arch_name = NULL; @@ -2809,6 +2812,7 @@ set_cpu_arch (int dummy ATTRIBUTE_UNUSED cpu_arch_tune = cpu_arch_isa; cpu_arch_tune_flags = cpu_arch_isa_flags; } + pre_386_16bit_warned = false; break; } @@ -5486,12 +5490,7 @@ parse_insn (char *line, char *mnemonic) { supported |= cpu_flags_match (t); if (supported == CPU_FLAGS_PERFECT_MATCH) - { - if (!cpu_arch_flags.bitfield.cpui386 && (flag_code != CODE_16BIT)) - as_warn (_("use .code16 to ensure correct addressing mode")); - - return l; - } + return l; } if (!(supported & CPU_FLAGS_64BIT_MATCH)) @@ -9491,6 +9490,13 @@ output_insn (void) fragP->tc_frag_data.max_bytes = max_branch_padding_size; } + if (!cpu_arch_flags.bitfield.cpui386 && (flag_code != CODE_16BIT) + && !pre_386_16bit_warned) + { + as_warn (_("use .code16 to ensure correct addressing mode")); + pre_386_16bit_warned = true; + } + /* Output jumps. */ if (i.tm.opcode_modifier.jump == JUMP) output_branch ();