From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60077.outbound.protection.outlook.com [40.107.6.77]) by sourceware.org (Postfix) with ESMTPS id EE5753854550 for ; Mon, 21 Nov 2022 07:37:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EE5753854550 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QhAGCrV3wb49ZjX00WHgUl5RoafaJmkW5X7b4sZUc/KuV30Pd0AF7oD2id/zcxdro7Qb5SwGAzDcLRdO8X6WcK+5ELd7E12Jtsi/9dSkuOjGGLVdyU+tM8cGM3oAZAw9ClBE8zw55t+HlyFhtISU7+majPbCXE5rWUciK8NLArMz9CWD5kK/hGDTQQtR25Z7fv5rolwTOqMHOAtvcXWp8MhE6nuMo4ReVerOo5MSYzjpaQywUh31cZvo2oGDBPAKLIpEfOGJzMkiJJnlp15rgp8aDYzLIW58tvWPv8EHmCTJ/SO2cSApJzZ1j1e7ht8qHt5FZyqAXpvgqOPPvcg1ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FrMX6FEbO124sNQpQuz0fbXxjsdWkA1rp6CtbK/SOu0=; b=aZe0eSqzHldnI676KfW+bCz3IwC/WgPRn65kIAyZxX0DdnSFnVzW2wn8VkKROPsvawFbemDdyWv8K+3gUSmzgq1xhsNy8VM9FZZXzjcbeTdXWbgxaXH6sWnN3MLZUtL3eA5RGuPEdEf+MeWkrVM3PzbsMGn4uuIj6IEczYV0Bt17AlJe+aBg5lQD+BoqiJKANjbl4QoknwKRB2cQ/VfErQeomppBVw/2NcvGhiMRXVqSaYJOQZSahciwSySaQJhs0GIz3Ey/T23YTmPREyL3PLGjvxAqoNyhNaL0YW2P6Hz30TdIIIQ6tlD4CDeQSqVepRP89MVOPkuWqmHiWhdGfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FrMX6FEbO124sNQpQuz0fbXxjsdWkA1rp6CtbK/SOu0=; b=BYU6AeSmGVa7hP+PuG+vZs4o8LB+OV6EsO/e9XrhY6iW9ibnTKePnA7fIVg4PP6LOQk2M74zJn3wNV1I+h+KEUyYwxyUseqe9cTXAfb1803H4jiXFS5mhONxq35ro9hEDxkJUPzM2i0jS7Pn/nMsI+MY2OlP8PExumAfZw+/Nk7VfDU6pUfceBP3/UtHeL/NyJ/BzH9StOXbyPaOJHO6Mrwmxw75W0gcwLlZBOI/gl/vnK1LoQjFypbf+VukzsLD21Yp7cV/a2GDJpV/kZsYv3P/q6QgkUBfHrw1iZHNxfR1MUBVswBNbq3LlrCYPbl4qUksIS6hwNFCDMb/fT11Lg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7919.eurprd04.prod.outlook.com (2603:10a6:102:c1::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Mon, 21 Nov 2022 07:37:30 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5834.011; Mon, 21 Nov 2022 07:37:29 +0000 Message-ID: <8eeba059-8d4f-b147-27e2-49e505c490a9@suse.com> Date: Mon, 21 Nov 2022 08:37:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 2/2] RISC-V: Better support for long instructions Content-Language: en-US To: Tsukasa OI Cc: binutils@sourceware.org, Nelson Chu , Kito Cheng , Palmer Dabbelt References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0095.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7919:EE_ X-MS-Office365-Filtering-Correlation-Id: 0a288809-8f4e-4de1-02f2-08dacb933e9e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pn2D4D1pZTX6GM85nqLdWSmxaGNUCxxKPo/0TFZXPQdYpdi4HSBUa2Yi83hnCTZTyTRceR/KSThOJqpEvTpRVPqv28yhcATeW2Ilpfw130WM/ve10O7uP7lspoqsYtp7iVokoZ8zhydLjeJM5WnA3UGvn3pF7SXMybvhs95m0tf16FDQiVtLLQdvKilHUVdQvHeYSvMFhsAR67dzKxbnKqdsHpSiphrFxdeDQg7f8bFgefLF0bTBPn2qmzn9nYBX7l9jHbWGqBC6gWzGQlLPD87ZhxJTzLWG59N5nrWMzuQTHevvQ7T4ky1QdsHHfp7XecHDq4KERt+pa5QVcnmOb4abOrNyEmZBCtPf16A/Nmjjb1cC7DfqWAachAnNeTM+DRgEJdEuGGMZvgpf7OkyjCvT2OjWmG0rrMRMeL6BzctjOVITOnkW7w6ii/riSCC5SrxDqBBMH5ofcE1LWin06k4EQ//GHdzo2n31SNEK3dAzo5n2xDHoZnfLFxahZViPzrdgpHMfVzj5l+vwhWdkpKY+/khE7Mhf2iB5EzNLoufoTQ7GAkNjE9z9fWtcuY+ohspXMLIjx8rGRz2V93exaY+V26QaTisay3KM2xk8zP3ijT9SFprr0KmCjnTSdNhcsvxOrZiw+OKUSTrN1u6/GPwdNKqaGh9v3N9nZI6y1uvWFtPYieRPkLSS0z+NhXJVqZyY086xGyFwxNjvTj6qD/xQgnRZorMm3W1oEP9r1r4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(136003)(39860400002)(376002)(366004)(396003)(451199015)(41300700001)(31686004)(8936002)(316002)(54906003)(66946007)(66899015)(5660300002)(66556008)(8676002)(66476007)(4326008)(6916009)(478600001)(31696002)(36756003)(86362001)(6506007)(83380400001)(26005)(6486002)(2906002)(186003)(2616005)(38100700002)(53546011)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OHZ5aHZyWlJmZG5uMFAzMU5lVXVkY1NZOFlkLzJMRHNHVWJnZlVSTEpEa2RY?= =?utf-8?B?SFg4MVZWMXl4NnJVRERoN2JaWnVTOTU0Q08vRCtoZ3hUU0dmZEJoSHAvLzQw?= =?utf-8?B?TzBURklVR2lWbnd6ZW1NWHp6OGFsUDFoSXZqN3pnbmJoRCtNSVovRGllK091?= =?utf-8?B?bm1MdTJTZUhoaHJBczZSZW04QlVtaDIxbitUR3NwMXlQR1pOblZ2dU4yQzhu?= =?utf-8?B?dDlyWE5EUWorYTk0Z2JxaFFRekcrMEpEdXVRc3Q5V1BMeVAwVEJFbHl2Y0NF?= =?utf-8?B?NVhCTWJMUWI3aHg1Y2tsNWhXT25hUThHNmozdkt4UmdIK0RGbTFtQVdxVmNv?= =?utf-8?B?OU94K29rYWVUVTk4dzBvNjZvWEdWMjJKRElQS3lBZUJ1VFhDYm1qWFErc3dw?= =?utf-8?B?ZmFRdXZjZHBFVjB3ZjMyZW92ZTBXcFA0WFh6anVCRlBLU0lKdzlsRWJJRW12?= =?utf-8?B?YldleWlzTk05N2ZZSndPWHFlWDdUTTFpalhsL0NYZFJ0STRQUlRIdXBxQTc3?= =?utf-8?B?ZTlnQzlpMWZzMEF6YzQzQzR0ejhuVnRETTJwWnlqMEI5N3RxUnczUGZyTldy?= =?utf-8?B?UzhRZXkzYTBublpDM1diOCthaFV4UitwMk5vNkJIMlRpRFhmOEpkY0ZoRCtV?= =?utf-8?B?eUN0ZDNOUlNnN3JvSXQrbmtLKzhMMlN0bWpQSXFyYXE3M3NOcEVmVFFKQS9Q?= =?utf-8?B?bHdxV3VZN0FBcFV0ZjF5SlMrTHRJSEZBakhTbHZqU0prRDhpN3NTN1JZNHlq?= =?utf-8?B?OW1BVVdBU3dWNk9yNkxTWnBnZ3p3TDN6dzI4QWw3OWsvY1Zpbmk3NWZwdERH?= =?utf-8?B?MWNJWWczbitvQ0I3cTZuZUdoTEpSOHVsdm9aekRJSjBORDFBRkVDQUtOL0ZQ?= =?utf-8?B?OUN6bElXbFhOVy9xcHgzOFc5VWsxOVQwQVZOTURtak9YSmUvU0RWNS9MVnlh?= =?utf-8?B?aktJNDVWVU9LcU0vZ3BCMlBwMkYrU0VoM3YrRHBYOTBrWkNpUi9hRHNsY3lz?= =?utf-8?B?MkxiTS9qVi8rOVdjSnQ4U1NpNDhhOXF6ckk0VG5Ob2ZEUWk3WllValNCWFZ3?= =?utf-8?B?VHNrSEhBcXJBNGMzZEt1bVBzZ3plM01Cek9kaEJQWlhmUFVZdkJrRkJiTVFm?= =?utf-8?B?Mm8zUGs2Z05uOHE0RThpelZXVTlPK0ZsdWQyejBXVVhpMXZsRzlOT0pNSSsx?= =?utf-8?B?VXZKNllXM3gyY3cydFBybzJNYTcwSzNQMnUwM09mU25VR1U2b2tPcm5ZVVJk?= =?utf-8?B?cFd4S01RU3N4bkdXVzF1bnF3YVNIU2thWm9lTkp6c3AzUFJ4Z3cvUjlkREov?= =?utf-8?B?TFpHZEwwamJQaVMrUkFLWVU1M2crR21oSko4aDdFUHp3Nmh5ZTJ0VXNvcUph?= =?utf-8?B?SDZ3dS9wV2tSU3dWWE1ycFRJWDE2cElOV1NMajFPOHdadVNWNElMZHRyT2JY?= =?utf-8?B?YlUvOHNMRVlSdnlqUmxtdFpWMFdCOUNvRzhBKzB3RmcwYzdqZE1IQjZIdzJ3?= =?utf-8?B?d3ZsZG14VUNoaTFIUk9ZNjhKbFhWU0VhaWpJUU5LaU0zRzU3RkkxazJRT1BX?= =?utf-8?B?enJGUkRGVUo4L2YxdElRNFFXZjZYbTlKR3lWaGZCNDZIVktTZnk4T3lETHND?= =?utf-8?B?SUVvVTI2OEFjdHc5VjFqdW94cW5lYzA5MitrUkZsZFVqMmJFR1d4OUVaSW5C?= =?utf-8?B?cHVINHhDK0hTWldnSkdjVFFqUDBJdVcvMEZmU2pRS21yenVkM3lEUVk1akIz?= =?utf-8?B?RjEzUDY4bytCQjRCOSt4OE85a0M5VlZvdGdLSmtmWEFEalVUYVAySjFVU2ow?= =?utf-8?B?Z243MFpRcmYxQ0Z1UUZkUDFacHEzaFlPTDVHWWlSMklVWnhURlFOR0lWWm5s?= =?utf-8?B?TzNFekpQdzdHbVhaNE1nczZYYlJ4M0ZzNm5EdE80dlRscndBNG9CYW13Ly9X?= =?utf-8?B?Q0FuQW5mbnJoV0JYVnFNR3Bobzg4MTl1N09FUGgwNHcwL3ZZc1NKUWRGRzNn?= =?utf-8?B?RU84UWF0WWdUQXQ1RWVoNmcxejhvZUtic0VKeENCUytlVEQ5MkJUTm5EUXB1?= =?utf-8?B?OUpJbjF3anZLbnpud3dWTnM2Q0JkVWtmaGhxVzUxWUU0Zi96VmpXSzZPK2t6?= =?utf-8?Q?Fdo2H/wkMgNcXkYKUHDtkQQJa?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a288809-8f4e-4de1-02f2-08dacb933e9e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 07:37:29.8770 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k53CZb4aFV33jDHexpGmU3jdpP0RSkEElVoafzswMm/8q/OiZ5dSrtwlvL4mQde2QHbJzKw7JoaW6CE6DEWeXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7919 X-Spam-Status: No, score=-3029.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 19.11.2022 08:10, Tsukasa OI wrote: > From: Tsukasa OI > > Commit bb996692bd96 ("RISC-V/gas: allow generating up to 176-bit > instructions with .insn") tried to start supporting long instructions but > it was insufficient. > > 1. It heavily depended on the bignum internals (radix of 2^16), > 2. It generates "value conflicts with instruction length" even if a big > number instruction encoding does not exceed its expected length, > 3. Because long opcode was handled separately (from struct riscv_cl_insn), > some information like DWARF line number correspondence was missing and > 4. On the disassembler, disassembler dump was limited up to 64-bit. > For long (unknown) instructions, instruction bits are incorrectly > zeroed out. Just FTR - of these 1 and 4 were deliberate (as in: deemed acceptable), the former the keep the code reasonably simple and the latter because focus was solely on the assembler. I recall dealing with some instances of 2, but as you demonstrate I failed to recognize and deal with further cases. I will admit that I didn't even think of debug info generation. > To solve these problems, this commit: > > 1. Handles bignum (and its encodings) precisely, > 2. Incorporates long opcode handling into regular struct > riscv_cl_insn-handling functions. > 3. Adds packet argument to support dumping instructions > longer than 64-bits. Thanks for taking the time to make improvements there. Jan