From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by sourceware.org (Postfix) with ESMTPS id 87397384640E for ; Thu, 25 Apr 2024 09:51:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 87397384640E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 87397384640E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::332 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714038669; cv=none; b=CFFRy2dMST/qNzLHjRVwyIQe3nOL/EQdJFbpg9yBkk6/Zi5RFYWaAU6ymJKROWlAbvanR59EMBf8V44LlJ66bJWdCmkkJRPA0rgmhSUyvJi6BBkDuwssiKl0/RwAQktzaU7whkCD3RsB0o2jkCTVx2mROiLTgYTXrbnxSSRK3ZE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714038669; c=relaxed/simple; bh=WejwX1KwSWJoqcvHcQ8X5QrSKoDOQ0qVn4rp1kTdawE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=e2pnZae+N+5pnAYK72B/qEF4ixFeMgfb5Xh7sl0HflWkUoWJak8QwNtQ9/ho1ZY1W606S8soAt8NqbSlu7MFndlnEroP1A9XwGaOM95erJnd/t/vahIf5CopoIj+PjPtQgG27uR9PxjJSF5AYD7azh+uNgfsJCLmX7YI3NLg0/o= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-41a72f3a1edso6470335e9.2 for ; Thu, 25 Apr 2024 02:51:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1714038666; x=1714643466; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=L0INWOpLmn8lXGiXJWMm2bOS6e4vENBVwQdGvhj2Zf4=; b=IW633OVFIcKW48u1Rfpf+/vHduqdEJwRv+kbgdBTpfsmgoK/vtPKplFachwJOIB3So E2En/hXIGebkJfUo8zMFjWPUo+uXT4P4LvXTr0NjfBYJdhLSi0g0CcIx6ApdZTj3GvM+ veSS9hVB9vQUgTdHtSBRUbo6t/nwCD/7iBs+Y0TLMe+/DLxMFbIOxHA4+/BEj+heZYoN yzKZRr/c6hv3zlWTFDTS25+JdsY08uuSH5K2mEPg8SsCc9WR5FJUQfNH0hygMlyJSkeZ 9byIHH2iKG94pY/jn213Ka8YaoDytua3vU4lTvWQTsuL/EZWIuQ42thmOH9g/Gv6gSPP zNxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714038666; x=1714643466; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=L0INWOpLmn8lXGiXJWMm2bOS6e4vENBVwQdGvhj2Zf4=; b=CWnhDarMv6Mhb3sPOae8G1DQ5XrREDB8xvUIXjF+xzojBI13Wdam4D+R6DlAZgiLUW fDTrwNSnY6tPZpiP86k97jnx0M7wGh6MSO1bNUZ+MDyQfzbysWyXEQQgMdNk2jNjH7f6 yUOVoMKXlW6qQkkbb0nJlkbqAFLDo40R+1hXHpJGgsVXczBk1bPdMhorlSfpKazZDgwD gWK7Behm40XWDOo7ndVqfUJyI3By93wPYctBzYhnUDxidXTN4sIDAhOjo003fMbVA8vk GN83jqnJbuBlT2l/yicceVbVV85keLUWqE1D2PD2ZgUwHRC+SQLoYw8d4/1YBxuaspLx qi4A== X-Forwarded-Encrypted: i=1; AJvYcCU2q2yk+abOXppkgUQ4GFmoG8EABpJuwXscT9IMZRrLZr714CnHAniDcB3s8gbW9HQ7hGkkDEI8ZfGVDLkeyl7heFdgS0iupA== X-Gm-Message-State: AOJu0Yyh8mfIKWuU4N/XPTFhcPDngUL25ECQj2cRtLXSlblKmFaPSccU 7K2GJIGaa0pfLBOlA0ZNbdLvqwtfteLOqei0HWGFwc1KUUnlYyrZsddYdPIr4A== X-Google-Smtp-Source: AGHT+IFCGSyQCXityNz6sJCt9mkrNteej84J7RTMhV33Im+IfaWX/zcg3skBAheqhV+IAV6oA8yo9Q== X-Received: by 2002:a05:600c:548a:b0:41a:7ab1:fd98 with SMTP id iv10-20020a05600c548a00b0041a7ab1fd98mr3947170wmb.21.1714038666190; Thu, 25 Apr 2024 02:51:06 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id w17-20020a05600c475100b004162d06768bsm30706736wmo.21.2024.04.25.02.51.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Apr 2024 02:51:05 -0700 (PDT) Message-ID: <8f26983d-7558-4260-910a-3c2182ad4a62@suse.com> Date: Thu, 25 Apr 2024 11:51:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] RISC-V: Add support for Zimop extension Content-Language: en-US To: Xiao Zeng Cc: kito.cheng@gmail.com, palmer@dabbelt.com, nelson@rivosinc.com, zhengyu@eswincomputing.com, binutils@sourceware.org References: <20240425081926.86228-1-zengxiao@eswincomputing.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20240425081926.86228-1-zengxiao@eswincomputing.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3025.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 25.04.2024 10:19, Xiao Zeng wrote: > This implements the Zimop (May-Be-Operations) extension, as of version 1.0. > > See > Just two cosmetic remarks (nits) on the new testcase: > --- /dev/null > +++ b/gas/testsuite/gas/riscv/zimop.s > @@ -0,0 +1,44 @@ > +target: > + # mop.r.n > + mop.r.0 a0, a1 Would be nice if insns and comments were indented the same. > + mop.r.1 a0, a1 > + mop.r.2 a0, a1 > + mop.r.3 a0, a1 > + mop.r.4 a0, a1 > + mop.r.5 a0, a1 > + mop.r.6 a0, a1 > + mop.r.7 a0, a1 > + mop.r.8 a0, a1 > + mop.r.9 a0, a1 > + mop.r.10 a0, a1 > + mop.r.11 a0, a1 > + mop.r.12 a0, a1 > + mop.r.13 a0, a1 > + mop.r.14 a0, a1 > + mop.r.15 a0, a1 > + mop.r.16 a0, a1 > + mop.r.17 a0, a1 > + mop.r.18 a0, a1 > + mop.r.19 a0, a1 > + mop.r.20 a0, a1 > + mop.r.21 a0, a1 > + mop.r.22 a0, a1 > + mop.r.23 a0, a1 > + mop.r.24 a0, a1 > + mop.r.25 a0, a1 > + mop.r.26 a0, a1 > + mop.r.27 a0, a1 > + mop.r.28 a0, a1 > + mop.r.29 a0, a1 > + mop.r.30 a0, a1 > + mop.r.31 a0, a1 > + # mop.rr.n > + mop.rr.0 a0, a1, a2 > + mop.rr.1 a0, a1, a2 > + mop.rr.2 a0, a1, a2 > + mop.rr.3 a0, a1, a2 > + mop.rr.4 a0, a1, a2 > + mop.rr.5 a0, a1, a2 > + mop.rr.6 a0, a1, a2 > + mop.rr.7 a0, a1, a2 > + > \ No newline at end of file Please avoid such. Jan