Hi. I can confirm these patches can compile and could be run normally. But the tests were omitted in this patch, so I could not confirm if the patches work. Do we need to add `#define ARCH_nanomips` in the front part like the official one? If so, definitions of `ARCH_nanomips` should be added in the `opcodes/disassemble.c` file. Comparing with the patch v5, I can see you have deleted the file `include/elf/mips-common.h` and moved its main contents to `include/elf/nanomips.h`. This should be fine, but in my opinion, the two FIXMEs in file `opcodes/nanomips-dis.c` should be kept: "/* FIXME: These should be shared with gdb somehow. */" and "/* FIXME: Should probably use a hash table on the major opcode here. */" as these behaviors were not fixed. Thanks. Tsing >This series introduces a subset of nanoMIPS functionalities. It's a pre-requirement for nanoMIPS support for GDB/SIM. > >Almost complete series is a "green patch" - it adds things, so the probability of making regressions of existing functionalities is minimal. > >Compared to the previous series version (v5), there are no functional impacts but changes are split into smaller parts.