From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30081.outbound.protection.outlook.com [40.107.3.81]) by sourceware.org (Postfix) with ESMTPS id 2039B380DF9E for ; Tue, 28 Jun 2022 13:52:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2039B380DF9E ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RgV+KYrP+4VIjS0ju6tYhqsPVfJeYgNIVWV62farCn5/sMig8t9HM5wsmue+JnowFuRBUkyUni9/AIypBYUNY36/LKCaSi6CPJjOANG8YH9XmyRtZ1Gth/gj436DEtxxsNKcM5d26MyxECjQg7BJXogbhDyhIT2TMkZRyDghMLkWDNiy6bxg7XUcmSzvH7IV8JjsPkrKaGg0LOrs06sIuLo4uBvVKx0KlZbFk7Iz0WXzVACo3fmx4Y3KpMZiXTmUlJJe52X5hkvALMhNnlZeYLl6+Lrav8gfgfli++gUvyC7er5Slx4xMs9il6DyMH+nloHDt2cVVSzT7IxC30+Eaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tkdVGJllkJT5glh/A651qHe3A9ZQ5Jo/U3lmd6SHXwU=; b=RiGqgHYs1dYYD+ik2sKioDN9iwBrmhPOc61Q7Son0gT8XK3qJnSrZDwxSSPDt6w+ZHV0Qo7Qlx1twLhnXQvfx3wI3rZNnHqrtfOevbfd8udTzJjVVhfdXlgcQDd5NGN/COlbhECVzVkM0QJJuLHcBCxXndBs7vuibuobp/pXlh55XGEWl0eGFTjZKCVSBdg+w6NcPyljSAeKLX5IZITpewQhJIiuj+cK8dlW0oKuSO6MTwkvb3aL8+FGhaCR9d9HyIz8a7JKSdUa4Jdj/aaHUmNfr2hQJSben/nkhlO2oL7o2asbrk/+SWgYQXRYfLS0n7o9q5LnXpQc59c+aCdoHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7393.eurprd04.prod.outlook.com (2603:10a6:20b:1d2::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.18; Tue, 28 Jun 2022 13:52:00 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5373.018; Tue, 28 Jun 2022 13:52:00 +0000 Message-ID: <8f8b421d-7cc5-1b4f-7e55-5f4b41716b4c@suse.com> Date: Tue, 28 Jun 2022 15:51:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] windres: add quotes around preprocessor cmd if needed Content-Language: en-US To: =?UTF-8?Q?Cl=c3=a9ment_Chigot?= Cc: binutils@sourceware.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0045.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ae11308a-4440-4428-5ec2-08da590d5fcb X-MS-TrafficTypeDiagnostic: AM8PR04MB7393:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VOknow9Dm7woovPwavPvOFHuGPjbOHK1j5yFfGYqcmiffjpiki+yiniK8JkV3PmUasWDQzA6r9hvXQnkxmzaWLpFmYRNTQtN8gVp/uWDUNMmiksxT4HZUNbbbh5U6HhqVca5Ip3fqxgVIzoJSedTXs29wUMW0aKt14CZs6vyqpWSZ5ntQLob0OrwS/1zvQBN5R+CDyfTDhQigsepOb54cAKWE07c5ri1FgPpMhVeRShJ0zCq8w97m3/q1l2dceLhcIzQdmO80Z95AbwZDhx5/HAWMCobX5/+EBLRVel8yp7F98DDsdHzVqC6+o3nq4BjkdC64QyZcOsExNvGXdmRDyr37v/6bs88HI0RNVKVxLESLYDMg3gqepRW3iIZ5AO8VoQOrn7wExVaC3MMBIlpK6bKVzXVv6A7CdmxTt55dEQUhgGlnZEmT94ctpoCtzA85mMCTNZIT4RokgY/ETalSD2b8Gf8W2itIy2XMquP2IMlScPxO9F1N8V0uFgSqPvXnaEgVG+/Wa4/dIER9IPVYaXBzcibuzFR2fLbuSj6lW0y2tmkrK8A4xO+6gxjaGgpf9ly88Dd+PycSKFQ6XGGwAQasDLeOO+foCeEMIx2NdChRbVIrBw+023TJWg68k8hvU8a+2J6Uk326InvEphuLer4CFnKjIC/4ejKfLZWs0i+YBeMR2OSMHv3VtXxumZEgE5HPZP8sEflxI4XM69GY7trvfHxeYQudl30lwReedGWxDCAghq1T/8c/7I4mN4g0XpvyEntbIDiSu+tM28jOAqRH0yok/GctVJJcvboxfqg9ZMQGrtKiJnauZwBdaCxMumOAzkhk7hpq2GG+M6V1QxARjwmFS+belEKEQcP6bQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(39860400002)(136003)(376002)(346002)(366004)(396003)(38100700002)(53546011)(41300700001)(2906002)(6486002)(8676002)(66476007)(966005)(66556008)(86362001)(66946007)(31696002)(26005)(6506007)(6512007)(316002)(4326008)(36756003)(31686004)(8936002)(186003)(5660300002)(478600001)(2616005)(83380400001)(6916009)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d2x0SnJIUGd0UEsvMUxQaU9YUjNOZXVHOUpmcUNnam9qZytGSnZTRFRhNHFG?= =?utf-8?B?SzE1c1ZvRWN6UVlHY3A2VHpxZ0hGMFZjOUQyWlh3L1NnTGhMSHJMaDV5SHg2?= =?utf-8?B?cUlLUzFadnVjWGxYSWVCUk52cWJIUWJ1a3NTM3FyU3FqcEg1dFd6NjNwTzJy?= =?utf-8?B?MEUvZVc0Y1BocEJUQm44ZWxBQ3JHa3FuL1l0TkwrZ25CT1BSN0YvejdLNSsr?= =?utf-8?B?UldvbTlmam42K2t4N0hWeDdBUy9oN1pYK3NDWkthVkhWZlRrbDZVSy9VQUEv?= =?utf-8?B?MFRtcUFGczZFSVZrVnFwZ2pEaTNKU1FOcHBzQnZYRlF4eW94aWV6RXJXNTk5?= =?utf-8?B?Y3Vqam8xVGFrL1RrdHBxblV2QzB2bDRheGdseXdkV20vRkwzY1YyRnRKRE5B?= =?utf-8?B?Y0xyN1dHOWt3eS9zRmtkY2JoVHZJZDlvQ0ZyZVFGREp0SkJkaU5YMGtXajRm?= =?utf-8?B?YzFCL0FLTUcvRjhqV2pTRll3dU9TRXYxeW1JbXlPNjh2Q3IvRFhOVUhWWTh3?= =?utf-8?B?c3l4c1prZnBDSWZ1cWpzdHdnTkdqcFlaSDNFQndyRHFNUjIwUzlzZWVRYUtv?= =?utf-8?B?ekNlYm15cjkrUGdVd3grb1Z4Nmt5SHAxVTkvaGVQUVVUTUltSjJ0bXlkN1JJ?= =?utf-8?B?R1hEdkxWdzlXRlVpOHEycndtd1l4d0RDTFYybmh3cGI1L0tvaUtlOXVSY3I1?= =?utf-8?B?TjI3cnVXMG9sRVZKTFVXajZZcU9PYTJSS2ZWcXkxcUtrZFZUeWY5S2I1dHpJ?= =?utf-8?B?TElqdEFJZDQ0bGdPNWR1NytyNFNsbGdjNlJ1Sm41TmJPQjdvbXBJZzNDczZH?= =?utf-8?B?NkFYVXNvVVNrSWV5OWo2NmliazdjWkZkRi9DMUpFUVRORyt3RE9ERlpoV0da?= =?utf-8?B?NTRzSnJUQk5Xd25IWEhQZkN3Ui9TQkdEV0lwRkxkMHdTR2NVRW9ZeHBNaVlR?= =?utf-8?B?U3JwaTU2RlJuL0lVcGNsa2VsOW9aUVpyeHc2b0szMzZWWmJkSWgvSS9zK3lQ?= =?utf-8?B?VkhyT091RzZCbWRjb05JRUhDOTNrcTNpV2FrOXRIR3YzTjg4OG1FS2hXM2xv?= =?utf-8?B?SzRNc0xFa1V6dkx1MVdvNitXMEFyczlyc05uUkhIWmlKMmlYMEJmY25CRHJ2?= =?utf-8?B?eGdLaHZkeEYxa2lGMDJ0eFFrVmNhaGJOR3BnbzY2RmhEZlkybEJYRVdoVlZp?= =?utf-8?B?WUJCRThUK2dXU3FqMmFveXEwSFZrRUZtQlkyTXVHclUvbDBvazBtajJERjJw?= =?utf-8?B?OUtvSzR6SEpkQ1ZtZFBpK01PSmtXYWlLZVVyZUR3bnNER2JXdlVUQWlzSDlT?= =?utf-8?B?MFZJZzlWUk81bGJYaUJBQVJwSTBmTi9KalF3c0t1bzU5ZUNtRm5qVDBUTHZ0?= =?utf-8?B?NS9acjN1WWRLWm9mVzFrRlphQUFJOEJkQVl6eGgrR3lWQjhkNnJrbjI3SVRy?= =?utf-8?B?UzZYankxY21zRVA2NUxLUUJldTBBdFVzWllCZWZRbnZJU1lORE9xVjZmdGhB?= =?utf-8?B?K3VHeHFBcy9QZmlOM0NFd1RoR0JVM1hqcC95amthZWEweElSWC9ETGRtWTJa?= =?utf-8?B?R0d1TDVrdFpqaHltVVFnNWhQWEk2aWlNMlhQL3ZDbGFhQ1RBV2NmcXlSa2hs?= =?utf-8?B?TEtUeThiZ3NOQVhzUGJwUjRVTTNNck01Z0hUZHNDRDl5K0F1MkdpdDV3TFhZ?= =?utf-8?B?c0k3eHlOMHdncG52WnFOQ2FjbGtRSU9qZEhiU0VIbk9uUlBFTG5KNWFZbnJY?= =?utf-8?B?M2s5NFplcGNxeTk0QmRvdHJyVXhNdmZId2Fmb1Q1U2tQQUhwUVZlUFpJVm5q?= =?utf-8?B?WCtmQVp4MlJEQ0t4RjF3bTBKbUZIb3paNERnZkFpcWdUcUV1NFd6bWdZL2xj?= =?utf-8?B?d1hOV2JqZkw1UTVrR015YSszSzQ1R2NpZG5HeFhDVExYbTE0bi81eFMvcnRh?= =?utf-8?B?ZkdUK3lRdlRIVnoxYkl4K0grYW53QVY3SEtNZHVSK2NzdXphUjBCcjBWK1d6?= =?utf-8?B?NmtLR3pleFRqc2hRMXZOaGIyY0hSb3pyd2lLRGZVa1U0S0lKZW1URTBiclQ5?= =?utf-8?B?UCtjbWxtTHI1N3I1N3IrRTZRT1lnYmxEODBhRmRsNkZ1WEpNZjkrS0VPZmN6?= =?utf-8?Q?H1SUNaq/mir6f9OGZDxFHG6Gx?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ae11308a-4440-4428-5ec2-08da590d5fcb X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2022 13:52:00.4519 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3lH20ldo5sTqKlZH5muP0paFtbGgh6B6O0hrISCCnCNIJQ6ifFw2RMnSHH9AxWPTthrqtsmNaTCIyDG0YSEw8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7393 X-Spam-Status: No, score=-3030.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2022 13:52:04 -0000 On 28.06.2022 14:26, Clément Chigot wrote: > On Tue, Jun 28, 2022 at 11:37 AM Clément Chigot wrote: >> >> On Tue, Jun 28, 2022 at 11:00 AM Jan Beulich wrote: >>> >>> On 28.06.2022 09:35, Clément Chigot via Binutils wrote: >>> Shouldn't you also (optionally) quote the pre-processor string >>> if that came into read_rc_file() as non-NULL? Everything else looks >>> okay to me. >> >> Yeah. I didn't run into this issue but looking at the code it should happen >> too. Thanks for pointing it out ! > > Actually the space issue is already handled by windres.c: > https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=binutils/windres.c;h=4df821ee8451bda70490d6626707c2bdd66eeb5f;hb=HEAD#l887 > It's not as complete as it should be. But apart of "%" I'm not sure > any other characters caught by "filename_need_quotes" can happen > in a folder name under Windows. Oh, I see. I'm not sure I see a strong need for dealing with %, so I'm wondering: Are you intending to make an updated patch, or do you want to commit the one you've got (which I'm okay with given your observation)? > Making "filename_need_quotes" more global might be a good idea > anyway. Right, but that could be a separate change then. Jan