From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by sourceware.org (Postfix) with ESMTPS id 600833858430 for ; Fri, 15 Dec 2023 08:44:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 600833858430 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 600833858430 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::22a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702629855; cv=none; b=rvBC1JCVtA1ijl0xaTgRVvLx9ZB6BZrZq2f5agzga1kz8o3osCojzAxQECYSI3mz40KgejYDW6dIMWpT9hCtknmLzDkmeR9lYR6o0rYpthmMRTuSFX5mG6yjhJvHDcQltv7SqVdnRwdwcUBVc6lk2/IDH4rI7+VAzAjVswDuM8Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702629855; c=relaxed/simple; bh=SSgNbuMMFC4XKFGjodpVH9fiHCXtnEYgK5hZppaOj6g=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=pnIV8Me/gZ4NqlfqR58q6ZRzEBP0ApemuwLjQDuoTnyxSRgnHypJbuL384mZnALnkRUrnCaxwFMbzsEH48cNIBqj0sPqfWx+V1+l6DQMc/qfafp9bYVVEOtpGI5BC7eb4Z28+iIrIuFRXvv1LsvH+DRLrOq33iXmlv55lrKv7bc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2c9efa1ab7fso4499261fa.0 for ; Fri, 15 Dec 2023 00:44:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1702629851; x=1703234651; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JEcNzgnS9cNG2IvsUfqfLFRoB6LgfxO+fsEWN52suDE=; b=UMHlm3w0wsNM1kkIs970YV9PlOojkwFRw8rUBEdmZT3/cQVTS/lHWipWH85hsWPmfv +gTbsy5XRZAK1NDuOjoDXXaa7DNmbEj59TjWB9PzqtcwPGeEYxwEnrpNActtUvf9TlYJ XzAz0CpmRuAMU9L/3kGPiasL5XLeD6ZeDcSroI4d50CdJD5PsWTexmVyJ8GE/d0cLM1R cQkJHEfLkI9/ltbaGb4snsWnbJw1EqWopDI3HDF4E4YQcktDTqpxWIGBTTJKtxrUZJH+ FxpAbaXMlSdbDzxlnPzP9EpPx6MxluX8UDg4EfC/MZp4Vpz3YKNdeF/E9XZRsxzdmeEo fnpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702629851; x=1703234651; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JEcNzgnS9cNG2IvsUfqfLFRoB6LgfxO+fsEWN52suDE=; b=SApJjMQkHeyjJxjha/xM9AQIhLgsaBLc0lt1ulYx4iVaDpcEFewyIX/x7AOLEdJYYS ZeVXItGCplGu535UpKRw6gdgrRHeiryVF81T4hT3CkEF0GF0eNHWVHmHn9/oDZGt8Bi8 i7hi5LrgKEwgK8Xq5CFBSboAHry8giFx3G9suMCBNKPQ3KAlUn4FLOAvqJD+bM/GTfHn NAhYK92cJGNkyGscXqaXe/jpkM7l6sGjJYW2WDUwz16f5Cwvu/NjxjDU6/LQgAb9vvaU twd5uA7dTJFUF4MdQw5wpQh5C8iY/Z+XnPTqVAHDrUDMilfr9qAiPHc4dRLJg6Q8IY2I OIfw== X-Gm-Message-State: AOJu0YxS1AtnVb4lckuh8EWIHydXWQZBDleUNEwsXQR3LzemJDVyQlZE oJ/LO8ocBBpgclxS/dXD+U/CPRNWEdsL8YF06om5 X-Google-Smtp-Source: AGHT+IGXNxxLEADkwIK5cvxBK6fbqreA3WN+9fHGf3YOWdgxgh9NIGeGjMocYI26taxA72QnJiVKUw== X-Received: by 2002:a2e:86c7:0:b0:2cc:4cb9:fb17 with SMTP id n7-20020a2e86c7000000b002cc4cb9fb17mr118482ljj.179.1702629851649; Fri, 15 Dec 2023 00:44:11 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id d2-20020a02a482000000b004691845afb0sm3830970jam.38.2023.12.15.00.44.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Dec 2023 00:44:11 -0800 (PST) Message-ID: <8f935a02-5270-4467-9741-3edbf2a41ba1@suse.com> Date: Fri, 15 Dec 2023 09:44:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 7/9] Support APX Push2/Pop2 Content-Language: en-US To: "Cui, Lili" Cc: "Lu, Hongjiu" , "binutils@sourceware.org" References: <20231124070213.3886483-1-lili.cui@intel.com> <20231124070213.3886483-7-lili.cui@intel.com> <5373d135-73d0-41db-a1cf-4079433ab379@suse.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3026.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 15.12.2023 09:38, Cui, Lili wrote: >> On 24.11.2023 08:02, Cui, Lili wrote: >>> @@ -5422,6 +5427,9 @@ md_assemble (char *line) >>> case unsupported_rc_sae: >>> err_msg = _("unsupported static rounding/sae"); >>> break; >>> + case unsupported_rsp_register: >>> + err_msg = _("cannot be used with %rsp register"); >>> + break; >> >> While this wording looks okay as visible here, please consider it in the context >> it is used in: "cannot be used with %rsp register for `push2'" >> is, I'm sorry to say that, clumsy at best. If you want to stick to setting err_msg, >> how about "%rsp register cannot be used"? Personally I'd prefer a resulting >> output of "%rsp register cannot be used with `push2'", but I wouldn't insist on >> you going that route if you don't like that. > > "%rsp register cannot be used" ,this is much better, thanks. It occurs to me only now (sorry) that %rsp is inappropriate to use when assembling Intel syntax insns. In that case the % may not be there (and as a result the entire register name then wants putting in single quotes, as we do elsewhere). >>> +check_APX_operands (const insn_template *t) { >>> + /* Push2* and Pop2* cannot use RSP and Pop2* cannot pop two same >> registers. >>> + */ >>> + if (t->mnem_off == MN_push2 || t->mnem_off == MN_push2p >>> + || t->mnem_off == MN_pop2 || t->mnem_off == MN_pop2p) >> >> Considering (perhaps just theoretical) further additions here, did you consider >> using switch()? Even without further additions this would imo be more legible >> (due to there being slightly less redundancy). >> > > Done. > > /* Push2* and Pop2* cannot use RSP and Pop2* cannot pop two same registers. > */ > switch (t->mnem_off) > { > case MN_pop2: > case MN_pop2p: > if (register_number (i.op[0].regs) == register_number (i.op[1].regs)) > { > i.error = invalid_dest_register_set; > return 1; > } Fall-through comment here please, ... > case MN_push2: > case MN_push2p: > if (register_number (i.op[0].regs) == 4 > || register_number (i.op[1].regs) == 4) > { > i.error = unsupported_rsp_register; > return 1; > } ... and break here please. Jan