public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: "Potharla, Rupesh" <Rupesh.Potharla@amd.com>
Cc: "George, Jini Susan" <JiniSusan.George@amd.com>,
	"Parasuraman, Hariharan" <Hariharan.Parasuraman@amd.com>,
	"Kumar N, Bhuvanendra" <Bhuvanendra.KumarN@amd.com>,
	"Potharla, Rupesh via Binutils" <binutils@sourceware.org>
Subject: Re: [PATCH] Ignore DWARF debug information for -gsplit-dwarf with dwarf-5.
Date: Thu, 29 Sep 2022 17:00:55 +0200	[thread overview]
Message-ID: <8f9d1b9f-01d9-c415-d362-57fbade05b81@suse.com> (raw)
In-Reply-To: <DM6PR12MB42195701D46DB4E1E29CFF67E7579@DM6PR12MB4219.namprd12.prod.outlook.com>

On 29.09.2022 14:43, Potharla, Rupesh via Binutils wrote:
> --- a/bfd/dwarf2.c
> +++ b/bfd/dwarf2.c
> @@ -4441,6 +4441,10 @@ parse_comp_unit (struct dwarf2_debug *stash,
>        return NULL;
>      }
> 
> +  /* Skip DWO_id field.  */
> +  if (unit_type == DW_UT_skeleton)
> +    info_ptr += 8;
> +
>    /* Read the abbrevs for this compilation unit into a table.  */
>    abbrevs = read_abbrevs (abfd, abbrev_offset, stash, file);
>    if (! abbrevs)

A few lines up from here there's already a check of unit_type against
DW_UT_type. May I suggest to convert that to switch() and add your new
code there in form of a separate case block?

Jan

  reply	other threads:[~2022-09-29 15:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-29 12:43 Potharla, Rupesh
2022-09-29 15:00 ` Jan Beulich [this message]
2022-09-29 15:54   ` Potharla, Rupesh
2022-09-29 16:03     ` Jan Beulich
2022-09-29 16:39       ` Potharla, Rupesh
2022-09-30  5:53         ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f9d1b9f-01d9-c415-d362-57fbade05b81@suse.com \
    --to=jbeulich@suse.com \
    --cc=Bhuvanendra.KumarN@amd.com \
    --cc=Hariharan.Parasuraman@amd.com \
    --cc=JiniSusan.George@amd.com \
    --cc=Rupesh.Potharla@amd.com \
    --cc=binutils@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).