From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from quail.birch.relay.mailchannels.net (quail.birch.relay.mailchannels.net [23.83.209.151]) by sourceware.org (Postfix) with ESMTPS id C020C3858D38 for ; Fri, 10 Nov 2023 16:10:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C020C3858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=eagercon.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eagercon.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C020C3858D38 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=23.83.209.151 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1699632604; cv=pass; b=Lx3Y9+ktpYOX5JAGC1fo20oC5tC08xcsCN8VHEiJFWyLKWZQYV2jMgFyjwPqBhqiLxQT0Kxwjm3EmT6Pqda/TM0aHOookK/hOjU1AE0HcoyrTqEsNj0rYhgTRe1KhdM01fqsgoRFhx24NIysZjU3NeV7mwf6erxtJGsyY3Hwxcg= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1699632604; c=relaxed/simple; bh=qAgx4GYRSiPriURWeX99s7YdAMVvDxKdEZI3vTc8EcU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=fGfppjIL63+mFquwKPSmQ60XVN+pVzgoJorgEMBbSk+6Vn6gMzUoxPH2MWJ/WJRlLaVCZbnVsIxCnQR2wGdWBXvAzF2l9eZ0LAvsjQzn1dr+9GKPGGfqETo/ybq9Y0p5eU1+YsdnxVkDetzJ0yc9NC1euXa1FzS4IG3/sy61V+g= ARC-Authentication-Results: i=2; server2.sourceware.org X-Sender-Id: dreamhost|x-authsender|eager@eagerm.com Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 73C6E6C0EDF; Fri, 10 Nov 2023 16:10:01 +0000 (UTC) Received: from pdx1-sub0-mail-a234.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 0FB506C1631; Fri, 10 Nov 2023 16:10:01 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1699632601; a=rsa-sha256; cv=none; b=S3Jb8ooiKQpNEWixt8wc7LL/yAX4sLncPHy869eaYnUWg2fqHVsEwiTN3kzISLcUf/3zu5 BE/hBLOEEFjdDf0/nqAPB5F5+atODBgY1pD/TCm74rHr+drWjJdPO1q/W0/8AR4e35h0WI +9aG0RQ82VIzrf/4BFfWRFb5yv7D4mj8nr4w6OreWpWH+y4h6kJ4bCH7BDydaE5JVcVfWV TvQslWN/x3EGLyWbZ5w3LAOGqoK8VHW+a+IHGQB25p6QRqNdzlqCG0R4sTdXurAWqwircS B5EU5wgaCC8F3An5TDyyTsmHtcdqtdR1+KXZtBnPnv8CZd6s2cKi3oJc5BAJcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1699632601; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iO3yt0uW81QcRWtW7UBrxH1akzSHQ76HLz8es2BmWk0=; b=POPySDOFuwu86ZC7twor3rH+1MOO7DSmdG5vFiseKrB5HaP7TqfereM/XEHT2BQhQpvi8v hfprZ2r3W24Vb92phZIoaAlpMGBLFZuMbmkV8j0cpwrAMf3N8wg4HbRhoIDLhSrVa6A3/8 NpBG7RDXun1xA9C4Yv8p4g4VKQYvUyKW8rNDZroA63E1GnqmmCWPEWUHQVgfKhuoWRslFx gZ5r53ED2XdGurvh4O6B0I/lDievsng436Rtjy87EATaZ/gKMQXua+XIS6xnhlBXgRpjQ+ k+018RzqypcNuRuDnwu3xCf5EZ/ak90or8MDUzF97vCQxk14h1r351lORDe45Q== ARC-Authentication-Results: i=1; rspamd-6f98f74948-j8k7d; auth=pass smtp.auth=dreamhost smtp.mailfrom=eager@eagercon.com X-Sender-Id: dreamhost|x-authsender|eager@eagerm.com X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|eager@eagerm.com X-MailChannels-Auth-Id: dreamhost X-Scare-Desert: 4d6dc0a734739b20_1699632601299_3722401602 X-MC-Loop-Signature: 1699632601299:1045761001 X-MC-Ingress-Time: 1699632601299 Received: from pdx1-sub0-mail-a234.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.112.106.240 (trex/6.9.2); Fri, 10 Nov 2023 16:10:01 +0000 Received: from [192.168.20.10] (c-73-170-238-207.hsd1.ca.comcast.net [73.170.238.207]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by pdx1-sub0-mail-a234.dreamhost.com (Postfix) with ESMTPSA id 4SRkLJ2WGQz61; Fri, 10 Nov 2023 08:10:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eagercon.com; s=dreamhost; t=1699632600; bh=iO3yt0uW81QcRWtW7UBrxH1akzSHQ76HLz8es2BmWk0=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=QrOJAxV+IxhzKpZDnIdEHDYwsu3xNyPSqAWRALoWprunRa70LE4RIgHlwFVOyUkuu iuBSdP1BdV64n+S+R6CGUaJZv1UHNGRqyICIBB/jnZjvbromdPV+ffP87uBx5o63Fl fn/HIqOLYU6GlZT4U+1LEm4k1sZreF5Yx9aI/FE76nNhiIrhWhrCJ+SwSw1jBitwbv W30FF6HgpOegxfzxJNpQdRzhbRkpXW0iCBziSzY8lQVPbHnlT2O7rebSJ8OaBuHwTl IUApQZTZG0Ad/ItvCrO6HUbldRj5bSQQvK7/QRwMt5Yb0eDjl3cemfME0W6uu//Yhj ji9LVlOxM7B6A== Message-ID: <904b7cbb-fc16-4fab-99b3-267d181f8b72@eagercon.com> Date: Fri, 10 Nov 2023 08:09:59 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/1] opcodes: microblaze: Fix bit masking bug Content-Language: en-US To: Nick Clifton , Neal Frager , binutils@sourceware.org, eager@eagercon.com, amodra@gmail.com Cc: ibai.erkiaga-elorza@amd.com, nagaraju.mekala@amd.com, mark.hatle@amd.com, sadanand.mutyala@amd.com, appa.rao.nali@amd.com, vidhumouli.hunsigida@amd.com, luca.ceresoli@bootlin.com References: <20231019113740.2071556-1-neal.frager@amd.com> From: Michael Eager In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/10/23 06:24, Nick Clifton wrote: > Hi Neal, > >> There is currently a bug in the bit masking for the barrel shift >> instructions because the bit mask is not including all of the >> register bits which must be zero.  With this patch, the disassembler >> can be sure that the 32-bit value is indeed a barrel shift instruction >> and not a data value in memory. >> >> This fix can be verified by assembling and disassembling the following: >> >>     .text >>     .long 0x65005f5f >> >> With this patch, the bug is fixed, and the objdump will know that >> 0x65005f5f is not a barrel shift instruction. >> > > Approved - please apply. This patch was applied on 10/19/23. -- Michael Eager