From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2078.outbound.protection.outlook.com [40.107.14.78]) by sourceware.org (Postfix) with ESMTPS id C324E3959C51 for ; Tue, 6 Dec 2022 07:29:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C324E3959C51 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ClB61wqDnCTfLx10ako1IH+z4HBJ9N6Fr9BdYE7AJSzGCns2XR1v5s1NuGcZ2eKOkof7F+ewLxV2F1dli0b9ZtvY26QBvYBnd6KwPHP47NAP4r/C5GSda2AXiC2RFKRlx8nJ4acXi74DQRWmwZzH8Q3Jz0PUQjJHEL9zi3kVAo7m/0ytlJpFBD5AUD3ViqfeweNE8pYnRsSvkLFa02PnG3G93T7UkWdTaLYd9N//QvM3Od3PGp3m35EIqi/lnbF56NxZ3eZ/xcev6RmyrBee6LN2nFSaoew3MdkezTd2wjzuCdF9xxssinvpCA0MTmk+TsEI/tF0C6epPJGVkzoUjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CzEeZ9aPexrBnW3v5iKBCCyoT3e1jTMovQYRdzEgdn0=; b=lim+4YVdN0yTacSGskXTTv511OX9usU09mY0jwJwo/eOTRcaX8LWG0y54A7C3Ar3FBUqhyrBoqhw8IT91DjS9KDG2MdVz4dhztLwS7RJb30te9tqtIfLopUGW7JFjyje45ruzyLVZYJkVO+pO7+hL5LZH+4PEy403nx8ATBPG3KOPFgydvU0ICxlQ0SvGNMl37+H4MbX9wjojrW4Tiqd1DUtyitPGmqPNKDQjEyqCzCDxbzLNIiyc+iZMPP4trr+M1TJCaoHOR+czWpiZLolbZ5TEWK3X9aZTErIz3NY3nM518MkKLsKiTp8cseYp0wDIM4wFiG6wt817D7q7TMl4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CzEeZ9aPexrBnW3v5iKBCCyoT3e1jTMovQYRdzEgdn0=; b=fR1SB/biBrLQD/ztN66OIkskPtptCGM0X81brHMWn0BIXIfwfowjJSRVDLlK6Jwx+fDuiLueKZTSAKxjLkBUT/57l2IWgV1SOzfP3iVSfO0vz+hA5+uhYwFWkp8Ar+f+Yz/RNK+EyyexAplNiQTZdLhilWzU0+7/A1vhekRCaz5KFt6t4XVtxESLqy/KiFCr4paseaWy72RUrNcII/v8WlA++pUrHOlJTNoeFvbRI70AwJCQDavNaOz8pa9UlSpK/+cAZUcANt5yGGqK7dyyUXADjH/GpueTA+cgtu2UwHpYQdsF1g9ygcLlVG5PgFWUulTcAFetTLwhOPCyWaInLg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB6830.eurprd04.prod.outlook.com (2603:10a6:803:132::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.21; Tue, 6 Dec 2022 07:29:35 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5880.014; Tue, 6 Dec 2022 07:29:35 +0000 Message-ID: <90dc84c9-7bef-d3da-f949-7b03ce8ac4f8@suse.com> Date: Tue, 6 Dec 2022 08:29:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] x86: Remove unnecessary vex.w check for xh_mode in disassembler Content-Language: en-US To: "Jiang, Haochen" Cc: "hjl.tools@gmail.com" , "binutils@sourceware.org" References: <20221205025311.73743-1-haochen.jiang@intel.com> <18459a42-b4a4-00b0-b00d-04ce01b1de34@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0177.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB6830:EE_ X-MS-Office365-Filtering-Correlation-Id: eb6b3c18-1bb7-4a68-9002-08dad75b9fe2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vlg8wot0WnwlYj7nEHAFuAAfQvKu+kvUmYjpjqSFZnDUuOwaEPmZmv8JunNCpFZ3DeEo+LrzNme5kuyWtbGj/SiSJzVmkoBGIxZdwzqqpViPesudwD6vuk+OO2x62Qn21/+EBqX6NYpknXZML0jewR4dbmwez00oIQM1IwVMJowGzpm7Z0DEELITUQEm5oP7MtA6uyJ56+Jpo3OOeOQC84FVooL4Mf9aaGmGQGu9zGWtLB94NrVZEKKb+4uEkT4Wfi1/+ObzvTaEG9wjqi2/uMF/F0PWclG6DMTBzsvb/2iBKTeNudPooJwsTVkBEDnSydwhgUXL56v1MpEsaNR98wiXwRRfx4BQid80O119eAPCq8gshWCtupwi02eNgcb88870YtT6YHrRhRtaVDKSEgkpSbTfYJkvEuUUetJUabOWi2dEa7a6uMJxncPtJQpLyMtTWtHhBpj2wSmoxox3RJgl/zYJXk0BJ5xmfU6q8+PT8pFWH80RqtPShUpT4pk6OEjC0H/6mqpnGlGTlogg7dnycQGCF1MDT3JNWVYOoAJIGKnBe+/60Dk9QQZpgG3UyLSYdc18F0TJEW181Tlkng7wt16Nw3vr1GmcMd2GkrQt809awmGpsZRiDQCxob1tcQgNuHj7LxQa+MSkhhtBoP6K8gcid3xdco5yP/YtPLbvgB5rZKLFG3pKjEXqcO3qawq0z4EzsDEYamo/wmAliGn0QEVaHwP5rTWnlj8Q/nc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(366004)(346002)(39860400002)(396003)(136003)(451199015)(66476007)(478600001)(8936002)(8676002)(66556008)(31686004)(41300700001)(5660300002)(54906003)(4326008)(4744005)(6916009)(316002)(66946007)(38100700002)(26005)(6486002)(53546011)(2906002)(36756003)(186003)(2616005)(6506007)(86362001)(6512007)(31696002)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SDBjakhjNi9vbmFpNkJwYUltSlZUTFVSYTRuV0JKRzFiRG5hS215b3Q2TU5X?= =?utf-8?B?UnY5cTM2alRPdU51SlhXcFRsRXg3blRTSEZxM0FJd0V4VzhjVTVFY0gyRGI3?= =?utf-8?B?cDJ6S1FDem5XK21HaWNaK1YxOHk5RC9kZng4SmtxUVlWTC9Qc2M3ZTArcnpo?= =?utf-8?B?ZVhmT0tOSldnNG5UWjhQTFRjclFpbnN3cG9yUWtiU1BGRGtTamxtL2dCdnNN?= =?utf-8?B?Nzl6Z2M4aTRvNDRNTk9HbFB5NHVzZ01vYnpCY0cwZjJFa2d6QW5SaVZ0RjRR?= =?utf-8?B?WEJGc0d3c2ZNM0lRejhkbmhkTGVuZFIwMGRtc2RMaEQxWFdpSnVuRVQ0SXk2?= =?utf-8?B?WjJaMFFoZUFDUGZwY1MxVU1HMWR6WEhyTC9iZHlUN0FZWWpza0sxRnRsYWY3?= =?utf-8?B?VzdrUkFWN0JuZEoxMkRSVDFUc1JDL3F1S1B3aVhEdC83bm8ybnRVK0JOVVFK?= =?utf-8?B?ejhNV24xWGdCbFhYUit6clJnNmxlR0x1dXB5VXVnOS9JSTZRWkN6bHUzbm41?= =?utf-8?B?bE9Bd2ZkbDVTUHIyV0pzc3oybmFEQzBObDJqYlQ5WUFmcE1vUmpvdkFqY2dv?= =?utf-8?B?VVgwOTNiMjhONlAydFhReGlBUmt3b1AxNGRjV1BTQVNGYVIyWWk1NTgybmI2?= =?utf-8?B?QkZrMUVaQjM1c3hRekVsMmQ0NXhtY1Q0ZzUyOEJzVHZ4MWFMWXh4blRSZjNC?= =?utf-8?B?Z2tmQzFhU2RreHdYVndBWlFOWWt6RFdESHBHU3Rhalh5OUNxOVh4bUNCei9k?= =?utf-8?B?RGZud2xPRVIzZmlUNGJUV1ZER2R0RlpDNjNyK2pLSGdhcm5lVkNFMTAxTUNv?= =?utf-8?B?N0pxVkhSemtYcHVOTnliYlBsTmVUamRiR3ZXYmtoNUEwQkdiTWNLOEZ6USsv?= =?utf-8?B?L0tJMFdBUlR0RUg5NjRzR0Z2MVZhaXBRR25MSG5FRVJqbCt4clA1YmhPSVBp?= =?utf-8?B?WWZaRnlzUnlqcVZKbnorbEhTa0R0YUNvcDhRalBkZnVVMzNtazJNTlMwdDh3?= =?utf-8?B?UWw1bzFvUEYzc28rOUZiZG1VVE1IVEZVWGZxellKWkFlMmZIR0ZFaStSSSta?= =?utf-8?B?bWw3K3pCcmFQVWZKeWo4anJFdG9hVnVYbzM5M3BCY3phOXF2WExTckdqSW1F?= =?utf-8?B?dWV4ejd3empTOUhsWnkwSFJNYXdVbDhqcFd4OXpBeDQrKytkYWFCR2xDNnJK?= =?utf-8?B?MTlOS0NvUHNQY0krQ0FNQUUvVU9tRFlqY0VzZHRNTk9xclEvMDVwS1hsSFpp?= =?utf-8?B?Qm9rKzBIblM1azBlTXNSTVI5ekNWam9EZUdlN2gyNDRacVFaYWp1SVJkanhj?= =?utf-8?B?dGovVytHNkZUb2VLdjZDVzhsZG9ha0N6NlFCUEczNDJiS05HdDViR3R0NkNa?= =?utf-8?B?aXA1UnJIcjRhaHRJUktUZXJDQTV1ekYyRlRHejZxd01zYjV6WW1KYzN4MC9B?= =?utf-8?B?ejJYYVBycWdTNytaVk10RURmQmRjZi9wWCs4SU41dnZHNFdOWGdhWnZoTjBC?= =?utf-8?B?dm5lSTNleUE1YXo0WEtFWk5tU3dRQ2tRN29CbmpUZm5yNmMwYTIyWS9jSjVp?= =?utf-8?B?d21mbER6aWl1M3Y5bnlYTFUzK0laSS93MTBvalRnaGNJT09qNENIRW5QQXV5?= =?utf-8?B?cHdGRlhHNFA5amQ1aVdSZEk3U0tTNFFHTlVWTEU3NWFnMStjOUM1cStXVXJu?= =?utf-8?B?U0ZCU1hZTzhjYk1RQVRzU0djR3Ura3VocDNvS29ucDQ1YlZBTXc4ZUpnV1NZ?= =?utf-8?B?aTMrdVROTHpTNDZ5NkpPckdxcUk3eUhvU2RqTFJSc05WWVdnZFJ6WlRsVGha?= =?utf-8?B?Zk16MjNkb0dJY2hHSllVZWRodTdtUzRtc3MzSWxMOVBYdzVpT3dnNXhxVnl0?= =?utf-8?B?djFGRGlRYk1YTGhzdDN5OE5QV2N5dlVTNUliOHl3L3pSVnY5WEFRVE9YNFdl?= =?utf-8?B?Q2M5OFJ2dXRtejM1V1hmRm9oWVhLQW00ZlNFMTk1cGJvcGVyWTlpR3NGVkIz?= =?utf-8?B?TW9USC9QL1BYUyt5ZFJxUlJ3VXZ2ZzhONEpQTlJ4Y3VTRDVKcHlHQVpNeEN1?= =?utf-8?B?d3doaTRaNGx1U2lBT0RWZmZwbGJ1bzRITjBBT0Y0aGR2eHBDRzAwQmZCQm9n?= =?utf-8?Q?Na45yMQCG5pgBYVAAHP57YbhK?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb6b3c18-1bb7-4a68-9002-08dad75b9fe2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2022 07:29:35.6548 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: U0rL1JCfELDch03F6lpEcr/tgKm9BrvfaLEds0XzFQ7MAJF8dTOrMlU37z3511086gDO2y0lLT6tQgXkjUqwug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6830 X-Spam-Status: No, score=-3029.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 06.12.2022 02:36, Jiang, Haochen wrote: >>> Another reason for removing this check is because xh_mode with >>> broadcast usage should not indicate the vex.w bit. Instead it should >>> be handled by a W table entry. >> >> There are no broadcast insns using xh_mode, and you can't really mean >> embedded broadcast (because EVEX.W needs to be properly encoded >> there). >> Hence I don't follow what you're talking about here. > > Maybe this part is a little misleading. I will delete that in commit message. > What I actually mean is just like what you commented. > > I suppose using a W table entry in the future to encode here if not using > something like %XH. Feel free to commit with that text dropped; aiui you've addressed H.J.'s question. Jan